Re: progress.c does not compile under Mac OS X

Oh, I'm a bit confused here - lots of things happening. Submitting patches to projects is usually fairly simple; it's excitingly fresh to get a bunch of replies, having the patch set revised, more replies, then a further revised patch set gets merged to a development branch, and then I get suddenl

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

On 08/29/2014 09:07 PM, Junio C Hamano wrote: > Jonas 'Sortie' Termansen writes: > That is easy to fix, isn't it? > > Where you said "If you have timer_settimer(), set this makefile > variable", you start the sentence with "If you have a working >

Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

Hi, Thanks for the interest. :) There's a whole lot of emails being sent. I'll make a nice V2 shortly that takes your feedback into consideration. :) But first let's discuss. I think we should define the intended criteria. I expect to find these systems out there: * No setitimer and no timer_s

Re: [PATCH 4/9] autoconf: Check for timer_t

For the record, this commit doesn't contain my errata for OS X: ifeq ($(uname_S),Darwin) ... HAVE_DEV_TTY = YesPlease + NO_TIMER_T = UnfortunatelyYes COMPAT_OBJS += compat/precompose_utf8.o ... endif -- To unsubscribe from this list: send the line "unsubscribe git" in the bod

Re: [PATCH 8/9] autoconf: Check for timer_settime

> Don't you mean it implies NO_TIMER_SETTIME? > > It seems to me that these were all added for TIMER_SETTIME, and not > NO_SETTIMER? Or am I just thoroughly confused? Thanks, that's a mistake. I copy-pasted the wrong line. :P All of those additions should just be: # This also implies NO_TIMER_SE

Re: [PATCH 2/9] autoconf: Check for timer_t

It would appear that Darwin does not have timer_t, at least from looking at the public libc and XNU headers online. A quick additional change is needed in config.mak.uname: ifeq ($(uname_S),Darwin) ... HAVE_DEV_TTY = YesPlease + NO_TIMER_T = UnfortunatelyYes COMPAT_OBJS += c

[PATCH 9/9] Use timer_settime for new platforms

fails with ENOSYS at runtime. This approach allows the code using timer_settime() and setitimer() to be simple and readable. My first attempt used #ifdef around each use of timer_settime(), this quickly turned a into unmaintainable maze of preprocessor conditionals. Signed-off-by: Jonas 'So

[PATCH 6/9] autoconf: Check for struct itimerspec

This type will be used in a following commit. This type was not previously used by git. This can cause trouble for people on systems without struct itimerspec if they only rely on config.mak.uname. They will need to set NO_STRUCT_ITIMERSPEC manually. Signed-off-by: Jonas 'Sortie'

[PATCH 5/9] autoconf: Check for struct itimerval

The makefile has provisions for this case, so let's detect it in the configure script as well. Signed-off-by: Jonas 'Sortie' Termansen --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index 31b3218..00842ae 100644 --- a/con

[PATCH 7/9] autoconf: Check for setitimer

The makefile has provisions for this case, so let's detect it in the configure script as well. Signed-off-by: Jonas 'Sortie' Termansen --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure.ac b/configure.ac index 3c64251..89eb48f 100644 --- a/con

[PATCH 8/9] autoconf: Check for timer_settime

will be useful in a following commit. Signed-off-by: Jonas 'Sortie' Termansen --- This patch can be improved by finding out which systems doesn't have timer_settime and adding entries for them to config.mak.uname. Makefile | 21 + config.mak.uname |

[PATCH 0/9] Use timer_settime for new platforms

win, MinGW and Windows. If you have other systems available, you can help me by telling me if they need some NO_FOO love in config.mak.uname as well. :-) Jonas 'Sortie' Termansen -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

[PATCH 3/9] autoconf: Check for struct timespec

This type will be used in a following commit. This type was not previously used by git. This can cause trouble for people on systems without struct timespec if they only rely on config.mak.uname. They will need to set NO_STRUCT_TIMESPEC manually. Signed-off-by: Jonas 'Sortie'

[PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

or it. We repair this case so we can rely on it in the following commits. Signed-off-by: Jonas 'Sortie' Termansen --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index f587749..f7fae20 100644 --- a/git-com

[PATCH 4/9] autoconf: Check for struct sigevent

This type will be used in a following commit. This type was not previously used by git. This can cause trouble for people on systems without struct sigevent if they only rely on config.mak.uname. They will need to set NO_STRUCT_SIGEVENT manually. Signed-off-by: Jonas 'Sortie'

[PATCH 2/9] autoconf: Check for timer_t

This type will be used in a following commit. This type was not previously used by git. This can cause trouble for people on systems without timer_t if they only rely on config.mak.uname. They will need to set NO_TIMER_T manually. Signed-off-by: Jonas 'Sortie' Termansen --- This pa