Re: [PATCH] Use ALLOC_GROW() instead of inline code

lifo->alloc * sizeof(struct commit_info)); > - } > + > + ALLOC_GROW(lifo->items, lifo->nr + 1, lifo->alloc); > info = lifo->items + lifo->nr; > info->commit = commit; > info->util = util; > diff --git a/replace_object.c b/replace_object.c > index cdcaf8c..843deef 100644 > --- a/replace_object.c > +++ b/replace_object.c > @@ -36,12 +36,8 @@ static int register_replace_object(struct replace_object > *replace, > return 1; > } > pos = -pos - 1; > - if (replace_object_alloc <= ++replace_object_nr) { > - replace_object_alloc = alloc_nr(replace_object_alloc); > - replace_object = xrealloc(replace_object, > - sizeof(*replace_object) * > - replace_object_alloc); > - } > + ALLOC_GROW(replace_object, replace_object_nr + 1, > replace_object_alloc); > + replace_object_nr++; > if (pos < replace_object_nr) > memmove(replace_object + pos + 1, > replace_object + pos, > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, He Sun -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] finish_tmp_packfile():use strbuf for pathname construction

2014-03-03 15:41 GMT+08:00 Eric Sunshine : > On Sat, Mar 1, 2014 at 9:29 PM, Sun He wrote: >> Signed-off-by: Sun He >> Helped-by: Eric Sunshine >> Helped-by: Michael Haggerty >> --- >> >> This patch has assumed that you have already fix the bug of >> tmpname in builtin/pack-objects.c:write_pack

Re: [PATCH v3] branch.c: change install_branch_config() to use skip_prefix()

2014-03-03 10:24 GMT+08:00 Guanglin Xu : > to avoid a magic code of 11. > > Helped-by: Eric Sunshine > Helped-by: Jacopo Notarstefano > Signed-off-by: Guanglin Xu > --- > > This is an implementation of the idea#2 of GSoC 2014 microproject. > > branch.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH v3] branch.c: change install_branch_config() to use skip_prefix()

1.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, He Sun -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] write_pack_file: use correct variable in diagnostic

e, >> strerror(errno)); >> } >> >> /* Enough space for "-.pack"? */ >> -- >> 1.9.0.138.g2de3478.dirty > > Nicely done. Everything is where it ought to be. > > As this is an actual bug fix (

Re: [PATCH v2] Place cache.h at the first place to match general rule

ain.c >> +++ b/sigchain.c >> @@ -1,5 +1,5 @@ >> -#include "sigchain.h" >> #include "cache.h" >> +#include "sigchain.h" >> >> #define SIGCHAIN_MAX_SIGNALS 32 >> >> diff --git a/test-sigchain.c b/test-sigchain.c &

Re: [PATCH v2] Replace tmpname with pack_tmp_name in warning. The developer mistook tmpname for pack_tmp_name.

2014-03-02 11:59 GMT+08:00 Eric Sunshine : > On Sat, Mar 1, 2014 at 9:43 PM, Sun He wrote: >> Subject: Replace tmpname with pack_tmp_name in warning. The developer >> mistook tmpname for pack_tmp_name. > > The subject should be a short summary of the change, and the rest of > the commit message b

Re: [PATCH] Replace memcpy with hashcpy when dealing hash copy globally

Got it. Thanks. 2014-03-01 17:13 GMT+08:00 Tay Ray Chuan : > On Sat, Mar 1, 2014 at 10:58 AM, Duy Nguyen wrote: >> On Sat, Mar 1, 2014 at 8:07 AM, Sun He wrote: >>> Signed-off-by: Sun He >>> --- >>> Find the potential places with memcpy by the bash command: >>>$ find . | xargs grep "memcpy

Re: [PATCH] Replace memcpy with hashcpy when dealing hash copy globally

2014-03-01 10:58 GMT+08:00 Duy Nguyen : > On Sat, Mar 1, 2014 at 8:07 AM, Sun He wrote: >> Signed-off-by: Sun He >> --- >> Find the potential places with memcpy by the bash command: >>$ find . | xargs grep "memcpy.*\(.*20.*\)" >> >> Helped-by: Michael Haggerty > > You may want to put this H

Re: [PATCH] Replace memcpy with hashcpy when dealing hash copy globally

2014-03-01 10:58 GMT+08:00 Duy Nguyen : > On Sat, Mar 1, 2014 at 8:07 AM, Sun He wrote: >> Signed-off-by: Sun He >> --- >> Find the potential places with memcpy by the bash command: >>$ find . | xargs grep "memcpy.*\(.*20.*\)" >> >> Helped-by: Michael Haggerty > > You may want to put this H

Re: [PATCH] implemented strbuf_write_or_die()

2014-03-01 19:21 GMT+08:00 Faiz Kothari : > Signed-off-by: Faiz Kothari > --- > Implemented write_or_die.c:strbuf_write_or_die() and used in relevant places > to substitute write_or_die(). I spotted other places where strbuf can be used > in place of buf[MAX_PATH] but that would require a change i

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

ated to bitmap, because the input packname is different from the output packname.. Cheers, He Sun > Anyways, no worries :) > > Cheers, > Faiz > > On Sat, Mar 1, 2014 at 12:40 PM, He Sun wrote: >> 2014-03-01 14:46 GMT+08:00 Faiz Kothari : >>> From: Faiz Kotahri &g

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

2014-03-01 14:46 GMT+08:00 Faiz Kothari : > From: Faiz Kotahri > > Signed-off-by: Faiz Kothari > --- > Sticking with implementation involving changing the prototype for > pack-write.c:finish_tmp_packfile() > Fixing a small bug in Sun He's implementation which caused a fail in some > tests. > >

Re: [PATCH] rewrite finish_bulk_checkin() using strbuf

e temporary index file"); > > - *end_of_name_prefix = '\0'; > - > free((void *)idx_tmp_name); > } > diff --git a/pack.h b/pack.h > index 12d9516..0afe8d1 100644 > --- a/pack.h > +++ b/pack.h > @@ -3,6 +3,7 @@ > > #include "object.h" > #include "csum-file.h" > +#include "strbuf.h" > > /* > * Packed object header > @@ -91,6 +92,6 @@ extern int encode_in_pack_object_header(enum object_type, > uintmax_t, unsigned ch > extern int read_pack_header(int fd, struct pack_header *); > > extern struct sha1file *create_tmp_packfile(char **pack_tmp_name); > -extern void finish_tmp_packfile(char *name_buffer, const char > *pack_tmp_name, struct pack_idx_entry **written_list, uint32_t nr_written, > struct pack_idx_option *pack_idx_opts, unsigned char sha1[]); > +extern void finish_tmp_packfile(struct strbuf *name_buffer, const char > *pack_tmp_name, struct pack_idx_entry **written_list, uint32_t nr_written, > struct pack_idx_option *pack_idx_opts, unsigned char sha1[]); > > #endif > -- > 1.7.9.5 > Cheers, He Sun -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rewrite bulk-checkin.c:finish_bulk_checkin() using strbuf

gt;pack_idx_opts, sha1); >>> for (i = 0; i < state->nr_written; i++) >>> diff --git a/pack-write.c b/pack-write.c >>> index 605d01b..ac38867 100644 >>> --- a/pack-write.c >>> +++ b/pack-write.c >>> @@ -336,7 +336,7 @@ struct sha1

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

the space and time costs. ^_^ > My point was that if there are multiple ways of solving the same > problem, it can be helpful for reviewers if your commit message > explains why the solution you chose is better than the others. > > Slowness and/or cleanliness of API were just examples you might use in > your commit message for justifying why you chose one approach over > another. OK, OK, Got it. Thank you very much. Cheers, He Sun -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OPTION_CMDMODE should be used when not accept an argument, and OPTION_NUMBER is of special type. So change the mode to OPTION_CMDMODE

2014-03-01 4:02 GMT+08:00 Junio C Hamano [via git] : > Duy Nguyen <[hidden email]> writes: > >> Way too long subject line. Keep it within 70-75 chars. The rest could >> be put in the body. >> >> On Fri, Feb 28, 2014 at 9:32 PM, 孙赫 <[hidden email]> wrote: >>> I am not sure if this is a bug. >>> I ne

Re: [PATCH] parse-options.c:parse_options_check() change OPTION_NUMBER to OPTION_CMDMODE

2014-03-01 3:42 GMT+08:00 Junio C Hamano : > Michael Haggerty writes: > >> On 02/28/2014 10:07 AM, Sun He wrote: >>> Signed-off-by: Sun He >>> --- >>> parse-options.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/parse-options.c b/parse-options.c >>> index 7b8d3f