[PATCH v5 1/1] sq_quote_buf_pretty: don't drop empty arguments

From: Garima Singh Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Reported by: Junio H

[PATCH v5 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

Hey, Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Looking forward to your review.

[PATCH v4 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

Hey, Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Looking forward to your review.

[PATCH v4 1/1] sq_quote_buf_pretty: don't drop empty arguments

From: Garima Singh Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Reported by: Junio H

Re: [PATCH v3 1/1] quote: handle numm and empty strings in sq_quote_buf_pretty

On 10/7/2019 1:27 PM, Eric Sunshine wrote: > On Mon, Oct 7, 2019 at 12:17 PM Garima Singh via GitGitGadget > wrote: >> quote: handle numm and empty strings in sq_quote_buf_pretty > > What is "numm"? Typo. Fixing in next update. > What does it mean to "hand

Re: [PATCH v3 1/1] quote: handle numm and empty strings in sq_quote_buf_pretty

I just noticed the typo in the commit message in my latest update. Sorry about that. Junio, would you be willing to fix it up whenever you queue the patch? Or would you like me to send another update. Thanks Garima G Singh On 10/7/2019 12:17 PM, Garima Singh via GitGitGadget wrote: > F

[PATCH v3 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

forward to your review. Cheers! Garima Singh Reported by: Junio Hamano gits...@pobox.com [gits...@pobox.com] in https://public-inbox.org/git/pull.298.git.gitgitgad...@gmail.com/T/#m9e33936067ec2066f675aa63133a2486efd415fd Garima Singh (1): quote: handle numm and empty strings in sq_quote_

[PATCH v3 1/1] quote: handle numm and empty strings in sq_quote_buf_pretty

From: Garima Singh The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. '

Re: [PATCH] add a Code of Conduct document

On 9/24/2019 2:44 AM, Jeff King wrote: > > If people are on board with this direction, it might be fun to pick up a > bunch of "Acked-by" trailers from people in the community who agree with > it. It might give it more weight if many members have publicly endorsed > it. > > I've cc'd g...@sfconse

Re: [DISCUSSION] Growing the Git community

ired, perhaps the rest of us could pick up the slack and say, "hey, your patchset was picked up by Junio in his gitster repo on this branch". I absolutely *love* this idea! Cheers! Garima Singh

Re: [DISCUSSION] Growing the Git community

ons you might have. Thanks, Garima Singh

Re: [PATCH v2 0/1] commit-graph: add --[no-]progress to write and verify

Ping :) Any more comments or concerns about this? On 8/26/2019 12:29 PM, Garima Singh via GitGitGadget wrote: Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

Ping :) Any thoughts on this? On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-grap

Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees

On 9/3/2019 10:22 PM, Taylor Blau wrote: Hi, I was running some of the new 'git commit-graph' commands, and noticed that I could consistently get 'git commit-graph write --reachable' to segfault when a commit's root tree is corrupt. I have an extremely-unfinished fix attached as an RFC PATCH

[PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

is a great start. Signed-off-by: Garima Singh garima.si...@microsoft.com [garima.si...@microsoft.com] CC: jeffh...@microsoft.com, sto...@gmail.com, garimasi...@gmail.com, ava...@gmail.com Garima Singh (1): commit-graph: emit trace2 cmd_mode for each sub-command builtin/commit-graph.c | 6

[PATCH 1/1] commit-graph: emit trace2 cmd_mode for each sub-command

From: Garima Singh Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between

[PATCH v2 0/1] commit-graph: add --[no-]progress to write and verify

Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very glad to have the opportunity to work with this community. I am new to the world of git client development but I

[PATCH v2 1/1] commit-graph: add --[no-]progress to write and verify.

From: Garima Singh Add --[no-]progress to git commit-graph write and verify. The progress feature was introduced in 7b0f229 ("commit-graph write: add progress output", 2018-09-17) but the ability to opt-out was overlooked. Signed-off-by: Garima Singh --- Documentation/git-commit

Re: [PATCH v2 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()

Thanks for the review Junio! I really appreciate it and look forward to hear what you think of the updated patch. Cheers! Garima Singh On Mon, Aug 26, 2019 at 10:44 AM Garima Singh via GitGitGadget wrote: > > From: Garima Singh > > The sq_quote_buf_pretty() function does not e

[PATCH v2 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

forward to your review. Cheers! Garima Singh Reported by: Junio Hamano gits...@pobox.com [gits...@pobox.com] in https://public-inbox.org/git/pull.298.git.gitgitgad...@gmail.com/T/#m9e33936067ec2066f675aa63133a2486efd415fd Garima Singh (1): quote: handle null and empty strings in sq_quote_

[PATCH v2 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()

From: Garima Singh The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. '

[PATCH 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()

From: Garima Singh In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg is a zero length string. It should emit quote-quote rather than nothing. This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings. [1] https://public-inbox.org/gi

[PATCH 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

Hey, In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg is a zero length string and how he believes the method should behave. This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings. Looking forward to your review. Cheers! Garima Singh

[PATCH 0/1] commit-graph: add --[no-]progress to write and verify

Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very glad to have the opportunity to work with this community. I am new to the world of git client development but I

[PATCH 1/1] commit-graph: add --[no-]progress to write and verify.

From: Garima Singh Add --[no-]progress to git commit-graph write and verify. The progress feature was introduced in 7b0f229 ("commit-graph write: add progress output", 2018-09-17) but the ability to opt-out was overlooked. Signed-off-by: Garima Singh --- Documentation/git-commit