[PATCH] fetch-pack: update the documentation for "..." arguments

2016-03-05 Thread Gabriel Souza Franco
When we started allowing an exact object name to be fetched from the command line, we forgot to update the documentation. Signed-off-by: Gabriel Souza Franco --- Documentation/git-fetch-pack.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/git-fetch-pack.txt b

[PATCH v4] fetch-pack: fix object_id of exact sha1

2016-03-04 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- Documentation/git-fetch

Re: [PATCH v3] fetch-pack: fix object_id of exact sha1

2016-03-03 Thread Gabriel Souza Franco
On Tue, Mar 1, 2016 at 1:54 AM, Jeff King wrote: > On Mon, Feb 29, 2016 at 11:12:56PM -0300, Gabriel Souza Franco wrote: > >> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, >> 2013-12-05) added support for specifying a SHA-1 as well as a ref name. >> Ad

[PATCH v3] fetch-pack: fix object_id of exact sha1

2016-02-29 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- I did keep the oid

Re: [PATCH v2] fetch-pack: fix object_id of exact sha1

2016-02-29 Thread Gabriel Souza Franco
of "", " " and "" based on a quick grep for get_oid_hex. On Mon, Feb 29, 2016 at 7:00 AM, Jeff King wrote: > On Sun, Feb 28, 2016 at 07:22:24PM -0300, Gabriel Souza Franco wrote: > >> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, >>

[PATCH v2] fetch-pack: fix object_id of exact sha1

2016-02-28 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- Not the cleanest

Re: [PATCH] fetch-pack: fix object_id of exact sha1

2016-02-27 Thread Gabriel Souza Franco
On Sat, Feb 27, 2016 at 7:12 PM, Jeff King wrote: > On Sat, Feb 27, 2016 at 05:32:54PM -0300, Gabriel Souza Franco wrote: > >> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, >> 2013-12-05) added support for specifying a SHA-1 as well as a ref name.

[PATCH] fetch-pack: fix object_id of exact sha1

2016-02-27 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- builtin/fetch-pack.c

Re: [PATCH] fetch-pack: fix unadvertised requests validation

2016-02-27 Thread Gabriel Souza Franco
On Sat, Feb 27, 2016 at 4:19 PM, Jeff King wrote: > On Sat, Feb 27, 2016 at 02:07:12PM -0500, Jeff King wrote: > >> We expect whoever creates the "sought" list to fill in the name and sha1 >> as appropriate. If that is not happening in some code path, then yeah, >> filter_refs() will not work as i

[PATCH] fetch-pack: fix unadvertised requests validation

2016-02-27 Thread Gabriel Souza Franco
Check was introduced in b791642 (filter_ref: avoid overwriting ref->old_sha1 with garbage, 2015-03-19), but was always false because ref->old_oid.hash is empty in this case. Instead copy sha1 from ref->name. Signed-off-by: Gabriel Souza Franco --- fetch-pack.c | 4 ++-- 1 file c