Re: git fsck failure on OS X with files >= 4 GiB

2015-10-29 Thread Filipe Cabecinhas
t; > produces a working git :-) > > Cheers, > Rafael > > > On 28 October 2015 at 23:37, Filipe Cabecinhas wrote: >> I did some debugging, and it seems CC_SHA1_Update (used by >> write_sha1_file_prepare if APPLE_COMMON_CRYPTO is defined in the Makefile) >> ta

Re: git fsck failure on OS X with files >= 4 GiB

2015-10-28 Thread Filipe Cabecinhas
I did some debugging, and it seems CC_SHA1_Update (used by write_sha1_file_prepare if APPLE_COMMON_CRYPTO is defined in the Makefile) takes a uint32_t as a "length" parameter, which explains why it stops working at 4GiB (UINT_MAX+1). In the OS X 10.11 SDK header CommonCrypto/CommonDigest.h, we hav

Re: write() _will_ fail on Mac OS X/XNU if nbytes > INT_MAX

2013-05-10 Thread Filipe Cabecinhas
Hi Junio, It compiles cleanly and runs. I'm running the test suite anyway, but don't expect any change from your latest patch. Thank you, Filipe F On Fri, May 10, 2013 at 4:13 PM, Filipe Cabecinhas wrote: > Hi Junio, > > Thanks for helping. Your text is correct and

Re: write() _will_ fail on Mac OS X/XNU if nbytes > INT_MAX

2013-05-10 Thread Filipe Cabecinhas
Hi Junio, Thanks for helping. Your text is correct and only diffs from my patch in the #define write(...) part, where I suppose you stripped the spaced in the arglist. Thank you, Filipe F On Fri, May 10, 2013 at 4:05 PM, Junio C Hamano wrote: > Filipe Cabecinhas writes: > >&

Re: write() _will_ fail on Mac OS X/XNU if nbytes > INT_MAX

2013-05-10 Thread Filipe Cabecinhas
. Signed-off-by: Filipe Cabecinhas --- Makefile | 5 + compat/clipped-write.c | 13 + config.mak.uname | 1 + git-compat-util.h | 5 + 4 files changed, 24 insertions(+) create mode 100644 compat/clipped-write.c diff --git a/Makefile b/Makefile index

Re: write() _will_ fail on Mac OS X/XNU if nbytes > INT_MAX

2013-05-09 Thread Filipe Cabecinhas
Hi Junio, Sorry for the delay. I've updated the patch to work as you suggested (I think). It's attached. Thank you, Filipe F On Tue, Apr 9, 2013 at 3:50 PM, Junio C Hamano wrote: > Filipe Cabecinhas writes: > >> >> Testing with dd bs=INT_MAX+1 coun

write() _will_ fail on Mac OS X/XNU if nbytes > INT_MAX

2013-04-09 Thread Filipe Cabecinhas
Hi all, While “git svn fetch”ing a subversion repository (private, sorry), I've encoutered a bug that appears in several git versions (always with the same symptoms): git from master (from 2013-04-08) git version 1.8.2.1 (compiled from homebrew) git version 1.7.12.4 (Apple Git-37) The only symp