Re: [PATCH v3] Simplify handling of setup_git_directory_gently() failure cases.

2019-01-05 Thread Erin Dahlgren
On Fri, Jan 4, 2019 at 12:26 AM Jeff King wrote: > > On Thu, Jan 03, 2019 at 10:09:18AM -0800, Junio C Hamano wrote: > > > >> @@ -1132,7 +1142,10 @@ const char *setup_git_directory_gently(int > > >> *nongit_ok) > > >> * the user has set GIT_DIR. It may be beneficial to disallow bogus > > >>

Re: [PATCH v2] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-27 Thread Erin Dahlgren
On Thu, Dec 27, 2018 at 8:24 AM Jeff King wrote: > > On Wed, Dec 26, 2018 at 02:22:39PM -0800, Junio C Hamano wrote: > > > >> Side note: One of the secondary goals of my patch was to make it > > >> really obvious that neither the GIT_DIR_HIT_CEILING nor the > > >> GIT_DIR_HIT_MOUNT_POINT case can

[PATCH v3] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-27 Thread Erin Dahlgren
setup_git_directory_gently() expects two types of failures to discover a git directory (e.g. .git/): - GIT_DIR_HIT_CEILING: could not find a git directory in any parent directories of the cwd. - GIT_DIR_HIT_MOUNT_POINT: could not find a git directory in any parent directories u

Re: [PATCH v2] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-18 Thread Erin Dahlgren
Hi Peff, On Tue, Dec 18, 2018 at 9:54 AM Jeff King wrote: > > On Sat, Dec 15, 2018 at 05:05:08PM -0800, Erin Dahlgren wrote: > > > setup_git_directory_gently() expects two types of failures to > > discover a git directory (e.g. .git/): > > [...] > > When I read

Re: [PATCH v2] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-18 Thread Erin Dahlgren
Sorry Johannes for the repeat message, I failed to send to all. On Tue, Dec 18, 2018 at 4:35 AM Johannes Schindelin wrote: > > Hi Erin, > > On Sat, 15 Dec 2018, Erin Dahlgren wrote: > > > diff --git a/setup.c b/setup.c > > index 1be5037..e1a9e17 100644 > >

[PATCH v2] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-15 Thread Erin Dahlgren
setup_git_directory_gently() expects two types of failures to discover a git directory (e.g. .git/): - GIT_DIR_HIT_CEILING: could not find a git directory in any parent directories of the cwd. - GIT_DIR_HIT_MOUNT_POINT: could not find a git directory in any parent directories u

Re: [PATCH] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-15 Thread Erin Dahlgren
On Fri, Dec 14, 2018 at 2:32 AM Johannes Schindelin wrote: > > Hi Erin, > > On Thu, 13 Dec 2018, Erin Dahlgren wrote: > > > setup_git_directory_gently() expects two types of failures to > > discover a git directory (e.g. .git/): > > > > - GIT_DIR_HIT_CEI

[PATCH] Simplify handling of setup_git_directory_gently() failure cases.

2018-12-13 Thread Erin Dahlgren
lead to the same behavior (ignoring the different help messages). Thanks-to: Johannes Schindelin Signed-off-by: Erin Dahlgren --- setup.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/setup.c b/setup.c index 1be5037..b441e39 100644 --- a