Helped-by: He Sun
Signed-off-by: Dmitry S. Dolzhenko
---
builtin/mktree.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/builtin/mktree.c b/builtin/mktree.c
index f92ba40..a964d6b 100644
--- a/builtin/mktree.c
+++ b/builtin/mktree.c
@@ -23,10 +23,7 @@ static void
Use ALLOC_GROW() instead inline code in
add_commit_info() and read_one_reflog()
Signed-off-by: Dmitry S. Dolzhenko
---
reflog-walk.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/reflog-walk.c b/reflog-walk.c
index b2fbdb2..2899729 100644
--- a/reflog-walk.c
Signed-off-by: Dmitry S. Dolzhenko
---
commit.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/commit.c b/commit.c
index 6bf4fe0..e004314 100644
--- a/commit.c
+++ b/commit.c
@@ -147,12 +147,8 @@ int register_commit_graft(struct commit_graft *graft, int
ignore_dups
Signed-off-by: Dmitry S. Dolzhenko
---
read-cache.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/read-cache.c b/read-cache.c
index fb440b4..cbdf954 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -990,11 +990,7 @@ int add_index_entry(struct index_state *istate, struct
Signed-off-by: Dmitry S. Dolzhenko
---
patch-ids.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c
index bc8a28f..bf81b92 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -83,10 +83,7 @@ static struct patch_id *add_commit(struct commit *commit
Signed-off-by: Dmitry S. Dolzhenko
---
attr.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/attr.c b/attr.c
index 8d13d70..734222d 100644
--- a/attr.c
+++ b/attr.c
@@ -338,12 +338,7 @@ static void handle_attr_line(struct attr_stack *res,
a = parse_attr_line
Use ALLOC_GROW() instead inline code in
locate_rename_dst() and register_rename_src()
Signed-off-by: Dmitry S. Dolzhenko
---
diffcore-rename.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diffcore-rename.c b/diffcore-rename.c
index 9b4f068..fbf3272 100644
Use ALLOC_GROW() instead inline code in
diffstat_add() and diff_q()
Signed-off-by: Dmitry S. Dolzhenko
---
diff.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diff.c b/diff.c
index e800666..aebdfda 100644
--- a/diff.c
+++ b/diff.c
@@ -1361,11 +1361,7
Signed-off-by: Dmitry S. Dolzhenko
---
bundle.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/bundle.c b/bundle.c
index e99065c..1388a3e 100644
--- a/bundle.c
+++ b/bundle.c
@@ -14,11 +14,7 @@ static const char bundle_signature[] = "# v2 git bundle\n";
s
Signed-off-by: Dmitry S. Dolzhenko
---
builtin/pack-objects.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..0ffad6f 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -1213,12 +1213,9
Helped-by: He Sun
Signed-off-by: Dmitry S. Dolzhenko
---
sha1_file.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 019628a..3cb17b8 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2624,12 +2624,7 @@ int pretend_sha1_file(void *buf
Signed-off-by: Dmitry S. Dolzhenko
---
cache-tree.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c
index 0bbec43..30149d1 100644
--- a/cache-tree.c
+++ b/cache-tree.c
@@ -75,11 +75,7 @@ static struct cache_tree_sub *find_subtree(struct
Signed-off-by: Dmitry S. Dolzhenko
---
dir.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dir.c b/dir.c
index 98bb50f..4ae38e4 100644
--- a/dir.c
+++ b/dir.c
@@ -1341,10 +1341,7 @@ static struct path_simplify *create_simplify(const char
**pathspec)
for (nr
Signed-off-by: Dmitry S. Dolzhenko
---
replace_object.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/replace_object.c b/replace_object.c
index cdcaf8c..843deef 100644
--- a/replace_object.c
+++ b/replace_object.c
@@ -36,12 +36,8 @@ static int
://thread.gmane.org/gmane.comp.version-control.git/242919
[2] http://thread.gmane.org/gmane.comp.version-control.git/242920
Dmitry S. Dolzhenko (14):
builtin/pack-objects.c: use ALLOC_GROW() in check_pbase_path()
bundle.c: use ALLOC_GROW() in add_to_ref_list()
cache-tree.c: use AL
Signed-off-by: Dmitry S. Dolzhenko
---
attr.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/attr.c b/attr.c
index 8d13d70..734222d 100644
--- a/attr.c
+++ b/attr.c
@@ -338,12 +338,7 @@ static void handle_attr_line(struct attr_stack *res,
a = parse_attr_line
Signed-off-by: Dmitry S. Dolzhenko
---
dir.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dir.c b/dir.c
index 98bb50f..4ae38e4 100644
--- a/dir.c
+++ b/dir.c
@@ -1341,10 +1341,7 @@ static struct path_simplify *create_simplify(const char
**pathspec)
for (nr
Use ALLOC_GROW() instead inline code in
add_commit_info() and read_one_reflog()
Signed-off-by: Dmitry S. Dolzhenko
---
reflog-walk.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/reflog-walk.c b/reflog-walk.c
index b2fbdb2..2899729 100644
--- a/reflog-walk.c
Signed-off-by: Dmitry S. Dolzhenko
---
replace_object.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/replace_object.c b/replace_object.c
index cdcaf8c..843deef 100644
--- a/replace_object.c
+++ b/replace_object.c
@@ -36,12 +36,8 @@ static int
Signed-off-by: Dmitry S. Dolzhenko
---
patch-ids.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c
index bc8a28f..bf81b92 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -83,10 +83,7 @@ static struct patch_id *add_commit(struct commit *commit
Use ALLOC_GROW() instead inline code in
locate_rename_dst() and register_rename_src()
Signed-off-by: Dmitry S. Dolzhenko
---
diffcore-rename.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diffcore-rename.c b/diffcore-rename.c
index 9b4f068..fbf3272 100644
Use ALLOC_GROW() instead inline code in
diffstat_add() and diff_q()
Signed-off-by: Dmitry S. Dolzhenko
---
diff.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diff.c b/diff.c
index e800666..aebdfda 100644
--- a/diff.c
+++ b/diff.c
@@ -1361,11 +1361,7
Signed-off-by: Dmitry S. Dolzhenko
---
cache-tree.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c
index 0bbec43..30149d1 100644
--- a/cache-tree.c
+++ b/cache-tree.c
@@ -75,11 +75,7 @@ static struct cache_tree_sub *find_subtree(struct
Signed-off-by: Dmitry S. Dolzhenko
---
commit.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/commit.c b/commit.c
index 6bf4fe0..e004314 100644
--- a/commit.c
+++ b/commit.c
@@ -147,12 +147,8 @@ int register_commit_graft(struct commit_graft *graft, int
ignore_dups
Signed-off-by: Dmitry S. Dolzhenko
---
bundle.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/bundle.c b/bundle.c
index e99065c..1388a3e 100644
--- a/bundle.c
+++ b/bundle.c
@@ -14,11 +14,7 @@ static const char bundle_signature[] = "# v2 git bundle\n";
s
Signed-off-by: Dmitry S. Dolzhenko
---
builtin/pack-objects.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..0ffad6f 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -1213,12 +1213,9
Dmitry S. Dolzhenko (11):
builtin/pack-objects.c: use ALLOC_GROW() in check_pbase_path()
bundle.c: use ALLOC_GROW() in add_to_ref_list()
cache-tree.c: use ALLOC_GROW() in find_subtree()
commit.c: use ALLOC_GROW() in register_commit_graft()
diff.c: use ALLOC_GROW()
diffcore-rename.c
Michael,
On 28.02.2014 18:38, Michael Haggerty wrote:
> Everything looks fine to me. Assuming the test suite ran 100%,
>
> Acked-by: Michael Haggerty
All tests passed successfully for this patch, at least on my machine.
Can I do something else to improve this patch?
--
To unsubscribe from this
Signed-off-by: Dmitry S. Dolzhenko
---
attr.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/attr.c b/attr.c
index 8d13d70..734222d 100644
--- a/attr.c
+++ b/attr.c
@@ -338,12 +338,7 @@ static void handle_attr_line(struct attr_stack *res,
a = parse_attr_line
Signed-off-by: Dmitry S. Dolzhenko
---
dir.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dir.c b/dir.c
index 98bb50f..4ae38e4 100644
--- a/dir.c
+++ b/dir.c
@@ -1341,10 +1341,7 @@ static struct path_simplify *create_simplify(const char
**pathspec)
for (nr
Affected functions: read_one_reflog(), add_commit_info()
Signed-off-by: Dmitry S. Dolzhenko
---
reflog-walk.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/reflog-walk.c b/reflog-walk.c
index b2fbdb2..879d2ed 100644
--- a/reflog-walk.c
+++ b/reflog-walk.c
Signed-off-by: Dmitry S. Dolzhenko
---
replace_object.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/replace_object.c b/replace_object.c
index cdcaf8c..843deef 100644
--- a/replace_object.c
+++ b/replace_object.c
@@ -36,12 +36,8 @@ static int
Signed-off-by: Dmitry S. Dolzhenko
---
patch-ids.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/patch-ids.c b/patch-ids.c
index bc8a28f..bf81b92 100644
--- a/patch-ids.c
+++ b/patch-ids.c
@@ -83,10 +83,7 @@ static struct patch_id *add_commit(struct commit *commit
Affected functions: locate_rename_dst(), register_rename_src()
Signed-off-by: Dmitry S. Dolzhenko
---
diffcore-rename.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diffcore-rename.c b/diffcore-rename.c
index 9b4f068..fbf3272 100644
--- a/diffcore-rename.c
Signed-off-by: Dmitry S. Dolzhenko
---
diff.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/diff.c b/diff.c
index e800666..aebdfda 100644
--- a/diff.c
+++ b/diff.c
@@ -1361,11 +1361,7 @@ static struct diffstat_file *diffstat_add(struct
diffstat_t *diffstat
Signed-off-by: Dmitry S. Dolzhenko
---
commit.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/commit.c b/commit.c
index 6bf4fe0..e004314 100644
--- a/commit.c
+++ b/commit.c
@@ -147,12 +147,8 @@ int register_commit_graft(struct commit_graft *graft, int
ignore_dups
Signed-off-by: Dmitry S. Dolzhenko
---
cache-tree.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/cache-tree.c b/cache-tree.c
index 0bbec43..30149d1 100644
--- a/cache-tree.c
+++ b/cache-tree.c
@@ -75,11 +75,7 @@ static struct cache_tree_sub *find_subtree(struct
Signed-off-by: Dmitry S. Dolzhenko
---
bundle.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/bundle.c b/bundle.c
index e99065c..1388a3e 100644
--- a/bundle.c
+++ b/bundle.c
@@ -14,11 +14,7 @@ static const char bundle_signature[] = "# v2 git bundle\n";
s
Signed-off-by: Dmitry S. Dolzhenko
---
builtin/pack-objects.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..56a6fc8 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -1213,12 +1213,7
Thank you for your remarks. In this patch I tried to take them into account.
Dmitry S. Dolzhenko (11):
builtin/pack-objects.c: change check_pbase_path() to use ALLOC_GROW()
bundle.c: change add_to_ref_list() to use ALLOC_GROW()
cache-tree.c: change find_subtree() to use ALLOC_GROW
Signed-off-by: Dmitry S. Dolzhenko
---
attr.c | 7 +--
builtin/pack-objects.c | 7 +--
bundle.c | 6 +-
cache-tree.c | 6 +-
commit.c | 8 ++--
diff.c | 12 ++--
diffcore-rename.c | 12
Change install_branch_config() to use skip_prefix()
for getting the short name of the remote branch.
Signed-off-by: Dmitry S. Dolzhenko
---
branch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..9382e02 100644
--- a/branch.c
+++ b
Michael,
Thank you for your remarks.
> If you look at what skip_prefix() and starts_with() do, I think you will
> find that you are doing too much work here.
How about this one?
const char *shortname = skip_prefix(remote, "refs/heads/");
int remote_is_branch = shortname != NULL;
Change install_branch_config() function to use skip_prefix()
for getting short name of remote branch.
Signed-off-by: Dmitry S. Dolzhenko
---
branch.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..310749b 100644
--- a/branch.c
+++ b
Thank you for your remarks. I'll try to fix my patch and send it again.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Refactor binary search in "commit_graft_pos" function: use
generic "sha1_pos" function.
Signed-off-by: Dmitry S. Dolzhenko
---
commit.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/commit.c b/commit.c
index 6bf4fe0..6ceee6a 1
Refactor binary search in "commit_graft_pos" function: use
generic "sha1_pos" function.
Signed-off-by: Dmitry S. Dolzhenko
---
commit.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/commit.c b/commit.c
index 6bf4fe0..8edaeb7 1
Hi.
I was just going to write an email about that I would like to
participate in GSoC and contribute to Git project.
I don't have wide experience in C programming, but I could be start as a
"janitor". I found several tasks here
https://git.wiki.kernel.org/index.php/Janitor. For example "Refa
48 matches
Mail list logo