Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

2014-03-31 Thread David Tran
> Junio C Hamano pobox.com> writes: > > > I would have to say that there is already an established pattern to > pick ranges that normal people understand well and it would be silly > to invent another more verbose way to express the same thing. You > tell your Print Dialog which page to print wi

Re: [PATCH 1/8] Import $LS_COLORS parsing code from coreutils

2014-03-21 Thread David Tran
Duy Nguyen gmail.com> writes: > On Fri, Mar 21, 2014 at 2:09 AM, David Tran gmail.com> wrote: > > Nguyễn Thái Ngọc Duy gmail.com> writes: > > > >> This could could help highlight files in ls-files or status output, or > >> even diff --name-only (but th

Re: [PATCH 1/8] Import $LS_COLORS parsing code from coreutils

2014-03-20 Thread David Tran
Nguyễn Thái Ngọc Duy gmail.com> writes: > This could could help highlight files in ls-files or status output, or > even diff --name-only (but that's questionable). > > This code is from coreutils.git commit > 7326d1f1a67edf21947ae98194f98c38b6e9e527 file src/ls.c. This is the > last GPL-2 commit

[PATCH v4] tests: use "env" to run commands with temporary env-var settings

2014-03-20 Thread David Tran
ng the "env" utility, we should be able to say test_must_fail git command to be tested which is much shorter and easier to read. Signed-off-by: David Tran --- Revision update: v1[1] and v2[2] fixed broken &&-chains and removed subshells that are no longer needed. v3[3] fixed typ

[PATCH v3] tests: use "env" to run commands with temporary env-var settings

2014-03-18 Thread David Tran
uot; utility, we should be able to say test_must_fail git command to be tested which is much short and easier to read. Signed-off-by: David Tran --- >>Let's see if I replied correctly with send-email. Retrying this again. >>How do I 'reply' to a thread using

[PATCH v2] tests: set temp variables using 'env' in test function instead of subshell

2014-03-18 Thread David Tran
nction sets the temp variables without leaking, removing the need of a subshell. Signed-off-by: David Tran --- Let's see if I replied correctly with send-email. Retrying this again. How do I 'reply' to a thread using send-email? I am David Tran a graduating CS/Math senior from Sonoma

[PATCH] tests: set temp variables using 'env' in test function instead of subshell

2014-03-17 Thread David Tran
nction sets the temp variables without leaking, removing the need of a subshell. Signed-off-by: David Tran --- Let's see if I replied correctly with send-email. I am David Tran a graduating CS/Math senior from Sonoma State University, United States. I would like to work with git for GSoC'14,

[PATCH] Removed subshell invocations in many of the tests when possible

2014-03-16 Thread David Tran
I am David Tran a graduating CS/Math senior from Sonoma State University, United States. I would like to work with git for GSoC'14, specifically the line options for git rebase --interactive. I have used git for a few years and know how destructive but important rebase is to git. I have crea