Re: [PATCH v2] compat: convert modes to use portable file type values

2014-12-04 Thread David Michael
On Wed, Dec 3, 2014 at 9:24 PM, David Michael wrote: > --- /dev/null > +++ b/compat/stat.c > @@ -0,0 +1,49 @@ > +#define _POSIX_C_SOURCE 200112L > +#include /* NULL */ > +#include /* *stat, S_IS* */ > +#include /* mode_t */ Oops, the line can be remove

[PATCH v2] compat: convert modes to use portable file type values

2014-12-03 Thread David Michael
g the translated modes. This makes projects portable across operating systems that use different file type definitions. Only the file type bits may be affected by these compatibility functions; the file permission bits are assumed to be 0 and are passed through unchanged. Signed-off-by: David Mi

Re: [PATCH] compat: convert modes to use portable file type values

2014-12-01 Thread David Michael
On Mon, Dec 1, 2014 at 12:57 PM, Junio C Hamano wrote: > David Michael writes: > >> On Mon, Dec 1, 2014 at 9:44 AM, Duy Nguyen wrote: >>> On Sun, Nov 30, 2014 at 9:41 AM, David Michael wrote: >>>> +int git_stat(const char *path, struct stat *buf) >>>

Re: [PATCH] compat: convert modes to use portable file type values

2014-12-01 Thread David Michael
On Mon, Dec 1, 2014 at 9:44 AM, Duy Nguyen wrote: > On Sun, Nov 30, 2014 at 9:41 AM, David Michael wrote: >> +int git_stat(const char *path, struct stat *buf) >> +{ >> + int rc; >> + rc = stat(path, buf); >> + if (buf != NULL) > >

Re: [PATCH] compat: convert modes to use portable file type values

2014-12-01 Thread David Michael
On Mon, Dec 1, 2014 at 7:48 AM, David Michael wrote: > On Mon, Dec 1, 2014 at 12:55 AM, Torsten Bögershausen wrote: >> On 12/01/2014 04:40 AM, David Michael wrote: >>> >>> On Sun, Nov 30, 2014 at 3:16 PM, Torsten Bögershausen >>> wrote: >>> [snip] &g

Re: [PATCH] compat: convert modes to use portable file type values

2014-12-01 Thread David Michael
On Mon, Dec 1, 2014 at 12:55 AM, Torsten Bögershausen wrote: > On 12/01/2014 04:40 AM, David Michael wrote: >> >> On Sun, Nov 30, 2014 at 3:16 PM, Torsten Bögershausen >> wrote: >> [snip] >>> >>> Could the code be more human-readable ? >&

Re: [PATCH] compat: convert modes to use portable file type values

2014-11-30 Thread David Michael
On Sun, Nov 30, 2014 at 3:16 PM, Torsten Bögershausen wrote: [snip] > Could the code be more human-readable ? > static inline mode_t mode_native_to_git(mode_t native_mode) > { > int perm_bits = native_mode & 0; > if (S_ISREG(native_mode)) > return 010 | perm

[PATCH] compat: convert modes to use portable file type values

2014-11-29 Thread David Michael
g the translated modes. This makes projects portable across operating systems that use different file type definitions. Only the file type bits may be affected by these compatibility functions; the file permission bits are assumed to be 0 and are passed through unchanged. Signed-off-by: David Mi

Re: [PATCH 3/3] compat/bswap.h: Detect endianness from XL C compiler macros

2014-10-26 Thread David Michael
On Sun, Oct 26, 2014 at 2:38 PM, Jeff King wrote: > On Sun, Oct 26, 2014 at 01:34:26PM -0400, David Michael wrote: > >> diff --git a/compat/bswap.h b/compat/bswap.h >> index f6fd9a6..7fed637 100644 >> --- a/compat/bswap.h >> +++ b/compat/bswap.h >> @@ -122

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread David Michael
On Sun, Oct 26, 2014 at 2:35 PM, Jeff King wrote: > On Sun, Oct 26, 2014 at 01:45:10PM -0400, Eric Sunshine wrote: > >> On Sun, Oct 26, 2014 at 1:33 PM, David Michael wrote: >> > The XL C compiler can fail due to mixing library path and object >> >> Can you

[PATCH 3/3] compat/bswap.h: Detect endianness from XL C compiler macros

2014-10-26 Thread David Michael
There is no /usr/include/endian.h equivalent on z/OS, but the compiler will define macros to indicate endianness on host and target hardware. This adds a test for these macros as a last resort for determining byte order. Signed-off-by: David Michael --- compat/bswap.h | 4 1 file changed

[PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread David Michael
Signed-off-by: David Michael --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fcd51ac..827006b 100644 --- a/Makefile +++ b/Makefile @@ -1610,8 +1610,8 @@ git.sp git.s git.o: EXTRA_CPPFLAGS = \ '-DGIT_INFO_PATH="$

[PATCH 1/3] git-compat-util.h: Support variadic macros with the XL C compiler

2014-10-26 Thread David Michael
When the XL C compiler is run with an appropriate language level or suboption, it defines a feature test macro to indicate support for variadic macros. This was tested on z/OS, but it should also work on AIX according to IBM documentation. Signed-off-by: David Michael --- git-compat-util.h | 2

Re: Subtree in Git

2013-03-02 Thread David Michael Barr
On Sat, Mar 2, 2013 at 9:05 AM, Paul Campbell wrote: > On Fri, Mar 1, 2013 at 2:28 AM, Kindjal wrote: >> David Michael Barr rr-dav.id.au> writes: >> >>> From a quick survey, it appears there are no more than 55 patches >>> squashed into the submitted pat

Re: [PATCH] Improve QNX support in GIT

2013-02-26 Thread David Michael
Hi, On Tue, Feb 26, 2013 at 12:25 PM, Matt Kraai wrote: > I didn't realize that QNX 6.3.2 provided getpagesize. Its header > files don't provide a prototype, so when I saw the warning, I assumed > it wasn't available. Since NO_GETPAGESIZE is only used by QNX, if > it's OK to reintroduce the war

[PATCH] git-compat-util.h: Provide missing netdb.h definitions

2013-02-25 Thread David Michael
Some platforms may lack the NI_MAXHOST and NI_MAXSERV values in their system headers, so ensure they are available. Signed-off-by: David Michael --- NI_MAXHOST is missing from my platform, and it has no compatibility definition anywhere. $ grep -FIR NI_MAXHOST imap-send.c

Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

2013-01-07 Thread David Michael
Hi, On Sat, Jan 5, 2013 at 3:55 AM, Nguyễn Thái Ngọc Duy wrote: > Perhaps this will help the getenv bug hunting (I assume we do the > hunting on Linux platform only). So far it catches this and is stuck > at getenv in git_pager(). For the record: I have been testing a macro pointing getenv at

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread David Michael
Hi, On Fri, Jan 4, 2013 at 8:17 PM, Junio C Hamano wrote: > In fact, > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/getenv.html > > says that only setenv(), unsetenv() and putenv() may invalidate > previous return values. Note that getenv() is not listed as a > function that i

[BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-04 Thread David Michael
platforms. Signed-off-by: David Michael --- I have encountered an issue with consecutive calls to getenv overwriting earlier values. Most notably, it prevents a plain "git clone" from working. Long story short: This value of GIT_DIR gets passed around setup.c until

Re: [RFC] test: Old shells and physical paths

2012-12-20 Thread David Michael
Hi, On Thu, Dec 20, 2012 at 12:01 AM, David Aguilar wrote: > Do you know if the differences are relegated to "cd", > or do other common commands such as awk, grep, sed, mktemp, expr, > etc. have similar issues? There are almost certainly going to be incompatibilities with other commands. The sy

Re: [RFC] test: Old shells and physical paths

2012-12-19 Thread David Michael
Hi, On Thu, Dec 20, 2012 at 12:17 AM, Junio C Hamano wrote: > Is "here is a nickel, get a better shell" an option? It is, somewhat. There is a pre-built port of GNU bash 2.03 for the platform, but I was trying to see how far things could go with the OS's supported shell before having to bring i

Re: [PATCH 1/4] Support builds when sys/param.h is missing

2012-12-14 Thread David Michael
Hi, On Fri, Dec 14, 2012 at 6:41 PM, Junio C Hamano wrote: > I have this suspicion that nobody would notice if we simply stopped > including the header. While I'm not aware of any subtleties it could be causing on other platforms, it does seem fine to drop sys/param.h on my test GNU/Linux system

[PATCH 3/4] Generalize the inclusion of strings.h

2012-12-14 Thread David Michael
The header strings.h was formerly only included for a particular platform to define strcasecmp, but another platform requiring this inclusion has been found. The build system will now include the file based on its presence determined by configure. Signed-off-by: David Michael --- Makefile

[PATCH 4/4] Declare that HP NonStop systems require strings.h

2012-12-14 Thread David Michael
This platform previously included strings.h automatically. However, the build system now requires an explicit option to do so. Signed-off-by: David Michael --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index fb78f7f..e84b0cb 100644 --- a/Makefile +++ b

[PATCH 2/4] Detect when the passwd struct is missing pw_gecos

2012-12-14 Thread David Michael
NO_GECOS_IN_PWENT was documented with other Makefile variables but was only enforced by manually defining it to the C preprocessor. This adds support for detecting the condition with configure and defining the make variable. Signed-off-by: David Michael --- Makefile | 3 +++ configure.ac

[PATCH 1/4] Support builds when sys/param.h is missing

2012-12-14 Thread David Michael
An option is added to the Makefile to skip the inclusion of sys/param.h. The only known platform with this condition thus far is the z/OS UNIX System Services environment. Signed-off-by: David Michael --- Makefile | 5 + configure.ac | 6 ++ git-compat-util.h | 2 ++ 3

Re: Build fixes for another obscure Unix

2012-12-14 Thread David Michael
Hi, On Fri, Dec 14, 2012 at 2:54 AM, Joachim Schmitz wrote: > For what's it worth: I ACK your HP-NonStop patch (as you can see by my > comment in git-compat-util.h I was thinking along the same line) > https://github.com/dm0-/git/commit/933d72a5cfdc63fa9c3c68afa2f4899d9c3f791e > together with its

Re: Build fixes for another obscure Unix

2012-12-13 Thread David Michael
Hi, On Thu, Dec 13, 2012 at 12:18 PM, Pyeron, Jason J CTR (US) wrote: >> Would there be any interest in applying such individual compatibility >> fixes for this system, even if a full port doesn't reach completion? > > What are the down sides? Can your changes be shown to not impact builds on >

Re: remote-testsvn: Hangs at revision

2012-12-05 Thread David Michael Barr
the end of the clone: warning: remote HEAD refers to nonexistent ref, unable to checkout. -- David Michael Barr -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] pack-objects: compression level for non-blobs

2012-11-26 Thread David Michael Barr
levels mismatch. > Limit its application to when the config pack.graphcompression is set. > > Signed-off-by: David Michael Barr (mailto:b...@rr-dav.id.au)> > --- > builtin/pack-objects.c | 49 + > 1 file changed, 45 insertio

[RFC] pack-objects: compression level for non-blobs

2012-11-25 Thread David Michael Barr
its application to when the config pack.graphcompression is set. Signed-off-by: David Michael Barr --- builtin/pack-objects.c | 49 + 1 file changed, 45 insertions(+), 4 deletions(-) I started working on this just before taking a vacation, so it&#

Re: Subtree in Git

2012-10-26 Thread David Michael Barr
is so I would also have to > re-discover everything. >From a quick survey, it appears there are no more than 55 patches squashed into the submitted patch. As I have an interest in git-subtree for maintaining the out-of-tree version of vcs-svn/ and a desire to improve my rebase-fu, I am t

Re: What's cooking in git.git (Oct 2012, #01; Tue, 2)

2012-10-04 Thread David Michael Barr
ting for comments from mentors and stakeholders. I have reviewed this topic and am happy with the design and implementation. I support this topic for inclusion. Acked-by: David Michael Barr > > * fa/vcs-svn (2012-09-19) 4 commits > - vcs-svn: remove repo_tree > - vcs-svn/svndump:

Re: Using bitmaps to accelerate fetch and clone

2012-09-27 Thread David Michael Barr
rver side greatly, perhaps a >> GitHubber ;-) might want to work on this on C Git, for GitHub itself >> of course, and, as a side effect, make the rest of us happy? > > Yeah, GitHub is definitely interested in this. I may take a shot at it, > but I know David Barr (cc'

Re: Failing svn imports from apache.org

2012-09-17 Thread David Michael Barr
extract the standard layout into a new repo. * Use git-svn to keep the new repo up-to-date. -- David Michael Barr On Saturday, 15 September 2012 at 8:07 PM, Enrico Weigelt wrote: > > > > Does anyone have an idea, what might be wrong here / how to fix it > > > ? > >

Re: [RFC 1/5] GSOC: prepare svndump for branch detection

2012-08-18 Thread David Michael Barr
c logic into vcs-svn. > [RFC 2/5] svndump: move struct definitions to .h. > [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling > [RFC 4/5] vcs-svn/svndump: rewrite handle_node(), > [RFC 5/5] vcs-svn: remove repo_tree I haven't read the rest of the series yet but I exp

Re: [PATCH/RFC v3 00/16] GSOC remote-svn

2012-08-14 Thread David Michael Barr
l no longer be reachable on this address after Friday. I hope to make future contributions with the identity: David Michael Barr This will be my persistent address. -- David Barr -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL] vcs-svn housekeeping

2012-07-06 Thread David Michael Barr
On Sat, Jul 7, 2012 at 3:10 AM, Jonathan Nieder wrote: > Hi Junio, > > The following changes since commit 58ebd9865d2bb9d42842fbac5a1c4eae49e92859: > > vcs-svn/svndiff.c: squelch false "unused" warning from gcc (2012-01-27 > 11:58:56 -0800) > > are available at: > > git://repo.or.cz/git/jrn.g