[PATCH v2] git-prompt.sh: add submodule indicator

2017-02-02 Thread Benjamin Fuchs
Hi everyone again, I guess this time I'm rerolling my patch the right way. Thanks again Gábor for your feedback. And thanks to Junio for being patient and explaining the reroll workflow Greeting, Benjamin Benjamin Fuchs (1): git-prompt.sh: add submodule indicator contrib/completio

[PATCH v2] git-prompt.sh: add submodule indicator

2017-02-02 Thread Benjamin Fuchs
new prompt will look like this: (sub:master). If the currently checked out submodule commit does not match the SHA-1 found in the index of the containing repository a "+" will be prepended (+sub:master). Adding a new optional env variable for the new feature. Signed-off-by: Benj

Re: [PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Benjamin Fuchs
Hi Junio, thanks for your reply. Some of your suggestions are covered by my rework in Patch [2/4]. In [2/4] I got rid of the loop by feedback of Gábor. Sorry if my patch wasn't well formed. On 31.01.2017 00:48, Junio C Hamano wrote: Benjamin Fuchs writes: I expirienced that working

[PATCH 0/4] git-prompt.sh: Full patch for submodule indicator

2017-01-30 Thread Benjamin Fuchs
eaper then the first version and has a 'dirty' indicator now. Tests exist also now. Looking forward to more feedback! Greetings, Benjamin Benjamin Fuchs (4): git-prompt.sh: add submodule indicator git-prompt.sh: rework of submodule indicator git-prompt.sh: fix for submodule 'di

[PATCH 4/4] git-prompt.sh: add tests for submodule indicator

2017-01-30 Thread Benjamin Fuchs
Signed-off-by: Benjamin Fuchs --- t/t9903-bash-prompt.sh | 43 +++ 1 file changed, 43 insertions(+) diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh index 97c9b32..4dce366 100755 --- a/t/t9903-bash-prompt.sh +++ b/t/t9903-bash-prompt.sh

[PATCH 3/4] git-prompt.sh: fix for submodule 'dirty' indicator

2017-01-30 Thread Benjamin Fuchs
Fixing wrong git diff line. Signed-off-by: Benjamin Fuchs --- contrib/completion/git-prompt.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index c44b9a2..43b28e9 100644 --- a/contrib/completion/git

[PATCH 2/4] git-prompt.sh: rework of submodule indicator

2017-01-30 Thread Benjamin Fuchs
Rework of the first patch. The prompt now will look like this: (+name:master). I tried to considere all suggestions. Tests still missing. Signed-off-by: Benjamin Fuchs --- contrib/completion/git-prompt.sh | 49 1 file changed, 24 insertions(+), 25

[PATCH 1/4] git-prompt.sh: add submodule indicator

2017-01-30 Thread Benjamin Fuchs
I expirienced that working with submodules can be confusing. This indicator will make you notice very easy when you switch into a submodule. The new prompt will look like this: (sub:master) Adding a new optional env variable for the new feature. Signed-off-by: Benjamin Fuchs --- contrib

[PATCH 4/4] git-prompt.sh: add tests for submodule indicator

2017-01-22 Thread Benjamin Fuchs
--- t/t9903-bash-prompt.sh | 43 +++ 1 file changed, 43 insertions(+) diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh index 97c9b32..4dce366 100755 --- a/t/t9903-bash-prompt.sh +++ b/t/t9903-bash-prompt.sh @@ -37,6 +37,11 @@ test_expect_success

[PATCH 3/3] git-prompt.sh: fix for submodule 'dirty' indicator

2017-01-22 Thread Benjamin Fuchs
Fixing wrong git diff line. --- contrib/completion/git-prompt.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index c44b9a2..43b28e9 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completi

[PATCH 2/2] git-prompt.sh: rework of submodule indicator

2017-01-22 Thread Benjamin Fuchs
Rework of the first patch. The prompt now will look like this: (+name:master). I tried to considere all suggestions. Tests still missing. --- contrib/completion/git-prompt.sh | 49 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/contrib/comp

[PATCH] git-prompt.sh: add submodule indicator

2017-01-19 Thread Benjamin Fuchs
I expirienced that working with submodules can be confusing. This indicator will make you notice very easy when you switch into a submodule. The new prompt will look like this: (sub:master) Adding a new optional env variable for the new feature. Signed-off-by: Benjamin Fuchs --- contrib