On 2018-08-21 15:22:43, Eric Sunshine wrote:
> On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré wrote:
>> On 2018-08-08 18:10:22, Matthieu Moy wrote:
>> > "jrnieder" wrote:
>> >> (+cc: some folks interested in git-remote-mediawiki)
>> >
>> &g
On 2018-08-08 18:10:22, Matthieu Moy wrote:
> "jrnieder" wrote:
>
>> (+cc: some folks interested in git-remote-mediawiki)
>
> Thanks.
>
> In case it still matters, an obvious Acked-by: Matthieu Moy
>
Hi,
I seem to have lost context of the original email, and can't find a copy
on public-inbox.o
From: Ingo Ruhnke
we still want to use spaces as separators in the config, but we should
allow the user to specify namespaces with spaces, so we use underscore
for this.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file
Yet another reroll to fix a typo.
On 2017-11-07 10:45:27, Thomas Adam wrote:
> On Mon, Nov 06, 2017 at 04:19:49PM -0500, Antoine Beaupré wrote:
>> If we fail to find a requested namespace, we should tell the user
>> which ones we know about, since those were already fetched. This
>> allows users to fe
awiki/issues/30
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index c9f46359b..af9cbc9d0 100755
--- a/contrib/mw-to-git/git-r
s are currently
"Special" (-1) and "Media" (-2) but we treat all negative namespaces
as "virtual" as a future-proofing mechanism.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Ideally, we'd process them in numeric order since that is more
logical, but we can't do that yet since this is where we find the
numeric identifiers in the first place. Lexicographic order is a good
compromise.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawik
that allows fetching all namespaces
automatically.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git
ecify
"(Main)" since that is the publicly documented name.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-rem
From: Kevin
This introduces a new remote.origin.namespaces argument that is a
space-separated list of namespaces. The list of pages extract is then
taken from all the specified namespaces.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote
On 2017-11-07 07:08:08, Thomas Adam wrote:
> On Mon, Nov 06, 2017 at 04:19:48PM -0500, Antoine Beaupré wrote:
>> From: Ingo Ruhnke
>>
>> we still want to use spaces as separators in the config, but we should
>> allow the user to specify namespaces with spaces, so we
On 2017-11-07 09:44:03, Junio C Hamano wrote:
> Antoine Beaupré writes:
>
>> On 2017-10-31 10:37:29, Junio C Hamano wrote:
>>>> There's also a hybrid solution used by git-multimail: have a copy of the
>>>> code in git.git, but do the development separate
Hopefully, the final series. This includes only one more fix, from
Thomas, to remove an extra loop.
This should, alas, be ready to merge.
From: Ingo Ruhnke
we still want to use spaces as separators in the config, but we should
allow the user to specify namespaces with spaces, so we use underscore
for this.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file
awiki/issues/30
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index 7dccb44e0..fcdc29197 100755
--- a/contrib/mw-to-git/git-r
that allows fetching all namespaces
automatically.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git
s are currently
"Special" (-1) and "Media" (-2) but we treat all negative namespaces
as "virtual" as a future-proofing mechanism.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Ideally, we'd process them in numeric order since that is more
logical, but we can't do that yet since this is where we find the
numeric identifiers in the first place. Lexicographic order is a good
compromise.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawik
ecify
"(Main)" since that is the publicly documented name.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-rem
From: Kevin
This introduces a new remote.origin.namespaces argument that is a
space-separated list of namespaces. The list of pages extract is then
taken from all the specified namespaces.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote
On 2017-11-02 22:31:02, Thomas Adam wrote:
> On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote:
>> On 2017-11-02 22:18:07, Thomas Adam wrote:
>> > Hi,
>> >
>> > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
>> >>
On 2017-11-02 18:43:00, Eric Sunshine wrote:
> On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote:
>> Virtual namespaces do not correspond to pages in the database and are
>> automatically generated by MediaWiki. It makes little sense,
>> therefore, to fetch pages from tho
On 2017-11-02 22:18:07, Thomas Adam wrote:
> Hi,
>
> On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
>> +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace
>> ($namespace_id)\n";
>
> How is this any different to using
s are currently
"Special" (-1) and "Media" (-2) but we treat all negative namespaces
as "virtual" as a future-proofing mechanism.
Reviewed-by: Eric Sunshine
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 5 -
1 file changed, 4 inserti
This should be the final roll of patches for namespace support. I
included the undef check even though that problem occurs elsewhere in
the code. I also removed the needless "my" move.
Hopefully that should be the last in the queue!
From: Kevin
This introduces a new remote.origin.namespaces argument that is a
space-separated list of namespaces. The list of pages extract is then
taken from all the specified namespaces.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote
From: Ingo Ruhnke
we still want to use spaces as separators in the config, but we should
allow the user to specify namespaces with spaces, so we use underscore
for this.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file
that allows fetching all namespaces
automatically.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git
Ideally, we'd process them in numeric order since that is more
logical, but we can't do that yet since this is where we find the
numeric identifiers in the first place. Lexicographic order is a good
compromise.
Reviewed-by: Eric Sunshine
Signed-off-by: Antoine Beaupré
---
contrib/mw-
awiki/issues/30
Reviewed-by: Eric Sunshine
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index f53e638cf..dc43a950b 100755
specify
"(Main)" since that is the publicly documented name.
Reviewed-by: Eric Sunshine
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
On 2017-11-02 10:24:40, Junio C Hamano wrote:
> Antoine Beaupré writes:
>
>> It might still worth fixing this, but I'm not sure what the process is
>> here - in the latest "what's cooking" Junio said this patchset would be
>> merged in "next&
On 2017-11-01 15:56:51, Eric Sunshine wrote:
>> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
>> b/contrib/mw-to-git/git-remote-mediawiki.perl
>> @@ -264,9 +264,14 @@ sub get_mw_tracked_categories {
>> sub get_mw_tracked_namespaces {
>> my $pages = shift;
>> foreach my $local
On 2017-11-01 09:52:09, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 10:51 PM, Antoine Beaupré wrote:
>> Virtual namespaces do not correspond to pages in the database and are
>> automatically generated by MediaWiki. It makes little sense,
>> therefore, to fetch pages from
On 2017-10-31 10:37:29, Junio C Hamano wrote:
>> There's also a hybrid solution used by git-multimail: have a copy of the
>> code in git.git, but do the development separately. I'm not sure it'd be
>> a good idea for Git-Mediawiki, but I'm mentionning it for completeness.
>
> I think the plan was t
On 2017-10-30 11:34:11, Matthieu Moy wrote:
> Antoine Beaupré writes:
>
>> @@ -52,7 +53,7 @@ sub smudge_filename {
>> $filename =~ s/ /_/g;
>> # Decode forbidden characters encoded in clean_filename
>> $filename =~ s/_%_([0-9a-fA-F][0-9a-fA
On 2017-10-30 11:29:55, Matthieu Moy wrote:
>> It should also be mentioned that this contrib isn't very active: I'm not
>> part of the GitHub organization, yet I'm probably the one that's been
>> the most active with patches in the last year (and I wasn't very active
>> at all).
>
> FYI, I'm no lon
On 2017-10-30 11:40:06, Matthieu Moy wrote:
> Antoine Beaupré writes:
>
>> Obviously, doing unit tests against a full MediaWiki instance isn't
>> exactly trivial.
>
> Not trivial, but doable: there is all the infrastructure to do so in t/:
> install-wiki.sh to auto
On 2017-10-29 23:52:16, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 10:43 PM, Antoine Beaupré wrote:
>> On 2017-10-29 15:49:28, Eric Sunshine wrote:
>>> This may be problematic since get_mw_namespace_id() may return undef
>>> rather than a number, in wh
Hi,
First thanks for the excellent feedback regarding the mediawiki
extension, it's great that obscure extensions like this see such
excellent reviews.
I think, however, it would be good to have a discussion about the future
of that extension in Git. The extension has a bit of a hybrid presence -
This patch series tries to integrate all the feedback received in the
recent review from Eric Sunshine. It completely removes the confusing
changes to get_mw_namespace_id_for_page() because I believe they are
unrelated to the namespace support.
I also split up the last patch in 4 different patches
awiki/issues/30
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote-mediawiki.perl
index 5199af6f6..61e6dd798 100755
--- a/contrib/mw-to-git/git-r
From: Ingo Ruhnke
we still want to use spaces as separators in the config, but we should
allow the user to specify namespaces with spaces, so we use underscore
for this.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file
s are currently
"Special" (-1) and "Media" (-2) but we treat all negative namespaces
as "virtual" as a future-proofing mechanism.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -
ecify
"(Main)" since that is the publicly documented name.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-rem
From: Kevin
This introduces a new remote.origin.namespaces argument that is a
space-separated list of namespaces. The list of pages extract is then
taken from all the specified namespaces.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote
that allows fetching all namespaces
automatically.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git
Ideally, we'd process them in numeric order since that is more
logical, but we can't do that yet since this is where we find the
numeric identifiers in the first place. Lexicographic order is a good
compromise.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawik
On 2017-10-29 15:49:28, Eric Sunshine wrote:
[...]
>> Reviewed-by: Antoine Beaupré
>> Signed-off-by: Antoine Beaupré
>> ---
>> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
>> b/contrib/mw-to-git/git-remote-mediawiki.perl
>> @@ -264,16 +264
On 2017-10-29 23:08:00, Kevin wrote:
> So I shared the patch some time ago (~2 years). Surprisingly its just
> now getting attention. I guess some renewed interest in using mediawiki
> with git.
I think what's happening is that someone (ie. me :p) figured it was
about frigging time to actually sen
On 2017-10-29 15:49:28, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote:
>> Subject: remote-mediawiki: allow using (Main) as a namespace and skip
>> special namespaces
>
> This patch is more difficult to review than it perhaps ought to be
On 2017-10-29 13:34:31, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote:
>> if we fail to find a requested namespace, we should tell the user
>
> s/if/If/
fixed.
>> which ones we know about, since we already do. this allows users to
>
>
On 2017-10-29 13:24:03, Eric Sunshine wrote:
> On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote:
>> From: Kevin
>>
>> this introduces a new remote.origin.namespaces argument that is a
>
> s/this/This/
ack.
>> space-separated list of namespaces. the li
sorry for the noise here, but the original patch didn't fix the length
in the right place. v2 fixed it in the library properly, but i forgot
to also include the length of the suffix. this should be good to go...
names, but
that would be more difficult and error prone for a situation that
should rarely happen in the first place.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/Git/Mediawiki.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/Git/Mediawiki.pm
b/co
names, but
that would be more difficult and error prone for a situation that
should rarely happen in the first place.
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/Git/Mediawiki.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/Git/Mediawiki.pm
b/co
mediawiki pages can have names longer than NAME_MAX (generally 255)
characters, which will fail on checkout. we simply strip out extra
characters, which may mean one page's content will overwrite another
(the last editing winning).
ideally, we would do a more clever system to find unique names, bu
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 31 +++--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote
Hi,
For a few years now, work has been happening in a [GitHub issue] to
improve git's support for MediaWiki sites, which are implemented in
the contrib/mw-to-git/ module, mostly visible in the
git-remote-mediawiki command.
[GitHub issue]: https://github.com/Git-Mediawiki/Git-Mediawiki/issues/10
fetching all namespaces
automatically.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl
b/contrib/mw-to-git/git-remote
From: Ingo Ruhnke
we still want to use spaces as separators in the config, but we should
allow the user to specify namespaces with spaces, so we use underscore
for this.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
1 file
From: Kevin
this introduces a new remote.origin.namespaces argument that is a
space-separated list of namespaces. the list of pages extract is then
taken from all the specified namespaces.
Reviewed-by: Antoine Beaupré
Signed-off-by: Antoine Beaupré
---
contrib/mw-to-git/git-remote
Any reason why this patch wasn't included / reviewed?
Thanks,
A.
On 2014-11-10 08:33:32, Antoine Beaupré wrote:
> For projects with separate history lines and, thus, multiple root-commits, the
> linear arrangement of `git log --graph --oneline` does not allow the user to
>
ons:
* line delimiters: we want to keep one commit per line
* tree indentation: it makes little sense with commit trees without
common history, and is more complicated to implement
Signed-off-by: Antoine Beaupré
---
revision.c | 8 ++--
t/t4202-log.sh
65 matches
Mail list logo
