[PATCH v4] push --force-with-lease: Fix ref status reporting

2016-01-29 Thread Andrew Wheeler
From: Andrew Wheeler The --force--with-lease push option leads to less detailed status information than --force. In particular, the output indicates that a reference was fast-forwarded, even when it was force-updated. Modify the --force-with-lease ref status logic to leverage the --force ref

Re: [PATCH v3] push --force-with-lease: Fix ref status reporting

2016-01-29 Thread Andrew Wheeler
> These all look OK (I am not sure about message i18n, though). > > Do we not test a case where --force-with-lease push is rejected due > to REF_STATUS_REJECT_STALE? Good idea, new patch on the way. -andrew -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a messag

Re: [PATCH v2] push --force-with-lease: Fix ref status reporting

2016-01-28 Thread Andrew Wheeler
Ignore -- I left an extra blank line. v3 is sent. On Thu, Jan 28, 2016 at 2:20 PM, Andrew Wheeler wrote: > From: Andrew Wheeler > > The --force--with-lease push option leads to less > detailed status information than --force. In particular, > the output indicates that a ref

[PATCH v3] push --force-with-lease: Fix ref status reporting

2016-01-28 Thread Andrew Wheeler
From: Andrew Wheeler The --force--with-lease push option leads to less detailed status information than --force. In particular, the output indicates that a reference was fast-forwarded, even when it was force-updated. Modify the --force-with-lease ref status logic to leverage the --force ref

[PATCH v2] push --force-with-lease: Fix ref status reporting

2016-01-28 Thread Andrew Wheeler
From: Andrew Wheeler The --force--with-lease push option leads to less detailed status information than --force. In particular, the output indicates that a reference was fast-forwarded, even when it was force-updated. Modify the --force-with-lease ref status logic to leverage the --force ref

Re: [PATCH] push --force-with-lease: Fix ref status reporting

2016-01-25 Thread Andrew Wheeler
On Mon, Jan 25, 2016 at 1:37 PM, Junio C Hamano wrote: > >* passing the --force argument > > + * > > This new blank line is probably unwanted. > Do we want to make sure that other people will not break this fix in > the future by adding a few tests, perhaps to t

[ BUG ] push --force-with-lease status output signals a "fast-fowarded" push when the ref is force-updated

2016-01-22 Thread Andrew Wheeler
problem seems to be that ref.forced_update is never set in remote.c. I have a patch below that works-around the problem, but it may be not the right approach. commit 81d8b713ee83161dbd7eb3dafd22718d1fa992a1 Author: Andrew Wheeler Date: Tue Jan 19 15:23:32 2016 -0600 push --force-wit

[PATCH] push --force-with-lease: Fix ref status reporting

2016-01-20 Thread Andrew Wheeler
From: Andrew Wheeler The --force--with-lease push option leads to less detailed status information than --force. In particular, the output indicates that a reference was fast-forwarded, even when it was force-updated. Modify the --force-with-lease ref status logic to leverage the --force ref