[PATCH v2] diff: run arguments through precompose_argv

I have used Junios proposal/changes for the commit message as I liked it and it is probably more in line with the usual commit messages of the git project. I hope this is ok. Let me know if you need me to do any more changes or what the next steps are if the patch is ok. Alexander Alexander

[PATCH v2] diff: run arguments through precompose_argv

change. It is not a problem per-se, as "log" family of commands already use parse_options() and call precompose_argv()--we can think of it as making the "diff" family of commands behave in a similar way as the commands in the "log" family. Signed-off-by: Alexander R

Re: [PATCH] diff: run arguments through precompose_argv

> On 12 May 2016, at 00:08, Junio C Hamano wrote: > > Alexander Rinass writes: > >>> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: >>> >>> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>>>> Thanks-to: Torsten Bögershausen >&

Re: [PATCH] diff: run arguments through precompose_argv

> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: > > Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>> Thanks-to: Torsten Bögershausen > > I sense NFD disease: The combining diaresis should combine with the o, not > the g. Here is a correct line to copy-and-paste if you like: > > Thanks-to

Re: git diff does not precompose unicode file paths (OS X)

> On 15 Mar 2016, at 06:45, Torsten Bögershausen wrote: > > >I created a test case but git diff exits with 0 if it does not recognize the > >file >path so the test case always succeeds. Can you give me a hint or one > >>example test case? > > The most clean (?) is to compare "git diff" NFC an

[PATCH] diff: run arguments through precompose_argv

-tree. Signed-off-by: Alexander Rinass Thanks-to: Torsten Bögershausen Thanks-to: Junio C Hamano --- builtin/diff-files.c | 1 + builtin/diff-index.c | 1 + builtin/diff-tree.c | 2 ++ builtin/diff.c | 1 + t/t3910-mac-os-precompose.sh | 42

[PATCH] diff: run arguments through precompose_argv

issue. Alexander Rinass (1): diff: run arguments through precompose_argv builtin/diff-files.c | 1 + builtin/diff-index.c | 1 + builtin/diff-tree.c | 2 ++ builtin/diff.c | 1 + t/t3910-mac-os-precompose.sh | 42

Re: git diff does not precompose unicode file paths (OS X)

> On 08 Mar 2016, at 13:30, Torsten Bögershausen wrote: > >>> And if not, I can put it on my TODO-stack. >> I have read through the official contribution guidelines and I think I can >> send an official patch. >> >> In this case, would you prefer to have a single commit since the change >> is r

Re: git diff does not precompose unicode file paths (OS X)

> On 04 Mar 2016, at 19:49, Ramsay Jones wrote: > > > > On 04/03/16 14:37, Alexander Rinass wrote: >> >>> On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: >>> >>> On 03/04/2016 10:07 AM, Alexander Rinass wrote: > [snip] > >&

Re: git diff does not precompose unicode file paths (OS X)

> On 04 Mar 2016, at 13:16, Torsten Bögershausen wrote: > > On 03/04/2016 10:07 AM, Alexander Rinass wrote: >> Hallo, >> >> It appears that the git diff command does not precompose file path >> arguments, even if the option core.precomposeunicode is set to tru

git diff does not precompose unicode file paths (OS X)

$(iconv -f utf-8 -t utf-8-mac <<< Ä) [...shows NO diff...] I took a look at the Git source code, and the builtin/diff*.c do not contain the parse_options call (which does the precompose_argv call) that the other builtins use. But I am not really familiar with either C or the Git pr