[PATCH v2] pull: warn on --verify-signatures with --rebase

ned-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --- The warning message was changed to make it clear that the pull (and rebase) operation still proceeds. And the commit message was amended with more reasoning about the change and why alternative approaches were not used. b

Re: [PATCH] pull: warn on --verify-signatures with --rebase

On Wed, May 18, 2016 at 09:04:24AM -0700, Junio C Hamano wrote: > > Previously git-pull silently ignored the --verify-signatures option for > > --rebase. > > Missing pieces information that would have made the patch more > complete are answers to these questions: > > - Is that a bad thing? Why?

[PATCH] pull: warn on --verify-signatures with --rebase

Previously git-pull silently ignored the --verify-signatures option for --rebase. Signed-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --- Sorry it took so long for the update. I made git-pull warn instead or error and explained why "the --verify-signatures opt

[PATCH v2] pull: make --rebase --verify-signatures illegal

Previously git-pull would silently ignore the --verify-signatures option. Signed-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --- I made the error-message conform to the CodingGuidelines (removed capitalization and full stop). Also, in the previous mail I said that I prop

[PATCH] pull: make --rebase --verify-signatures illegal

Previously git-pull would silently ignore the --verify-signatures option. Signed-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --- We had some discussion back in December about a patch that added --verify-signatures to git-pull, that was declined. I proposed making g

Re: [PATCH] rebase: add --verify-signatures

Sorry, I didn't do a group-reply in my last mail. On Mon, Dec 21, 2015 at 03:46:54PM -0800, Junio C Hamano wrote: > Alexander 'z33ky' Hirsch <1ze...@gmail.com> writes: > > > On Thu, Dec 17, 2015 at 10:22:20AM -0800, Junio C Hamano wrote: > >> I suspec

Re: [PATCH] rebase: add --verify-signatures

On Wed, Dec 16, 2015 at 10:12:12AM -0800, Junio C Hamano wrote: > I do not quite understand how that would help anything. I do not > personally believe in projects that wants to sign each and every > commit, but to them, "an empty signed commit on top" would not fix > anything once they have an un

Re: [PATCH] rebase: add --verify-signatures

On Thu, Dec 10, 2015 at 11:53:45AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Alexander 'z33ky' Hirsch <1ze...@gmail.com> writes: > > > >> + if test -n "$rebase_root" > >> + then >

[PATCH] rebase: add --verify-signatures

This option works analogous to --verify-signatures for git-merge by checking that the commits, that are rebased onto, have good GPG signatures. Additionally, git-pull now forwards --verify-signatures to rebase as well. Signed-off-by: Alexander 'z33ky' Hirsch <1ze...@gmail.com> --

Re: rebase has no --verify-signatures

On Tue, Dec 08, 2015 at 01:21:25AM +, brian m. carlson wrote: > On Mon, Dec 07, 2015 at 03:00:15PM +0100, Alexander 'z33ky' Hirsch wrote: > > Is there any technical reason why rebase should not have a > > --verify-signatures flag? I have written a patch to git-rebase

rebase has no --verify-signatures

Hi, The git merge command has a --verify-signatures flag, which, when set, checks that the commits to be merged have trusted GPG signatures. git pull also knows this flag and forwards it to the merge command. However, doing a git pull --rebase --verify-signatures silently ignores it, since reb

[PATCH] status: allow branch info color customization

From: Alexander Hirsch <1ze...@gmail.com> git status -bs (--branch --short) does not seem to allow customization of the colors for the local and remote branch. This patch adds these via the color.status.local and color.status.remote config variables. Given the trivial nature of this patch I did n