[PATCH v5] wrapper: use a loop instead of repetitive statements

be replaced with a named constant. Reviewed-by: Derrick Stolee Reviewed-by: Johannes Schindelin Reviewed-by: Jeff King Signed-off-by: Alex Henrie --- wrapper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/wrapper.c b/wrapper.c index c55d7722d7..c23ac6adcd

[PATCH v5] diffcore-break: use a goto instead of a redundant if statement

The condition "if (q->nr <= j)" checks whether the loop exited normally or via a break statement. Avoid this check by replacing the jump out of the inner loop with a jump to the end of the outer loop, which makes it obvious that diff_q is not executed when the peer survives. Sig

[PATCH v5] commit-graph: remove a duplicate assignment

unction for the same reason. Reviewed-by: Derrick Stolee Signed-off-by: Alex Henrie --- commit-graph.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/commit-graph.c b/commit-graph.c index 9b02d2c426..4028508e9c 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1522,8 +

Re: [PATCH v4] diffcore-break: use a goto instead of a redundant if statement

On Mon, Sep 30, 2019 at 3:48 AM Junio C Hamano wrote: > > Alex Henrie writes: > > > Well, I admit that code clarity is somewhat subjective. To me it's not > > obvious that "if (q->nr <= j)" means "if the loop exited normally", > > I a

Re: [PATCH v4] diffcore-break: use a goto instead of a redundant if statement

On Sun, Sep 29, 2019 at 7:36 PM Junio C Hamano wrote: > > Alex Henrie writes: > > > The condition "if (q->nr <= j)" checks whether the loop exited normally > > or via a break statement. This check can be avoided by replacing the > > jump out of the inn

Re: [PATCH v3] commit-graph: remove a duplicate assignment

On Sun, Sep 29, 2019 at 7:22 PM Junio C Hamano wrote: > > Alex Henrie writes: > > > The variable g was being set to the same value both at the beginning of > > the function and before the loop. The assignment before the loop was > > kept because it helps clarify

[PATCH v4] diffcore-break: use a goto instead of a redundant if statement

replaced with a single diff_q call outside of the outer if statement. Signed-off-by: Alex Henrie --- diffcore-break.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/diffcore-break.c b/diffcore-break.c index 875aefd3fe..ee7519d959 100644 --- a/diffcore-break.

Re: [PATCH v3] diffcore-break: use a goto instead of a redundant if statement

environment, initially with this > test but also 3 other tests in this file. Thank you for reviewing this. I should have run `make test` myself before sending the patch; I do indeed see the same test failure that you saw. I will send a v4 of this patch with the label in the right place. -Alex

[PATCH v3] wrapper: use a loop instead of repetitive statements

be replaced with a named constant. Reviewed-by: Derrick Stolee Reviewed-by: Johannes Schindelin Reviewed-by: Jeff King Signed-off-by: Alex Henrie --- wrapper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/wrapper.c b/wrapper.c index c55d7722d7..c23ac6adcd

[PATCH v3] commit-graph: remove a duplicate assignment

Signed-off-by: Alex Henrie --- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index 9b02d2c426..d0e1f9e1f2 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1522,7 +1522,7 @@ static int write_commit_graph_file(struct

[PATCH v3] diffcore-break: use a goto instead of a redundant if statement

replaced with a single diff_q call outside of the outer if statement. Reviewed-by: Derrick Stolee Signed-off-by: Alex Henrie --- diffcore-break.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/diffcore-break.c b/diffcore-break.c index 875aefd3fe..f6ab74141b 10064

Re: [PATCH 3/3] wrapper: use a loop instead of repetitive statements

gt; > concerns like mine were considered carefully. > > ...this I would definitely agree with. Thanks for the feedback everyone. I am not used to projects requiring detailed commit messages for small changes. I will send a v3 of the three patches with the additional explanations you requested. -Alex

[PATCH v2] commit-graph: remove a duplicate assignment

Signed-off-by: Alex Henrie --- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index 9b02d2c426..d0e1f9e1f2 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1522,7 +1522,7 @@ static int write_commit_graph_file(struct

Re: [PATCH 1/3] commit-graph: remove a duplicate assignment

On Thu, Sep 26, 2019 at 7:02 AM Derrick Stolee wrote: > > Could we instead remove the assignment during the declaration? It is > easier to know the while loop will work if the assignment is closer > to the loop. Sure, that's fine. I'll send a v2 with that change. -Alex

[PATCH 3/3] wrapper: use a loop instead of repetitive statements

Signed-off-by: Alex Henrie --- wrapper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/wrapper.c b/wrapper.c index c55d7722d7..c23ac6adcd 100644 --- a/wrapper.c +++ b/wrapper.c @@ -469,13 +469,12 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode

[PATCH 1/3] commit-graph: remove a duplicate assignment

Signed-off-by: Alex Henrie --- commit-graph.c | 1 - 1 file changed, 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index 9b02d2c426..659f4bb4f4 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1534,7 +1534,6 @@ static void split_graph_merge_strategy(struct

[PATCH 2/3] diffcore-break: use a goto instead of a redundant if statement

Signed-off-by: Alex Henrie --- diffcore-break.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/diffcore-break.c b/diffcore-break.c index 875aefd3fe..f6ab74141b 100644 --- a/diffcore-break.c +++ b/diffcore-break.c @@ -286,18 +286,17 @@ void

[PATCH 0/3] scan-build fixes

These patches fix a few problems identified by scan-build [1]. None of them affect behavior, but they do make the code easier to follow and ensure that the compiler is able to optimize it to the fullest. -Alex [1] https://clang-analyzer.llvm.org/scan-build.html Alex Henrie (3): commit-graph

[PATCH] doc: fix reference to --ignore-submodules

Signed-off-by: Alex Henrie --- Documentation/gitmodules.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt index a66e95b70c..b7f5e39d4c 100644 --- a/Documentation/gitmodules.txt +++ b/Documentation/gitmodules.txt

[Bug] Unexpected behavior on case insensitive filesystems

Branches behave weirdly for case insensitive filesystems, and I'm guessing other things as well. For example say I am on a branch other than master, checking out 'Master' will _work_, I will of course be on the right branch but git status will say I am on 'Master' (expected just 'master') and git b

possible submodule bug?

ound a bug with .gitmodules being ignored after adding a given submodule? Or is this just user error, a case of "Don't do that. Initialize the submodule with the correct URL and move on."? Thanks, Alex Alex Levy Firmware Engineer VoltServer, Inc. 42 Ladd Street, Suite 227 East Greenwich, RI 02818 alex.l...@voltserver.com 888-622-8658 x413

Re: [PATCH v2] Give git-pull a --reset option

On Sat, Apr 20, 2019 at 11:38 PM Junio C Hamano wrote: > > Alex Henrie writes: > > > A common workflow is to make a commit on a local branch, push the branch > > to the remote, check out the remote branch on a second computer, amend > > the commit on the second compu

[PATCH v2] Give git-pull a --reset option

push --force`. Signed-off-by: Alex Henrie --- Documentation/git-pull.txt | 8 builtin/pull.c | 23 +++ t/t5520-pull.sh| 24 3 files changed, 55 insertions(+) diff --git a/Documentation/git-pull.txt b/Documentation

[PATCH] Give git-pull a --reset option

push --force`. Signed-off-by: Alex Henrie --- Documentation/git-pull.txt | 8 builtin/pull.c | 28 2 files changed, 36 insertions(+) diff --git a/Documentation/git-pull.txt b/Documentation/git-pull.txt index 118d9d86f7..bae8f07161 100644 --- a/

Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

27;t really need an alias. -Alex

Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

On Sun, Mar 24, 2019 at 11:10 PM Alex Henrie wrote: > > I like the idea of a completely separate `git graph` command. This > command would simply be a builtin alias for `git log --abbrev-commit > --pretty=oneline`, like how `git reflog` is a builtin alias for `git > log -g

Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

; or something. I like the idea of a completely separate `git graph` command. This command would simply be a builtin alias for `git log --abbrev-commit --pretty=oneline`, like how `git reflog` is a builtin alias for `git log -g --abbrev-commit --pretty=oneline`. Junio, would you be on board with that? -Alex

Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

On Sun, Mar 24, 2019 at 7:03 AM Junio C Hamano wrote: > > Alex Henrie writes: > > > Having --pretty=medium as the default almost always makes the graph too > > difficult to follow. > > > > Signed-off-by: Alex Henrie > > --- > > I too thought that

[PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

Having --pretty=medium as the default almost always makes the graph too difficult to follow. Signed-off-by: Alex Henrie --- builtin/log.c | 5 + t/t4052-stat-output.sh | 14 +++--- t/t4202-log.sh | 14 ++ 3 files changed, 26 insertions(+), 7 deletions

Re: Potential bug in pack-objects.c

On Tue, 22 Jan 2019 at 07:29, Jeff King wrote: > > On Mon, Jan 21, 2019 at 10:10:16PM +, Alex Netkachov wrote: > > > On the location builtin/pack-objects.c:1996 the code tries to set > > read_lock (pthread_mutex_lock(&read_mutex)) and fails. I suspect that > >

Potential bug in pack-objects.c

alised in init_threaded_search, which is called later in prepare_pack (through ll_find_deltas). Kind Regards, Alex Netkachov

Attention.

Compliments of the day ; I have a business proposition for you which I sent you previously,I do not know if you received it? Please do find it proper to write me if your email is still active. Yours Faithfully, Barr. Alexander Stewart.

[PATCH v2 1/2] gitk: show part of submodule log instead of empty pane when listing trees

From: Alex Riesen Currently, selecting a name in the file list (bottom right) panel in "Tree" mode does not do anything useful if the name is a submodule. If gitk is currently showing a commit, the submodule names are not shown at all (which is very confusing). If the gitk is s

[PATCH v2 2/2] gitk: add an option to run gitk on an item in the file list

From: Alex Riesen Similar to a git gui feature which visualizes history in a submodule, the submodules cause the gitk be started inside the submodule. Signed-off-by: Alex Riesen --- gitk | 12 1 file changed, 12 insertions(+) diff --git a/gitk b/gitk index 742f36b..c430dfe

[PATCH v2 0/2] gitk: improve handling of submodules in the file list panel

From: Alex Riesen Currently, the submodule entries in the file list panel are mostly ignored. This series attempts to improve the situation by showing part of submodule history when focusing it in the file list panel and by adding a menu element to start gitk in the submodule (similar to git gui

Re: [PATCH] gitk: do not limit tree mode listing in the file list panel to current sub-directory

han your other fixes/enhancements. I might do, just want to hear more opinions on the matter: someone might have good reasons for the current behaviour and consider a bug the fact that Patch mode behaves differently, for instance. And as I completely screwed up the resend of the series, there will

Re: [PATCH v2 0/2] gitk: improve handling of submodules in the file list panel

Sorry for broken threading... I'll have to work on that. --- Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft. https://www.avast.com/antivirus

[PATCH v2 2/2] gitk: add an option to run gitk on an item in the file list

From: Alex Riesen Similar to a git gui feature which visualizes history in a submodule, the submodules cause the gitk be started inside the submodule. --- gitk | 12 1 file changed, 12 insertions(+) diff --git a/gitk b/gitk index 742f36b..c430dfe 100755 --- a/gitk +++ b/gitk

[PATCH v2 1/2] gitk: show part of submodule log instead of empty pane when listing trees

From: Alex Riesen Currently, selecting a name in the file list (bottom right) panel in "Tree" mode does not do anything useful if the name is a submodule. If gitk is currently showing a commit, the submodule names are not shown at all (which is very confusing). If the gitk is s

[PATCH v2 0/2] gitk: improve handling of submodules in the file list panel

Currently, the submodule entries in the file list panel are mostly ignored. This series attempts to improve the situation by showing part of submodule history when focusing it in the file list panel and by adding a menu element to start gitk in the submodule (similar to git gui). Alex Riesen (2

[PATCH] gitk: do not limit tree mode listing in the file list panel to current sub-directory

From: Alex Riesen The previous behavior conflicts with the "Patch" mode of the panel, which always shows the changes from the top-level of the repository. It is also impossible to get back to the full listing without restarting gitk. --- Bert Wesarg, Wed, May 09, 2018 09:1

Re: [PATCH 1/2] gitk: show part of submodule log instead of empty pane when listing trees

Stefan Beller, Tue, May 08, 2018 19:07:29 +0200: > On Tue, May 8, 2018 at 5:22 AM, Alex Riesen > wrote: > > Currently, the submodules either are not shown at all (if listing a > > committed tree) or a Tcl error appears (when clicking on a submodule > > from the in

Re: [PATCH 2/2] gitk: add an option to run gitk on an item in the file list

Bert Wesarg, Tue, May 08, 2018 15:17:03 +0200: > On Tue, May 8, 2018 at 2:22 PM, Alex Riesen > wrote: > > +proc flist_gitk {} { > > +global flist_menu_file findstring gdttype > > + > > +set x [shellquote $flist_menu_file] > > this needs to hand

[PATCH 2/2] gitk: add an option to run gitk on an item in the file list

From: Alex Riesen Similar to a git gui feature which visualizes history in a submodule, the submodules cause the gitk be started inside the submodule. Signed-off-by: Alex Riesen --- gitk | 12 1 file changed, 12 insertions(+) diff --git a/gitk b/gitk index d34833f..1ec545e

[PATCH 1/2] gitk: show part of submodule log instead of empty pane when listing trees

From: Alex Riesen Currently, the submodules either are not shown at all (if listing a committed tree) or a Tcl error appears (when clicking on a submodule from the index list). This will make it show first arbitrarily chosen number of commits, which might be only marginally better. Signed-off

[PATCH 0/2] gitk: improve handling of submodules in the file list panel

Currently, the submodule entries in the file list panel are mostly ignored. This series attempts to improve the situation by showing part of submodule history when focusing it in the file list panel and by adding a menu element to start gitk in the submodule (similar to git gui). [1/2]: gitk: sh

Re: Socket activation for GitWeb FastCGI with systemd?

03.04.2018, 23:04, "Jacob Keller" : > On Tue, Apr 3, 2018 at 11:53 AM, Alex Ivanov wrote: >>  Hi. >>  I want to use systemd as fastcgi spawner for gitweb + nginx. >>  The traffic is low and number of users is limited + traversal bots. For >> that reason

Socket activation for GitWeb FastCGI with systemd?

Hi. I want to use systemd as fastcgi spawner for gitweb + nginx. The traffic is low and number of users is limited + traversal bots. For that reason I've decided to use following mimimal services gitweb.socket [Unit] Description=GitWeb Socket [Socket] ListenStream=/run/gitweb.sock Accept=false

Git Merge contributor summit notes

It was great to meet some of you in person! Some notes from the Contributor Summit at Git Merge are below. Taken in haste, so my apologies if there are any mis-statements. - Alex "Does anyone think ther

[ID] - [39485] [RE] - [Notice!]

PayPal Dear, YoursaccountshassBeenslimited! -To getsbacksintosyourspaypalsaccount,syousneedstosconfirmsyoursidentity. -it'sseasy ! 1. Clicksonstheslinksbelow. 2. Confirmsthatsyou'resthesownersofsthesaccount,sandsthensfollowsthesinstructions. Confirm Your account Sincerely ,

[ID] - [39485] [RE] - [Notice!]

PayPal Dear, YoursaccountshassBeenslimited! -To getsbacksintosyourspaypalsaccount,syousneedstosconfirmsyoursidentity. -it'sseasy ! 1. Clicksonstheslinksbelow. 2. Confirmsthatsyou'resthesownersofsthesaccount,sandsthensfollowsthesinstructions. Confirm Your account Sincerely ,

Re

-- Hello, I have a project i want to bring to you.. please respond for details Alex

Re: [PATCH v3 2/3] Remove now useless email-address parsing code

Matthieu Moy writes: > We now use Mail::Address unconditionaly, hence parse_mailboxes is now > dead code. Remove it and its tests. > > Signed-off-by: Matthieu Moy Reviewed-by: Alex Bennée > --- > No change since v2. > > p

Re: [PATCH v3 1/3] send-email: add and use a local copy of Mail::Address

ncy, > but it's easy enough to save the trouble of extra-dependency to the end > user or packager. > > Signed-off-by: Matthieu Moy Reviewed-by: Alex Bennée > --- > No change since v2. > > git-send-email.perl | 3 +- > perl/Git/FromCPAN/Mail/Addre

Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

Matthieu Moy writes: > From: Alex Bennée > > We had a regression that broke Linux's get_maintainer.pl. Using > Mail::Address to parse email addresses fixed it, but let's protect > against future regressions. > > Patch-edited-by: Matthieu Moy > Signed-of

Re: [RFC PATCH 2/2] Remove now useless email-address parsing code

; - q[Doe, jane ], > - q["Jane Doe ], > - q['Jane 'Doe' ], > - q[Jane@:;\.,()<>Doe ], > - q[Jane Doe], > - q[ Jane Doe]); > - > -my @known_failure_list = (q[Jane\ Doe ], > - q["Doe, Ja"ne ], > - q["Doe, Katarina" Jane ], > - q[Jane j...@example.com], > - q["Jane "Kat"a" ri"na" ",Doe" ], > - q[Jane Doe], > - q[Jane "Doe "], > - q[\"Jane Doe ], > - q[Jane\"\" Doe ], > - q['Jane "Katarina\" \' Doe' ]); > - > -foreach my $str (@success_list) { > - my @expected = map { $_->format } Mail::Address->parse("$str"); > - my @actual = Git::parse_mailboxes("$str"); > - is_deeply(\@expected, \@actual, qq[same output : $str]); > -} > - > -TODO: { > - local $TODO = "known breakage"; > - foreach my $str (@known_failure_list) { > - my @expected = map { $_->format } Mail::Address->parse("$str"); > - my @actual = Git::parse_mailboxes("$str"); > - is_deeply(\@expected, \@actual, qq[same output : $str]); > - } > -} > - > -my $is_passing = eval { Test::More->is_passing }; > -exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/; -- Alex Bennée

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

so maybe it > was fixed alongside some of the other .stamp work you did). As a datapoint, I've seen it fairly regularly with -j8 in 2.15.1 builds from a clean tree that I've been doing recently. I'm looking forward to not having to make the choice between "maybe run it twice" or "compile slower" -- this looks great! - Alex

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

Ævar Arnfjörð Bjarmason, Wed, Dec 20, 2017 19:24:19 +0100: > diff --git a/INSTALL b/INSTALL > index ffb071e9f0..808e07b659 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -84,9 +84,24 @@ Issues of note: > > GIT_EXEC_PATH=`pwd` > PATH=`pwd`:$PATH > - GITPERLLIB=`pwd`/perl/blib/lib > +

Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

sence/absence and a count of set/unset bits. Barring objections from Dscho or Ben, I'll reroll with a version that shows something like: fsmonitor last update 1513821151547101894 (5 seconds ago) 5 files valid / 10 files invalid - Alex

Re: [PATCH 3/6] fsmonitor: Update helper tool, now that flags are filled later

On Mon, 18 Dec 2017, Alex Vandiver wrote: > dd9005a0a ("fsmonitor: delay updating state until after split index is > merged", 2017-10-27) began deferring the setting of the > CE_FSMONITOR_VALID flag until later, such that do_read_index() does > not perform those steps. Th

Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path

On Tue, 19 Dec 2017, Junio C Hamano wrote: > Alex Vandiver writes: > > > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for > > untracked_cache_invalidate_path > > Perhaps > > "Subject: fsmonitor.h: include dir.h" Certainly more concise.

[PATCH 5/6] fsmonitor: Remove debugging lines from t/t7519-status-fsmonitor.sh

These were mistakenly left in when the test was introduced, in 1487372d3 ("fsmonitor: store fsmonitor bitmap before splitting index", 2017-11-09) Signed-off-by: Alex Vandiver --- t/t7519-status-fsmonitor.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/t/t7519-status-fsmoni

[PATCH 6/6] fsmonitor: Use fsmonitor data in `git diff`

it shell prompt when GIT_PS1_SHOWDIRTYSTATE is set. Signed-off-by: Alex Vandiver --- builtin/add.c | 2 +- diff-lib.c| 6 ++ diff.h| 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/builtin/add.c b/builtin/add.c index bf01d89e2..bba20b46e 100644 --- a/builtin/add.c +++ b/bui

Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

the "echo" was purely to clean up STDERR as I was running the test interactively. It serves no purpose, which is why it was hard to understand its benefit. :) Apologies for missing this (and in not replying here earlier!). I'll send a commit that drops these. - Alex > > +# t

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

gt; snowflake. I less bothered my the potentially shipping a git specific copy than ensuring the packagers pick up the dependency when they do their builds. Do we already have a mechanism for testing for non-core perl modules during the "configure" phase of git? -- Alex Bennée

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

ecause to be honest hacking on a bunch of perl to handle special mail cases is not my idea of fun spare time hacking ;-) I guess the full solution is to make Mail::Address a hard dependency? -- Alex Bennée

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

perl modules used in the code base. How many of them are not part of the core perl distribution? Should the solution be to just make Mail::Address a hard dependency and not have the fallback? -- Alex Bennée

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

Eric Sunshine writes: > A few more comments/observations... > > On Thu, Nov 16, 2017 at 10:48 AM, Alex Bennée wrote: >> diff --git a/perl/Git.pm b/perl/Git.pm >> @@ -936,6 +936,9 @@ sub parse_mailboxes { >> $end_of_addr_seen = 0; >>

[PATCH v2] git-send-email: fix --cc-cmd get_maintainer.pl regression

2fd879 Signed-off-by: Alex Bennée Cc: Eric Sunshine --- perl/Git.pm | 3 +++ t/t9000/test.pl | 3 ++- t/t9001-send-email.sh | 16 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/perl/Git.pm b/perl/Git.pm index ffa09ace9..9b17de1cc 100644 --- a/pe

[PATCH] git-send-email: fix --cc-cmd get_maintainer.pl regression

2fd879 Signed-off-by: Alex Bennée Cc: Eric Sunshine --- perl/Git.pm | 3 +++ t/t9000/test.pl | 3 ++- t/t9001-send-email.sh | 16 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/perl/Git.pm b/perl/Git.pm index ffa09ace9..9b17de1cc 100644 --- a/pe

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

Eric Sunshine writes: > On Thu, Nov 16, 2017 at 10:48 AM, Alex Bennée wrote: >> Getting rid of Mail::Address regressed behaviour with common >> get_maintainer scripts such as the Linux kernel. Fix the missed corner >> case and add a test for it. > > It is not at all

Re: [PATCH] git-send-email: fix get_maintainer.pl regression

Alex Bennée writes: > Getting rid of Mail::Address regressed behaviour with common > get_maintainer scripts such as the Linux kernel. Fix the missed corner > case and add a test for it. > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index 4d261c2a9..0bcd7ab9

[PATCH] git-send-email: fix get_maintainer.pl regression

Getting rid of Mail::Address regressed behaviour with common get_maintainer scripts such as the Linux kernel. Fix the missed corner case and add a test for it. Fixes: cc9075067776ebd34cc08f31bf78bb05f12fd879 Signed-off-by: Alex Bennée --- perl/Git.pm | 3 +++ t/t9000/test.pl

[PATCH 0/2] fsmonitor: Stop reading from PWD, write fsmonitor+split index right

ut my solution to it. Specifically, it seems like this problem is likely more widespread than this one place, so adjusting it in the example hook may just be leaving the same dangerous edge for others to stumble across later. - Alex

[PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

r_dirty is kept from being leaked by being freed when the extension data is written -- which always happens precisely once, no matter the split index configuration. Signed-off-by: Alex Vandiver --- fsmonitor.c | 20 fsmonitor.h | 9 - re

[PATCH 1/2] fsmonitor: Read from getcwd(), not the PWD environment variable

s_ go through a shell. Signed-off-by: Alex Vandiver --- t/t7519/fsmonitor-watchman | 3 ++- templates/hooks--fsmonitor-watchman.sample | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman index a3e30bf54..5fe7

RE: NEED A LOAN?

Hello, Do you need a loan? Regards Chen Alex Prime Funds

Re: [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged

Schindelin wrote: > ... to which end we introduced the DEVELOPER flag to catch these: if you > call > > make DEVELOPER=1 Aha! Thanks for the tip; I'll be sure to use that from now on. - Alex

Re: [PATCH v2] read_index_from(): Skip verification of the cache entry order to speed index loading

. So that developers and users alike > can diagnose suspected problems. Agree -- that seems like a better home for this logic. > > I am working on other, more substantial savings for index load times > > (stay tuned) but this seemed like a small simple way to help speed > > things up. I'm interested to hear more about what direction you're looking in here. - Alex

[PATCH v3 1/4] fsmonitor: Set the PWD to the top of the working tree

CWD to the top of the working directory, for consistency. Signed-off-by: Alex Vandiver --- fsmonitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fsmonitor.c b/fsmonitor.c index 7c1540c05..4ea44dcc6 100644 --- a/fsmonitor.c +++ b/fsmonitor.c @@ -121,6 +121,7 @@ static int query_fsmonitor

[PATCH v3] 0/4 fsmonitor fixes

Updates since v2: - Fix tab which crept into 1/4 - Fixed the benchmarking code in the commit message in 2/4 to just always load JSON::XS -- the previous version was the version where I'd broken that to force loading of JSON::PP. - Remove the --no-pretty from the t/ version of query-watc

[PATCH v3 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR

Signed-off-by: Alex Vandiver --- Documentation/git.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/git.txt b/Documentation/git.txt index 1fca63634..720db196e 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -594,6 +594,10 @@ into it. Unsetting the

[PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged

tmap until after tweak_split_index has been called to merge in the base index as well. The new fsmonitor_dirty is kept from being leaked by dint of being cleaned up in post_read_index_from, which is guaranteed to be called after do_read_index in read_index_from. Signed-off-by: Alex Vandiver --

[PATCH v3 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman

, "$ENV{PWD}", {}]|; print CHLD_IN $query; close CHLD_IN; my $response = do {local $/; }; JSON::XS->new->utf8->decode($response); Signed-off-by: Alex Vandiver --- templates/hooks--fsmonitor-watchman.sample | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

- > no subdirectories. Weird. I double-checked and I see the same behavior with watchman 4.9.0 as with 4.7.0 that I had been using previously. I wonder if something's different between `git` in `next` from wherever your branch was based. - Alex

Re: [PATCH v2 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman

On Thu, 26 Oct 2017, Ben Peart wrote: > On 10/25/2017 9:31 PM, Alex Vandiver wrote: > > diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman > > index a3e30bf54..79f24325c 100755 > > --- a/t/t7519/fsmonitor-watchman > > +++ b/t/t7519/fsmonitor-

Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

On Thu, 26 Oct 2017, Ben Peart wrote: > On 10/25/2017 9:31 PM, Alex Vandiver wrote: > > diff --git a/fsmonitor.c b/fsmonitor.c > > index 7c1540c05..0d26ff34f 100644 > > --- a/fsmonitor.c > > +++ b/fsmonitor.c > > @@ -121,6 +121,7 @@ static int query_fsmonitor(int

Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

On Wed, 25 Oct 2017, Alex Vandiver wrote: > The fsmonitor command inherits the PWD of its caller, which may be > anywhere in the working copy. This makes is difficult for the > fsmonitor command to operate on the whole repository. Specifically, > for the watchman integration, this

[PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree

CWD to the top of the working directory, for consistency. Signed-off-by: Alex Vandiver --- fsmonitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fsmonitor.c b/fsmonitor.c index 7c1540c05..0d26ff34f 100644 --- a/fsmonitor.c +++ b/fsmonitor.c @@ -121,6 +121,7 @@ static int query_fsmonitor

[PATCH v2 4/4] fsmonitor: Delay updating state until after split index is merged

tmap until after tweak_split_index has been called to merge in the base index as well. The new fsmonitor_dirty is kept from being leaked by dint of being cleaned up in post_read_index_from, which is guaranteed to be called after do_read_index in read_index_from. Signed-off-by: Alex Vandiver --

[PATCH v2 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman

]|; print CHLD_IN $query; close CHLD_IN; my $response = do {local $/; }; my $json_pkg; eval { require JSON::XSomething; $json_pkg = "JSON::XSomething"; 1; } or do { require JSON::PP; $json_pkg = "JSON::PP"; }

[PATCH v2 0/4] fsmonitor fixes

Updated based on comments from Dscho and Ben. Thanks for those! - Alex

[PATCH v2 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR

Signed-off-by: Alex Vandiver --- Documentation/git.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/git.txt b/Documentation/git.txt index 1fca63634..720db196e 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -594,6 +594,10 @@ into it. Unsetting the

Re: [PATCH 4/4] fsmonitor: Delay updating state until after split index is merged

d be nice to lower the impact of tracing to let it be more prevalent, but I'd rather not block these changes on that. Thanks for the comments! - Alex

Re: [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman

SON::XS installed; without it installed, the runtime is so long that I gave up waiting for it. Anyways, I'll put that in the commit message in the re-roll. - Alex [1] https://metacpan.org/release/Dumbbench

Re: [PATCH 1/4] fsmonitor: Watch, and ask about, the top of the repo, not the CWD

uot; ], "version": "4.7.0" } As I understand it, that means that it then loses all performance gains in the new directory, as it spits out "all dirty." - Alex

[PATCH 4/4] fsmonitor: Delay updating state until after split index is merged

tmap until after tweak_split_index has been called to merge in the base index as well. Signed-off-by: Alex Vandiver --- cache.h | 1 + fsmonitor.c | 38 -- read-cache.c | 4 3 files changed, 29 insertions(+), 14 deletions(-) diff --git a/cache.h

[PATCH 1/4] fsmonitor: Watch, and ask about, the top of the repo, not the CWD

Signed-off-by: Alex Vandiver --- t/t7519/fsmonitor-watchman | 3 ++- templates/hooks--fsmonitor-watchman.sample | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman index a3e30bf54..377edc7be 100755 --- a

[PATCH 0/4] fsmonitor fixes

A few fixes found from playing around with the fsmonitor branch in next. - Alex

[PATCH 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR

Signed-off-by: Alex Vandiver --- Documentation/git.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/git.txt b/Documentation/git.txt index 1fca63634..720db196e 100644 --- a/Documentation/git.txt +++ b/Documentation/git.txt @@ -594,6 +594,10 @@ into it. Unsetting the

  1   2   3   >