On 03/22/2014 04:13 AM, Michael Haggerty wrote:
> My expectation when I invented that microproject was that converting the
> code to be table-driven would be judged *not* to be an improvement. I
> was hoping that a student would say "the 'if' statement is OK, but let's
> delete this ridiculous unr
On 03/19/2014 04:21 PM, Eric Sunshine wrote:
> Thanks for the resubmission. Comments below...
>
> On Tue, Mar 18, 2014 at 10:33 AM, Aleksey Mokhovikov
> wrote:
>> Subject: [PATCH][GSOC] Selection of the verbose message is replaced with
>> generated message in install_
Matthieu Moy grenoble-inp.fr> writes:
>
> Hi,
>
> Aleksey Mokhovikov gmail.com> writes:
>
> Please, read the threads for other submissions for this microproject.
> Most remarks done there also apply for your case. See for example:
>
> http://thread.gmane.o
This patch replaces if chain with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Compare with original construction
Pr
Eric Sunshine sunshineco.com> writes:
> The subject should be concise. Try to keep it at 65-70 characters or
> less. More detailed information can be written following the subject
> (separated from the subject by a blank line).
>
> Write in imperative tone: say "replace X with Y" rather than "X i
This patch replaces if chain that selects the message with
2 dimensional array of format strings and arguments.
Signed-off-by: Aleksey Mokhovikov
---
This patch is unrelated with previous one, but related to GSoC.
So I don't know if I should create new thread for this patch.
Compare
concatenating them the into one template string.
Signed-off-by: Aleksey Mokhovikov
---
branch.c | 39 ---
1 file changed, 16 insertions(+), 23 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..2ee353f 100644
--- a/branch.c
+++ b/branch.c
7 matches
Mail list logo
