Recommendations for adding strerror() in log statament

2018-10-17 Thread
Hi, Our team works on enhance logging practices by learning from historical log revisions in evolution. And we find 2 patches that add strerror() to the log statement which is printed when the return value of commit_lock_file() is smaller than 0. While applying this rule to git-2.14.2, we find 3

Recommendations for updating error() to error_errno()

2018-10-16 Thread
Hi, Our team works on enhance logging practices by learning from historical log  revisions in evolution. And we find three patches that update error(..., strerror(errmp)) to error_errno(...). While applying this rule to git-2.14.2, we find 9 missed spot in file refs/files-backend.c, 1 in apply.c

recommendations for log enhancement

2018-01-28 Thread
Our team studies the consistent edits of git during evolution. And we find several missed edits in the latest release of git. For example, there are two consist edits we have figured out from historical commits: 1) . Version: git 2.3.9 – git-2.3.10 File: builtin/merge-tree.c dst.s

Recommendation for consistent update on invoke of "sha1_to_hex()"

2018-01-04 Thread
Our team researches on consistent update of Git during evolution. And we have figured out several spots that may be missed.  By mining historical patches, we suggest that invokes of sha1_to_hex() should be replaced with that of oid_to_hex(). One example for recommendation and corresponding pat

Patch recommendation for replace invoke of error() to that of error_errno()

2018-01-04 Thread
Our team researches on consistent update of Git during evolution. And we have figured out several spots that may be missed.  By mining historical patches, we suggest that invokes of error(..., strerror(errno)) should be replaced with that of error_errno(). One example for recommendation and co