Re: Is GIT GUI still in progress?

2019-10-13 Thread Jiang Xin
> 김건우 于2019年10月10日周四 上午12:02写道: > > > > Hello. > > > > I have a question whether the GIT GUI project still in progress or not > > because I want to contribute to translating GIT GUI into Korean. I asked > > prati0100 who is a maintainer of GIT GUI on > > Github(https://github.com/prati0100/git-gui

Re: Is GIT GUI still in progress?

2019-10-13 Thread Jiang Xin
김건우 于2019年10月10日周四 上午12:02写道: > > Hello. > > I have a question whether the GIT GUI project still in progress or not > because I want to contribute to translating GIT GUI into Korean. I asked > prati0100 who is a maintainer of GIT GUI on > Github(https://github.com/prati0100/git-gui), but he doesn'

Re: Local Config File: Submodule initialization looks broken with the --recurse-submodules option when cloning a repository

2019-10-13 Thread Ron
> Initially reported for GFW on version 2.20.1, I have tested with Linux Mint > Mate 19.1 Tessa which by default uses git version 2.17.1 > > It produces a config file with the relevant submodule entries looking like > this: > > -

[PATCH 0/1] git-gui: Improve Japanese translation

2019-10-13 Thread KIDANI Akito via GitGitGadget
Fixed word order in Japanese translation. kdnakt (1): Improve Japanese translation git-gui/po/ja.po | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) base-commit: 08da6496b61341ec45eac36afcc8f94242763468 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-396%2Fkd

[PATCH 1/1] Improve Japanese translation

2019-10-13 Thread kdnakt via GitGitGadget
From: kdnakt Signed-off-by: kdnakt --- git-gui/po/ja.po | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/git-gui/po/ja.po b/git-gui/po/ja.po index 208651c1af..2f61153ab9 100644 --- a/git-gui/po/ja.po +++ b/git-gui/po/ja.po @@ -4,14 +4,15 @@ # # しらいし ななこ , 2007. #

Re: [PATCH v4 1/1] Make gitdir work with worktrees, respect core.hooksPath, etc

2019-10-13 Thread Johannes Schindelin
Hi Pratyush, On Mon, 14 Oct 2019, Pratyush Yadav wrote: > On 12/10/19 11:24PM, Johannes Schindelin wrote: > > Hi Pratyush, > > > > On Sat, 12 Oct 2019, Pratyush Yadav wrote: > > > > > On 08/10/19 04:33AM, Johannes Schindelin via GitGitGadget wrote: > > > > > > > @@ -1453,10 +1501,16 @@ proc resca

Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget

2019-10-13 Thread Pratyush Yadav
Hi Birger, Your subject is a bit redundant. A reader of this commit can easily see the diff and know that you implemented "proc select_path_in_widget". What's more important is why you implemented it. That is what should go in the commit message. So for example in this patch, you can say somet

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-13 Thread Pratyush Yadav
On 09/10/19 01:01AM, Harish Karumuthil wrote: > Hi all, there is an update: > > I added necessary error catching code so that, script will not crash if the > keybinding code is worng. Instead of crashing it will print error message. > The final patch will look something like this. Like I mentione

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-13 Thread Pratyush Yadav
Hi Harish, Sorry for the late reply. Couldn't find much time last few days. On 07/10/19 11:43AM, Harish Karumuthil wrote: > Hi Pratyush, Regarding your messages, > > >On Sun, 2019-10-06 at 02:31 +0530, Pratyush Yadav wrote: > > You don't need to "set up" an email client with git-send-email. > >

Re: [PATCH v4 1/1] Make gitdir work with worktrees, respect core.hooksPath, etc

2019-10-13 Thread Pratyush Yadav
On 12/10/19 11:24PM, Johannes Schindelin wrote: > Hi Pratyush, > > On Sat, 12 Oct 2019, Pratyush Yadav wrote: > > > On 08/10/19 04:33AM, Johannes Schindelin via GitGitGadget wrote: > > > > > @@ -1453,10 +1501,16 @@ proc rescan {after {honor_trustmtime 1}} { > > > global HEAD PARENT MERGE_HEAD c

Re: Git Gui: Branch->create currently fails...

2019-10-13 Thread Pratyush Yadav
On 12/10/19 09:34PM, Philip Oakley wrote: > Hi Pratyus, > On 08/10/2019 01:00, Pratyush Yadav wrote: > > On 07/10/19 11:02PM, Philip Oakley wrote: > > > I'd never used the Branch:Create before (this is via mouse) and it threw > > > an > > > error, which appears to be repeatable, so I'm reporting i

[PATCH] remote-curl: use argv_array in parse_push()

2019-10-13 Thread René Scharfe
Use argv_array to build an array of strings instead of open-coding it. This simplifies the code a bit. We also need to make the specs parameter of push(), push_dav() and push_git() const to match the argv member of the argv_array. That's fine, as all three only actually read from the specs array

[PATCH] http-push: simplify deleting a list item

2019-10-13 Thread René Scharfe
The first step for deleting an item from a linked list is to locate the item preceding it. Be more careful in release_request() and handle an empty list. This only has consequences for invalid delete requests (removing the same item twice, or deleting an item that was never added to the list), bu

[PATCH] column: use utf8_strnwidth() to strip out ANSI color escapes

2019-10-13 Thread René Scharfe
Make use of utf8_strnwidth()'s feature to skip ANSI escape sequences instead of open-coding it. This shortens the code and makes it more consistent. This changes the behavior, though: The old code skips all kinds of Control Sequence Introducer sequences, while utf8_strnwidth() only skips the Sele

[PATCH] contrib: git-cpcover: copy cover letter

2019-10-13 Thread Michael S. Tsirkin
My flow looks like this: 1. git format-patch -v --cover-letter -o 2. vi /v--cover-letter.patch /v--cover-letter.patch copy subject and blurb, avoiding patchset stats 3. add changelog update blurb as appropriate 4. git send-email /v-* The following perl script automates step 2 above.

Re: [PATCH] parser: Unmangle From: headers that have been mangled for DMARC purposes

2019-10-13 Thread Andrew Donnellan
On 12/10/19 2:51 am, Jeff King wrote: On Sat, Oct 12, 2019 at 02:42:49AM +1100, Daniel Axtens wrote: where a possible solution was to get senders to use in-body From headers even when sending their own patches. [...] I'm not sure this solution is correct. If I take a patch from Andrew, backpo

Re: [RFC PATCH 10/10] pack-objects: improve partial packfile reuse

2019-10-13 Thread Jeff King
On Sat, Oct 12, 2019 at 09:04:58AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > The current code does so by creating a new entry in the reused_chunks > > array. In the worst case that can grow to have the same number of > > entries as we have objects. So this code was an attempt to pad

Re: [PATCH 11/11] graph: fix coloring of octopus dashes

2019-10-13 Thread Jeff King
On Thu, Oct 10, 2019 at 11:16:24AM -0700, Denton Liu wrote: > > test_expect_success 'log --graph with normal octopus merge, no color' ' > > So, I decided to merge 'dl/octopus-graph-bug' with your branch and I > couldn't be happier! I had to make a couple of minor tweaks to the > existing test ca

Re: [PATCH 00/11] Improve the readability of log --graph output

2019-10-13 Thread Jeff King
On Thu, Oct 10, 2019 at 09:13:42AM -0700, James Coglan via GitGitGadget wrote: > A final addition to that set of changes fixes the coloring of dashes that > are drawn next to octopus merges, in a manner compatible with all these > changes. The early commits in this set are refactorings that make t