Hello,
This is a repost, since the original message seems to have been lost somehow.
I am trying to add a file to an arbitrary branch without touching the current
worktree with as little overhead as possible. This should work no matter in
which state the current worktree is in. And it should not
From: Johannes Schindelin
We have just introduced the helper `index_pos_to_insert_pos()` to help
avoiding underflows when returning `-1 - pos` for cases where we want to
return an insert position, using the ones' complement (as `int`).
As pointed out during the review of the patch series that in
This is a spill-over from my patch series that introduces support for
building Git using Visual Studio in our CI builds, based on a suggestion by
Johannes Sixt: complete the symmetry by adding a helper that does the
opposite of index_pos_to_insert_pos().
I tried to be super inventive and came up
Hello Thomas,
On Mon, Oct 07, 2019 at 02:48:31PM +0100, Thomas Gummerer wrote:
> I can hopefully do some more testing and write automated tests later
> today or tomorrow. In the meantime it would be awesome if you could
> confirm if this patch fixes the problem you were seeing.
I assume you alre
SZEDER Gábor writes:
>> func(PROGRESS | REGRESS);
>> func(PROGRESS + REGRESS);
>> func(PROGRESS * 3);
>> }
>>
>> how caller came about to give 3?
>
> No, they tend to show (PROGRESS | REGRESS), at least both gdb and lldb
> do.
OK.
> If the enum has
Junio C Hamano writes:
> Yuck. It's already in 'next', isn't it?
Yuck, indeed. Here is your v2 in an incremental form to be queued
on top.
Thanks.
-- >8 --
Subject: [PATCH 3/2] transport: push codepath can take arbitrary repository
The previous step added annotations with "the_repository" t
Jonathan Tan writes:
> When building the packfile to be sent, send_pack() is given a list of
> remote refs to be used as exclusions. For each ref, it first checks if
> the ref exists locally, and if it does, passes it with a "^" prefix to
> pack-objects. However, in a partial clone, the check may
Josh Steadmon writes:
> On 2019.10.07 14:46, Jonathan Tan wrote:
>> > We'd like to collect better statistics about where the time is spent in
>> > fetches and pushes so that we can hopefully identify some areas for
>> > future optimization. So let's add some trace2 regions around some of the
>> >
SZEDER Gábor writes:
> On one hand, these object ids won't mean much to anyone who might have
> to debug such a test failure in the future, and on the other these
> tests are about 'git format-patch', not about 'git rev-list'. If the
> check were written like this:
>
> count=$(git rev-list --c
"Garima Singh via GitGitGadget" writes:
> From: Garima Singh
>
> Empty arguments passed on the command line can be a represented by
> a '', however sq_quote_buf_pretty was incorrectly dropping these
> arguments altogether. Fix this problem by ensuring that such
> arguments are emitted as '' inst
Thomas Gummerer writes:
> We can however rely on 'patch.def_name' in that case, which is
> extracted from the 'diff --git' line and should be equal to
> 'patch.new_name'. Use that instead to avoid the segfault.
This patch makes the way this function calls parse_git_diff_header()
more in line wi
Junio C Hamano wrote:
> Eric Wong writes:
>
> > "struct hashmap_entry" inside "struct subprocess_entry"
> > no longer needs to be the first member of any struct,
> > so the old comment is no longer true.
>
> Hmm, is that true?
>
> struct cmd2process {
> struct subprocess_entry subprocess
Alban Gruin writes:
> This can be seen as a continuation of ag/reduce-rewriting-todo.
>
> Currently, complete_action() releases its todo list before calling
> sequencer_continue(), which reloads the todo list from the disk. This
> series removes this useless round trip.
>
> Patches 1, 2, and 3 o
Elijah Newren writes:
> In commit 208e69a4ebce ("merge-recursive: fix the diff3 common ancestor
I think the above was an earlier incarntion of what is now known as
8e4ec337 ("merge-recursive: fix the diff3 common ancestor label for
virtual commits", 2019-10-01).
> label for virtual commits", 20
Elijah Newren writes:
> This resulted in garbage strings being printed for the virtual merge
> bases, which was visible in git.git by just merging commit b744c3af07
> into commit 6d8cb22a4f. There are two ways to fix this: set
> opt->ancestor to NULL after using it to avoid re-use, or add a
> !o
Johannes Schindelin writes:
>> I didn't quite understand this part, though.
>>
>> The default creation factor is 60 (roughly speaking, it wants 60% of
>> the lines to match between two patches, otherwise it considers the
>> patches to be unrelated).
>>
>> Would the updated creation fa
Eric Wong writes:
> "struct hashmap_entry" inside "struct subprocess_entry"
> no longer needs to be the first member of any struct,
> so the old comment is no longer true.
Hmm, is that true?
struct cmd2process {
struct subprocess_entry subprocess;
unsigned int supported_capabili
Hi Johannes,
Could you please change the commit subject to more clearly state that we
are caching all paths. This is not something just related to hooks any
more.
On 04/10/19 02:41PM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin
>
> Since v2.9.0, Git knows about the
On 07/10/19 11:02PM, Philip Oakley wrote:
> I'd never used the Branch:Create before (this is via mouse) and it threw an
> error, which appears to be repeatable, so I'm reporting it at the moment so
I'm afraid I can't reproduce it. I tested by creating a worktree of
git.git by running:
git work
> Changes since V1:
> * Use the repository struct argument in transport_push(), rather than
> the global the_repository.
Thanks, the patches now look good to me. I verified that the repository
argument to the trace functions just cause a different repo ID to be
printed, which is what we want (e.
On 07/10/19 10:39AM, Junio C Hamano wrote:
> Pratyush Yadav writes:
>
> > -+# Git Gui - A graphical user interface for Git
> > ++# Git GUI - A graphical user interface for Git
> > +
> > -+Git Gui is a GUI for [git](https://git-scm.com/) written in Tcl/Tk.
> > It allows
> > -
On 2019.10.07 14:46, Jonathan Tan wrote:
> > We'd like to collect better statistics about where the time is spent in
> > fetches and pushes so that we can hopefully identify some areas for
> > future optimization. So let's add some trace2 regions around some of the
> > fetch/push phases so we can b
We'd like to collect better statistics about where the time is spent in
fetches and pushes so that we can hopefully identify some areas for
future optimization. So let's add some trace2 regions around some of the
fetch/push phases so we can break down their timing.
Changes since V1:
* Use the repo
Add trace2 regions to fetch-pack.c and builtins/fetch.c to better track
time spent in the various phases of a fetch:
* listing refs
* negotiation for protocol versions v0-v2
* fetching refs
* consuming refs
Signed-off-by: Josh Steadmon
---
builtin/fetch.c | 22 +++---
fetch-pack
Add trace2 regions in transport.c and builtin/push.c to better track
time spent in various phases of pushing:
* Listing refs
* Checking submodules
* Pushing submodules
* Pushing refs
Signed-off-by: Josh Steadmon
---
builtin/push.c | 2 ++
transport.c| 14 --
2 files changed, 14
On 07/10/2019 23:02, Philip Oakley wrote:
I'd never used the Branch:Create before (this is via mouse) and it
threw an error, which appears to be repeatable, so I'm reporting it at
the moment so I don't forget ...
(I'm chasing down other issue at the moment ;-)
Forgot to mention, this was in a
I'd never used the Branch:Create before (this is via mouse) and it threw
an error, which appears to be repeatable, so I'm reporting it at the
moment so I don't forget ...
(I'm chasing down other issue at the moment ;-)
This is with the version 0.21.GI git version 2.23.0.windows.1 Tcl/Tck 8.6.9
Hi Junio,
On Mon, 7 Oct 2019, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> >> I just implemented this here:
> >> https://github.com/gitgitgadget/gitgitgadget/pull/128 (it still needs to
> >> be reviewed and merged before it takes effect).
> >
> > FWIW this is now merged.
>
> Nice.
>
>
> We'd like to collect better statistics about where the time is spent in
> fetches and pushes so that we can hopefully identify some areas for
> future optimization. So let's add some trace2 regions around some of the
> fetch/push phases so we can break down their timing.
Thanks.
Patch 1 looks g
When building the packfile to be sent, send_pack() is given a list of
remote refs to be used as exclusions. For each ref, it first checks if
the ref exists locally, and if it does, passes it with a "^" prefix to
pack-objects. However, in a partial clone, the check may trigger a lazy
fetch. Ensure t
On Sat, Oct 05, 2019 at 10:43:51AM +0200, Bert Wesarg wrote:
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 83f52614d3..2f2cd6fea6 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1606,6 +1606,26 @@ test_expect_success 'From line has expected fo
On Sun, Oct 06, 2019 at 01:32:54AM +0530, Rajni Jha wrote:
> Hello!
Welcome! Thank you for introducing yourself and please don't hesitate to
ask any questions you may have.
>
> I am an outreachy applicant and I am looking forward to working with git
> for my outreachy internship.
Hope this will
From: Derrick Stolee
If a user provides folders A/ and A/B/ for inclusion in a cone-mode
sparse-checkout file, the parsing logic will notice that A/ appears
both as a "parent" type pattern and as a "recursive" type pattern.
This is unexpected and hence will complain via a warning and revert
to th
From: Derrick Stolee
If two 'git sparse-checkout set' subcommands are launched at the
same time, the behavior can be unexpected as they compete to write
the sparse-checkout file and update the working directory.
Take a lockfile around the writes to the sparse-checkout file. In
addition, acquire
From: Derrick Stolee
During the development of the sparse-checkout "cone mode" feature,
an incorrect placement of the initializer for "use_cone_patterns = 1"
caused warnings to show up when a .gitignore file was present with
non-cone-mode patterns. This was fixed in the original commit
introducin
From: Derrick Stolee
The sparse-checkout feature in "cone mode" can use the fact that
the recursive patterns are "connected" to the root via parent
patterns to decide if a directory is entirely contained in the
sparse-checkout or entirely removed.
In these cases, we can skip hashing the paths wi
From: Derrick Stolee
The sparse-checkout builtin used 'git read-tree -mu HEAD' to update the
skip-worktree bits in the index and to update the working directory.
This extra process is overly complex, and prone to failure. It also
requires that we write our changes to the sparse-checkout file befo
From: Derrick Stolee
When a large repository has many sparse-checkout patterns, the
process for updating the skip-worktree bits can take long enough
that a user gets confused why nothing is happening. Update the
clear_ce_flags() method to write progress.
Signed-off-by: Derrick Stolee
---
cache
From: Derrick Stolee
To make the cone pattern set easy to use, update the behavior of
'git sparse-checkout [init|set]'.
Add '--cone' flag to 'git sparse-checkout init' to set the config
option 'core.sparseCheckoutCone=true'.
When running 'git sparse-checkout set' in cone mode, a user only
needs
From: Derrick Stolee
The read-tree builtin has a --verbose option that signals to show
progress and other data while updating the index. Update this to
be on by default when stderr is a terminal window.
This will help tools like 'git sparse-checkout' to automatically
benefit from progress indica
From: Derrick Stolee
The instructions for disabling a sparse-checkout to a full
working directory are complicated and non-intuitive. Add a
subcommand, 'git sparse-checkout disable', to perform those
steps for the user.
Signed-off-by: Derrick Stolee
---
Documentation/git-sparse-checkout.txt | 2
From: Derrick Stolee
The parent and recursive patterns allowed by the "cone mode"
option in sparse-checkout are restrictive enough that we
can avoid using the regex parsing. Everything is based on
prefix matches, so we can use hashsets to store the prefixes
from the sparse-checkout file. When che
From: Derrick Stolee
The 'git sparse-checkout set' subcommand takes a list of patterns
and places them in the sparse-checkout file. Then, it updates the
working directory to match those patterns. For a large list of
patterns, the command-line call can get very cumbersome.
Add a '--stdin' option
From: Jeff Hostetler
When Git updates the working directory with the sparse-checkout
feature enabled, the unpack_trees() method calls clear_ce_flags()
to update the skip-wortree bits on the cache entries. This
check can be expensive, depending on the patterns used.
Add trace2 regions around the
This series makes the sparse-checkout feature more user-friendly. While
there, I also present a way to use a limited set of patterns to gain a
significant performance boost in very large repositories.
Sparse-checkout is only documented as a subsection of the read-tree docs
[1], which makes the fea
From: Derrick Stolee
The sparse-checkout feature can have quadratic performance as
the number of patterns and number of entries in the index grow.
If there are 1,000 patterns and 1,000,000 entries, this time can
be very significant.
Create a new Boolean config option, core.sparseCheckoutCone, to
From: Derrick Stolee
The 'git sparse-checkout set' subcommand takes a list of patterns
as arguments and writes them to the sparse-checkout file. Then, it
updates the working directory using 'git read-tree -mu HEAD'.
The 'set' subcommand will replace the entire contents of the
sparse-checkout fil
From: Derrick Stolee
When someone wants to clone a large repository, but plans to work
using a sparse-checkout file, they either need to do a full
checkout first and then reduce the patterns they included, or
clone with --no-checkout, set up their patterns, and then run
a checkout manually. This
From: Derrick Stolee
Getting started with a sparse-checkout file can be daunting. Help
users start their sparse enlistment using 'git sparse-checkout init'.
This will set 'core.sparseCheckout=true' in their config, write
an initial set of patterns to the sparse-checkout file, and update
their wor
From: Derrick Stolee
The sparse-checkout feature is mostly hidden to users, as its
only documentation is supplementary information in the docs for
'git read-tree'. In addition, users need to know how to edit the
.git/info/sparse-checkout file with the right patterns, then run
the appropriate 'git
Hey,
Empty arguments passed on the command line can be a represented by a '',
however sq_quote_buf_pretty was incorrectly dropping these arguments
altogether. Fix this problem by ensuring that such arguments are emitted as
'' instead.
Looking forward to your review. Cheers! Garima Singh
Reported
From: Garima Singh
Empty arguments passed on the command line can be a represented by
a '', however sq_quote_buf_pretty was incorrectly dropping these
arguments altogether. Fix this problem by ensuring that such
arguments are emitted as '' instead.
Reported by: Junio Hamano
Signed-off-by: Garim
Hi Johannes,
Le 04/10/2019 à 17:09, Johannes Schindelin via GitGitGadget a écrit :
> From: Johannes Schindelin
>
> MSVC would complain thusly:
>
> C4200: nonstandard extension used: zero-sized array in struct/union
>
> Let's just use the `FLEX_ARRAY` constant that we introduced for exactly
Hi Birger,
Le 07/10/2019 à 12:43, Birger Skogeng Pedersen a écrit :
> It seems this topic has kindof derailed(?). But I feel like voicing my
> opinion nonetheless.
>
> -%<-
>
> My biggest gripe with not using Github is how to keep track of replies
> (comments) to a topic. I have to navigate thro
On 10/6/2019 12:22 AM, Elijah Newren wrote:
> On Thu, Sep 19, 2019 at 1:45 PM Derrick Stolee via GitGitGadget
> wrote:
>>
>> From: Derrick Stolee
>>
>> The sparse-checkout feature can have quadratic performance as
>> the number of patterns and number of entries in the index grow.
>> If there are
On 10/6/2019 12:10 AM, Elijah Newren wrote:
> On Thu, Sep 19, 2019 at 1:46 PM Derrick Stolee via GitGitGadget
> wrote:
>>
>> From: Derrick Stolee
>>
>> The instructions for disabling a sparse-checkout to a full
>> working directory are complicated and non-intuitive. Add a
>> subcommand, 'git spar
On Tue, Oct 01, 2019 at 04:16:26AM -0700, Johannes Schindelin via GitGitGadget
wrote:
> From: Johannes Schindelin
Good idea, now that 'make hdr-check' runs clean this will help to keep
it that way.
I think adding it to the static analysis job makes sense, as opposed
to the additional VM startup
On 10/5/2019 8:30 PM, Elijah Newren wrote:
> On Sat, Oct 5, 2019 at 3:44 PM Elijah Newren wrote:
>>
>> On Thu, Sep 19, 2019 at 3:07 PM Derrick Stolee via GitGitGadget
>> wrote:
>>> +static int write_patterns_and_update(struct pattern_list *pl)
>>> +{
>>> + char *sparse_filename;
>>> +
When running "git fetch" in a partial clone with no blobs, for example,
by:
git clone --filter=blob:none --no-checkout \
https://kernel.googlesource.com/pub/scm/git/git
git -C git fetch
"git fetch" will fail to load the config blob object, printing "unable
to load config blob object".
Th
On 10/3/19 4:36 PM, Junio C Hamano wrote:
>> +if (pos >= istate->cache_nr)
>> +BUG("fsmonitor_dirty has more entries than the index
>> (%"PRIuMAX" >= %"PRIuMAX")",
>> +(uintmax_t)pos, (uintmax_t)istate->cache_nr);
>
> This is how we show size_t values without usin
On Tue, Oct 01, 2019 at 11:55:24AM -0700, Elijah Newren wrote:
> Commits 404ebceda01c ("dir: also check directories for matching
> pathspecs", 2019-09-17) and 89a1f4aaf765 ("dir: if our pathspec might
> match files under a dir, recurse into it", 2019-09-17) added calls to
> match_pathspec() and do_
On 2019-10-07 21:20, Elijah Newren wrote:
On Mon, Oct 7, 2019 at 10:05 AM Semyon Kirnosenko wrote:
On 2019-10-07 20:43, SZEDER Gábor wrote:
On Mon, Oct 07, 2019 at 07:14:25PM +0400, Semyon Kirnosenko wrote:
I have a question about log command.
Probably I'm just missing something but anyway.
On 10/7/2019 1:27 PM, Eric Sunshine wrote:
> On Mon, Oct 7, 2019 at 12:17 PM Garima Singh via GitGitGadget
> wrote:
>> quote: handle numm and empty strings in sq_quote_buf_pretty
>
> What is "numm"?
Typo. Fixing in next update.
> What does it mean to "handle" these things? A possible rewrite o
On Sat, Sep 28, 2019 at 12:40:52PM +0900, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
> > On Fri, Sep 20, 2019 at 09:53:48AM -0700, William Baker via GitGitGadget
> > wrote:
> >> diff --git a/midx.h b/midx.h
> >> index f0ae656b5d..e6fa356b5c 100644
> >> --- a/midx.h
> >> +++ b/midx.h
> >> @@
On Mon, Oct 7, 2019 at 12:17 PM Garima Singh via GitGitGadget
wrote:
> quote: handle numm and empty strings in sq_quote_buf_pretty
What is "numm"?
What does it mean to "handle" these things? A possible rewrite of the
subject to explain the problem more precisely rather than using
generalizations
On Mon, Oct 7, 2019 at 10:05 AM Semyon Kirnosenko wrote:
>
> On 2019-10-07 20:43, SZEDER Gábor wrote:
> > On Mon, Oct 07, 2019 at 07:14:25PM +0400, Semyon Kirnosenko wrote:
> >> I have a question about log command.
> >> Probably I'm just missing something but anyway.
> >> I can illustrate the ques
On Wed, Oct 02, 2019 at 02:43:48PM +0900, Junio C Hamano wrote:
> William Baker writes:
>
> > Although my debugger might not be the smartest, I haven't noticed any
> > downsides to switching this to an enum.
>
> Well, if you write
>
> enum { BIT_0 = 1, BIT_1 = 2, BIT_3 = 4 } var;
>
> it'
When the user focuses the Commit Message widget (to write a message), the
diff view may be blank.
With this patch a staged file is automatically selected when the Commit
Message widget is focused, if no other file is selected (i.e. diff view
is blank).
Signed-off-by: Birger Skogeng Pedersen
---
Signed-off-by: Birger Skogeng Pedersen
---
git-gui.sh | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index fd476b6..b7f4d1e 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2669,25 +2669,31 @@ proc show_less_context {} {
I just noticed the typo in the commit message in my latest update.
Sorry about that.
Junio, would you be willing to fix it up whenever you queue the patch?
Or would you like me to send another update.
Thanks
Garima G Singh
On 10/7/2019 12:17 PM, Garima Singh via GitGitGadget wrote:
> From: Gari
On 2019-10-07 20:43, SZEDER Gábor wrote:
On Mon, Oct 07, 2019 at 07:14:25PM +0400, Semyon Kirnosenko wrote:
I have a question about log command.
Probably I'm just missing something but anyway.
I can illustrate the question on the repository of Git.
Let's look at revision 1ed91937
It is a merge b
So I kinda got this working, but only when focusing the commit message widget.
I did not manage to get it working when invoking "do_add_all", (e.g.
when pressing CTRL/CMD+i). I added this:
bind $ui_comm <$M1B-Key-i> {do_add_all;select_staged_file;break}
bind $ui_comm <$M1B-Key-I> {do_add_all;sele
On Mon, Oct 07, 2019 at 07:14:25PM +0400, Semyon Kirnosenko wrote:
> I have a question about log command.
> Probably I'm just missing something but anyway.
> I can illustrate the question on the repository of Git.
> Let's look at revision 1ed91937
> It is a merge based on pair of revisions a9572072
Hey,
The sq_quote_buf_pretty() function does not emit anything when the incoming
string is empty, but the function is to accumulate command line arguments,
properly quoted as necessary, and the right way to add an argument that is
an empty string is to show it quoted, i.e. ''.
Looking forward to
From: Garima Singh
The sq_quote_buf_pretty() function does not emit anything
when the incoming string is empty, but the function is to
accumulate command line arguments, properly quoted as
necessary, and the right way to add an argument that is an
empty string is to show it quoted, i.e. ''. We wa
On 10/07, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > Date: Fri, 04 Oct 2019 08:09:25 -0700 (PDT)
> > [...]
> > X-Google-Original-Date: Fri, 04 Oct 2019 15:09:10 GMT
> > [...]
> >
> > I am fairly certain that the latter is the actual `Date:` line sent to
> > GMail,
Hi there.
I have a question about log command.
Probably I'm just missing something but anyway.
I can illustrate the question on the repository of Git.
Let's look at revision 1ed91937
It is a merge based on pair of revisions a9572072 and 294c695d.
According to blame these parent revisions have dif
In commit 208e69a4ebce ("merge-recursive: fix the diff3 common ancestor
label for virtual commits", 2019-09-30) which was a fix to commit
743474cbfa8b ("merge-recursive: provide a better label for diff3 common
ancestor", 2019-08-17), the label for the common ancestor was changed
from always being
On 10/5/2019 3:40 PM, Elijah Newren wrote:
> On Thu, Sep 19, 2019 at 3:06 PM Derrick Stolee via GitGitGadget
> wrote:
>
>> During the 'git sparse-checkout init' call, we must first look
>> to see if HEAD is valid, or else we will fail while trying to
>> update the working directory. The first che
On 10/07, Uwe Kleine-König wrote:
> Hello,
>
> With git 2.23.0 I have:
>
> uwe@taurus:~/tmp/rangediff-segfault$ git init
> Initialized empty Git repository in
> /home/uwe/tmp/rangediff-segfault/.git/
> uwe@taurus:~/tmp/rangediff-segfault$ echo root > root
> uwe@taurus:~/t
Hi dear,
I'm Mrs Karin Großmann, please i wish to have a communication with you.
I am waiting for your answer,
mrskaringrossma...@gmail.com
Mrs Karin Großmann.
Hello,
I am Austin S. Miller. I need your assistance
Thank you in advance
Sincerely,
Austin S. Miller
Hello,
With git 2.23.0 I have:
uwe@taurus:~/tmp/rangediff-segfault$ git init
Initialized empty Git repository in
/home/uwe/tmp/rangediff-segfault/.git/
uwe@taurus:~/tmp/rangediff-segfault$ echo root > root
uwe@taurus:~/tmp/rangediff-segfault$ git add root
It seems this topic has kindof derailed(?). But I feel like voicing my
opinion nonetheless.
I have to say I absolutely agree with Johannes Schindelin here. I
would really prefer a more modern way of contributing to this project
(any software project, really) than using emails. Be that Github,
Gitl
Hi Junio,
On Mon, 7 Oct 2019, Johannes Schindelin wrote:
> On Mon, 7 Oct 2019, Junio C Hamano wrote:
>
> > Johannes Schindelin writes:
> >
> > > Hi Junio,
> > > ...
> > >> Thanks. I think it is much better to prepare these tests like this
> > >> patch does to be broken when phrasing changes---t
Hi Junio,
On Mon, 7 Oct 2019, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > Hi Junio,
> > ...
> >> Thanks. I think it is much better to prepare these tests like this
> >> patch does to be broken when phrasing changes---that would give
> >> feedback and confidence to the person who i
Hi Harish,
On Mon, 7 Oct 2019, Harish Karumuthil wrote:
> > However, it might not even need to put in _such_ a lot of work: in my
> > tests, `Control-,` worked just as well as `Control-comma`. To test this
> > for yourself, use this snippet (that is slightly modified from the
> > example at the b
Good news for you today
Getting a legitimate loan has always been a big problem for clients. The issue
of credit security is something that customers are increasingly worried about,
as well as looking for a loan from a legitimate lender. Intermex Investment
Group offers you an interest rate on
Good news for you today
Getting a legitimate loan has always been a big problem for clients. The issue
of credit security is something that customers are increasingly worried about,
as well as looking for a loan from a legitimate lender. Intermex Investment
Group offers you an interest rate on
Currently, the get_replay_opts() function does not initialise the
`squash_onto' field (which is used for the `--root' mode), only
read_populate_opts() does. That would lead to incorrect results when
calling pick_commits() without reading the options from the disk first.
Let’s change that.
Signed
Currently, complete_action() calls sequencer_continue() to do the
rebase. Before the former calls pick_commits(), it
- calls read_and_refresh_cache() -- this is unnecessary here as we've
just called require_clean_work_tree()
- calls read_populate_opts() -- this is unnecessary as we're starti
This can be seen as a continuation of ag/reduce-rewriting-todo.
Currently, complete_action() releases its todo list before calling
sequencer_continue(), which reloads the todo list from the disk. This
series removes this useless round trip.
Patches 1, 2, and 3 originally come from a series meani
In a todo list, `done_nr' is the amount of commands that were executed
or skipped, but skip_unnecessary_picks() did not update it.
This variable is mostly used by command prompts (ie. git-prompt.sh and
the like). As in the previous commit, this inconsistent behaviour is
not a problem yet, but it
`total_nr' is the total number of items, counting both done and todo,
that are in a todo list. But unlike `nr', it was not updated when an
item was appended to the list.
This variable is mostly used by command prompts (ie. git-prompt.sh and
the like). By forgetting to update it, the original cod
The total amount of commands can be used to show the progression of the
rebasing in a shell. It is written to the disk by read_populate_todo()
when the todo list is loaded from sequencer_continue() or
pick_commits(), but not by complete_action().
This moves the part writing total_nr to a new func
Hi Pratyush,
On Mon, 7 Oct 2019, Pratyush Yadav wrote:
> On 06/10/19 10:27PM, Johannes Schindelin wrote:
> >
> > On Mon, 7 Oct 2019, Pratyush Yadav wrote:
> >
> > > On 06/10/19 11:49AM, Johannes Schindelin wrote:
> > > >
> > > > On Sun, 6 Oct 2019, Pratyush Yadav wrote:
> > > >
> > > > > On 06/10
Junio C Hamano wrote:
> Eric Wong writes:
>
> > Comments stating that "struct hashmap_entry" must be the first
> > member in a struct are no longer valid.
>
> After this patch, there is one "/* must be the first member! */"
> comment left in convert.c, which is both misleading and unfortunate;
97 matches
Mail list logo
