Re: Oppdatering av helpdesk!!

2019-09-11 Thread Jakubišin Peter
?Kjaere postkassebruker Du har mottatt denne e-postmeldingen fordi kontoen din er brukt fra et annet sted av deg eller noen andre. vi har mandat til a apne en etterforskning av denne saken. For a beskytte kontoen din, vennligst se lenken nedenfor for en oyeblikkelig oppdatering for a sikre kont

Re: [PATCH 2/2] git-gui: add hotkey to toggle "Amend Last Commit" check button/menu

2019-09-11 Thread Birger Skogeng Pedersen
Hi Pratyush, On Wed, Sep 11, 2019 at 10:55 PM Pratyush Yadav wrote: > Also, I notice that the bindings for other letters have the same > function bound for both small and capital letters (IOW, same behavior > with shift held and released). > > I don't necessarily think that is a great idea. It is

Re: Oppdatering av helpdesk

2019-09-11 Thread Jakubišin Peter
?Kjaere postkassebruker Du har mottatt denne e-postmeldingen fordi kontoen din er brukt fra et annet sted av deg eller noen andre. vi har mandat til a apne en etterforskning av denne saken. For a beskytte kontoen din, vennligst se lenken nedenfor for en oyeblikkelig oppdatering for a sikre kont

[PATCH v2 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW

2019-09-11 Thread Stephen P. Smith
Remove the reference to the GIT_TEST_DATE_NOW which is done in date.c. We can't get rid of the "x" variable, since it serves as a generic scratch variable for parsing later in the function. Signed-off-by: Stephen P. Smith --- t/helper/test-date.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 1/2] Quit passing 'now' to date code

2019-09-11 Thread Stephen P. Smith
Commit b841d4ff43 (Add `human` format to test-tool, 2019-01-28) added a get_time() function which allows $GIT_TEST_DATE_NOW in the environment to override the current time. So we no longer need to interpret that variable in cmd__date(). Therefore, we can stop passing the "now" parameter down throu

[PATCH v2 0/2] Date test code clean-up

2019-09-11 Thread Stephen P. Smith
As part of a previous patch submission[1], a cleanup patch was suggested to remove a now unnecessary passing of a date environment variable to the production code. While the two patches in the set could easily be submitted as a single patch, I split the removal of the getenv() call into a second p

Do you know that you can hack any ATM machine !!!

2019-09-11 Thread marie frasson
Blank ATM Cards We have specially programmed ATM cards that can be used to hack any ATM machine, this ATM cards can be used to withdraw cash at the ATM or swipe, stores and outlets. We sell this cards to all our customers and interested buyers worldwide, the cards has a daily withdrawal limit of

Re: [PATCH] upload-pack: disable commit graph more gently for shallow traversal

2019-09-11 Thread Taylor Blau
On Wed, Sep 11, 2019 at 08:18:46PM -0400, Jeff King wrote: > On Wed, Sep 11, 2019 at 08:04:14PM -0400, Jeff King wrote: > > > When the client has asked for certain shallow options like > > "deepen-since", we do a custom rev-list walk that pretends to be > > shallow. Before doing so, we have to disa

Re: [PATCH] upload-pack: disable commit graph more gently for shallow traversal

2019-09-11 Thread Taylor Blau
Hi Peff, Thanks in advance for digging into all of this. I feel guilty for having found the issue myself, and then gotten a headache for just long enough to have you completely fix the issue by the time that I got back. So, thanks :-). On Wed, Sep 11, 2019 at 08:04:15PM -0400, Jeff King wrote: >

Re: [PATCH] list-objects: don't queue root trees unless revs->tree_objects is set

2019-09-11 Thread Jeff King
On Wed, Sep 11, 2019 at 09:11:37PM -0400, Jeff King wrote: > Let's try it after running "git commit-graph write": > > [before] > Benchmark #1: git -C linux rev-list HEAD >/dev/null > Time (mean ± σ): 1.458 s ± 0.011 s[User: 1.199 s, System: 0.259 > s] > Range (min … max):

[PATCH] list-objects: don't queue root trees unless revs->tree_objects is set

2019-09-11 Thread Jeff King
On Wed, Sep 11, 2019 at 08:18:46PM -0400, Jeff King wrote: > > That creates an interesting problem for commits that have _already_ been > > parsed using the commit graph. Their commit->object.parsed flag is set, > > their commit->graph_pos is set, but their commit->maybe_tree may still > > be NULL

Re: [PATCH] upload-pack: disable commit graph more gently for shallow traversal

2019-09-11 Thread Jeff King
On Wed, Sep 11, 2019 at 08:04:14PM -0400, Jeff King wrote: > When the client has asked for certain shallow options like > "deepen-since", we do a custom rev-list walk that pretends to be > shallow. Before doing so, we have to disable the commit-graph, since it > is not compatible with the shallow

[PATCH] upload-pack: disable commit graph more gently for shallow traversal

2019-09-11 Thread Jeff King
When the client has asked for certain shallow options like "deepen-since", we do a custom rev-list walk that pretends to be shallow. Before doing so, we have to disable the commit-graph, since it is not compatible with the shallow view of the repository. That's handled by 829a321569 (commit-graph:

Re: [PATCH] Documentation: fix build with Asciidoctor 2

2019-09-11 Thread brian m. carlson
On 2019-09-10 at 18:44:22, Jeff King wrote: > First off, thank you again for your explanations. I dread digging into > how anything related to docbook or xml works, so having you serve it up > on a silver platter is a delight. :) I'm happy to do it. I was an English major in college and virtually

[PATCH v2 0/1] Fix perl error "unescaped left brace in regex" for paranoid update hook

2019-09-11 Thread Dominic Winkler via GitGitGadget
A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: {. In v5.26, this won't just warn, it'll cause a syntax error. (see https://metacpan.org/pod/

[PATCH v2 1/1] contrib/hooks: escape left brace in regex in the paranoid update hook

2019-09-11 Thread Dominic Winkler via GitGitGadget
From: Dominic Winkler A literal "{" should now be escaped in a pattern starting from perl versions >= v5.26. In perl v5.22, using a literal { in a regular expression was deprecated, and will emit a warning if it isn't escaped: \{. In v5.26, this won't just warn, it'll cause a syntax error. (see

Re: [PATCH 1/1] Fix perl error "unescaped left brace in regex" for paranoid update hook

2019-09-11 Thread Johannes Schindelin
Hi Dominic, all looks good, with one exception: the Subject should start with `:`, i.e. in this instance something like this would be better: contrib/hooks: escape left brace in regex in the paranoid update hook Ciao, Johannes On Mon, 9 Sep 2019, Dominic Winkler via GitGitGadget wrote: > From:

Re: [PATCH 1/1] doc: small formatting fix

2019-09-11 Thread Johannes Schindelin
Hi Cameron, On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote: > From: Cameron Steffen > > move an incorrectly placed backtick This sentence is incomplete, and does not really explain _why_ the backtick needs to be moved. Something like this would be much clearer: Most likely

Re: [PATCH 0/1] doc: small formatting fix

2019-09-11 Thread Johannes Schindelin
Hi Cameron, On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote: > Edit: I need permission to submit please You got that permission already ;-) Ciao, Johannes > > Cameron Steffen (1): > doc: small formatting fix > > Documentation/pretty-formats.txt | 2 +- > 1 file changed, 1 inserti

Re: [PATCH 2/2] git-gui: add hotkey to toggle "Amend Last Commit" check button/menu

2019-09-11 Thread Pratyush Yadav
Birger, Please ignore the two emails I sent about basing your work on top of Bert's. I see that you have already done so (or maybe Bert did it, I don't know), and I was reading an older version of the patch. On 05/09/19 10:09PM, Bert Wesarg wrote: > From: Birger Skogeng Pedersen > > Selecting

Re: [PATCH 0/1] multi-pack-index: add --no-progress

2019-09-11 Thread Derrick Stolee
On 9/11/2019 11:37 AM, William Baker via GitGitGadget wrote: > Hello Git contributors! > > My name is William Baker and I work at Microsoft. Over the past few years > I've worked closely with the Microsoft team contributing to the git > ecosystem and I'm excited to start working with the community

Re: [PATCH 2/9] sparse-checkout: create 'init' subcommand

2019-09-11 Thread Derrick Stolee
On 8/23/2019 7:02 PM, Elijah Newren wrote: > On Tue, Aug 20, 2019 at 8:13 AM Derrick Stolee via GitGitGadget > wrote: >> +static int sc_read_tree(void) >> +{ >> + struct argv_array argv = ARGV_ARRAY_INIT; >> + int result = 0; >> + argv_array_pushl(&argv, "read-tree", "-m", "-u",

Re: [PATCH 1/2] git-gui: convert new/amend commit radiobutton to checketton

2019-09-11 Thread Pratyush Yadav
Typo in the subject. s/checketton/checkbutton/ On 05/09/19 10:09PM, Bert Wesarg wrote: > Signed-off-by: Bert Wesarg > --- > git-gui.sh | 36 +--- > lib/checkout_op.tcl | 6 +++--- > lib/commit.tcl | 4 ++-- > lib/index.tcl | 8 > 4

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Pratyush Yadav
On 12/09/19 12:04AM, Pratyush Yadav wrote: > On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote: > > Hi Pratyush, > > > > I'm hoping this will be merged, even without changing the radio > > selectors to a checkbox(?). The patch from Bert resolves the issue I > > raised about wanting the hotkey. >

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Pratyush Yadav
On 11/09/19 12:27PM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > I'm hoping this will be merged, even without changing the radio > selectors to a checkbox(?). The patch from Bert resolves the issue I > raised about wanting the hotkey. > What do you think? What do you mean by "this"? I am gu

[PATCH v4 2/3] merge: use refresh_and_write_cache

2019-09-11 Thread Thomas Gummerer
Use the 'refresh_and_write_cache()' convenience function introduced in the last commit, instead of refreshing and writing the index manually in merge.c Signed-off-by: Thomas Gummerer --- builtin/merge.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/builtin/me

[PATCH v4 1/3] factor out refresh_and_write_cache function

2019-09-11 Thread Thomas Gummerer
Getting the lock for the index, refreshing it and then writing it is a pattern that happens more than once throughout the codebase, and isn't trivial to get right. Factor out the refresh_and_write_cache function from builtin/am.c to read-cache.c, so it can be re-used in other places in a subsequen

[PATCH v4 3/3] stash: make sure to write refreshed cache

2019-09-11 Thread Thomas Gummerer
When converting stash into C, calls to 'git update-index --refresh' were replaced with the 'refresh_cache()' function. That is fine as long as the index is only needed in-core, and not re-read from disk. However in many cases we do actually need the refreshed index to be written to disk, for exam

[PATCH v4 0/3] make sure stash refreshes the index properly

2019-09-11 Thread Thomas Gummerer
Compared to the previous round this round introduces a gentle flag for refresh_and_write_{index,cache}, which should make this function suitable for use in the Dscho's builtin-add-i series. The latter will have to be I have also pushed this to https://github.com/tgummerer/git tg/stash-refresh-

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

2019-09-11 Thread Jeff Hostetler
On 9/10/2019 9:54 AM, Garima Singh wrote: Ping :) Any thoughts on this? On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we h

Re: [PATCH] completion: add missing completions for log, diff, show

2019-09-11 Thread Max Rothman
Just pinging again, I'd love to move this forward! On Thu, Aug 1, 2019 at 8:54 PM Max Rothman wrote: > > Ping :) > > > On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > > > The bash completion script knows some options to "git log" and > > "git show" only in the positive form, (e.g. "--abbr

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-11 Thread Johannes Sixt
Am 11.09.19 um 19:48 schrieb Pratyush Yadav: > Since this entire debate essentially boils down to personal preference, > there is no clear answer. So I'll just go with the author's > implementation. Fair enough. -- Hannes

Git.pm normalizes $GIT_DIR, was Re: git-send-email does not use conditional configuration

2019-09-11 Thread Jeff King
On Wed, Sep 11, 2019 at 06:58:26PM +0200, Konstantinos Dalamagkidis wrote: > I am using "includeIf.gitdir:/work". I tried to reproduce it at my home > workstation where I have the exact same configuration, but in the beginning > I couldn't. Then I realized, that at work the /work folder is actuall

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-11 Thread Thomas Gummerer
On 09/11, Johannes Schindelin wrote: > Hi Thomas, > > On Fri, 6 Sep 2019, Thomas Gummerer wrote: > > Oops, I didn't realize there was another series in flight that also > > introduces 'repo_refresh_and_write_index'. Probably should have done > > a test merge of this with pu. > > Yep, our patches

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-11 Thread Pratyush Yadav
On 11/09/19 08:49AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav wrote: > > This patch LGTM, but I'm not sure how to resolve the keybindings > > problem. Junio suggested we have configurable keybindings, and I agree > > with him, but until we d

Re: git-send-email does not use conditional configuration

2019-09-11 Thread Konstantinos Dalamagkidis
On 9/11/19 4:08 PM, Jeff King wrote: On Wed, Sep 11, 2019 at 08:14:45AM +0200, Konstantinos Dalamagkidis wrote: In my git configuration, I have an includeif section for work related repositories that configures the user and sendemail sections. What kind of includeIf are you using? Does it wor

[PATCH 0/1] multi-pack-index: add --no-progress

2019-09-11 Thread William Baker via GitGitGadget
Hello Git contributors! My name is William Baker and I work at Microsoft. Over the past few years I've worked closely with the Microsoft team contributing to the git ecosystem and I'm excited to start working with the community. Derrick Stolee helped me pick out my first task, and it's to add sup

[PATCH 1/1] multi-pack-index: add --no-progress Add --no-progress option to git multi-pack-index. The progress feature was added in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-0

2019-09-11 Thread William Baker via GitGitGadget
From: William Baker Signed-off-by: William Baker --- Documentation/git-multi-pack-index.txt | 6 +- builtin/multi-pack-index.c | 14 +--- midx.c | 30 +- midx.h | 6 -- t/t5319-

Re: [PATCH] ci: install P4 from package to fix build error

2019-09-11 Thread Johannes Schindelin
Hi, On Tue, 10 Sep 2019, SZEDER Gábor wrote: > On Tue, Sep 10, 2019 at 12:51:01AM +0200, Johannes Schindelin wrote: > > On Fri, 6 Sep 2019, SZEDER Gábor wrote: > > > > > On Fri, Sep 06, 2019 at 12:27:11PM +0200, SZEDER Gábor wrote: > > > > > Let's install P4 from the package repository, because t

[PATCH v2 0/1] doc: small formatting fix

2019-09-11 Thread Cameron Steffen via GitGitGadget
Move a closing backtick that was placed one character too soon. Cameron Steffen (1): doc: minor formatting fix Documentation/pretty-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e Published-As: https://github.com/gitgit

[PATCH v2 1/1] doc: minor formatting fix

2019-09-11 Thread Cameron Steffen via GitGitGadget
From: Cameron Steffen Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen --- Documentation/pretty-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt inde

Re: [PATCH 2/9] sparse-checkout: create 'init' subcommand

2019-09-11 Thread Derrick Stolee
On 8/23/2019 7:02 PM, Elijah Newren wrote: > On Tue, Aug 20, 2019 at 8:13 AM Derrick Stolee via GitGitGadget > wrote: >> >> From: Derrick Stolee >> >> Getting started with a sparse-checkout file can be daunting. Help >> users start their sparse enlistment using 'git sparse-checkout init'. >> This

Re: git-send-email does not use conditional configuration

2019-09-11 Thread Jeff King
On Wed, Sep 11, 2019 at 08:14:45AM +0200, Konstantinos Dalamagkidis wrote: > In my git configuration, I have an includeif section for work > related repositories that configures the user and sendemail > sections. What kind of includeIf are you using? Does it work with an unconditional include? Th

could not fork child process rebasing required

2019-09-11 Thread Castro Alvarez, Sebastian
Dear Git team, I have recently updated my computer to W10. So, I reinstalled the newest version of Git, and it is not working. It gives the following error: Error: Could not fork child process: Resource temporarily unavailable (-1). DLL rebasing may be required; see 'rebaseall / rebase --help'.

pd/fetch-jobs, was Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)

2019-09-11 Thread Johannes Schindelin
Hi Junio, On Sat, 7 Sep 2019, Junio C Hamano wrote: > * pd/fetch-jobs (2019-08-13) 5 commits > . fetch: make --jobs control submodules and remotes > . fetch: add the --submodule-fetch-jobs option > . fetch: add the fetch.jobs config key > . fetch: add the "--fetch-jobs" option > . fetch: ren

Re: [PATCH 1/1] doc: small formatting fix

2019-09-11 Thread Derrick Stolee
On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote: > From: Cameron Steffen > > move an incorrectly placed backtick The change below is simple enough, but we prefer using full sentences in the commit messages. This includes capitalization and punctuation. Thanks, -Stolee > Signed-of

Re: [PATCH 0/1] doc: small formatting fix

2019-09-11 Thread Derrick Stolee
On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote: > Edit: I need permission to submit please Hi Cameron. When using GitGitGadget, your PR description becomes your cover letter on the mailing list. This is a great place for you to describe how you discovered this problem and if you ha

Re: [PATCH v3 1/3] factor out refresh_and_write_cache function

2019-09-11 Thread Johannes Schindelin
Hi Thomas, On Fri, 6 Sep 2019, Thomas Gummerer wrote: > On 09/05, Junio C Hamano wrote: > > Thomas Gummerer writes: > > > > > Getting the lock for the index, refreshing it and then writing it is a > > > pattern that happens more than once throughout the codebase, and isn't > > > trivial to get r

Re: feature request, git-gui: add hotkey to toggle amend/new

2019-09-11 Thread Birger Skogeng Pedersen
Hi Pratyush, I'm hoping this will be merged, even without changing the radio selectors to a checkbox(?). The patch from Bert resolves the issue I raised about wanting the hotkey. What do you think? Birger

an urgent mail pls

2019-09-11 Thread Nayef Abu Sakran
Do you receive the mail i send to you?

Fwd: Path instead of pathspec for “git checkout [--] ”

2019-09-11 Thread Bogdan Butnaru
Hello! Not sure if I’m doing something wrong here, but it seems that when calling “git checkout [--] ”, the last argument is not interpreted correctly. I have a repository that contains a multi-module Maven project, and as such it contains several “pom.xml” files, one in the root directory and a