Re: [GSoC] How to protect cached_objects

2019-05-25 Thread Duy Nguyen
On Sat, May 25, 2019 at 11:04 PM Matheus Tavares Bernardino wrote: > > On Fri, May 24, 2019 at 6:55 AM Duy Nguyen wrote: > > > > On Thu, May 23, 2019 at 11:51 PM Matheus Tavares Bernardino > > wrote: > > > > > > > > Hi, everyone > > > > > > As one of my first tasks in GSoC, I'm looking to protec

Re: receive.denyCurrentBranch that allows pushing data, just not changing branch

2019-05-25 Thread Ævar Arnfjörð Bjarmason
On Sat, May 25 2019, Shawn Landden wrote: > It would be nice if when pushing to a checked out repo you could get > up git to still push the commits, just not update the branch's HEAD. How would this proposed feature differ from what receive.denyCurrentBranch=false does now? You have a commit X

receive.denyCurrentBranch that allows pushing data, just not changing branch

2019-05-25 Thread Shawn Landden
It would be nice if when pushing to a checked out repo you could get up git to still push the commits, just not update the branch's HEAD. -Shawn Landden

Re: git archive generates tar with malformed pax extended attribute

2019-05-25 Thread brian m. carlson
On 2019-05-25 at 20:46:16, Ævar Arnfjörð Bjarmason wrote: > Solaris tar also complains about this. I've seen that for ages, but > never thought to report it, I figured it was well-known. > > When you "tar xf" an archive git-archive it complains: > > tar: pax_global_header: typeflag 'g' not re

Re: git archive generates tar with malformed pax extended attribute

2019-05-25 Thread Ævar Arnfjörð Bjarmason
On Sat, May 25 2019, René Scharfe wrote: > Am 24.05.19 um 10:13 schrieb Jeff King: >> On Fri, May 24, 2019 at 09:35:51AM +0200, Keegan Carruthers-Smith wrote: >> I can't reproduce on Linux, using GNU tar (1.30) nor with bsdtar 3.3.3 (from Debian's bsdtar package). What does your "tar -

Re: [PATCH 0/3] fix diff-parseopt regressions

2019-05-25 Thread Todd Zullinger
Duy Nguyen wrote: > On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote: >> I applied this on top of master/2.22.0-rc1 and see a number >> of compiler errors using gcc-9.1.1 with fedora's standard >> compiler options for rpm builds. > > That last patch 4/3 is not meant to be applied. Yes I've s

Re: git archive generates tar with malformed pax extended attribute

2019-05-25 Thread Ævar Arnfjörð Bjarmason
On Fri, May 24 2019, Jeff King wrote: > On Fri, May 24, 2019 at 08:45:23AM +0200, Keegan Carruthers-Smith wrote: > >> git archive can generate a malformed tar archive. bsdtar reports the >> error "tar: Ignoring malformed pax extended attribute" when reading >> the archive. Go's "tar/archive" pac

Re: [GSoC] How to protect cached_objects

2019-05-25 Thread Matheus Tavares Bernardino
On Fri, May 24, 2019 at 6:55 AM Duy Nguyen wrote: > > On Thu, May 23, 2019 at 11:51 PM Matheus Tavares Bernardino > wrote: > > > > > Hi, everyone > > > > As one of my first tasks in GSoC, I'm looking to protect the global > > states at sha1-file.c for future parallelizations. Currently, I'm > > a

Re: [GSoC] How to protect cached_objects

2019-05-25 Thread Matheus Tavares Bernardino
On Fri, May 24, 2019 at 3:13 AM Jeff King wrote: > > On Thu, May 23, 2019 at 01:51:47PM -0300, Matheus Tavares Bernardino wrote: > > > As one of my first tasks in GSoC, I'm looking to protect the global > > states at sha1-file.c for future parallelizations. Currently, I'm > > analyzing how to deal

[PATCH v2] list-objects-filter: disable 'sparse:path' filters

2019-05-25 Thread Christian Couder
If someone wants to use as a filter a sparse file that is in the repository, something like "--filter=sparse:oid=:" already works. So 'sparse:path' is only interesting if the sparse file is not in the repository. In this case though the current implementation has a big security issue, as it makes

Re: git archive generates tar with malformed pax extended attribute

2019-05-25 Thread Andreas Schwab
On Mai 25 2019, René Scharfe wrote: > Can Unicode symlink targets contain NULs? We wouldn't want to damage > them even if we decide to truncate. The POSIX interface doesn't allow creating such a symlink, since the argument to symlink is a C string. Andreas. -- Andreas Schwab, sch...@linux-m6

Re: git archive generates tar with malformed pax extended attribute

2019-05-25 Thread René Scharfe
Am 24.05.19 um 10:13 schrieb Jeff King: > On Fri, May 24, 2019 at 09:35:51AM +0200, Keegan Carruthers-Smith wrote: > >>> I can't reproduce on Linux, using GNU tar (1.30) nor with bsdtar 3.3.3 >>> (from Debian's bsdtar package). What does your "tar --version" say? >> >> bsdtar 2.8.3 - libarchive 2.8

Mac OSX git uninstall unsuccessful

2019-05-25 Thread Mobro
Through the MAC system prompt direct installation of git, after installation found that the local sshkey and GitHub account link, has been prompted "Connection closed by 192.30.253.112 port 22", check the log found no problem. So it is suspected that the GIT installation was wrong. Under termina

Re: [PATCH 0/1] trace2: fix tracing when NO_PTHREADS is defined

2019-05-25 Thread Duy Nguyen
On Thu, May 23, 2019 at 12:51 PM Jeff King wrote: > For fun, here's a constant-time zero-allocation implementation that I > came up with. It passes t0211 with NO_PTHREADS, but I didn't test it > beyond that. > > diff --git a/thread-utils.h b/thread-utils.h > index 4961487ed9..f466215742 100644 > -

Re: Incorrect diff-parseopt conversion?

2019-05-25 Thread Duy Nguyen
On Fri, May 24, 2019 at 5:08 PM Ævar Arnfjörð Bjarmason wrote: > >> OK, I just had a look at the code in parse-options.c. > >> Hmm, somewhat ugly! :-D > > > > Yeah it's a bit hackish. The problem is parse-options (and also config > > parser) does not allow passing user data to the callback. Changi

Re: [PATCH 0/3] fix diff-parseopt regressions

2019-05-25 Thread Duy Nguyen
On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote: > > Hi, > > Nguyễn Thái Ngọc Duy wrote: > > This should fix the diff tests failure on s360x. It's a serious problem > > and I plan to do something to prevent it from happening again. > > Thanks for looking at this! > > I applied this on top of