Re: [PATCH v2 2/2] send-email: honor transferencoding config option again

2019-05-08 Thread Junio C Hamano
Eric Sunshine writes: > On Wed, May 8, 2019 at 6:56 AM Junio C Hamano wrote: >> Since e67a228cd8a ("send-email: automatically determine >> transfer-encoding"), the value of sendmail.transferencoding in the >> configuration file is ignored, because $target_xfer_encoding is > > s/,// (also all ot

Re: [PATCH] tag: fix typo in nested tagging hint

2019-05-08 Thread Junio C Hamano
Denton Liu writes: > In eea9c1e78f (tag: advise on nested tags, 2019-04-04), tag was taught > to hint at the user if a nested tag is made. However, this message had a > typo and it said "The object referred to by your new is...", which was > missing a "tag" after "new". Fix this message by adding

Re: [PATCH 12/17] Documentation: describe split commit-graphs

2019-05-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > With commit-graph- all these unlink() race conditions go away, > partial reads due to concurrent graph writing becomes a non-issue (we'd > just leave the old files, "gc" deals with them later..), no need to > carefully fsync() files/dirs etc as we need to careful

Re: [PATCH v3] repack: enable bitmaps by default on bare repos

2019-05-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Sat, May 04 2019, SZEDER Gábor wrote: > ... >> And don't forget that the commit-graph progress bar still prints >> nonsense :) > > I'm inclined to just wait until Derrick's refactorings land post-2.22.0 Fine by me. Thanks.

Re: Fwd: [PATCH v2 1/1] diff-highlight: Use correct /dev/null for UNIX and Windows

2019-05-08 Thread Junio C Hamano
Git Gadget writes: > Forwarding this mail to the Git mailing list, as the original did not > make it there (for reasons unknown). It seems that the forwarding mechansim (if this weren't manual---I cannot tell) mangles whitespaces? No need to resend, as the receiving end manually fixed them up.

LOANS !!!

2019-05-08 Thread DIAL DIRECT LOAN SA.
Dial Direct Loan SA Consolidate your debts with Dial Direct Loan SA for your peace of mind at a fixed interest rate of 4.75%,personal and business loans are also welcome.For details file in your applications by sending an email to: infodialdirectlo...@mail2consultant.com. Yours in Service, S

Re: Proposal: Remembering message IDs sent with git send-email

2019-05-08 Thread Emily Shaffer
On Wed, May 08, 2019 at 07:10:13PM -0400, Drew DeVault wrote: > I want to gather some thoughts about this. Say you've written a patch > series and are getting ready to send a -v2. If you set > --in-reply-to=ask, it'll show you a list of emails you've recently sent, > and their subject lines, and as

Re: Cannot access git-scm.com with Tor

2019-05-08 Thread Jeff King
On Wed, May 08, 2019 at 08:39:17AM +, opal hart wrote: > On Tue, 7 May 2019 03:33:22 -0400 > Jeff King wrote: > > > The "security settings" toggle for the site on Cloudflare is already set > > to "low", and there are no other restrictions. Is it actually blocking? > > Or is it asking for a C

Re: [PATCH v2 2/2] send-email: honor transferencoding config option again

2019-05-08 Thread brian m. carlson
On Wed, May 08, 2019 at 07:56:07PM +0900, Junio C Hamano wrote: > diff --git a/git-send-email.perl b/git-send-email.perl > index 98bc295c6e..b9dd775b63 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -231,7 +231,7 @@ sub do_edit { > my (@suppress_cc); > my ($auto_8bit_encoding

Proposal: Remembering message IDs sent with git send-email

2019-05-08 Thread Drew DeVault
I want to gather some thoughts about this. Say you've written a patch series and are getting ready to send a -v2. If you set --in-reply-to=ask, it'll show you a list of emails you've recently sent, and their subject lines, and ask you to pick one to use the message ID from. It'll set the In-Reply-T

Re: [PATCH v2 2/4] archive-tar: mark RECORDSIZE/BLOCKSIZE as unsigned

2019-05-08 Thread Jeff King
On Wed, May 08, 2019 at 01:45:25PM +0200, Johannes Schindelin wrote: > Hi René, > > On Thu, 2 May 2019, René Scharfe wrote: > > > Am 27.04.19 um 01:27 schrieb Johannes Schindelin via GitGitGadget: > > > From: Johannes Schindelin > > > > > > They really are unsigned, and we are using e.g. BLOCKS

Re: [PATCH] coccicheck: optionally batch spatch invocations

2019-05-08 Thread Jeff King
On Wed, May 08, 2019 at 08:36:10AM -0400, Denton Liu wrote: > > %.cocci.patch: %.cocci $(COCCI_SOURCES) > > @echo '' SPATCH $<; \ > > - if ! echo $(COCCI_SOURCES) | xargs -n $(SPATCH_BATCH_SIZE) \ > > + if test $(SPATCH_BATCH_SIZE) = 0; then \ > > + limit=; \ > > + else \

Re: Git build on antique PowerMac

2019-05-08 Thread Ævar Arnfjörð Bjarmason
On Sun, May 05 2019, Eric Sunshine wrote: > On Sun, May 5, 2019 at 3:43 PM Jeffrey Walton wrote: >> I have a PowerMac I use for testing. [...] >> make -C t/ all >> readline() on unopened filehandle test_must_fail >> run_sub_test_lib_test at check-non-portable-shell.pl line 34. >> Modific

Re: [PATCH v3] repack: enable bitmaps by default on bare repos

2019-05-08 Thread Jeff King
On Wed, May 08, 2019 at 06:13:58PM +0200, Ævar Arnfjörð Bjarmason wrote: > > I do wonder if this really needs to be part of the progress bar. The > > goal of the progress bar is to give the user a sense that work is > > happening, and (if possible, but not for "enumerating") an idea of when > > it

[ANNOUNCE] git-cinnabar 0.5.1

2019-05-08 Thread Mike Hommey
Hi, Git-cinnabar is a git remote helper to interact with mercurial repositories. It allows to clone, pull and push from/to mercurial remote repositories, using git. Code on https://github.com/glandium/git-cinnabar This release on https://github.com/glandium/git-cinnabar/releases/tag/0.5.1 What's

[PATCH 1/1] difftool --no-index: error out on --dir-diff (and don't crash)

2019-05-08 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin In `--no-index` mode, we now no longer require a worktree nor a repository. But some code paths in `difftool` expect those to be present. The most notable such code path is the `--dir-diff` one: we use the existing checkout machinery to copy the files, and that machiner

[PATCH 0/1] difftool: --no-index is incompatible with --dir-diff

2019-05-08 Thread Johannes Schindelin via GitGitGadget
While debugging why a straight-forward backport of the js/difftool-no-index branch onto Git for Windows' master does not work as expected (spoiler: it's due to git diff --no-index now implying --ext-diff, a change that is not yet in Git for Windows' master), I ran into quite a few segmentation fau

Re: [PATCH v2 2/2] send-email: honor transferencoding config option again

2019-05-08 Thread Eric Sunshine
On Wed, May 8, 2019 at 6:56 AM Junio C Hamano wrote: > Since e67a228cd8a ("send-email: automatically determine > transfer-encoding"), the value of sendmail.transferencoding in the > configuration file is ignored, because $target_xfer_encoding is s/,// > already defined read_config sub parses the

Re: [PATCH v3] repack: enable bitmaps by default on bare repos

2019-05-08 Thread Ævar Arnfjörð Bjarmason
On Sat, May 04 2019, SZEDER Gábor wrote: > On Sat, May 04, 2019 at 08:52:01AM +0200, Ævar Arnfjörð Bjarmason wrote: >> As an aside this is the Nth time I notice how crappy that "Enumerating >> objects" progress bar is. > > And don't forget that the commit-graph progress bar still prints > nonsen

Re: [PATCH v5 1/2] documentation: add tutorial for first contribution

2019-05-08 Thread Jonathan Tan
> > And "official" is a phrase I have trouble with in this context. A > > mirror does not have to be blessed as official; that's the point of > > a mirror---anybody can make one to help users with better > > connectivity or availability, as long as its users trust the mirror > > maintainer for mir

Re: GSoC students and mentors 2019

2019-05-08 Thread Rohit Ashiwal
Hey Thomas Thanks for the heartwarming welcome and cheers Matheus for getting selected to GSoC '19. May all our code gets merged (in respective projects ofc :p). Best Rohit

Re: [PATCH 00/17] [RFC] Commit-graph: Write incremental files

2019-05-08 Thread Ævar Arnfjörð Bjarmason
On Wed, May 08 2019, Derrick Stolee via GitGitGadget wrote: > This patch series is marked as RFC quality because it is missing some key > features and tests, but hopefully starts a concrete discussion of how the > incremental commit-graph writes can work. If this is a good direction, then > it w

Re: [PATCH] Doc: add missing backticks to pull.rebase value

2019-05-08 Thread Derrick Stolee
On 5/8/2019 2:43 PM, Denton Liu wrote: > In the documentation for pull.rebase, all of the valid values are > surrounded with backticks except for "true". Surround "true" with these > missing backticks. This would make the rendered docs [1] look a bit better, but I think this series is incomplete.

[PATCH] tag: fix typo in nested tagging hint

2019-05-08 Thread Denton Liu
In eea9c1e78f (tag: advise on nested tags, 2019-04-04), tag was taught to hint at the user if a nested tag is made. However, this message had a typo and it said "The object referred to by your new is...", which was missing a "tag" after "new". Fix this message by adding the "tag". Signed-off-by: D

Re: [PATCH v5 1/2] documentation: add tutorial for first contribution

2019-05-08 Thread Emily Shaffer
On Wed, May 08, 2019 at 12:46:47PM +0900, Junio C Hamano wrote: > Emily Shaffer writes: > > > +=== Clone the Git Repository > > + > > +Git is mirrored in a number of locations. Clone the repository from one of > > them; > > +https://git-scm.com/downloads suggests one of the best places to clone

Re: [PATCH 12/17] Documentation: describe split commit-graphs

2019-05-08 Thread Derrick Stolee
On 5/8/2019 1:20 PM, SZEDER Gábor wrote: > On Wed, May 08, 2019 at 08:53:57AM -0700, Derrick Stolee via GitGitGadget > wrote: >> From: Derrick Stolee > Consider the following sequence of events: > > 1. There are three commit-graph files in the repository. > > 2. A git process opens the base

[PATCH] Doc: add missing backticks to pull.rebase value

2019-05-08 Thread Denton Liu
In the documentation for pull.rebase, all of the valid values are surrounded with backticks except for "true". Surround "true" with these missing backticks. Signed-off-by: Denton Liu --- Documentation/config/pull.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentati

Re: What's cooking in git.git (May 2019, #01; Thu, 9)

2019-05-08 Thread Elijah Newren
On Wed, May 8, 2019 at 10:23 AM Junio C Hamano wrote: > * en/unicode-in-refnames (2019-04-26) 1 commit > - Honor core.precomposeUnicode in more places > > The names of the refs stored as filesystem entities may become > different from what the end-user expects, just like files in the > workin

Re: [PATCH v2 2/2] format-patch: teach format.notes config option

2019-05-08 Thread Beat Bolli
On 08.05.19 19:31, Denton Liu wrote: > Hi Beat, > > On Wed, May 08, 2019 at 07:18:18PM +0200, Beat Bolli wrote: >> On 08.05.19 17:02, Denton Liu wrote: >>> In git-format-patch, notes can be appended with the `--notes` option. >>> However, this must be specified by the user on an >>> invocation-by-

Re: What's cooking in git.git (May 2019, #01; Thu, 9)

2019-05-08 Thread Denton Liu
Hi Junio, On Thu, May 09, 2019 at 02:23:24AM +0900, Junio C Hamano wrote: > Here are the topics that have been cooking. Commits prefixed with > '-' are only in 'pu' (proposed updates) while commits prefixed with > '+' are in 'next'. The ones marked with '.' do not appear in any of > the integrat

What's cooking in git.git (May 2019, #01; Thu, 9)

2019-05-08 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The 8th batch of topics, which Hop

Re: [PATCH v2 2/2] format-patch: teach format.notes config option

2019-05-08 Thread Denton Liu
Hi Beat, On Wed, May 08, 2019 at 07:18:18PM +0200, Beat Bolli wrote: > On 08.05.19 17:02, Denton Liu wrote: > > In git-format-patch, notes can be appended with the `--notes` option. > > However, this must be specified by the user on an > > invocation-by-invocation basis. If a user is not careful,

Re: [PATCH v2 2/2] format-patch: teach format.notes config option

2019-05-08 Thread Beat Bolli
On 08.05.19 17:02, Denton Liu wrote: > In git-format-patch, notes can be appended with the `--notes` option. > However, this must be specified by the user on an > invocation-by-invocation basis. If a user is not careful, it's possible > that they may forget to include it and generate a patch series

Re: [PATCH 12/17] Documentation: describe split commit-graphs

2019-05-08 Thread SZEDER Gábor
On Wed, May 08, 2019 at 08:53:57AM -0700, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The design for the split commit-graphs uses file names to force > a "stack" of commit-graph files. This allows incremental writes > without updating the file format. > > Signed-off-by: Der

GSoC students and mentors 2019

2019-05-08 Thread Thomas Gummerer
As in past years, Git is participating in Google Summer of Code this year. The student slots have just been announced, and we're going to have 2 students and 4 (co-)mentors this year. Please join me in congratulating Rohit Ashiwal and Matheus Tavares Bernardino for being accepted into the program

Re: [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes

2019-05-08 Thread LI, BO XUAN
Hi Junio, Understood. Thanks for the clarification. Best regards, Boxuan Li On Wed, May 8, 2019 at 1:49 PM Junio C Hamano wrote: > > "LI, BO XUAN" writes: > > > Thanks for your review! I can understand your point, but I've got a > > quick question: > > > > What if format-patch really breaks an

Re: [PATCH v3] repack: enable bitmaps by default on bare repos

2019-05-08 Thread Ævar Arnfjörð Bjarmason
On Wed, May 08 2019, Jeff King wrote: > On Tue, May 07, 2019 at 10:12:06AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > I think we'd want a way to tell the bitmap code to update our progress >> > meter as it traverses (both single objects, but also taking into account >> > when it finds a bitmap

[PATCH 10/17] commit-graph: extract copy_oids_to_commits()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. Extract copy_oids_to_commits(), which fills the commits list with the distinct commits from the oids list. During this loop, it also counts the number of "extra" edges from octopus merge

[PATCH 15/17] commit-graph: write split commit-graph files

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Signed-off-by: Derrick Stolee --- commit-graph.c | 248 +++- commit-graph.h | 1 + t/t5318-commit-graph.sh | 2 +- 3 files changed, 244 insertions(+), 7 deletions(-) diff --git a/commit-graph.c b/commit-graph.c inde

[PATCH 16/17] commit-graph: add --split option

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Signed-off-by: Derrick Stolee --- builtin/commit-graph.c | 10 +++--- t/t5318-commit-graph.sh | 26 ++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index 828b1a713f..c2c07d3917 1

[PATCH 00/17] [RFC] Commit-graph: Write incremental files

2019-05-08 Thread Derrick Stolee via GitGitGadget
This patch series is marked as RFC quality because it is missing some key features and tests, but hopefully starts a concrete discussion of how the incremental commit-graph writes can work. If this is a good direction, then it would replace ds/commit-graph-format-v2. The commit-graph is a valuable

[PATCH 05/17] commit-graph: create write_commit_graph_context

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too large and complex. To simplify it, we should extract several small methods. However, we will risk repeating a lot of declarations related to progress incidators and object id or commit lists. Create a new write_commit_graph_context stru

[PATCH 12/17] Documentation: describe split commit-graphs

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The design for the split commit-graphs uses file names to force a "stack" of commit-graph files. This allows incremental writes without updating the file format. Signed-off-by: Derrick Stolee --- Documentation/technical/commit-graph.txt | 142 +++ 1 fil

[PATCH 03/17] commit-graph: collapse parameters into flags

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() and write_commit_graph_reachable() methods currently take two boolean parameters: 'append' and 'report_progress'. We will soon expand the possible options to send to these methods, so instead of complicating the parameter list, first simplify it. Col

[PATCH 02/17] commit-graph: return with errors during write

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method uses die() to report failure and exit when confronted with an unexpected condition. This use of die() in a library function is incorrect and is now replaced by error() statements and an int return type. Now that we use 'goto cleanup' to jump t

[PATCH 09/17] commit-graph: extract count_distinct_commits()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. Extract count_distinct_commits(), which sorts the oids list, then iterates through to find duplicates. Signed-off-by: Derrick Stolee --- commit-graph.c | 35 ++

[PATCH 08/17] commit-graph: extract fill_oids_from_all_packs()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. Extract fill_oids_from_all_packs() that reads all pack-files for commits and fills the oid list in the context. Signed-off-by: Derrick Stolee --- commit-graph.c | 26 +++--

[PATCH 04/17] commit-graph: remove Future Work section

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit-graph feature began with a long list of planned benefits, most of which are now complete. The future work section has only a few items left. As for making more algorithms aware of generation numbers, some are only waiting for generation number v2 to ensure the per

[PATCH 11/17] commit-graph: extract write_commit_graph_file()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. Extract write_commit_graph_file() that takes all of the information in the context struct and writes the data to a commit-graph file. Signed-off-by: Derrick Stolee --- commit-graph.c

[PATCH 06/17] commit-graph: extract fill_oids_from_packs()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. This extracts fill_oids_from_packs() that reads the given pack-file list and fills the oid list in the context. Signed-off-by: Derrick Stolee --- commit-graph.c | 83 +

[PATCH 07/17] commit-graph: extract fill_oids_from_commit_hex()

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method is too complex, so we are extracting methods one by one. Extract fill_oids_from_commit_hex() that reads the given commit id list and fille the oid list in the context. Signed-off-by: Derrick Stolee --- commit-graph.c | 72 ++

[PATCH 13/17] commit-graph: lay groundwork for incremental files

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Signed-off-by: Derrick Stolee --- commit-graph.c | 66 -- commit-graph.h | 4 +++ 2 files changed, 62 insertions(+), 8 deletions(-) diff --git a/commit-graph.c b/commit-graph.c index 7723156964..f790f44a9c 100644 --- a/commi

[PATCH 17/17] fetch: add fetch.writeCommitGraph config setting

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Signed-off-by: Derrick Stolee --- builtin/fetch.c | 17 + 1 file changed, 17 insertions(+) diff --git a/builtin/fetch.c b/builtin/fetch.c index b620fd54b4..cf0944bad5 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -23,6 +23,7 @@ #include "packfile.h

[PATCH 14/17] commit-graph: load split commit-graph files

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Starting with commit-graph, load commit-graph files in a sequence as follows: commit-graph commit-graph-1 commit-graph-2 ... commit-graph-N This creates N + 1 files in order. Signed-off-by: Derrick Stolee --- commit-graph.c | 39

[PATCH 01/17] commit-graph: fix the_repository reference

2019-05-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The parse_commit_buffer() method takes a repository pointer, so it should not refer to the_repository anymore. Signed-off-by: Derrick Stolee --- commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit.c b/commit.c index a5333c7ac6..e4d1233226 10

Re: [PATCH 01/19] revision.h: avoid bit fields in struct rev_info

2019-05-08 Thread Derrick Stolee
On 5/8/2019 10:41 AM, Duy Nguyen wrote: > On Wed, May 8, 2019 at 9:07 PM Derrick Stolee wrote: >> >> On 5/8/2019 7:12 AM, Nguyễn Thái Ngọc Duy wrote: >>> Bitfield addresses cannot be passed around in a pointer. This makes it >>> hard to use parse-options to set/unset them. Turn this struct to >>>

[PATCH v2 2/2] format-patch: teach format.notes config option

2019-05-08 Thread Denton Liu
In git-format-patch, notes can be appended with the `--notes` option. However, this must be specified by the user on an invocation-by-invocation basis. If a user is not careful, it's possible that they may forget to include it and generate a patch series without notes. Teach git-format-patch the `

[PATCH v2 0/2] format-patch: teach format.notes config option

2019-05-08 Thread Denton Liu
Hi Junio, Thanks for the review. I made format.notes accept one (or more) refs now. Changes since v1: * Made format.notes accept a notes ref instead of a boolean Denton Liu (2): git-format-patch.txt: document --no-notes option format-patch: teach format.notes config option Documentation/

[PATCH v2 1/2] git-format-patch.txt: document --no-notes option

2019-05-08 Thread Denton Liu
Internally, git-format-patch uses the `handle_revision_opt` parser. The parser handles the `--no-notes` option to negate an earlier `--notes` option, but it isn't documented. Document this option so that users are aware of it. Signed-off-by: Denton Liu --- Documentation/git-format-patch.txt | 4

Re: [PATCH 01/19] revision.h: avoid bit fields in struct rev_info

2019-05-08 Thread Duy Nguyen
On Wed, May 8, 2019 at 9:07 PM Derrick Stolee wrote: > > On 5/8/2019 7:12 AM, Nguyễn Thái Ngọc Duy wrote: > > Bitfield addresses cannot be passed around in a pointer. This makes it > > hard to use parse-options to set/unset them. Turn this struct to > > normal integers. This of course increases th

Re: [PATCH 1/2] midx: pass a repository pointer

2019-05-08 Thread Derrick Stolee
On 5/7/2019 4:31 AM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> From: Derrick Stolee >> >> Much of the multi-pack-index code focuses on the multi_pack_index >> struct, and so we only pass a pointer to the current one. However, >> we will insert a dependency on the pac

Re: [PATCH v3] repack: enable bitmaps by default on bare repos

2019-05-08 Thread Derrick Stolee
On 5/8/2019 3:11 AM, Jeff King wrote: > On Tue, May 07, 2019 at 10:12:06AM +0200, Ævar Arnfjörð Bjarmason wrote: > >>> I think we'd want a way to tell the bitmap code to update our progress >>> meter as it traverses (both single objects, but also taking into account >>> when it finds a bitmap and

Re: [PATCH 01/19] revision.h: avoid bit fields in struct rev_info

2019-05-08 Thread Derrick Stolee
On 5/8/2019 7:12 AM, Nguyễn Thái Ngọc Duy wrote: > Bitfield addresses cannot be passed around in a pointer. This makes it > hard to use parse-options to set/unset them. Turn this struct to > normal integers. This of course increases the size of this struct > multiple times, but since we only have a

Re: [PATCH] coccicheck: optionally batch spatch invocations

2019-05-08 Thread Denton Liu
Hi Jeff, On Wed, May 08, 2019 at 03:07:54AM -0400, Jeff King wrote: > On Tue, May 07, 2019 at 01:52:32PM +0900, Junio C Hamano wrote: > > > Jeff King writes: > > > > > Yes, 2^31-1 is probably a better number, but it's harder to write out. :) > > > > > > Here's what a patch might look like to im

Re: [PATCH v2 2/4] archive-tar: mark RECORDSIZE/BLOCKSIZE as unsigned

2019-05-08 Thread Johannes Schindelin
Hi René, On Thu, 2 May 2019, René Scharfe wrote: > Am 27.04.19 um 01:27 schrieb Johannes Schindelin via GitGitGadget: > > From: Johannes Schindelin > > > > They really are unsigned, and we are using e.g. BLOCKSIZE as `size_t` > > parameter to pass to `write_or_die()`. > > True, but the compiler

Re: [PATCH 2/2] mingw: enable DEP and ASLR

2019-05-08 Thread Johannes Schindelin
Hi Brian, On Wed, 1 May 2019, brian m. carlson wrote: > On Wed, May 01, 2019 at 08:39:22PM +0200, Alban Gruin wrote: > > -Og also exists to debug[0], even if it’s far less known. Perhaps it’s > > better to check for -g (and its variants[1]) as the user clearly states > > their intent to debug th

Re: [PATCH 2/2] mingw: enable DEP and ASLR

2019-05-08 Thread Johannes Schindelin
Hi Alban, On Wed, 1 May 2019, Alban Gruin wrote: > Le 01/05/2019 à 00:41, Johannes Schindelin a écrit : > > > > On Tue, 30 Apr 2019, Johannes Sixt wrote: > > > >> [had to add Dscho as recipient manually, mind you] > > > > I usually pick up responses to GitGitGadget patch series even if I am not >

[PATCH v2 0/2] Enable Data Execution Protection and Address Space Layout Randomization on Windows

2019-05-08 Thread Johannes Schindelin via GitGitGadget
These two techniques make it harder to come up with exploits, by reducing what is commonly called the "attack surface" in security circles: by making the addresses less predictable, and by making it harder to inject data that is then (mis-)interpreted as code, this hardens Git's executables on Wind

[PATCH v2 2/2] mingw: enable DEP and ASLR

2019-05-08 Thread İsmail Dönmez via GitGitGadget
From: =?UTF-8?q?=C4=B0smail=20D=C3=B6nmez?= Enable DEP (Data Execution Prevention) and ASLR (Address Space Layout Randomization) support. This applies to both 32bit and 64bit builds and makes it substantially harder to exploit security holes in Git by offering a much more unpredictable attack sur

[PATCH v2 1/2] mingw: do not let ld strip relocations

2019-05-08 Thread İsmail Dönmez via GitGitGadget
From: =?UTF-8?q?=C4=B0smail=20D=C3=B6nmez?= This is the first step for enabling ASLR (Address Space Layout Randomization) support. We want to enable ASLR for better protection against exploiting security holes in Git: it makes it harder to attack software by making code addresses unpredictable.

Re: [PATCH 2/2] mingw: enable DEP and ASLR

2019-05-08 Thread Johannes Schindelin
Hi Jonathan & Peff, On Wed, 1 May 2019, Jonathan Nieder wrote: > Jeff King wrote: > > > I wonder if this points to this patch touching the wrong level. These > > compiler flags are a thing that _some_ builds want (i.e., production > > builds where people care most about security and not about deb

[PATCH 03/19] revision.c: prepare to convert handle_revision_pseudo_opt()

2019-05-08 Thread Nguyễn Thái Ngọc Duy
This patch is essentially no-op. It allows to parse_options() to handle some options. But the new option list remains empty. The option will be moved one by one from the old manual parsing code to this list. Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 44

[PATCH 11/19] rev-parseopt: convert --reflog

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/revision.c b/revision.c index d34e17984d..6efa9bee1e 100644 --- a/revision.c +++ b/revision.c @@ -2452,6 +2452,18 @@ static int rev_opt_glob(const struct opt

[PATCH 15/19] rev-parseopt: convert --single-worktree

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/revision.c b/revision.c index f04eb7f140..dd22ac5c39 100644 --- a/revision.c +++ b/revision.c @@ -2601,6 +2601,9 @@ static void make_pseudo_options(struct rev_in

[PATCH 02/19] revision.h: move repo field down

2019-05-08 Thread Nguyễn Thái Ngọc Duy
This block at the top of rev_info is "Starting list" and repo is obviously not one. Move it to the bottom since it's not that important to stay on top. Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/revision.h b/revision.h

[PATCH 08/19] rev-parseopt: convert --remotes

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/revision.c b/revision.c index 5183cdf66d..bcfca8856f 100644 --- a/revision.c +++ b/revision.c @@ -2425,6 +2425,27 @@ static int rev_opt_branch

[PATCH 16/19] rev-parseopt: prepare to convert handle_revision_opt()

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Besides preparing an empty option table to be added in. The table is also concatenated with diff option table so we don't need diff_opt_parse() anymore. Merging with pseudo-opt table though will not happen until we kill parse_revision_opt(). --abbrev has to be converted right away to override the

[PATCH 07/19] rev-parseopt: convert --tags

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/revision.c b/revision.c index 0d34f81716..5183cdf66d 100644 --- a/revision.c +++ b/revision.c @@ -2425,6 +2425,27 @@ static int rev_opt_branch

[PATCH 04/19] rev-parseopt: convert --all

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 41 ++--- revision.h | 2 ++ 2 files changed, 32 insertions(+), 11 deletions(-) diff --git a/revision.c b/revision.c index 65d40c9255..9a346577f6 100644 --- a/revision.c +++ b/revision.c @@ -30,6 +30,10 @@

[PATCH 12/19] rev-parseopt: convert --indexed-objects

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/revision.c b/revision.c index 6efa9bee1e..9cfa4dc151 100644 --- a/revision.c +++ b/revision.c @@ -2438,6 +2438,18 @@ static int rev_opt_exclude(const struct

[PATCH 14/19] rev-parseopt: convert --no-walk and --do-walk

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 47 ++- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/revision.c b/revision.c index b02cb4660b..f04eb7f140 100644 --- a/revision.c +++ b/revision.c @@ -2464,6 +2464,29 @@ static int

[PATCH 00/19] Convert revision.c to parseopt part 1/4

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Following the conversion in diff.c to use parse_options, this time it's revision.c. There are about 76 patches to convert all options, split in 4 parts. After that there are about 10 more to convert rev users to use parse_options() directly. Full 76 patches are available here [1]. I'm not quite do

[PATCH 09/19] rev-parseopt: convert --glob

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/revision.c b/revision.c index bcfca8856f..013b8ec19f 100644 --- a/revision.c +++ b/revision.c @@ -30,6 +30,9 @@ #include "prio-queue.h" #include "

[PATCH 10/19] rev-parseopt: convert --exclude

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/revision.c b/revision.c index 013b8ec19f..d34e17984d 100644 --- a/revision.c +++ b/revision.c @@ -2428,6 +2428,16 @@ static int rev_opt_branches(const struct

[PATCH 06/19] rev-parseopt: convert --bisect

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/revision.c b/revision.c index 7db1109b57..0d34f81716 100644 --- a/revision.c +++ b/revision.c @@ -2387,6 +2387,23 @@ static int rev_opt_all(const st

[PATCH 05/19] rev-parseopt: convert --branches

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/revision.c b/revision.c index 9a346577f6..7db1109b57 100644 --- a/revision.c +++ b/revision.c @@ -34,6 +34,10 @@ OPT_CALLBACK_F(s,

[PATCH 01/19] revision.h: avoid bit fields in struct rev_info

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Bitfield addresses cannot be passed around in a pointer. This makes it hard to use parse-options to set/unset them. Turn this struct to normal integers. This of course increases the size of this struct multiple times, but since we only have a handful of rev_info variables around, memory consumption

[PATCH 13/19] rev-parseopt: convert --not

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/revision.c b/revision.c index 9cfa4dc151..b02cb4660b 100644 --- a/revision.c +++ b/revision.c @@ -2464,6 +2464,17 @@ static int rev_opt_glob(const struct opti

[PATCH 19/19] rev-parseopt: convert --min-age and --max-age

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- parse-options-cb.c | 8 parse-options.h| 4 revision.c | 10 -- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/parse-options-cb.c b/parse-options-cb.c index 6e2e8d6273..7cdbbf5f6d 100644 --- a/parse-optio

[PATCH 18/19] rev-parseopt: convert --skip

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/revision.c b/revision.c index c53347d362..42d466cd08 100644 --- a/revision.c +++ b/revision.c @@ -1996,6 +1996,9 @@ static void make_rev_options(struct rev_info *revs)

[PATCH 17/19] rev-parseopt: convert --max-count

2019-05-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- revision.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/revision.c b/revision.c index f15aa3e62d..c53347d362 100644 --- a/revision.c +++ b/revision.c @@ -1976,12 +1976,26 @@ static int rev_opt_abbrev(co

[PATCH] Improving HP-UX support

2019-05-08 Thread Osipov, Michael
Hi folks, please find a patch attached to properly compile and link Git 2.21.0 on HP-UX IA64. The patch includes basically two changes: * Detection of big endian on HP-UX otherwise SHA1 calc is broken * Detection of linking style with HP aCC export PREFIX=/opt/ports export LIBDIR=$PREFIX/li

Re: [PATCH 1/1] cvsexportcommit: force crlf translation

2019-05-08 Thread Junio C Hamano
Johannes Schindelin writes: > How about this: > > The offical CVS for Windows (called CVS NT) produces DOS line > endings in its `cvs status` output. Let's teach our own > `cvsexportcommit` command to handle that gracefully. > > It is unlikely that anybody wants to spend time "f

Re: [PATCH 1/1] cvsexportcommit: force crlf translation

2019-05-08 Thread Johannes Schindelin
Hi Junio, On Tue, 7 May 2019, Junio C Hamano wrote: > "Dustin Spicuzza via GitGitGadget" writes: > > > From: Dustin Spicuzza > > > > When using cvsnt + msys + git, it seems like the output of cvs status > > had \r\n in it, and caused the command to fail. > > This is a bit under-explained in tha

[PATCH v2 1/2] send-email: update the mechanism to set default configuration values

2019-05-08 Thread Junio C Hamano
The program has a good mechanism to specify the fallback default values for boolean configuration variables after two invocations of read_config() for "sendmail.$ident.$var" and "sendemail.$var" have not found any configuration. Imitate it so that we can set the default values for non-boolean vari

[PATCH v2 2/2] send-email: honor transferencoding config option again

2019-05-08 Thread Junio C Hamano
Since e67a228cd8a ("send-email: automatically determine transfer-encoding"), the value of sendmail.transferencoding in the configuration file is ignored, because $target_xfer_encoding is already defined read_config sub parses the configuration file. Instead of initializing variable $target_xfer_en

[PATCH v2 0/2] send-email: set xfer encoding correctly

2019-05-08 Thread Junio C Hamano
Earlier I sent a series of "oops that was wrong" which was rather embarrassing. This is what I have to replace Heinrich's patch that was not quite right, while making it harder to make the same mistake while defining fallback default values to configuration variables. Junio C Hamano (2): send-e

Fwd: [PATCH v2 1/1] diff-highlight: Use correct /dev/null for UNIX and Windows

2019-05-08 Thread Git Gadget
Forwarding this mail to the Git mailing list, as the original did not make it there (for reasons unknown). -- Forwarded message - From: Chris. Webster via GitGitGadget Date: Wed, Oct 31, 2018 at 11:58 PM Subject: [PATCH v2 1/1] diff-highlight: Use correct /dev/null for UNIX and Wi

Re: [PATCH v3 00/16] Add new command 'restore'

2019-05-08 Thread Duy Nguyen
On Wed, May 8, 2019 at 1:31 AM Emily Shaffer wrote: > > > I found myself in a situation where I had accidentally > > > staged all my changes to tracked files (I think resulting from a stash > > > pop which generated a merge conflict?) and didn't see a good way to > > > unstage everything using res

Re: Re* [PATCH 1/1] send-email: fix transferencoding config option

2019-05-08 Thread Junio C Hamano
Junio C Hamano writes: > So, here is a two-patch series that tries to do so, primarily done > to gauge if there still is the level of interest needed to make it > worth for us to pursue this topic. Here is the first one; I'll send > the second one that takes advantage of this change separately (

  1   2   >