Re: git-gui: unstaged changes windowpane resets after unstaging a line

2019-03-31 Thread Bert Wesarg
On Sun, Mar 31, 2019 at 9:48 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > > On Sun, 31 Mar 2019 at 21:15, Bert Wesarg wrote: > > > > Hi Jan, > > > > On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > > > > > > Hello > > > > > > After performing "Unstage Line From Commi

AW: Problem with filename containing '?'

2019-03-31 Thread Kurt Ablinger
Good morning, sorry to waste your time - my check was incomplete - the file in question is there. But the problem with eGit/jGit on Windows (Eclipse) persists. I did not check jGit in linux. The problem seems to be, that linux accepts ? in filenames - but windows does not - so no problem wit

Re: [GSoC][PATCH v5 2/7] clone: better handle symlinked files at .git/objects/

2019-03-31 Thread Matheus Tavares Bernardino
On Sun, Mar 31, 2019 at 2:40 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares wrote: > > There is currently an odd behaviour when locally cloning a repository > > with symlinks at .git/objects: using --no-hardlinks all symlinks are > > dereferenced but without it, Git will try to hardlink t

Re: [GSoC][PATCH v4 2/7] clone: better handle symlinked files at .git/objects/

2019-03-31 Thread Matheus Tavares Bernardino
On Sat, Mar 30, 2019 at 4:27 PM Thomas Gummerer wrote: > > On 03/30, Matheus Tavares Bernardino wrote: > > On Fri, Mar 29, 2019 at 5:05 PM Thomas Gummerer > > wrote: > > > > > > On 03/29, Matheus Tavares Bernardino wrote: > > > > Ok, what if instead of using linkat() we use 'realpath(const char

Re: Typo in the .gitignore docs?

2019-03-31 Thread Duy Nguyen
Please send plain text mails. HTML mails are dropped by git@vger.kernel.org so other people will not see them. On Sun, Mar 31, 2019 at 6:27 PM Dr. Adam Nielsen wrote: > > Thank you for your quick response. > > I will create a pull request and its probably best to continue the discussion > from t

[PATCH] index-pack: show progress while checking objects

2019-03-31 Thread SZEDER Gábor
When 'git index-pack' is run by 'git clone', its check_objects() function usually doesn't take long enough to be a concern, but I just run into a situation where it took about a minute or so: I inadvertently put some memory pressure on my tiny laptop while cloning linux.git, and then there was quit

Re: [PATCH] mailinfo: support Unicode scissors

2019-03-31 Thread SZEDER Gábor
On Mon, Apr 01, 2019 at 12:01:04AM +0200, Andrei Rybak wrote: > diff --git a/mailinfo.c b/mailinfo.c > index b395adbdf2..4ef6cdee85 100644 > --- a/mailinfo.c > +++ b/mailinfo.c > @@ -701,6 +701,13 @@ static int is_scissors_line(const char *line) > c++; >

Hi

2019-03-31 Thread christa deng
-- Hello dear. My name is Miss Christa Dim, I'm from the Republic of Sudan, but I live here as an orphan in the Republic of Togo. I have seen your data on my private internet search and have something very important and confidential to discuss with you please contact me back for more discussion, p

Re: Google "Season of Docs"

2019-03-31 Thread Philip Oakley
hi Kapil, On 31/03/2019 07:41, Kapil Jain wrote: On Sat, Mar 30, 2019 at 10:48 PM Philip Oakley wrote: * Developers rarely want to write documentation (it's too obvious to them) -- Our code base has become larger than the average brain-full, maybe that (developer education) also could also bene

Re: [RFC] git stash --snapshot

2019-03-31 Thread Thomas Gummerer
On 03/21, Randall S. Becker wrote: > About two weeks ago there was a discussion about building an undo stack. > https://public-inbox.org/git/000401d4d6c8$f68bb020$e3a31060$@nexbridge.com/ > > it had me thinking about whether a stash --snapshot might be useful. Below > is a conceptual change - by

[PATCH] mailinfo: support Unicode scissors

2019-03-31 Thread Andrei Rybak
'git am --scissors' allows cutting a patch from an email at a scissors line. Such a line should contain perforation, i.e. hyphens, and a scissors symbol. Only ASCII graphics scissors '8<' '>8' '%<' '>%' are recognized by 'git am --scissors' command at the moment. Unicode character 'BLACK SCISSOR

Re: Google "Season of Docs"

2019-03-31 Thread Thomas Gummerer
On 03/30, Philip Oakley wrote: > We mentor Summer of Code projects. > Perhaps we should be doing something similar for docs.  Now Google are: One thing that I think is worth highlighting, that I don't think is clear from the blog post or this email, is that in contrast to Google Summer of Code, Se

Re: git-gui: unstaged changes windowpane resets after unstaging a line

2019-03-31 Thread Jan Ziak
On Sun, 31 Mar 2019 at 21:15, Bert Wesarg wrote: > > Hi Jan, > > On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > > > > Hello > > > > After performing "Unstage Line From Commit" action, the "Unstaged > > Changes" windowpane is reset. The reset does not happen with "Unst

Re: [GSoC] Unify ref-filter formats with other --pretty formats

2019-03-31 Thread Olga Telezhnaya
вс, 31 мар. 2019 г. в 20:45, Kapil Jain : > > On Fri, Mar 29, 2019 at 7:23 PM Kapil Jain wrote: > > > > On Thu, Mar 28, 2019 at 11:14 PM Olga Telezhnaya > > wrote: > > > > > > Unfortunately, I can't consult you properly about structure of > > > pretty.c. I guess that would be your first task of t

Re: git-gui: unstaged changes windowpane resets after unstaging a line

2019-03-31 Thread Bert Wesarg
Hi Jan, On Sun, Mar 31, 2019 at 8:45 PM Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > > Hello > > After performing "Unstage Line From Commit" action, the "Unstaged > Changes" windowpane is reset. The reset does not happen with "Unstage > Hunk From Commit" action. because its not necessary when sta

Re: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

2019-03-31 Thread Thomas Gummerer
On 03/31, jonathan chang wrote: > On Sun, Mar 31, 2019 at 3:38 AM Thomas Gummerer wrote: > > > > On 03/30, Jonathan Chang wrote: > > > Signed-off-by: Jonathan Chang > > > --- > > > t/t-basic.sh | 14 -- > > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > > > diff --git

Re: [GSoC] Unify ref-filter formats with other --pretty formats

2019-03-31 Thread Thomas Gummerer
On 03/31, Kapil Jain wrote: > On Fri, Mar 29, 2019 at 7:23 PM Kapil Jain wrote: > > > > On Thu, Mar 28, 2019 at 11:14 PM Olga Telezhnaya > > wrote: > > > > > > Unfortunately, I can't consult you properly about structure of > > > pretty.c. I guess that would be your first task of the internship to

git-gui: searching for a matching regular expression in file contents

2019-03-31 Thread Jan Ziak
Hello git gui is missing a search functionality in the "Portions staged for commit" windowpane. Ctrl+F key combination currently has the same effect as the PageDown key. git version 2.21.0 Sincerely Jan

git-gui: unstaged changes windowpane resets after unstaging a line

2019-03-31 Thread Jan Ziak
Hello After performing "Unstage Line From Commit" action, the "Unstaged Changes" windowpane is reset. The reset does not happen with "Unstage Hunk From Commit" action. git version 2.21.0 Sincerely Jan

Re: [GSoC][PATCH v5 0/7] clone: dir-iterator refactoring with tests

2019-03-31 Thread Thomas Gummerer
On 03/30, Matheus Tavares wrote: > This patchset contains: > - a replacement of explicit recursive dir iteration at > copy_or_link_directory for the dir-iterator API; > - some refactoring and behaviour changes at local clone, mainly to > take care of symlinks and hidden files at .git/objects; a

Re: [GSoC][PATCH v5 3/7] dir-iterator: add flags parameter to dir_iterator_begin

2019-03-31 Thread Thomas Gummerer
On 03/30, Matheus Tavares wrote: > Add the possibility of giving flags to dir_iterator_begin to initialize > a dir-iterator with special options. > > Currently possible flags are DIR_ITERATOR_PEDANTIC, which makes > dir_iterator_advance abort immediately in the case of an error while > trying to f

Re: [GSoC] Unify ref-filter formats with other --pretty formats

2019-03-31 Thread Kapil Jain
On Fri, Mar 29, 2019 at 7:23 PM Kapil Jain wrote: > > On Thu, Mar 28, 2019 at 11:14 PM Olga Telezhnaya > wrote: > > > > Unfortunately, I can't consult you properly about structure of > > pretty.c. I guess that would be your first task of the internship to > > dive into it and think how to improve

Re: [GSoC][PATCH v5 2/7] clone: better handle symlinked files at .git/objects/

2019-03-31 Thread Thomas Gummerer
On 03/30, Matheus Tavares wrote: > There is currently an odd behaviour when locally cloning a repository > with symlinks at .git/objects: using --no-hardlinks all symlinks are > dereferenced but without it, Git will try to hardlink the files with the > link() function, which has an OS-specific beha

[PATCH v2 4/4] replace: fix --graft when passing a tag first

2019-03-31 Thread Christian Couder
When passing a tag as the first argument to `git replace --graft`, it can be useful to accept it and use the underlying commit as a the commit that will be replaced. This already works for lightweight tags, but unfortunately for annotated tags we have been using the hash of the tag object instead

[PATCH v2 3/4] replace: fix --graft when passing a tag as parent

2019-03-31 Thread Christian Couder
When passing a tag as a parent argument to `git replace --graft`, it can be useful to accept it and use the underlying commit as a parent. This already works for lightweight tags, but unfortunately for annotated tags we have been using the hash of the tag object instead of the hash of the underlyi

[PATCH v2 1/4] t6050: use test_line_count instead of wc -l

2019-03-31 Thread Christian Couder
This modernizes a test and makes it more portable. Reviewed-by: Taylor Blau Signed-off-by: Christian Couder --- t/t6050-replace.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh index d638119750..41b177936e 100755 --- a/t/t6050-

[PATCH v2 0/4] fix `git replace --graft` tag related issues

2019-03-31 Thread Christian Couder
This is version 2 of a small patch series to fix tag related issues in `git replace --graft` that Andreas Schwab reported in: https://public-inbox.org/git/mvmd0mcsjkf@suse.de/ The first version of this patch series was: https://public-inbox.org/git/20190328171722.9753-1-chrisc...@tuxfamily.o

[PATCH v2 2/4] t6050: redirect expected error output to a file

2019-03-31 Thread Christian Couder
Otherwise the error from `git rev-parse` is uselessly polluting the debug output. Redirecting to a file, instead of /dev/null, makes it possible to check that we got the error we expected, so let's check that too. Reviewed-by: Taylor Blau Helped-by: Eric Sunshine Helped-by: Ævar Arnfjörð Bjarma

Re: Typo in the .gitignore docs?

2019-03-31 Thread Duy Nguyen
On Sun, Mar 31, 2019 at 4:54 PM Duy Nguyen wrote: > The "does not contain" is correct, but perhaps the wording is a bit > too easy to misunderstand. If you go back to the original version of > this document in cedb8d5d33 (Create a new manpage for the gitignore > format, and reference it elsewhere,

Re: Typo in the .gitignore docs?

2019-03-31 Thread Duy Nguyen
On Sun, Mar 31, 2019 at 2:53 AM Dr. Adam Nielsen wrote: > > Hi everyone, > > I think there is a typo in the gitignore docs. > > Its stated on https://git-scm.com/docs/gitignore that > > >If the pattern does not contain a slash /, Git treats it as a shell > >glob pattern and checks for a match agai