Ree...

2019-01-13 Thread KHIM LEANG
Greetings! I sent this letter to you 2days ago,but I'm not sure if you get it,and this is the reason i repeat it again.Please get back to me for more details. Regards, Khim Leang

[PATCH] partial-clone: add missing 'is' in doc

2019-01-13 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/technical/partial-clone.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/partial-clone.txt b/Documentation/technical/partial-clone.txt index 1ef66bd788..896c7b3878 100644 --- a/Documentation/technica

Re: [PATCH 3/5] match-trees: use hashcpy to splice trees

2019-01-13 Thread brian m. carlson
On Fri, Jan 11, 2019 at 09:54:46AM -0500, Jeff King wrote: > On Fri, Jan 11, 2019 at 09:51:06AM -0500, Jeff King wrote: > > > I think rewrite_here needs to be a direct pointer into the buffer, since > > we plan to modify it. > > > > I think rewrite_with is correct to be an object_id. It's either

Re: [PATCH 1/2] git-p4: add failing test for shelved CL update involving move

2019-01-13 Thread Eric Sunshine
On Sun, Jan 13, 2019 at 8:58 AM Luke Diamand wrote: > Updating a shelved P4 changelist where one or more of the files have > been moved does not work. Add a test for this. Perhaps this message could give more detail about the actual problem than the generic "does not work" which provides no usefu

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-13 Thread Alban Gruin
Hi Stephen, thank you for your patch. I left a few comments below. Le 11/01/2019 à 22:51, Stephen Boyd a écrit : > The Linux kernel receives many patches to the devicetree files each > release. The hunk header for those patches typically show nothing, > making it difficult to figure out what nod

[PATCH] config.h: fix hdr-check warnings

2019-01-13 Thread Ramsay Jones
commit 8f7c7f ("config.c: add repo_config_set_worktree_gently()", 2018-12-27) adds three function declarations that cause the hdr-check make target to complain. The hdr-check complaint is caused by placing the new declarations, which include 'struct repository *' parameters, before the declar

[PATCH] rebase-interactive.h: fix hdr-check warnings

2019-01-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Alban, If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch, could you please squash this into the relevant patch [commit c27b32f0ec4 ("sequencer: refactor check_todo_list() to work on a todo_list", 2018-12-29)]. [Both commit e5b1c9d9299 a

[PATCH] sequencer: mark file local symbols as static

2019-01-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Alban, If you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch, could you please squash this into the relevant patch [commit 45f215c912 ("rebase-interactive: use todo_list_write_to_file() in edit_todo_list()", 2018-12-29)]. I believe this com

[PATCH] revision.c: fix sparse warnings (sparse algorithm)

2019-01-13 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Derrick, If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could you please squash this into the relevant patch [commit 9949aaeef4 ("revision: implement sparse algorithm", 2018-12-14)]. This commit caused both 'sparse' and my 'static-check.pl'

[PATCH 0/2] git-p4: handle moved files when updating a P4 shelve

2019-01-13 Thread Luke Diamand
I found this bug recently in git-p4 - updating a shelved changelist where files are being moved doesn't work. The destination of any moves needs to be added to the list of files passed to P4. Luke Diamand (2): git-p4: add failing test for shelved CL update involving move git-p4: handle update

[PATCH 2/2] git-p4: handle update of moved files when updating a shelve

2019-01-13 Thread Luke Diamand
Perforce requires a complete list of files being operated on. If git is updating an existing shelved changelist, then any files which are moved were not being added to this list. Signed-off-by: Luke Diamand --- git-p4.py| 1 + t/t9807-git-p4-submit.sh | 2 +- 2 files changed, 2 i

[PATCH 1/2] git-p4: add failing test for shelved CL update involving move

2019-01-13 Thread Luke Diamand
Updating a shelved P4 changelist where one or more of the files have been moved does not work. Add a test for this. Signed-off-by: Luke Diamand --- t/t9807-git-p4-submit.sh | 53 +--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/t/t9807-git-p

Re: [PATCH] fetch: fix extensions.partialclone name in error message

2019-01-13 Thread Eric Sunshine
On Sun, Jan 13, 2019 at 3:52 AM Christian Couder wrote: > There is "extensions.partialclone" and "core.partialCloneFilter", but > not "core.partialclone". Only "extensions.partialclone" is meant to > contain a remote name. > > While at it, let's wrap the relevant code lines to keep them at a > rea

[PATCH] fetch: fix extensions.partialclone name in error message

2019-01-13 Thread Christian Couder
There is "extensions.partialclone" and "core.partialCloneFilter", but not "core.partialclone". Only "extensions.partialclone" is meant to contain a remote name. While at it, let's wrap the relevant code lines to keep them at a reasonable lenght. Signed-off-by: Christian Couder --- builtin/fetch