Re: [PATCH 1/3] Add 'human' date format

2019-01-03 Thread Jeff King
On Thu, Jan 03, 2019 at 06:19:56AM -0700, Stephen P. Smith wrote: > On Thursday, January 3, 2019 12:37:35 AM MST Jeff King wrote: > > I like the idea of "human", and I like the idea of "auto", but it seems > > to me that these are really two orthogonal things. E.g., might some > > people not want

Re: git-send-email warnings & process dying of signal 11

2019-01-03 Thread Carlo Arenas
one important point to consider when tracking this bug is that perl is not crashing, but is told to abort by some instrumentation (most likely gcc's fortify) and as shown by : *** buffer overflow detected ***: /usr/bin/perl terminated Carlo

Re: git version 2.20.1.windows.1 throws file name too long in gitk

2019-01-03 Thread Bret Barkelew
They are the exact same path (with a different drive letter). Another thing I've been able to confirm is I uninstalled git 2.20.1 and installed 2.19.0 on the failing system, and the older version of Git works. I've also tried a suggested fix I saw elsewhere to enable long path names in the Windows

Re: [PATCH] diff: add support for reading files literally with --no-index

2019-01-03 Thread brian m. carlson
On Thu, Jan 03, 2019 at 06:18:55PM -0800, Jonathan Nieder wrote: > I may be a minority in this opinion, but I had trouble understanding > what --literally would do from its name. I suspect we can come up > with a better name. > > Unfortunately, I'm terrible at coming up with names. :-P > > --der

git version 2.20.1.windows.1 throws file name too long in gitk

2019-01-03 Thread Bret Barkelew
When I open gitk in a particular repository under this version of Git for Windows, I now get a dialog box that says "Error: couldn't execute "git": file name too long". I've noticed that the most pronounced effect is that I cannot see the file diffs (or sometimes the file name list) for any of the

Re: [PATCH] diff: add support for reading files literally with --no-index

2019-01-03 Thread Jonathan Nieder
Hi, brian m. carlson wrote: > In some shells, such as bash and zsh, it's possible to use a command > substitution to provide the output of a command as a file argument to > another process, like so: > > diff -u <(printf "a\nb\n") <(printf "a\nc\n") > > However, this syntax does not produce usef

Re: [PATCH] diff: add support for reading files literally with --no-index

2019-01-03 Thread brian m. carlson
On Wed, Jan 02, 2019 at 10:56:45AM -0800, Junio C Hamano wrote: > This is good as a goal, but the implementation seems to be overly > eager to dereference any symlink or non-regular file found in any > level of recursion. The use case presented as the justification in > the proposed log message, a

git clone on page 44 of progit-en.1084.pdf (2nd try)

2019-01-03 Thread Charles Kerr
Hello- I am an easily-derailed newbie reading chapter 2 of progit-en.1084.pdf (1) On page 44 of my copy, where it first discusses git clone, there's reference to a "linkable library". How does this relate to "repository". I thought the aim here was to get a clone of a remote repository (2)

Re: [PATCH v2 0/2] Accept error packets in any context

2019-01-03 Thread Masaya Suzuki
On Thu, Jan 3, 2019 at 3:05 PM Junio C Hamano wrote: > > Masaya Suzuki writes: > > > This makes it possible for servers to send an error message back to clients > > in > > an arbitrary situation. > > > > The first patch was originally sent in [1]. This version includes some fix. > > > > The seco

Re: [PATCH 3/3] t0006-date.sh: add `human` date format tests.

2019-01-03 Thread Stephen P. Smith
On Thursday, January 3, 2019 2:45:39 PM MST Junio C Hamano wrote: > Philip Oakley writes: > >> > >>check_human_date 432000 "$THIS_YEAR_REGEX" # 5 days ago > > > > Just a quick bikeshed: if used, would this have a year end 5 day > > roll-over error potential, or will it always use the single

Re: [PATCH v12 00/26] Convert "git stash" to C builtin

2019-01-03 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > This is a new iteration of git-stash which also takes > sd/stash-wo-user-name into account. I cherry-picked > some of dscho's commits (from [1]) to keep the scripted > version of `git stash` as `git-legacy-stash`. I took a brief look and left a comment on 04/26

Re: [PATCH v2 0/2] Accept error packets in any context

2019-01-03 Thread Junio C Hamano
Masaya Suzuki writes: > This makes it possible for servers to send an error message back to clients in > an arbitrary situation. > > The first patch was originally sent in [1]. This version includes some fix. > > The second patch was originally sent in [2]. Later, this was cherry-picked in > [3].

Re: [Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

2019-01-03 Thread Junio C Hamano
"Randall S. Becker" writes: > On January 3, 2019 16:41, Eric Sunshine wrote: >> On Thu, Jan 3, 2019 at 4:04 PM wrote: >> > The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without >> > using the FLOSS package supplied by HPE. The convenient location for >> > including the relevant hea

Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread Junio C Hamano
"Randall S. Becker" writes: > On January 3, 2019 16:38, Eric Sunshine wrote: >> On Thu, Jan 3, 2019 at 4:04 PM wrote: >> > A number of configuration options are not automatically detected by >> > configure mechanisms, including the location of Perl and Python. >> > >> > There was a problem at a

RE: [Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

2019-01-03 Thread Randall S. Becker
On January 3, 2019 16:41, Eric Sunshine wrote: > On Thu, Jan 3, 2019 at 4:04 PM wrote: > > The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without > > using the FLOSS package supplied by HPE. The convenient location for > > including the relevant headers is in this file. > > > > The NS

Re: Regression `git checkout $rev -b branch` while in a `--no-checkout` clone does not check out files

2019-01-03 Thread Anthony Sottile
On Thu, Jan 3, 2019 at 1:51 PM Junio C Hamano wrote: > > Anthony Sottile writes: > > > On Thu, Jan 3, 2019 at 12:26 PM Junio C Hamano wrote: > >> A "fix" to Ben's optimization for this particular case should be > >> fairly straight-forward. I think we have a special case in the > >> checkout co

RE: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread Randall S. Becker
On January 3, 2019 16:38, Eric Sunshine wrote: > On Thu, Jan 3, 2019 at 4:04 PM wrote: > > A number of configuration options are not automatically detected by > > configure mechanisms, including the location of Perl and Python. > > > > There was a problem at a specific set of operating system vers

Re: Regression `git checkout $rev -b branch` while in a `--no-checkout` clone does not check out files

2019-01-03 Thread Junio C Hamano
Anthony Sottile writes: > On Thu, Jan 3, 2019 at 12:26 PM Junio C Hamano wrote: >> A "fix" to Ben's optimization for this particular case should be >> fairly straight-forward. I think we have a special case in the >> checkout codepath for an initial checkout and disable "carry forward >> the fa

Re: [PATCH 3/3] t0006-date.sh: add `human` date format tests.

2019-01-03 Thread Junio C Hamano
Philip Oakley writes: > On 02/01/2019 18:15, Junio C Hamano wrote: >> We perhaps can use "test-tool date timestamp", like so >> >> check_human_date $(test-tool date timestamp "18000 seconds ago") ... >> >> or moving the part that munges 18000 into the above form inside >> check_human_date he

Re: [Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

2019-01-03 Thread Eric Sunshine
On Thu, Jan 3, 2019 at 4:04 PM wrote: > The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without > using the FLOSS package supplied by HPE. The convenient location > for including the relevant headers is in this file. > > The NSIG define is also not defined on __TANDEM, so we define it

Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread Eric Sunshine
On Thu, Jan 3, 2019 at 4:04 PM wrote: > A number of configuration options are not automatically detected by > configure mechanisms, including the location of Perl and Python. > > There was a problem at a specific set of operating system versions > that caused getopt to have compile errors. Account

Re: [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread Junio C Hamano
writes: > I will reissue the whole package for you. I think I hacked it badly. Will > get to it after $DAYJOB is done. Thanks.

Re: [PATCH 3/3] t0006-date.sh: add `human` date format tests.

2019-01-03 Thread Philip Oakley
On 02/01/2019 18:15, Junio C Hamano wrote: We perhaps can use "test-tool date timestamp", like so check_human_date $(test-tool date timestamp "18000 seconds ago") ... or moving the part that munges 18000 into the above form inside check_human_date helper function, e.g. check_hu

[Patch v5 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop

2019-01-03 Thread randall . s . becker
From: "Randall S. Becker" The system definition header files on HPE NonStop do not define intptr_t and uintptr_t as do other platforms. These typedefs are added specifically wrapped in a __TANDEM ifdef. Signed-off-by: Randall S. Becker --- compat/regex/regcomp.c | 8 1 file changed, 8

[Patch v5 0/4] HPE NonStop Port Commits

2019-01-03 Thread randall . s . becker
From: "Randall S. Becker" This set of patches is a distilled version of the minimal set of changes to git that will allow it to run as client and server on HPE NonStop NSE and NSX systems. NSR systems are no longer under support so references to them have been removed. Each patch in this set is i

[Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread randall . s . becker
From: "Randall S. Becker" A number of configuration options are not automatically detected by configure mechanisms, including the location of Perl and Python. There was a problem at a specific set of operating system versions that caused getopt to have compile errors. Account for this by providi

[Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

2019-01-03 Thread randall . s . becker
From: "Randall S. Becker" The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without using the FLOSS package supplied by HPE. The convenient location for including the relevant headers is in this file. The NSIG define is also not defined on __TANDEM, so we define it here as 100 if it is

[Patch v5 1/4] transport-helper: use xread instead of read

2019-01-03 Thread randall . s . becker
From: "Randall S. Becker" This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c was the only place outside of wrapper.c where it is used instead of xread. Signed-off-by: Randall S. Becker --- transport

git add --intent-to-add + git stash "Cannot save the current worktree state"

2019-01-03 Thread Anthony Sottile
Minimal reproduction ``` git init t git -C t commit --allow-empty -m 'initial commit' touch t/a git -C t add --intent-to-add a git -C t stash ``` ``` + git init t Initialized empty Git repository in /private/tmp/t/t/.git/ + git -C t commit --allow-empty -m 'initial commit' [master (root-commit) 8

Re: Regression `git checkout $rev -b branch` while in a `--no-checkout` clone does not check out files

2019-01-03 Thread Anthony Sottile
On Thu, Jan 3, 2019 at 12:26 PM Junio C Hamano wrote: > A "fix" to Ben's optimization for this particular case should be > fairly straight-forward. I think we have a special case in the > checkout codepath for an initial checkout and disable "carry forward > the fact that the user wanted all the

Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-03 Thread Junio C Hamano
SZEDER Gábor writes: > One of our test scripts, 't1510-repo-setup.sh' [1], still can't be > reliably run with '-x' tracing enabled, unless it's executed with a > Bash version supporting BASH_XTRACEFD (since v4.1). We have a lengthy > condition to check the version of the shell running the test s

Re: Regression `git checkout $rev -b branch` while in a `--no-checkout` clone does not check out files

2019-01-03 Thread Junio C Hamano
Duy Nguyen writes: > I plan to revert this commit anyway when the new command "git > switch-branch" comes. The optimization will be unconditionally in the > new command without this hack and users are encouraged to use that one > instead of "git checkout". I tend to think that the behaviour is p

RE: [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread randall.s.becker
On January 3, 2019 14:45, Junio C Hamano wrote: > To: randall.s.bec...@rogers.com > Cc: git@vger.kernel.org; Randall S. Becker > Subject: Re: [PATCH v4 2/4] config.mak.uname: support for modern HPE > NonStop config. > > randall.s.bec...@rogers.com writes: > > > @@ -470,8 +489,13 @@ ifeq ($(uname

Re: [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.

2019-01-03 Thread Junio C Hamano
randall.s.bec...@rogers.com writes: > @@ -470,8 +489,13 @@ ifeq ($(uname_S),NONSTOP_KERNEL) > NO_MKDTEMP = YesPlease > # Currently libiconv-1.9.1. > OLD_ICONV = UnfortunatelyYes > - NO_REGEX = YesPlease > + NO_REGEX=NeedsStartEnd > NO_PTHREADS = UnfortunatelyYes > >

Re: [PATCH v4 1/4] transport-helper: use xread instead of read

2019-01-03 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 02, 2019 at 12:55:51PM -0800, Junio C Hamano wrote: > >> > Signed-off-by: Randall S. Becker >> > --- >> > transport-helper.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/transport-helper.c b/transport-helper.c >> > index bf225

Re: [PATCH v2 1/2] Change how HTTP response body is returned

2019-01-03 Thread Junio C Hamano
Masaya Suzuki writes: > Subject: Re: [PATCH v2 1/2] Change how HTTP response body is returned Perhaps: Subject: http: change the way response body is returned but if we can state why we want to do so concisely, that would be even better. > This changes the way HTTP response body is return

Re: [PATCH] config.mak.dev: add -Wformat

2019-01-03 Thread Jonathan Nieder
Hi, Junio C Hamano wrote: > I think it is a good idea to give fallback/redundancy for this > case. I do not have strong opinion between -Wall and -Wformat, > but I'd probably vote for the former if pressed. > > -- >8 -- > From: Thomas Gummerer > Date: Fri, 12 Oct 2018 19:40:37 +0100 > Subject:

Re: [PATCH v3] Simplify handling of setup_git_directory_gently() failure cases.

2019-01-03 Thread Junio C Hamano
>Subject: Re: [PATCH v3] Simplify handling of setup_git_directory_gently() >failure cases. Perhaps Subject: setup: simplify setup_git_directory_gently() failure cases to clarify which part of the entire world this patch is touching. Jeff King writes: > This patch isn't _too_ big, s

Re: [PATCH v2 3/4] t3502: validate '-m 1' argument is now accepted for non-merge commits

2019-01-03 Thread SZEDER Gábor
On Fri, Dec 14, 2018 at 07:53:51AM +0300, Sergey Organov wrote: > Signed-off-by: Sergey Organov > --- > t/t3502-cherry-pick-merge.sh | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/t/t3502-cherry-pick-merge.sh b/t/t3502-cherry-pick-merge.sh > index b160271..

Re: [PATCH] config.mak.dev: add -Wformat

2019-01-03 Thread Junio C Hamano
Jonathan Nieder writes: > In October, Thomas Gummerer wrote: >> On 10/12, Jonathan Nieder wrote: >>> Jeff King wrote: >>> ... -Wformat is part of -Wall, which we already turn on by default (even for non-developer builds). > ... > As discussed in [1], autoconf appears to not put -Wall in

Re: [PATCH 5/5] travis-ci: build with the right compiler

2019-01-03 Thread Johannes Schindelin
Hi Gábor, On Thu, 20 Dec 2018, SZEDER Gábor wrote: > Our 'Makefile' hardcodes the compiler to build Git as 'CC = cc'. This ... This CC variable ... > can be overridden from the command line, i.e. 'make CC=gcc-X.Y' will > build with that particular GCC version, but not from the environment, > i

RE: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2019-01-03 Thread Strain, Roger L.
> -Original Message- > From: Johannes Schindelin > > Hi Roger, > > > On Wed, 2 Jan 2019, Strain, Roger L. wrote: > > > TL;DR: Current script uses git rev-list to retrieve all commits which > > are reachable from HEAD but not from . Is there a syntax that > > will instead return all com

RE: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2019-01-03 Thread Johannes Schindelin
Hi Roger, On Wed, 2 Jan 2019, Strain, Roger L. wrote: > TL;DR: Current script uses git rev-list to retrieve all commits which > are reachable from HEAD but not from . Is there a syntax that > will instead return all commits reachable from HEAD, but stop traversing > when is encountered? It's a

Re: What's cooking in git.git (Dec 2018, #02; Fri, 28)

2019-01-03 Thread Johannes Schindelin
Hi Elijah, On Fri, 28 Dec 2018, Elijah Newren wrote: > On Fri, Dec 28, 2018 at 10:04 AM Junio C Hamano wrote: > > > * en/rebase-merge-on-sequencer (2018-11-08) 2 commits > > - rebase: implement --merge via git-rebase--interactive > > - git-rebase, sequencer: extend --quiet option for the inte

ps/stash-in-c, was Re: What's cooking in git.git (Dec 2018, #02; Fri, 28)

2019-01-03 Thread Johannes Schindelin
Hi Junio, On Fri, 28 Dec 2018, Junio C Hamano wrote: > * ps/stash-in-c (2018-11-26) 22 commits > . stash: replace all `write-tree` child processes with API calls > . stash: optimize `get_untracked_files()` and `check_changes()` > . stash: convert `stash--helper.c` into `stash.c` > . stash: co

Re: [PATCH 3/3] t0006-date.sh: add `human` date format tests.

2019-01-03 Thread Stephen P. Smith
On Wednesday, January 2, 2019 11:42:20 PM MST Junio C Hamano wrote: > > Are you suggesting that t4202-log.sh not be updated and that only and > > t7007- show.sh and t0006-date.sh updated? > > I am saying that using "log -1" and "show" in different tests _only_ > for the value of "Date:" field doe

Re: [PATCH 1/3] Add 'human' date format

2019-01-03 Thread Stephen P. Smith
On Thursday, January 3, 2019 12:37:35 AM MST Jeff King wrote: > I like the idea of "human", and I like the idea of "auto", but it seems > to me that these are really two orthogonal things. E.g., might some > people not want to do something like: > > git config log.date auto:relative I didn't see

Re: [PATCH 3/3] t0006-date.sh: add `human` date format tests.

2019-01-03 Thread Stephen & Linda Smith
On Thursday, January 3, 2019 12:44:22 AM MST Jeff King wrote: > We already have $TEST_DATE_NOW, which "test-tool date" will respect for > various commands to pretend that it's currently a particular time. I > think you'd need to add a sub-command similar to "relative" (which > directly calls show_d

[PATCH v2] test-lib: check Bash version for '-x' without using shell arrays

2019-01-03 Thread SZEDER Gábor
One of our test scripts, 't1510-repo-setup.sh' [1], still can't be reliably run with '-x' tracing enabled, unless it's executed with a Bash version supporting BASH_XTRACEFD (since v4.1). We have a lengthy condition to check the version of the shell running the test script, and disable tracing if i

Re: [PATCH] test-lib: check Bash version for '-x' without using shell arrays

2019-01-03 Thread SZEDER Gábor
On Wed, Jan 02, 2019 at 12:19:49AM +0100, SZEDER Gábor wrote: > To my understanding both shells are right and conform to POSIX, > because the standard allows both behavior by stating the following > under '2.8.1 Consequences of Shell Errors': > > "An expansion error is one that occurs when the s

Re: Regression `git checkout $rev -b branch` while in a `--no-checkout` clone does not check out files

2019-01-03 Thread Duy Nguyen
On Wed, Jan 2, 2019 at 11:18 PM Anthony Sottile wrote: > heated a small room but here's the results of the bisect! > > fa655d8411cc2d7ffcf898e53a1493c737d7de68 is the first bad commit > commit fa655d8411cc2d7ffcf898e53a1493c737d7de68 > Author: Ben Peart > Date: Thu Aug 16 18:27:11 2018 + >

Suspicious fetch-pack behaviour

2019-01-03 Thread Guilhem Bonnefille
Hi, One of my users reported a strange problem: a simple HTTPS clone did not work with Git 1.8.3.1 on RedHat 7. I did many tests and I was not able to understand why his clone don't work while I'm able to do it on other similar host. Nevertheless, we did more investigations. One of them: a raw st

Re: [PATCH v4 1/3] ref-filter: add worktreepath atom

2019-01-03 Thread Eric Sunshine
On Thu, Jan 3, 2019 at 12:40 AM Jeff King wrote: > On Mon, Dec 24, 2018 at 12:47:54AM -0800, nbelakov...@gmail.com wrote: > > +test_expect_success 'validate worktree atom' ' > > + { > > + echo master: $PWD && > > + echo master_worktree: $PWD/worktree_dir && > > + echo side: not che

Re: git-send-email warnings & process dying of signal 11

2019-01-03 Thread Rafał Miłecki
On 2019-01-01 23:45, Rafał Miłecki wrote: Hello & Happy New Year! I've recently switched from openSUSE 42.3 (perl 5.18.2 & git 2.13.7) to the openSUSE Tumbleweed (perl 5.28.1 & git 2.20.1) and send-email doesn't work for me anymore. FWIW it doesn't seem like a git regression. I've manually inst