[PATCH] doc: remove unneeded TODO for release_commit_memory

2018-12-31 Thread Albert Burt
The code that was merged with commit 1102405 left in an TODO that is no longer relevant. It seems as if we can remove this todo. util seems to not be a field of the struct commit, definition of struct commit --> commit.c:27 The commit list also, does not contain a field for util. By making a

[PATCH] log: add %S option (like --source) to log --format

2018-12-31 Thread issac . trotts
From: Issac Trotts Make it possible to write for example git log --format="%H,%S" where the %S at the end is a new placeholder that prints out the ref (tag/branch) for each commit. Using %d might seem like an alternative but it only shows the ref for the last commit in the branch. Sig

Unusual library path on OS X

2018-12-31 Thread Jeffrey Walton
Hi Everyone, I'm building Git 1.20.1 from sources on OS X. Git (and its dependents) were configured with: PKGCONFPATH: /usr/local/lib/pkgconfig CPPFLAGS: -I/usr/local/include -DNDEBUG CFLAGS: -g2 -O2 -march=native -fPIC CXXFLAGS: -g2 -O2 -march=native -fPIC LDFLAG

Re: [PATCH v3 6/8] test-lib: extract Bash version check for '-x' tracing

2018-12-31 Thread Carlo Arenas
slightly offtopic and definitely not meant to be relevant as a critic on this specific change which I found otherwise fine, but just a heads up that this test itself is bash specific (since it uses arrays, against the recommendation in Documentation/CodingGuidelines) and therefore breaks, at least

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Marc Balmer
> Am 31.12.2018 um 12:36 schrieb Duy Nguyen : > > On Mon, Dec 31, 2018 at 6:24 PM Marc Balmer wrote: >> In a (private) Email to me, he indicated that had no time for a fix. Maybe >> he can speak up here? > > Well, I guess Junio will revert when he's back after the holidays > then. Meanwhile

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Duy Nguyen
On Mon, Dec 31, 2018 at 6:24 PM Marc Balmer wrote: > In a (private) Email to me, he indicated that had no time for a fix. Maybe > he can speak up here? Well, I guess Junio will revert when he's back after the holidays then. Meanwhile.. > In any case, if I can help testing, I am in. I just don

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Marc Balmer
> Am 31.12.2018 um 12:20 schrieb Duy Nguyen : > > On Mon, Dec 31, 2018 at 6:13 PM Marc Balmer wrote: >> >> >> >>> Am 31.12.2018 um 11:51 schrieb Duy Nguyen : >>> >>> On Mon, Dec 31, 2018 at 5:44 PM Marc Balmer wrote: Hi One of the last three commits in git-subtree.sh

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Duy Nguyen
On Mon, Dec 31, 2018 at 6:13 PM Marc Balmer wrote: > > > > > Am 31.12.2018 um 11:51 schrieb Duy Nguyen : > > > > On Mon, Dec 31, 2018 at 5:44 PM Marc Balmer wrote: > >> > >> Hi > >> > >> One of the last three commits in git-subtree.sh introduced a regression > >> leading to a segfault. > >> > >>

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Marc Balmer
> Am 31.12.2018 um 11:51 schrieb Duy Nguyen : > > On Mon, Dec 31, 2018 at 5:44 PM Marc Balmer wrote: >> >> Hi >> >> One of the last three commits in git-subtree.sh introduced a regression >> leading to a segfault. >> >> Here is the error message when I try to split out my i18n files: >> >

Re: Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Duy Nguyen
On Mon, Dec 31, 2018 at 5:44 PM Marc Balmer wrote: > > Hi > > One of the last three commits in git-subtree.sh introduced a regression > leading to a segfault. > > Here is the error message when I try to split out my i18n files: > > $ git subtree split --prefix=i18n > cache for e39a2a0c6431773a5d8

Regression in git-subtree.sh, introduced in 2.20.1, after 315a84f9aa0e2e629b0680068646b0032518ebed

2018-12-31 Thread Marc Balmer
Hi One of the last three commits in git-subtree.sh introduced a regression leading to a segfault. Here is the error message when I try to split out my i18n files: $ git subtree split --prefix=i18n cache for e39a2a0c6431773a5d831eb3cb7f1cd40d0da623 already exists! (Lots of output omitted) 436