Re: [PATCH] upload-pack: reject shallow requests that would return nothing

2018-05-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > To avoid this, if rev-list returns nothing, we abort the clone/fetch. > The user could adjust their request (e.g. --shallow-since further back > in the past) and retry. Yeah, that makes sense. > Another possible option for this case is to fall back to a default >

Re: js/empty-config-section-fix, was Re: What's cooking in git.git (May 2018, #03; Wed, 23)

2018-05-27 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Thu, 24 May 2018, Junio C Hamano wrote: > >> * js/empty-config-section-fix (2018-05-18) 1 commit >> - config: a user-provided invalid section is not a BUG >> >> Error codepath fix. >> >> Will merge to 'next'. > > As a hotfix, maybe we can fast-t

Re: What's cooking in git.git (May 2018, #03; Wed, 23)

2018-05-27 Thread Junio C Hamano
Elijah Newren writes: > On Wed, May 23, 2018 at 5:02 PM, Junio C Hamano wrote: >> Here are the topics that have been cooking. Commits prefixed with >> '-' are only in 'pu' (proposed updates) while commits prefixed with >> '+' are in 'next'. The ones marked with '.' do not appear in any of >> t

Re: [GSoC] GSoC with git, week 4

2018-05-27 Thread Christian Couder
Hi Alban, On Sat, May 26, 2018 at 6:32 PM, Alban Gruin wrote: > > I published my blog post about this week. You can read it here: > > https://blog.pa1ch.fr/posts/2018/05/26/en/gsoc2018-week-4.html > > All comments are welcome! Thanks for publishing a nice update! Christian.

Re: [PATCH 2/1] SubmittingPatches: not git-secur...@googlegroups.com

2018-05-27 Thread Junio C Hamano
Thomas Gummerer writes: > Yeah sorry, that's what I meant. > https://public-inbox.org/git/20180308150820.22588-1-ava...@gmail.com/ > is the reference I meant to put there. > > How about something like the below? This is tested with asciidoc > 8.6.10 and asciidoctor 1.5.6.2. I'm also happy to sq

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Junio C Hamano
Phillip Wood writes: > I tried your recipe and got the same result as you. However I think it > could be a problem with 'git status' rather than 'git rebase > --exec'. If I run your recipe in /tmp/a and do > > cd dir > GIT_DIR=/tmp/a/.git git status > > I get the same result as when running 'git

Re: [PATCH] packfile: Correct zlib buffer handling

2018-05-27 Thread Junio C Hamano
Junio C Hamano writes: > Duy Nguyen writes: > >> On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: >>> Duy Nguyen writes: >>> On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton wrote: > @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct > packed_git *p, >>

Re: [PATCH v3 06/20] commit-graph: add 'verify' subcommand

2018-05-27 Thread Jakub Narebski
Derrick Stolee writes: > If the commit-graph file becomes corrupt, we need a way to verify > that its contents match the object database. In the manner of > 'git fsck' we will implement a 'git commit-graph verify' subcommand > to report all issues with the file. > > Add the 'verify' subcommand to

Proposal

2018-05-27 Thread Miss Zeliha Omer Faruk
-- Hello I have been trying to contact you. Did you get my business proposal? Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turke

[PATCH 2/1] SubmittingPatches: not git-secur...@googlegroups.com

2018-05-27 Thread Thomas Gummerer
On 05/27, Jonathan Nieder wrote: > Thomas Gummerer wrote: > > > Add a mention of the security mailing list to the README. > > 2caa7b8d27 ("git manpage: note git-secur...@googlegroups.com", > > 2018-03-08) already added it to the man page, but I suspect that for > > many developers, such as myself,

Re: [PATCH v3 05/20] commit-graph: load a root tree from specific graph

2018-05-27 Thread Jakub Narebski
Derrick Stolee writes: > When lazy-loading a tree for a commit, it will be important to select > the tree from a specific struct commit_graph. Create a new method that > specifies the commit-graph file and use that in > get_commit_tree_in_graph(). Is this for the same reason why parse_commit_in_

[PATCH v2 12/11] completion: complete general config vars in two steps

2018-05-27 Thread Nguyễn Thái Ngọc Duy
There are 581 config variables as of now when you do "git config " which can fill up a few screens and is not very helpful when you have to look through columns of text to find what you want. This patch instead shows you only first level when you do git config There are 78 items, which use

Re: [PATCH v3 04/20] commit: force commit to parse from object database

2018-05-27 Thread Jakub Narebski
Derrick Stolee writes: > In anticipation of verifying commit-graph file contents against the > object database, create parse_commit_internal() to allow side-stepping > the commit-graph file and parse directly from the object database. > > Due to the use of generation numbers, this method should n

Re: Weird revision walk behaviour

2018-05-27 Thread Kevin Bracey
On 24/05/2018 23:26, Kevin Bracey wrote: On Wed, May 23, 2018 at 07:10:58PM +0200, SZEDER Gábor wrote:    $ git log --oneline master..ba95710a3b -- ci/    ea44c0a594 Merge branch 'bw/protocol-v2' into jt/partial-clone-proto-v2 In this case, we're hitting a merge commit which is not on mast

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Philip Oakley
Hi Ondrej, Phillip, From: "Phillip Wood" Hi Ondrej On 27/05/18 13:53, Ondrej Mosnáček wrote: Hi Philip, 2018-05-27 14:28 GMT+02:00 Philip Oakley : You may need to give a bit more background of things that seem obvious to you. So where is the src directory you are cd'ing to relative to the

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Philip Oakley
Hi Ondrej, Phillip, From: "Phillip Wood" Hi Ondrej On 27/05/18 13:53, Ondrej Mosnáček wrote: Hi Philip, 2018-05-27 14:28 GMT+02:00 Philip Oakley : You may need to give a bit more background of things that seem obvious to you. So where is the src directory you are cd'ing to relative to the

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Phillip Wood
Hi Ondrej On 27/05/18 13:53, Ondrej Mosnáček wrote: Hi Philip, 2018-05-27 14:28 GMT+02:00 Philip Oakley : You may need to give a bit more background of things that seem obvious to you. So where is the src directory you are cd'ing to relative to the directory/repository you are creating? It

Re: [PATCH] README: note git-secur...@googlegroups.com

2018-05-27 Thread Jonathan Nieder
Thomas Gummerer wrote: > Add a mention of the security mailing list to the README. > 2caa7b8d27 ("git manpage: note git-secur...@googlegroups.com", > 2018-03-08) already added it to the man page, but I suspect that for > many developers, such as myself, the README would be the first place > to go

[PATCH] README: note git-secur...@googlegroups.com

2018-05-27 Thread Thomas Gummerer
Add a mention of the security mailing list to the README. 2caa7b8d27 ("git manpage: note git-secur...@googlegroups.com", 2018-03-08) already added it to the man page, but I suspect that for many developers, such as myself, the README would be the first place to go looking for it. Use the same word

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Ondrej Mosnáček
Hi Philip, 2018-05-27 14:28 GMT+02:00 Philip Oakley : > You may need to give a bit more background of things that seem obvious to > you. > So where is the src directory you are cd'ing to relative to the > directory/repository you are creating? It is located in the top-level directory of the worki

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Philip Oakley
You may need to give a bit more background of things that seem obvious to you. So where is the src directory you are cd'ing to relative to the directory/repository you are creating? What is [the name of] the directory you are currently in, etc. ? Philip -- From: "Ondrej Mosnáček" Bump? Has an

Re: [PATCH] packfile: Correct zlib buffer handling

2018-05-27 Thread Junio C Hamano
Duy Nguyen writes: > On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton >>> wrote: @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct packed_git *p, return NULL; >>>

Re: git rebase -i --exec and changing directory

2018-05-27 Thread Ondrej Mosnáček
Bump? Has anyone had time to look at this? Thanks, Ondrej Mosnacek 2018-05-19 18:38 GMT+02:00 Ondrej Mosnáček : > Hello, > > I am trying to run a script to edit multiple commits using 'git rebase > -i --exec ...' and I ran into a strange behavior when I run 'cd' > inside the --exec command and s

Re: [PATCH v3 03/20] commit-graph: parse commit from chosen graph

2018-05-27 Thread Jakub Narebski
Derrick Stolee writes: > Before verifying a commit-graph file against the object database, we > need to parse all commits from the given commit-graph file. Create > parse_commit_in_graph_one() to target a given struct commit_graph. If I understand it properly the problem is that when verifying a

Re: why do "git log -h" and "git show -h" print the same thing?

2018-05-27 Thread Thomas Gummerer
On 05/24, Stefan Beller wrote: > On Thu, May 24, 2018 at 6:37 AM, Robert P. J. Day > wrote: > > > > maybe this is deliberate, but it's confusing that, with git 2.17.0, > > the output of both "git log -h" and "git show -h" is exactly the same: > > > > $ git log -h > > usage: git log [] [] [[--]

[PATCH v2 2/3] completion: suppress some -no- options

2018-05-27 Thread Nguyễn Thái Ngọc Duy
Most --no- options do have some use, even if rarely to negate some option that's specified in an alias. These options --no-ours and --no-theirs however have no clear semantics. If I specify "--ours --no-theirs", the second will reset writeout stage and is equivalent of "--no-ours --no-theirs" whic

[PATCH v2 0/3] completion: complete all possible -no-

2018-05-27 Thread Nguyễn Thái Ngọc Duy
The RFC was here [1]. We have started recently to rely on parse-options to help complete options. One of the leftover items is allowing completing --no- form. This series enables that. Changes since the RFC version: - There's no magic numbers (previously we keep 3 --no- options) - When there are

[PATCH v2 1/3] parse-options: option to let --git-completion-helper show negative form

2018-05-27 Thread Nguyễn Thái Ngọc Duy
When 7fb6aefd2a (Merge branch 'nd/parseopt-completion' - 2018-03-14) is merged, the completion for negative form is left out because the series is alread long and it could be done in a follow up series. This is it. --git-completion-helper now provides --no-xxx so that git-completion.bash can drop

[PATCH v2 3/3] completion: collapse extra --no-.. options

2018-05-27 Thread Nguyễn Thái Ngọc Duy
The commands that make use of --git-completion-helper feature could now produce a lot of --no-xxx options that a command can take. This in many case could nearly double the amount of completable options, using more screen estate and also harder to search for the wanted option. This patch attempts

Re: [PATCH v2 04/11] help: add --config to list all available config

2018-05-27 Thread Eric Sunshine
On Sat, May 26, 2018 at 9:55 AM, Nguyễn Thái Ngọc Duy wrote: > Sometimes it helps to list all available config vars so the user can > search for something they want. The config man page can also be used > but it's harder to search if you want to focus on the variable name, > for example. > > This

Re: [PATCH v2 1/4] diff: ignore --ita-[in]visible-in-index when diffing worktree-to-tree

2018-05-27 Thread Eric Sunshine
On Sat, May 26, 2018 at 8:08 AM, Nguyễn Thái Ngọc Duy wrote: > This option is supposed to fix the diff of "diff-files" (not reporting > ita entries as new files) and "diff-index --cached " ( showing s/(\s/(/ > ita entries as present in the index with empty content) but not > "diff-index ". > > W