These calls make it possible to have the make command or the
make options in a config file, instead of in environment
variables.
Signed-off-by: Christian Couder
---
t/perf/run | 3 +++
1 file changed, 3 insertions(+)
diff --git a/t/perf/run b/t/perf/run
index ad442fe64a..6bd15e7017 100755
--- a
This environment variable can be set to some revisions or
directories whose Git versions should be tested, in addition
to the revisions or directories passed as arguments to the
'run' script.
This enables a "perf.dirsOrRevs" configuration variable to
be used to set revisions or directories whose G
It is error prone and tiring to use many long environment
variables to give parameters to the 'run' script.
Let's make it easy to store some parameters in a config
file and to pass them to the run script.
The GIT_PERF_CONFIG_FILE variable will be set to the
argument of the '--config' option. This
Add get_var_from_env_or_config() to easily set variables
from a config file if they are defined there and not already set.
This can also set them to a default value if one is provided.
As an example, use this function to set GIT_PERF_REPEAT_COUNT
from the perf.repeatCount config option or from th
Goal
Using many long environment variables to give parameters to the 'run'
script is error prone and tiring.
We want to make it possible to store the parameters to the 'run'
script in a config file. This will make it easier to store, reuse,
share and compare parameters.
In the future it cou
On Thu, Jul 13, 2017 at 12:21 AM, Paolo Bonzini wrote:
> diff --git a/trailer.h b/trailer.h
> index e90ba1270..f306bf059 100644
> --- a/trailer.h
> +++ b/trailer.h
> @@ -1,11 +1,33 @@
> #ifndef TRAILER_H
> #define TRAILER_H
>
> +enum action_where {
> + WHERE_END,
> + WHERE_AFTER,
>
On Wed, Jul 12, 2017 at 5:53 PM, Junio C Hamano wrote:
> Jonathan Nieder writes:
>
>>> In the function push_submodule[1] we use add_submodule_odb[2] to determine
>>> if a submodule has been populated. However the function does not work with
>>> the submodules objects that are added, instead a new
Hello Dear,
How are you doing? I hope you are doing well. I am writing as I have written to
you previously without any response from you. I hope all is well with you.I
will appreciate if you will acknowledge your receipt of this mail.
Thank you and have a good day.
Miss Naya
Please Write Me a
On Wed, Jul 12, 2017 at 05:44:14PM -0700, Stefan Beller wrote:
> With this patch, commit.h doesn't contain the string 'sha1' any more.
From a relatively quick look, these look sane to me.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opini
Jonathan Nieder writes:
>> In the function push_submodule[1] we use add_submodule_odb[2] to determine
>> if a submodule has been populated. However the function does not work with
>> the submodules objects that are added, instead a new child process is used
>> to perform the actual push in the su
Signed-off-by: Stefan Beller
---
builtin/tag.c| 2 +-
builtin/verify-tag.c | 9 +
tag.c| 10 +-
tag.h| 2 +-
4 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 01154ea8dc..b25bf8daa2 10064
With this patch, commit.h doesn't contain the string 'sha1' any more.
Signed-off-by: Stefan Beller
---
Before diving into the "RFC object store" series further, I want to get
rid of the final sha1s in {commit,tag}.{c,h}.
commit.c | 6 +++---
commit.h | 2 +-
fsck.c| 2 +-
shallow.c | 4 +
We've been having scaling problems with insane number of references
(>866k), so I started thinking a lot about improving ref storage.
I've written a simple approach, and implemented it in JGit.
Performance is promising:
- 62M packed-refs compresses to 27M
- 42.3 usec lookup
You can read a re
On Wed, Jul 12, 2017 at 5:01 PM, Jonathan Nieder wrote:
> These footnotes don't answer the question that I really have: why did
> this use add_submodule_odb in the first place?
oh, I forgot to put that down: presumably add_submodule_odb was
used because it was available back then? Note the dates
Hi,
Stefan Beller wrote:
> In the function push_submodule[1] we use add_submodule_odb[2] to determine
> if a submodule has been populated. However the function does not work with
> the submodules objects that are added, instead a new child process is used
> to perform the actual push in the submo
Jeff King writes:
> I could see somebody arguing that format-patch should respect a project
> preference, since its primary purpose is to communicate your work to the
> rest of the project.
>
> But then you could make a similar argument for other diff options, too.
Yeah, and that opens a whole c
In the function push_submodule[1] we use add_submodule_odb[2] to determine
if a submodule has been populated. However the function does not work with
the submodules objects that are added, instead a new child process is used
to perform the actual push in the submodule.
Use is_submodule_populated[3
I usually try to stay as late as possible to finish all the
integration branches in order before pushing out the result; it is
more efficient to be able to batch things (for humans).
I however noticed that This often means we would have multiple build
jobs at Travis for branches and builds on Wi
On 13/07/2017 01:02, Junio C Hamano wrote:
> Paolo Bonzini writes:
>
>> From: Paolo Bonzini
>>
>> These options are useful to experiment with "git interpret-trailers"
>> without having to tinker with .gitconfig. It can also be useful in the
>> oddball case where you want a different placement f
On Wed, Jul 12, 2017 at 06:21:28PM -0400, roeder@mailnull.com wrote:
> In Git on macOS (git version 2.13.2 | brew install git) the status
> command will show folders as untracked even though they are committed
> and checked out from the repository. Does not reproduce on Windows and
> Ubuntu.
>
The latest maintenance release Git v2.13.3 is now available at
the usual places.
The tarballs are found at:
https://www.kernel.org/pub/software/scm/git/
The following public repositories all have a copy of the 'v2.13.3'
tag and the 'maint' branch that the tag points at:
url = https://kern
Paolo Bonzini writes:
> From: Paolo Bonzini
>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig. It can also be useful in the
> oddball case where you want a different placement for the trailer.
>
> Compared to "git -c", they are m
In Git on macOS (git version 2.13.2 | brew install git) the status command will
show folders as untracked even though they are committed and checked out from
the repository. Does not reproduce on Windows and Ubuntu.
Repro steps:
1. Download https://www.dropbox.com/s/0q5pbpqpckwzj7b/gitstatusrep
From: Paolo Bonzini
Allow using non-default values for trailers without having to set
them up in .gitconfig first. For example, if you have the following
configuration
trailer.signed-off-by.where = end
you may use "--where before" when a patch author forgets his
Signed-off-by and provides
From: Paolo Bonzini
Pass the command-line arguments as a pointer to a new struct. This
will be extended in the next patch to include more options.
Signed-off-by: Paolo Bonzini
---
v1->v2: constify
builtin/interpret-trailers.c | 13 ++---
trailer.c| 14
From: Paolo Bonzini
These options are useful to experiment with "git interpret-trailers"
without having to tinker with .gitconfig. It can also be useful in the
oddball case where you want a different placement for the trailer.
Compared to "git -c", they are more easily discoverable, and also ha
From: Paolo Bonzini
Separate the mechanical changes out of the next patch. The functions
are changed to take a pointer to enum, because struct conf_info is not
going to be public.
Set the default values explicitly in default_conf_info, since they are
not anymore close to default_conf_info and i
Am 12.07.2017 um 19:40 schrieb Stefan Beller:
Thanks for the feedback - it's been very, very useful to me!
> Yes, a local path implies --local in git-clone, which (a) uses hardlinks
> and (b) avoids some other protocol overhead.
I guess (a) is the most important one for repositories large enoug
On Wed, Jul 12, 2017 at 2:37 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> 2. collaboration.
>> When I want to review a patch from the mailing list,
>> I could (a) download the patch, apply locally, see the diff
>> formatted nicely according to diff.orderFile.
>
> If you are
Jonathan Nieder writes:
>
> All that said, I don't have a strong opinion on this. Both the 1-word
> approach (a pointer) and 24-word approach (embedding) are tolerable
> and there are reasons to prefer each.
I do not care too much about 24-word wastage. If this were not "a
pointer pretending t
Stefan Beller writes:
> 2. collaboration.
> When I want to review a patch from the mailing list,
> I could (a) download the patch, apply locally, see the diff
> formatted nicely according to diff.orderFile.
If you are not doing a review of a patch with complex changes that
benefits b
On 12/07/2017 23:10, Jonathan Tan wrote:
> When I would expect the last 2 commands to produce the same output. Maybe
> invoke set_where(where, NULL) when "unset" is true? And change set_where()
> accordingly. Same for the other two option parsing functions.
Sounds good, and I'll also add a test ca
Hi,
Junio C Hamano wrote:
> Brandon Williams writes:
>> Since it is a pointer then using a '#define' to replace 'the_index'
>> (which is not a pointer) would be a little more challenging.
>
> The above is merely realizing another downside that stems from the
> earlier design decision that the in
From: "Johannes Schindelin"
Hi all,
it has been a while since Windows XP support has been dropped from Git for
Windows (v2.10.0 was the last version to support it), mainly due to the
code changes inherited from Cygwin's code base, which discontinued
supporting Windows XP after version 2.5.2 (be
William Duclot writes:
>> - The original said "When you have resolved this problem", without
>>giving a guidance how to resolve, and without saying what the
>>problem is. The updated one says "conflict" to clarify the
>>"problem", and suggests "git add" as the tool to use after a
>>
On Wed, 12 Jul 2017 15:46:44 +0200
Paolo Bonzini wrote:
> -static void print_all(FILE *outfile, struct list_head *head, int trim_empty)
> +static void print_all(FILE *outfile, struct list_head *head,
> + struct trailer_opts *opts)
This can be "const struct trailer_opts *", I th
On Wed, 12 Jul 2017 15:46:45 +0200
Paolo Bonzini wrote:
> -static struct conf_info default_conf_info;
> +static struct conf_info default_conf_info = {
> + .where = WHERE_END,
> + .if_exists = EXISTS_ADD_IF_DIFFERENT_NEIGHBOR,
> + .if_missing = MISSING_ADD,
> +};
I'm not sure if Git i
On Wed, 12 Jul 2017 15:46:46 +0200
Paolo Bonzini wrote:
> +static int option_parse_where(const struct option *opt,
> + const char *arg, int unset)
> +{
> + enum action_where *where = opt->value;
> +
> + if (unset)
> + return 0;
> +
> + return set_
Jeff King writes:
> ... And I
> really think it's not "a little more work". Even if we decided to keep
> the same file and replace the PID in it with the daemonized one, I think
> that still isn't quite right. Because we don't do so atomically unless
> we take gc.pid.lock again.
Exactly.
Ævar Arnfjörð Bjarmason writes:
> On Tue, Jul 11 2017, Junio C. Hamano jotted:
>
>> Just so that people do not misunderstand, it is not our goal to
>> declare that now you need a fully C99 compiler to build Git.
>> ...
>
> I think in the context of this desire Johannes Sixt's "Actually, I'm
> ser
On Wed, Jul 12, 2017 at 1:57 PM, Jeff King wrote:
> On Wed, Jul 12, 2017 at 01:44:46PM -0700, Junio C Hamano wrote:
>
>> Stefan Beller writes:
>>
>> > I want to force myself to think about the design before pointing out
>> > memory leaks and coding style, so the least I would wish for is:
>>
On Wed, Jul 12 2017, Junio C. Hamano jotted:
> Stefan Beller writes:
>
>> I want to force myself to think about the design before pointing out
>> memory leaks and coding style, so the least I would wish for is:
>> *.h
>> *.c
>> but as we have more to look at, I would want to have t
On Wed, Jul 12, 2017 at 1:44 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
> Just set diff.orderFile to suit your taste without bothering other
> people, I would say.
I must have explained it very badly, I'll try again:
There are 2 different use cases to use diffs.
1. my personal use ca
On Wed, Jul 12, 2017 at 01:44:46PM -0700, Junio C Hamano wrote:
> Stefan Beller writes:
>
> > I want to force myself to think about the design before pointing out
> > memory leaks and coding style, so the least I would wish for is:
> > *.h
> > *.c
> > but as we have more to look at
Stefan Beller writes:
> I want to force myself to think about the design before pointing out
> memory leaks and coding style, so the least I would wish for is:
> *.h
> *.c
> but as we have more to look at, I would want to have the most abstract
> thing to come first. And most abst
On Wed, Jul 12, 2017 at 10:30:25PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > Is it really "in a row" that's a problem? The second fetch should not
> > begin until the first one is done, including until its auto-gc exits.
> > And even with background gc, we do the ref-locking operations first, due
Brandon Williams writes:
> For all intents and purposes the index struct that is stored in 'struct
> repository' is an embedded instance, its just stored as a pointer
> instead of being a direct part of the struct itself.
The question really is this. In order to realize the intents and
purposes
Hi,
Ben Peart wrote:
> On 7/11/2017 3:48 PM, Jonathan Tan wrote:
>> Teach sha1_file to invoke a hook whenever a blob is requested and
>> unavailable but is promised. The hook is a shell command that can be
>> configured through "git config"; this hook takes in a list of hashes and
>> writes (if s
On Wed, Jul 12 2017, Jeff King jotted:
> On Wed, Jul 12, 2017 at 09:38:46PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> In 131b8fcbfb ("fetch: run gc --auto after fetching", 2013-01-26) first
>> released with v1.8.2 Jeff changed git-fetch to run "git gc --auto"
>> afterwards.
>>
>> This means that
On Wed, Jul 12, 2017 at 09:38:46PM +0200, Ævar Arnfjörð Bjarmason wrote:
> In 131b8fcbfb ("fetch: run gc --auto after fetching", 2013-01-26) first
> released with v1.8.2 Jeff changed git-fetch to run "git gc --auto"
> afterwards.
>
> This means that if you run two git fetches in a row the second
Hi,
Jeff Hostetler wrote:
> My primary concern is scale and managing the list of objects over time.
[...]
> For
> example, on the Windows repo we have (conservatively) 100M+ blobs (and
> growing). Assuming 28 bytes per, gives a 2.8
On Tue, Jul 11 2017, Junio C. Hamano jotted:
> Ben Peart writes:
>
>>> If this patch can survive a few releases without complaint,
>>> then we can feel more confident that designated initializers
>>> are widely supported by our user base. It also is an
>>> indication that other C99 features may
On Tue, 20 Jun 2017 09:54:34 +0200
Christian Couder wrote:
> Git can store its objects only in the form of loose objects in
> separate files or packed objects in a pack file.
>
> To be able to better handle some kind of objects, for example big
> blobs, it would be nice if Git could store its ob
On 07/11, Stefan Beller wrote:
> On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote:
>
> > + if (repo_submodule_init(&submodule, superproject, path))
> > + return 0;
>
> What happens if we go through the "return 0", do we rather want to
> print an error ?
Should just in
On 07/11, Jacob Keller wrote:
> On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote:
> > Convert grep to use 'struct repository' which enables recursing into
> > submodules to be handled in-process.
> >
> > Signed-off-by: Brandon Williams
> > ---
> > Documentation/git-grep.txt | 7 -
> > b
On 07/11, Jonathan Nieder wrote:
> Hi,
>
> Brandon Williams wrote:
>
> > Convert grep to use 'struct repository' which enables recursing into
> > submodules to be handled in-process.
>
> \o/
>
> This will be even nicer with the changes described at
> https://public-inbox.org/git/20170706202739.
On Wed, Jul 12, 2017 at 11:24:47AM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
> > On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote:
>
> >> Each 'struct repository' does have its own config so we could
> >> potentially want a config in a submodule to override some config in t
On Wed, Jul 12, 2017 at 11:09:23AM -0700, Jonathan Nieder wrote:
> > I didn't follow the rest of the "struct repository" series closely, but
> > I don't feel like we ever reached a resolution on how config would be
> > handled. I notice that the in-process "ls-files" behaves differently
> > than t
Am 12.07.2017 um 03:26 schrieb brian m. carlson:
On Tue, Jul 11, 2017 at 07:24:07AM +0200, Johannes Sixt wrote:
I can revive the patches if there is interest.
I'd be interested in at least a pointer to them if you have one. I
think it might allow us to take advantage of desirable features tha
Jeff King wrote:
> On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote:
>> Each 'struct repository' does have its own config so we could
>> potentially want a config in a submodule to override some config in the
>> superproject. Though for right now it may be simpler to not worry abo
On Wed, Jul 12, 2017 at 11:06:03AM -0700, Brandon Williams wrote:
> > I didn't follow the rest of the "struct repository" series closely, but
> > I don't feel like we ever reached a resolution on how config would be
> > handled. I notice that the in-process "ls-files" behaves differently
> > than
On Wed, Jul 12, 2017 at 11:09 AM, Jonathan Nieder wrote:
> Hi,
>
> Jeff King wrote:
>
>> I didn't follow the rest of the "struct repository" series closely, but
>> I don't feel like we ever reached a resolution on how config would be
>> handled. I notice that the in-process "ls-files" behaves diff
Hi,
Jeff King wrote:
> I didn't follow the rest of the "struct repository" series closely, but
> I don't feel like we ever reached a resolution on how config would be
> handled. I notice that the in-process "ls-files" behaves differently
> than the old one when config differs between the submodul
On 07/12, Jeff King wrote:
> On Tue, Jul 11, 2017 at 03:04:05PM -0700, Brandon Williams wrote:
>
> > This series utilizes the new 'struct repository' in order to convert grep
> > to be
> > able to recurse into submodules in-process much like how ls-files was
> > converted
> > to recuse in-proces
On 07/11, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > Have the index state which is stored in 'the_repository' be a pointer to
> > the in-core instead 'the_index'. This makes it easier to begin
> > transitioning more parts of the code base to operate on a 'struct
> > repository'.
> >
Am 10.07.2017 um 04:10 schrieb Junio C Hamano:
Jeff King writes:
... And you could even drop origlen by
replacing it with "baselen - 3" at the end. But somehow doing the
computation on the fly actually seems more complicated to me (from the
perspective of a reader who is trying to make sure al
On Wed, Jul 12, 2017 at 3:47 AM, Joachim Durchholz wrote:
> Hi all,
>
> I'm pretty sure this is a FAQ, but articles I found on the Internet were
> either mere "recipes" (i.e. tell you how, but don't explain why), or bogged
> down in so many details that I was never sure how to proceed from there.
On 7/11/2017 3:48 PM, Jonathan Tan wrote:
Teach sha1_file to invoke a hook whenever a blob is requested and
unavailable but is promised. The hook is a shell command that can be
configured through "git config"; this hook takes in a list of hashes and
writes (if successful) the corresponding obje
On 07/11, Jonathan Nieder wrote:
> Hi,
>
> Brandon Williams wrote:
>
> > Have the index state which is stored in 'the_repository' be a pointer to
> > the in-core instead 'the_index'. This makes it easier to begin
> > transitioning more parts of the code base to operate on a 'struct
> > repositor
On 7/11/2017 3:48 PM, Jonathan Tan wrote:
Currently, Git does not support repos with very large numbers of blobs
or repos that wish to minimize manipulation of certain blobs (for
example, because they are very large) very well, even if the user
operates mostly on part of the repo, because Git i
On 07/11, Jonathan Nieder wrote:
> Brandon Williams wrote:
>
> > Have 'repo_read_index()' behave more like the other read_index family of
> > functions and don't discard the index if it has already been populated.
> >
> > Signed-off-by: Brandon Williams
> > ---
> > repository.c | 2 --
> > 1 fil
On 07/11, Stefan Beller wrote:
> On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams wrote:
> > Have 'repo_read_index()' behave more like the other read_index family of
> > functions and don't discard the index if it has already been populated.
>
> instead rely on the quick return of read_index_fro
Miguel Torroja writes:
> The motivation for setting skip_info default to True is because any
> extra message output by a p4 trigger to stdout, seems to be reported
> as {'code':'info'} when the p4 command output is marshalled.
>
> I though it was the less intrusive way to filter out the verbose
On Wed, Jul 12, 2017 at 09:46:25AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Instead, we can do something a bit simpler: take the lock
> > only for the duration of the pre-detach work, then detach,
> > then take it again for the post-detach work. Technically,
> > this means that the
Jeff King writes:
> Instead, we can do something a bit simpler: take the lock
> only for the duration of the pre-detach work, then detach,
> then take it again for the post-detach work. Technically,
> this means that the post-detach lock could lose to another
> process doing pre-detach work. But
Hi,
Here is my old mail with updated pointer. This may be useful for people
to migrate git to cvs while keeping cvs up-to-date.
On Wed, Jul 12, 2017 at 03:41:58PM +0200, Johannes Schindelin wrote:
> Hi,
>
> On Mon, 13 Jul 2015, Osamu Aoki wrote:
>
> > Thanks for "git cvsexportcommit -W" featur
On 12/07/2017 16:47, Christian Couder wrote:
> On Wed, Jul 12, 2017 at 3:46 PM, Paolo Bonzini wrote:
>>
>> These options are useful to experiment with "git interpret-trailers"
>> without having to tinker with .gitconfig. It can also be useful in the
>> oddball case where you want a different plac
On Wed, Jul 12, 2017 at 3:46 PM, Paolo Bonzini wrote:
>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig. It can also be useful in the
> oddball case where you want a different placement for the trailer.
>
> The case that stimulated
From: Paolo Bonzini
Separate the mechanical changes out of the next patch. The functions
are changed to take a pointer to enum, because struct conf_info is not
going to be public.
Write down the defaults explicitly in default_conf_info, since they are
not anymore close to default_conf_info and
From: Paolo Bonzini
These options are useful to experiment with "git interpret-trailers"
without having to tinker with .gitconfig. It can also be useful in the
oddball case where you want a different placement for the trailer.
The case that stimulated the creation of the patches was configuring
From: Paolo Bonzini
Pass the command-line arguments as a pointer to a new struct. This
will be extended soon to include more options.
Signed-off-by: Paolo Bonzini
---
builtin/interpret-trailers.c | 13 ++---
trailer.c| 14 --
trailer.h
From: Paolo Bonzini
Allow using non-default values for trailers without having to set
them up in .gitconfig first. For example, if you have the following
configuration
trailer.signed-off-by.where = end
you may use "--where before" when a patch author forgets his
Signed-off-by and provides
Hi all,
I'm pretty sure this is a FAQ, but articles I found on the Internet were
either mere "recipes" (i.e. tell you how, but don't explain why), or
bogged down in so many details that I was never sure how to proceed from
there.
Basic situation:
There's a master repository (Github or corp
The motivation for setting skip_info default to True is because any
extra message output by a p4 trigger to stdout, seems to be reported
as {'code':'info'} when the p4 command output is marshalled.
I though it was the less intrusive way to filter out the verbose
server trigger scripts, as some co
On 11 July 2017 at 23:53, Miguel Torroja wrote:
> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 triggers in t
On Tue, Jul 11, 2017 at 03:04:05PM -0700, Brandon Williams wrote:
> This series utilizes the new 'struct repository' in order to convert grep to
> be
> able to recurse into submodules in-process much like how ls-files was
> converted
> to recuse in-process. The result is a much smaller code foo
On 11 July 2017 at 00:42, Junio C Hamano wrote:
> Martin Ågren writes:
>> I am not moving all builtins to handling the pager on their own,
>> but instead introduce a flag IGNORE_PAGER_CONFIG and use it only
>> with the tag builtin. That means there's another flag to reason
>> about, but it avoids
87 matches
Mail list logo
