---
On Fri, May 5, 2017 at 7:54 AM, Johannes Sixt wrote:
> GNU C Library 2016? Is this GPL v3 code? that would be incompatible with GPL
> v2, I think.
No, it's all under LGPL 2.1, the glibc license has not changed since
2010.
As noted in patch 02 one amendmend to one of the LGPL 2.1 files from
Am 05.05.2017 um 00:00 schrieb Ævar Arnfjörð Bjarmason:
---
compat/regex/regcomp.c | 356 +
1 file changed, 209 insertions(+), 147 deletions(-)
diff --git a/compat/regex/regcomp.c b/compat/regex/regcomp.c
index d8bde06f1a..a1fb2e400e 100644
--- a/
Signed-off-by: Jeff Smith
---
builtin.h | 2 --
builtin/blame.c| 28
builtin/cat-file.c | 1 +
diff.c | 23 +++
diff.h | 7 +++
5 files changed, 31 insertions(+), 30 deletions(-)
diff --git a/builtin.h b
Signed-off-by: Jeff Smith
---
Makefile| 1 +
builtin/blame.c | 198 +--
commit-fake.c | 200
commit-fake.h | 9 +++
4 files changed, 211 insertions(+), 197 deletions(-)
cr
In adding blame functionality to cgit, I do not wish to duplicate huge
portions of builtin/blame.c there. I would rather shift its core
functionality into libgit.a -- which cgit already uses -- and in cgit I
can focus on the web presentation aspect.
I was able to split three separate cohesive pie
Signed-off-by: Jeff Smith
---
builtin/blame.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 07506a3..42c56eb 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -8,7 +8,6 @@
#include "cache.h"
#include "refs.h"
#include "builtin.h"
-#include "blob
Signed-off-by: Jeff Smith
---
builtin/blame.c | 149 +++-
1 file changed, 93 insertions(+), 56 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index c873cc2..dc7600c 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -62,11 +62,6
Signed-off-by: Jeff Smith
---
builtin/blame.c | 274
scoreboard.c| 273 +++
scoreboard.h| 2 +
3 files changed, 275 insertions(+), 274 deletions(-)
diff --git a/builtin/blame.c
Signed-off-by: Jeff Smith
---
Makefile|1 +
builtin/blame.c | 1358 +--
scoreboard.c| 1296
scoreboard.h| 74 +++
4 files changed, 1372 insertions(+), 1357 deletions(-)
Signed-off-by: Jeff Smith
---
builtin/blame.c | 264 +---
scoreboard.h| 1 +
2 files changed, 140 insertions(+), 125 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 0af99e3..3bde5a6 100644
--- a/builtin/blame.c
+++ b/bui
Signed-off-by: Jeff Smith
---
builtin/blame.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index c419981..cc46f56 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -449,9 +449,7 @@ static struct origin *make_origin(struct
Signed-off-by: Jeff Smith
---
object.h| 2 ++
pathspec.h | 4
refs.h | 3 +++
tree-walk.h | 2 ++
4 files changed, 11 insertions(+)
diff --git a/object.h b/object.h
index f52957d..9737582 100644
--- a/object.h
+++ b/object.h
@@ -1,6 +1,8 @@
#ifndef OBJECT_H
#define OBJECT_H
+#
Signed-off-by: Jeff Smith
---
Makefile| 1 +
builtin/blame.c | 151 +---
origin.c| 62 +++
origin.h| 101 +
4 files changed, 165 insertions(+), 150 deletions(-)
hi,
I used the command below,there's an error,please help me to solve it !
Thank you ~
git push
Best Regards~
ada Wang
Hi,
Git v2.13.0-rc2 introduced 4 new messages, let's start round 2 for Git
2.13.0 l10n.
You can get it from the usual place:
https://github.com/git-l10n/git-po/
As how to update your XX.po and help to translate Git, please see
"Updating a XX.po file" and other sections in “po/README" file.
Hello dear,
I am Miss Makena Jelani. hope you remember me? is been a long time,
where have you been. well, contact me so we can talk
Makena.
On 04/05/17 10:26, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Thu, 4 May 2017, Ramsay Jones wrote:
>
>> diff --git a/archive-tar.c b/archive-tar.c
>> index 319a5b1c7..6dddc0cff 100644
>> --- a/archive-tar.c
>> +++ b/archive-tar.c
>> @@ -33,7 +33,7 @@ static int write_tar_filter_archive(cons
On 01/05/17 06:35, Junio C Hamano wrote:
>
> * nd/fopen-errors (2017-04-23) 17 commits
> - warn_failure_to_open_read_optional_path(): a new helper
> - t1308: add a test case on open a config directory
> - config.c: handle error on failing to fopen()
> - xdiff-interface.c: report errno on fai
On 2017-05-04 07:57 PM, Stefan Beller wrote:
On Thu, May 4, 2017 at 3:48 PM, Soni L. wrote:
Can we get delta compression hooks? I'm working with voxel data as my source
code (it's a long story...) and git doesn't handle changing lines of voxels
very well.
Example, I have something from posit
On Thu, May 4, 2017 at 3:48 PM, Soni L. wrote:
> Can we get delta compression hooks? I'm working with voxel data as my source
> code (it's a long story...) and git doesn't handle changing lines of voxels
> very well.
>
> Example, I have something from position (0,0,0) to position (0,10,0) and I
>
Can we get delta compression hooks? I'm working with voxel data as my
source code (it's a long story...) and git doesn't handle changing lines
of voxels very well.
Example, I have something from position (0,0,0) to position (0,10,0) and
I replace it with something else. Git doesn't handle this
---
compat/regex/regex.h | 120 +---
compat/regex/regexec.c | 242 +
2 files changed, 193 insertions(+), 169 deletions(-)
diff --git a/compat/regex/regex.h b/compat/regex/regex.h
index 61c9683872..b602b5567f 100644
--- a/compat
---
compat/regex/intprops.h | 448
compat/regex/verify.h | 286 +++
2 files changed, 734 insertions(+)
create mode 100644 compat/regex/intprops.h
create mode 100644 compat/regex/verify.h
diff --git a/compat/regex/int
---
compat/regex/regcomp.c | 356 +
1 file changed, 209 insertions(+), 147 deletions(-)
diff --git a/compat/regex/regcomp.c b/compat/regex/regcomp.c
index d8bde06f1a..a1fb2e400e 100644
--- a/compat/regex/regcomp.c
+++ b/compat/regex/regcomp.c
@@ -1,
---
compat/regex/regex_internal.c | 118 +-
compat/regex/regex_internal.h | 118 ++
2 files changed, 144 insertions(+), 92 deletions(-)
diff --git a/compat/regex/regex_internal.c b/compat/regex/regex_internal.c
index
---
compat/regex/regex.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/compat/regex/regex.c b/compat/regex/regex.c
index 5cb23e5d59..d6e525e567 100644
--- a/compat/regex/regex.c
+++ b/compat/regex/regex.c
@@ -1,5 +1,12 @@
+/*
+ * This is git
Update the gawk regex engine from the upstream gawk.git as detailed in
the README added in a previous change.
This is from gawk.git's gawk-4.1.0-2558-gb2651a80 which is the same
code as in the stable gawk-4.1.4 release, but with one trivial change
on top added in commit 725d2f78 ("Add small regex
Add a README file to compat/regex describing how the copy of the gawk
engine should be maintained.
Since gawk's regex engine was originally imported in git.git in commit
d18f76dccf ("compat/regex: use the regex engine from gawk for compat",
2010-08-17) the Git project has forked the upstream code.
See the first patch for motivation & why.
The only reason this has a cover letter is to explain the !fixup
commits. IIRC the mailing list has a 100K limit, which this series
would violate, so I split up the second commit.
Consider all these !fixup commits to have by Signed-off-by, easier to
say t
The previous patch reorders the delete operations in fast-export
(preceding any other one), keeps renaming as last operations to
process (as original source code) and for any other operation it keeps
the same order as "diff"
The non deterministic reordering was one of the concerns when I first
sen
When fd47ae6a5b (diff: teach diff to display submodule difference with an
inline diff, 2016-08-31) was introduced, we did not think of recursing
into nested submodules.
When showing the inline diff for submodules, automatically recurse
into nested submodules as well with inline submodule diffs.
S
Hi,
My little bitbucket "cherry-pick" button is failing on Windows from a
"git reset --hard" blowing up.
My situation: Git-2.10.2.windows.1 / Bitbucket-4.14.3 / Windows
10-10.0-amd64. But I suspect even more recent Git will have the same
problem.
Now, I'm pretty far from Kansas here as you'll
The delete operations of the fast-export output should precede any addition
belonging to the same commit, Addition and deletion with the same name
entry could happen in case of file to directory and viceversa.
As an equal comparison doesn't have any deterministic final order,
it's better to keep o
Hi,
Junio C Hamano wrote:
> Duy Nguyen writes:
>> I attempted the same thing once or twice in the past, had the same
>> impression and dropped it. But I think it's good to get rid of cache_*
>> macros, at least outside builtin/ directory.
>
> One thing that needs to be kept in mind is that a mec
Eine Spende von 1 Million Britische Pfund zu Ihnen in gutem Glauben
Hi Junio,
On Thu, 4 May 2017, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > Well, a couple of comments about your comment:
> >
> > - we say "shell scripts", but we're sloppy there: they are "Unix shell
> > scripts", as they are executed by Unix shells. As such, it is pretty
> >
Hi again,
Jeff Hostetler wrote:
> In my original RFC there were comments/complaints that with
> missing blobs we lose the ability to detect corruptions. My
> proposed changes to index-pack and rev-list (and suggestions
> for other commands like fsck) just disabled those errors.
> Personally, I'm
On Wed, May 3, 2017 at 7:48 PM, Junio C Hamano wrote:
> Duy Nguyen writes:
>
In the long run we may want to drop the macros guarded by
NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them.
>>>
>>> Why?
>>
>> Well.. why did you add NO_THE_INDEX_COMP... in the first place? ;-
Acked-by: Matthias Rüster
Am 04.05.2017 um 19:08 schrieb Ralf Thielow:
> Translate 96 new messages came from git.pot update in dfc182b (l10n:
> git.pot: v2.13.0 round 1 (96 new, 37 removed)).
>
> Signed-off-by: Ralf Thielow
> ---
> po/de.po | 325
> ---
On 05/03/2017 09:29 PM, Junio C Hamano wrote:
Jonathan Tan writes:
I see the semantics as "don't write what you already have", where
"have" means what you have in local storage, but if you extend "have"
to what upstream has, then yes, you're right that this changes
(ignoring shallow clones).
Translate 96 new messages came from git.pot update in dfc182b (l10n:
git.pot: v2.13.0 round 1 (96 new, 37 removed)).
Signed-off-by: Ralf Thielow
---
po/de.po | 325 ---
1 file changed, 143 insertions(+), 182 deletions(-)
diff --git a/p
On 5/3/2017 2:27 PM, Jonathan Nieder wrote:
Hi,
Jeff Hostetler wrote:
Missing-Blob Support
Let me offer up an alternative idea for representing
missing blobs. This is differs from both of our previous
proposals. (I don't have any code for this new proposal,
I just want
Ethan Clevenger wrote:
> Git version: 2.12.2.windows.2
>
> `git svn tag 1.0` results in:
Note, "git svn tag" uses the same backend code as "git svn branch",
and there was a recent fix for that in
commit e0688e9b28f2c5ff711460ee8b62077be5df2360
("git svn: fix authentication with 'branch'")
Loo
Git version: 2.12.2.windows.2
`git svn tag 1.0` results in:
> Copying https://plugins.svn.wordpress.org/gf-payment-continue/trunk at
> r1651123 to https://plugins.svn.wordpress.org/gf-payment-continue/tags/1.0...
> Authentication failed: No more credentials or we tried too many times.
> Authenti
A release candidate Git v2.13.0-rc2 is now available for testing
at the usual places. It is comprised of 699 non-merge commits
since v2.12.0, contributed by 59 people, 15 of which are new faces.
The tarballs are found at:
https://www.kernel.org/pub/software/scm/git/testing/
The following pu
Johannes Schindelin writes:
> Well, a couple of comments about your comment:
>
> - we say "shell scripts", but we're sloppy there: they are "Unix shell
> scripts", as they are executed by Unix shells. As such, it is pretty
> obvious that they favor Unix line endings, right? And that they do n
On Fri, Apr 28, 2017 at 03:20:21PM -0400, Devin Lehmacher wrote:
> > > Test Summary Report
> > > ---
> > > t0301-credential-cache.sh(Wstat: 256 Tests: 29
> > > Failed: 6)
> > > Failed tests: 12, 24-28
> > > Non-zero exit status: 1
> >
> > Confirmed I'm
When the `name_rev()` function is asked to dereference the tip name, it
allocates memory. But when it turns out that another tip already
described the commit better than the current one, we forgot to release
the memory.
Pointed out by Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/nam
There is really no reason why we would need to hold onto the allocated
string longer than necessary.
Reported by Coverity.
Signed-off-by: Johannes Schindelin
---
worktree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/worktree.c b/worktree.c
index bae787cf8d7..89a81b13de3
The buffer allocated by shorten_unambiguous_ref() needs to be released.
Discovered by Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/worktree.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 1722a9bdc2a..ff5dfd
Identified via Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/pack-redundant.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/builtin/pack-redundant.c b/builtin/pack-redundant.c
index 72c815844dd..cb1df1c7614 100644
--- a/builtin/pack-redundant.c
+++ b/builtin/pack-redundant.c
@@
The `guess_ref()` returns an allocated buffer of which `make_linked_ref()`
does not take custody (`alloc_ref()` makes a copy), therefore we need to
release the buffer afterwards.
Noticed via Coverity.
Signed-off-by: Johannes Schindelin
---
remote.c | 5 +++--
1 file changed, 3 insertions(+), 2
Coverity reported a memory leak in this function. However, it can only
be called once, as setup_git_directory() changes global state and hence
is not reentrant.
Mark the variable as static to indicate that this is a singleton.
Signed-off-by: Johannes Schindelin
---
setup.c | 2 +-
1 file change
Signed-off-by: Johannes Schindelin
---
builtin/mktree.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/builtin/mktree.c b/builtin/mktree.c
index de9b40fc63b..da0fd8cd706 100644
--- a/builtin/mktree.c
+++ b/builtin/mktree.c
@@ -72,7 +72,7 @@ static void mktree_line(char *
We free()d the `log` buffer when dwim_log() returned 1, but not when it
returned a larger value (which meant that it still allocated the buffer
but we simply ignored it).
While in the vicinity, make sure that the `reflogs` structure as well as
the `branch` variable are released properly, too.
Ide
Reported by Coverity.
Signed-off-by: Johannes Schindelin
---
shallow.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/shallow.c b/shallow.c
index 25b6db989bf..f9370961f99 100644
--- a/shallow.c
+++ b/shallow.c
@@ -473,11 +473,15 @@ static void paint_down(struct paint
Reported by, you guessed it, Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/fast-export.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index e0220630d00..64617ad8e36 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@
This function did a whole lot of unnecessary work, such as reading in
four files just to figure out that, oh, hey, we do not need to look at
them after all because the HEAD is not detached.
Simplify the entire function to return early when possible, to read in
the files only when necessary, and to
The setup_explicit_git_dir() function does not take custody of the string
passed as first parameter; we have to release it if we turned the value of
git_dir into an absolute path.
Signed-off-by: Johannes Schindelin
---
setup.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff
Discovered by Coverity.
Signed-off-by: Johannes Schindelin
---
line-log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/line-log.c b/line-log.c
index a23b910471b..b9087814b8c 100644
--- a/line-log.c
+++ b/line-log.c
@@ -1125,6 +1125,7 @@ static int process_ranges_ordinary_commit(struct rev
Reported via Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/receive-pack.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index f96834f42c9..48c07ddb659 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pac
This change addresses part of the NEEDSWORK comment above the code,
therefore the comment needs to be adjusted, too.
Discovered via Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/checkout.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/builtin/c
Discovered by Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/cat-file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 1890d7a6390..9af863e7915 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -165,6 +165,7 @@ static int cat
In the (admittedly, concocted) case that PATH consists only of path
delimiters, we would leak the duplicated string.
Reported by Coverity.
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
While POSIX states that it is okay to pass EOF to isspace() (and it seems
to be implied that EOF should *not* be treated as whitespace), and also to
pass EOF to ungetc() (which seems to be intended to fail without buffering
the character), it is much better to handle these cases explicitly. Not
onl
To initialize the foreground color attributes of "plain text", our ANSI
emulation tries to infer them from the currently attached console while
running the is_console() function. This function first tries to detect any
console attached to stdout, then it is called with stderr.
If neither stdout no
I recently registered the git-for-windows fork with Coverity to ensure
that even the Windows-specific patches get some static analysis love.
While at it, I squashed a couple of obvious issues in the part that is
not Windows-specific.
Note: while this patch series squashes some of those issues, th
When we could not convert the UTF-8 sequence into Unicode for writing to
the Console, we should not try to write an insanely-long sequence of
invalid wide characters (mistaking the negative return value for an
unsigned length).
Reported by Coverity.
Signed-off-by: Johannes Schindelin
---
compat
Reported via Coverity.
Signed-off-by: Johannes Schindelin
---
wt-status.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/wt-status.c b/wt-status.c
index 03754849626..0a6e16dbe0f 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1168,6 +1168,7 @@ static int read_rebase_todolist(const char *fnam
When we fail to read, or parse, the file, we still want to close the file
descriptor and release the strbuf.
Reported via Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/am.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/builtin/am.c b/builtin/am.c
In case of errors, we really want the file descriptor to be closed.
Discovered by a Coverity scan.
Signed-off-by: Johannes Schindelin
---
config.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/config.c b/config.c
index b4a3205da32..a30056ec7e9 100644
--- a/config.c
+++
It would appear that we allocate (and forget to release) memory if the
patch ID is not even defined.
Reported by the Coverity tool.
Signed-off-by: Johannes Schindelin
---
patch-ids.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/patch-ids.c b/patch-ids.c
index fa8f11de82
This change plugs a couple of memory leaks and makes sure that the file
descriptor is closed in run_dir_diff().
Spotted by Coverity.
Signed-off-by: Johannes Schindelin
---
builtin/difftool.c | 33 +++--
1 file changed, 23 insertions(+), 10 deletions(-)
diff --git a/
2017-05-03 21:27 GMT+02:00 Christian Brabandt :
> On Mi, 03 Mai 2017, Ralf Thielow wrote:
>
>> Ref or Reference is translated as "Referenz" while
>> Rev or Revision is translated as "Commit" so I think
>> the translation is correct.
>
> Oh right. I also noticed that sometimes complete sentences wer
2017-05-03 19:29 GMT+02:00 Matthias Rüster :
> Hi Ralf,
>
> thanks again for your work!
>
>
>>
>> #: ref-filter.c:565
>> -#, fuzzy, c-format
>> +#, c-format
>> msgid "format: %%(then) atom used after %%(else)"
>> -msgstr "Format: %%(end) Atom fehlt"
>> +msgstr "format: %%(then) nach %%(else) verw
On Thu, May 4, 2017 at 1:32 PM, Johannes Schindelin
wrote:
> Hi Ævar,
>
> On Thu, 4 May 2017, Ævar Arnfjörð Bjarmason wrote:
>
>> So I think if your criteria for working on integrating v2 is users
>> noticing it elsewhere and asking you for it you'll likely never switch
>> to it.
>
> Speaking for
Hi Ævar,
On Thu, 4 May 2017, Ævar Arnfjörð Bjarmason wrote:
> So I think if your criteria for working on integrating v2 is users
> noticing it elsewhere and asking you for it you'll likely never switch
> to it.
Speaking for myself, my biggest problem with your patch series is to find
the time to
Hi,
On Thu, 4 May 2017, ankostis wrote:
> On 4 May 2017 at 11:47, Adam Dinwoodie wrote:
> > Confirmed: the Cygwin project as a general rule doesn't support this
> > sort of mixing of Windows and Cygwin tools. Either use Python and Git
> > packages both provided by Cygwin, or both provided by Wi
Hi René,
On Wed, 3 May 2017, René Scharfe wrote:
> Am 02.05.2017 um 18:02 schrieb Johannes Schindelin:
> > Reported via Coverity.
> >
> > Signed-off-by: Johannes Schindelin
> > ---
> > wt-status.c | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/wt-status
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from
part of our Jackpot Lottery of 50 Million Dollars, respond with your details
for claims.
We await your earliest response and God Bless you.
Friedrich And Annand Mayrhofer.
---
This email has been checked f
Hi René,
On Wed, 3 May 2017, René Scharfe wrote:
> Am 02.05.2017 um 18:00 schrieb Johannes Schindelin:
> > In the (admittedly, concocted) case that PATH consists only of colons, we
> > would leak the duplicated string.
>
> Nit: It's about semicolons, right? At least that's what get_path_split
>
On Thu, May 4, 2017 at 11:11 AM, Johannes Schindelin
wrote:
> Hi Ævar,
>
> On Wed, 3 May 2017, Ævar Arnfjörð Bjarmason wrote:
>
>> [Just replying to you & Duy in the same mail, easier]
>
> It makes it harder on everybody else, though, as two slightly different
> discussion points are conflated now
Hi René,
On Wed, 3 May 2017, René Scharfe wrote:
> Am 02.05.2017 um 18:01 schrieb Johannes Schindelin:
> >
> > diff --git a/compat/winansi.c b/compat/winansi.c
> > index 793420f9d0d..fd6910746c8 100644
> > --- a/compat/winansi.c
> > +++ b/compat/winansi.c
> > @@ -105,6 +105,8 @@ static int is_co
On 4 May 2017 at 11:47, Adam Dinwoodie wrote:
> Confirmed: the Cygwin project as a general rule doesn't support this
> sort of mixing of Windows and Cygwin tools. Either use Python and Git
> packages both provided by Cygwin, or both provided by Windows.
>
> Mixing and matching does work sometimes
My point was to ensure that where English is used on-screen it should make
sense, which in this particular case it didn't (a French idiom which, on using
an automatic translator, didn't make sense in English). The same of course
applies to other languages used on-screen.
I agree about ensurin
The test t4051-diff-function-context.sh passes on Linux when
core.autocrlf=true even without marking its support files as LF-only,
but they fail when core.autocrlf=true in Git for Windows' SDK.
The reason is that `grep ... >file.c.new` will keep CR/LF line endings
on Linux (obviously treating CRs
The test suite is mainly developed on Linux and MacOSX, which is the
reason that nobody thought to mark files as LF-only as needed.
The symptom is a test suite that fails left and right when being checked
out using Git for Windows (which defaults to core.autocrlf=true).
Mostly, the problems stem
Without this change, the completion script does not work, as Bash expects
its scripts to have line feeds as end-of-line markers (this is
particularly prominent in quoted multi-line strings, where carriage
returns would slip into the strings as verbatim characters otherwise).
This change is require
Seeing as Git originates from the Linux ecosystem, it is understandable
that the assumption of Unix line endings is deeply ingrained in Git's
source code as well as its test suite.
However, we must not force files that are otherwise unrelated to tests
to have Unix line endings just to appease test
The current convention is to either generate files on the fly in tests,
or to use supporting files taken from a t/t/ directory (where
matches the test's number, or the number of the test from which we
borrow supporting files).
The test t3901-i18n-patch.sh was obviously introduced before t
Bash does not handle scripts with CR/LF line endings correctly, therefore
they *have* to be forced to LF-only line endings.
Funnily enough, this fixes t3000-ls-files-others and
t1021-rerere-in-workdir when git.git was checked out with
core.autocrlf=true, as these test still use git-new-workdir (on
On Windows, the default line endings are denoted by a Carriage Return
byte followed by a Line Feed byte, while Linux and MacOSX use a single
Line Feed byte to denote a line ending.
To help with this situation, Git introduced several mechanisms over the
last decade, most prominently the `core.autoc
[Cc:ing Jonathan Nieder, who reviewed the first iteration of this patch
series, and Jeff Hostetler who is guilty of prodding me into finishing
this patch series in the first place.]
Over the past decade, there have been a couple of attempts to remedy the
situation regarding line endings (Windows/D
On Wed, May 03, 2017 at 04:32:15PM +0200, Johannes Schindelin wrote:
> On Wed, 3 May 2017, ankostis wrote:
>
> > On 3 May 2017 11:47, Johannes Schindelin wrote:
> > > On Tue, 2 May 2017, ankostis wrote:
> > >
> > >> On Windows, with Cygwin-git 02.12.2-1 the python command:
> > >> [...]
> > >
> > >
Hi Junio,
On Wed, 3 May 2017, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > For starters, those files include shell scripts: the most prevalent
> > shell interpreter in use (and certainly used in Git for Windows) is
> > Bash, and Bash does not handle CR/LF line endings gracefully.
>
Le jeudi 4 mai 2017, 08:52:43 CEST Kerry, Richard a écrit :
>
> May I suggest that " The most approaching commands" doesn't make much sense
> as English (I don't think a command can "approach").
> Perhaps it should be " The most appropriate commands".
>
>
> Regards,
> Richard.
>
Thank you f
On 04/05/17 16:16, Ævar Arnfjörð Bjarmason wrote:
> What's the real use-case here? If you do "set -e" in your shell you
> also get e.g.:
>
> $ ls -l blah
> ls: cannot access blah: No such file or directory
> === Command terminated with exit status 2 (Thu May 4 11:16:03 2017) ===
>
>
Hi Ramsay,
On Thu, 4 May 2017, Ramsay Jones wrote:
> diff --git a/archive-tar.c b/archive-tar.c
> index 319a5b1c7..6dddc0cff 100644
> --- a/archive-tar.c
> +++ b/archive-tar.c
> @@ -33,7 +33,7 @@ static int write_tar_filter_archive(const struct archiver
> *ar,
> #if TIME_MAX == 0x
> #d
Hi Lars,
On Wed, 3 May 2017, Lars Schneider wrote:
> The Git for Windows CI web app sometimes returns HTTP errors of
> "502 bad gateway" or "503 service unavailable" [1]. We also need to
> check the HTTP content because the GfW web app seems to pass through
> (error) results from other Azure cal
On Thu, May 4, 2017 at 10:26 AM, Tom Hale wrote:
>
> On 17/04/17 11:24, Junio C Hamano wrote:
>> "Tom \"Ravi\" Hale" writes:
>>
>> > If a user types `set -e` in an interactive shell, and is using __git_ps1
>> > to set
>> > their prompt, the shell will die if the current directory isn't inside a
1 - 100 of 108 matches
Mail list logo
