On 5/3/2017 22:22, Jeff King wrote:
>> My patch deals with 'remote..refspec', i.e. 'remote->fetch'.
>> Apparently some extra care is necessary for 'remote..tagOpt' and
>> 'remote->fetch_tags', too. Perhaps there are more, I haven't checked
>> again, and maybe we'll add similar config variables in
Nguyễn Thái Ngọc Duy writes:
> Changes since v1:
>
> - fopen_or_warn() and warn_on_fopen_errors() are introduced. The
>latter's name is probably not great...
> - A new patch (first one) to convert a bunch to using xfopen()
> - Fix test failure on Windows, found by Johannes Sixt
> - Fix t
Nguyễn Thái Ngọc Duy writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> dir.c | 3 +--
> git-compat-util.h | 2 ++
> wrapper.c | 10 ++
> 3 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/dir.c b/dir.c
> index f451bfa48c..8218a24962 100644
> --
Jeff King writes:
>> 4. Now git says git: 'stahs' is not a git command. See 'git --help'.
>>
>> Did you mean this?
>>
>> stash
>
> After this step git exits, and you're back at your shell prompt...
Perhaps the suggestion message should be rephrased not to sound like
it is asking confirmation?
Johannes Schindelin writes:
> For starters, those files include shell scripts: the most prevalent
> shell interpreter in use (and certainly used in Git for Windows) is
> Bash, and Bash does not handle CR/LF line endings gracefully.
Good to know. I am not sure if it is OK for shell scripts not t
Johannes Schindelin writes:
>> If 'git-rebase--interactive.sh' is bound to be replaced, I could
>> just shrink this to the Documentation cleanup (patches 4 and 5)
>> and rework the rest on top of your new implementation.
>
> I kind of hoped that Junio would chime in with his verdict. That would b
Jonathan Tan writes:
> I see the semantics as "don't write what you already have", where
> "have" means what you have in local storage, but if you extend "have"
> to what upstream has, then yes, you're right that this changes
> (ignoring shallow clones).
>
> This does remove a resistance that we
Johannes Schindelin writes:
> Hi Junio,
>
> On Mon, 1 May 2017, Junio C Hamano wrote:
>
>> Junio C Hamano writes:
>>
>> > Johannes Schindelin writes:
>> >
>> >> diff --git a/builtin/name-rev.c b/builtin/name-rev.c
>> >> index 92a5d8a5d26..a4ce73fb1e9 100644
>> >> --- a/builtin/name-rev.c
>> >>
On 05/03, Samuel Lijin wrote:
> On Wed, May 3, 2017 at 12:14 PM, Stefan Beller wrote:
> > On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote:
> >>
> >> Just to throw out an example, I'm relatively new to the codebase (I've
> >> been lurking on the mailing list for a few months now) and for a
> >>
On 05/03, Junio C Hamano wrote:
> Duy Nguyen writes:
>
> >>> In the long run we may want to drop the macros guarded by
> >>> NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them.
> >>
> >> Why?
> >
> > Well.. why did you add NO_THE_INDEX_COMP... in the first place? ;-) j/k
>
> That
Duy Nguyen writes:
>>> In the long run we may want to drop the macros guarded by
>>> NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them.
>>
>> Why?
>
> Well.. why did you add NO_THE_INDEX_COMP... in the first place? ;-) j/k
That was to mark the code that implements the underlying
For the list, in plain text:
IIUC, they use the date received to sort. I think this might stem from
a historical cruft: emails sometimes took non-trivial amounts of time
to transit, back in the old days. MUAs (especially web-based ones)
probably did not want to violate user expectation by placing
Jean-Noël AVILA writes:
> Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
>> Jean-Noel Avila writes:
>> > The building of the reflog message is using strbuf, which is not
>> > friendly with internationalization frameworks. No other reflog
>> > messages are translated right now
Jean-Noël AVILA writes:
> Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
>> Jean-Noel Avila writes:
>> > The building of the reflog message is using strbuf, which is not
>> > friendly with internationalization frameworks. No other reflog
>> > messages are translated right now
Ævar Arnfjörð Bjarmason writes:
> It makes sense to have a configurable delay for git-send-email
> unrelated to this option, I'd use a facility like that.
>
> A lot of mail clients just sort based on date/msgid or whatever not
> date/subject, so the rapid-fire output of send-email often arrives o
On Mon, May 01, 2017 at 02:28:53AM +, brian m. carlson wrote:
> This is the eighth series of patches to convert unsigned char [20] to
> struct object_id. This series converts lookup_commit, lookup_blob,
> lookup_tree, lookup_tag, and finally parse_object to struct object_id.
I've made the cha
On Tue, May 02, 2017 at 11:05:14AM -0700, Brandon Williams wrote:
> On 05/01, brian m. carlson wrote:
> > - if (!logobj && commit_reflog->recno >= 0 &&
> > is_null_sha1(reflog->ooid.hash)) {
> > + if (!logobj && commit_reflog->recno >= 0 && is_null_oid(&reflog->ooid))
> > {
>
> Not relevant
Commit dddbad728c ("timestamp_t: a new data type for timestamps",
26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an
unsigned long, which was used at the time to represent timestamps in
git. A later commit 28f4aee3fb ("use uintmax_t for timestamps",
26-04-2017) changed the typ
On Tue, May 02, 2017 at 11:13:08AM -0700, Brandon Williams wrote:
> Should this 20 be converted to GIT_{SHA1,MAX}_RAWSZ? I know this is a
> generated patch so maybe this is addressed, or will be addressed later?
Since this is a purely mechanical patch, I plan on addressing it later.
I'll probably
On Mon, May 01, 2017 at 06:27:58PM -0400, Jeff King wrote:
> If you have 40 hex digits, then you have 20 hex pairs. But delimiting
> them all takes only 19 slashes, since they only go in between pairs[1].
>
> So the fully expanded formula is:
>
> GIT_MAX_HEXSZ + (1) actual hex byt
On Mon, May 01, 2017 at 04:24:23PM -0700, Jonathan Tan wrote:
> On 04/30/2017 07:29 PM, brian m. carlson wrote:
> > - if (line->len <= 42)
> > + if (!line->len)
> > return NULL;
>
> I would omit this check - parse_oid_hex already exits early if the first
> character is NUL. (The ex
If I run an interactive rebase on a branch without the --root flag, git
does not modify (change the hash, etc.) any initial commits that are
being "pick"ed in the same order. However, if I use --root, every single
commit is modified.
Here's an example:
* Old (immediately after running "git rebas
The Git for Windows CI web app sometimes returns HTTP errors of
"502 bad gateway" or "503 service unavailable" [1]. We also need to
check the HTTP content because the GfW web app seems to pass through
(error) results from other Azure calls with HTTP code 200.
Wait a little and retry the request if
Hi,
Jonathan Tan wrote:
> The binary search to lookup a packfile offset from a .idx file
> (which involves disk reads) would take longer for all lookups (not
> just lookups for missing blobs) - I think I prefer keeping the lists
> separate, to avoid pessimizing the (likely) usual case where the
>
"git read-tree -m" requires a tree argument to name the tree to be
merged in. Git uses a cutesy error message to say so and why:
$ git read-tree -m
warning: read-tree: emptying the index with no arguments is
deprecated; use --empty
fatal: just how do you expect me to merge 0 trees
git-filter-branch requires the specification of a branch by one way or
another. If no branch appears to have been specified, we know the user
got the usage wrong but we don't know what they were trying to do ---
e.g. maybe they specified the ref to rewrite but in the wrong place.
The safest soluti
There has been a bug report by a corporate user that stated that
"spelling mistake of stash followed by a yes prints character 'y'
infinite times."
This analysis was false. When the spelling of a command contains
errors, the git program tries to help the user by providing candidates
which are clos
Am 02.05.2017 um 18:02 schrieb Johannes Schindelin:
Reported via Coverity.
Signed-off-by: Johannes Schindelin
---
wt-status.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/wt-status.c b/wt-status.c
index 0a6e16dbe0f..1f3f6bcb980 100644
--- a/wt-status.c
+++ b/wt-s
On 05/03/2017 09:38 AM, Jeff Hostetler wrote:
On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote:
From: Jeff Hostetler
[RFC] Partial Clone and Fetch
=
[...]
E. Unresolved Thoughts
==
*TODO* The server should optionally return (in a side-band?)
On Wed, May 03, 2017 at 04:42:58PM +0200, SZEDER Gábor wrote:
> write_refspec_config() nicely encapsulates writing the proper fetch
> refspec configuration according to the given command line options. Of
> course these options are already known right at the start, so solely
> in this regard we co
Hi,
Stefan Beller wrote:
> On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote:
>> Is there e.g. a build farm where we can check for this kind of thing
>> more systematically on supported platforms?
>
> There is the OpenSuse build farm that provides builds for all kinds of
> linux distributio
On Wed, May 03, 2017 at 02:16:47PM +0200, Sebastian Schuberth wrote:
> I'd assume that this would work:
>
> $ git clone -c
> remote.origin.fetch=+refs/changes/*:refs/remotes/origin/changes/*
> https://gerrit.googlesource.com/git-repo
>
> In fact, this *does* add the custom refs correct to .git/
On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote:
>
> Is there e.g. a build farm where we can check for this kind of thing
> more systematically on supported platforms?
There is the OpenSuse build farm that provides builds for all kinds of
linux distributions, though we'd rather be looking
Am 02.05.2017 um 18:00 schrieb Johannes Schindelin:
In the (admittedly, concocted) case that PATH consists only of colons, we
would leak the duplicated string.
Nit: It's about semicolons, right? At least that's what get_path_split
is searching for. Or is there some kind of translation going o
Am 02.05.2017 um 18:01 schrieb Johannes Schindelin:
When stdout is not connected to a Win32 console, we incorrectly used an
uninitialized value for the "plain" character attributes.
Detected by Coverity.
Signed-off-by: Johannes Schindelin
---
compat/winansi.c | 2 ++
1 file changed, 2 inser
Am 03.05.2017 um 11:46 schrieb Duy Nguyen:
On Tue, May 2, 2017 at 2:22 AM, Jeff King wrote:
On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
I can only get gcc and clang to call memcpy instead of inlining it by
specifying -fno-builtin. Do you use that option? If yes, why? (Jus
Ævar Arnfjörð Bjarmason wrote:
> Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
>
> Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
> non NUL-terminated string", 2016-09-21) git has errored out at
> compile-time if the regular expression library doesn't suppo
On Mi, 03 Mai 2017, Ralf Thielow wrote:
> Ref or Reference is translated as "Referenz" while
> Rev or Revision is translated as "Commit" so I think
> the translation is correct.
Oh right. I also noticed that sometimes complete sentences were used and
sometimes not. It would be nice to have a con
Le mercredi 3 mai 2017, 10:04:01 CEST Jonathan Nieder a écrit :
> Hi,
>
> Jean-Noel Avila wrote:
> > Subject: read-tree.c: rework UI when merging no trees
>
> nit: this is about user-facing behavior, not an implementation detail,
> so the part before the colon can be the command that changed
> (r
Le mercredi 3 mai 2017 09:51:58 CEST, vous avez écrit :
> Jean-Noel Avila wrote:
> > Subject: usability: fix am and checkout for nevermind questions
> >
> > Signed-off-by: Jean-Noel Avila
>
> Thanks for working on improving Git's UX. I agree with the goal in
> general (we should not gratuitousl
On Wed, May 3, 2017 at 11:26 AM, Samuel Lijin wrote:
> On Wed, May 3, 2017 at 1:19 PM, Stefan Beller wrote:
>> On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote:
>>> If git sees a directory which contains only untracked and ignored
>>> files, clean -d should not remove that directory.
>>
>> Yes
Hi,
Jeff Hostetler wrote:
> On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote:
>> [RFC] Partial Clone and Fetch
>> =
>> [...]
>> E. Unresolved Thoughts
>> ==
>>
>> *TODO* The server should optionally return (in a side-band?) a list
>> of the blobs t
On Wed, May 3, 2017 at 5:16 AM, Sebastian Schuberth
wrote:
> Hi,
>
> I'm trying to clone a custom ref, avoiding the need to init && fetch
> manually. From reading [1] which says:
>
> "Set a configuration variable in the newly-created repository; this
> takes effect immediately after the repository
On Wed, May 3, 2017 at 1:19 PM, Stefan Beller wrote:
> On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote:
>> If git sees a directory which contains only untracked and ignored
>> files, clean -d should not remove that directory.
>
> Yes that states a fact; it is not clear why we want to have this
On Wed, May 3, 2017 at 12:14 PM, Stefan Beller wrote:
> On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote:
>>
>> Just to throw out an example, I'm relatively new to the codebase (I've
>> been lurking on the mailing list for a few months now) and for a
>> recent project (I'm an undergrad wrapping
On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote:
> If git sees a directory which contains only untracked and ignored
> files, clean -d should not remove that directory.
Yes that states a fact; it is not clear why we want to have this test here
and now. (Is it testing for a recently fixed regre
On Tue, May 2, 2017 at 8:29 PM, Samuel Lijin wrote:
> Introduce a method that allows us to check if one dir_entry corresponds
> to a path which contains the path corresponding to another dir_entry.
> ---
> dir.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/dir.c b/dir.c
> inde
Le mercredi 3 mai 2017, 09:47:44 CEST Jonathan Nieder a écrit :
> Hi,
>
> Jean-Noel Avila wrote:
> > As described in the bug report at
> >
> > https://github.com/git/git-scm.com/issues/999
>
> External issue tracker URLs have been known to change or disappear and
> we try to make commit messages
Hi Ralf,
thanks again for your work!
>
> #: ref-filter.c:565
> -#, fuzzy, c-format
> +#, c-format
> msgid "format: %%(then) atom used after %%(else)"
> -msgstr "Format: %%(end) Atom fehlt"
> +msgstr "format: %%(then) nach %%(else) verwendet"
>
Is there a "Atom" missing?
"format: %%(then)
On Wed, May 3, 2017 at 4:31 AM, Samuel Lijin wrote:
> On Tue, May 2, 2017 at 9:05 AM, Jeff Hostetler wrote:
>>
>>
>> On 5/2/2017 12:17 AM, Stefan Beller wrote:
>>>
>>> On Mon, May 1, 2017 at 6:36 PM, Junio C Hamano wrote:
Stefan Beller writes:
> This applies to origin/master.
Hi,
Jean-Noel Avila wrote:
> Signed-off-by: Jean-Noel Avila
As with the previous patches, this is a good place to put the motivation
for the patch.
> ---
> git-filter-branch.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-filter-branch.sh b/git-filter-branch.s
Hi,
Jean-Noel Avila wrote:
> Subject: read-tree.c: rework UI when merging no trees
nit: this is about user-facing behavior, not an implementation detail,
so the part before the colon can be the command that changed
(read-tree:).
nit: the word "rework" is dangerous in a commit message in the sam
On Wed, May 3, 2017 at 3:27 AM, Duy Nguyen wrote:
> On Tue, May 2, 2017 at 8:36 AM, Junio C Hamano wrote:
>> Stefan Beller writes:
>>
>>> This applies to origin/master.
>>>
>>> For better readability and understandability for newcomers it is a good idea
>>> to not offer 2 APIs doing the same thi
+cc rashmipa...@gmail.com
On Wed, May 3, 2017 at 9:47 AM, Jonathan Nieder wrote:
> Hi,
>
> Jean-Noel Avila wrote:
>
>> As described in the bug report at
>>
>> https://github.com/git/git-scm.com/issues/999
>
> External issue tracker URLs have been known to change or disappear and
> we try to make
Jean-Noel Avila wrote:
> Subject: usability: fix am and checkout for nevermind questions
>
> Signed-off-by: Jean-Noel Avila
Thanks for working on improving Git's UX. I agree with the goal in
general (we should not gratuitously surprise users) but I think I
lack context for appreciating this par
Hi,
Jean-Noel Avila wrote:
> As described in the bug report at
>
> https://github.com/git/git-scm.com/issues/999
External issue tracker URLs have been known to change or disappear and
we try to make commit messages self-contained instead of relying on
them. It is common to put a 'Requested-by:'
Translate 96 new messages came from git.pot update in dfc182b (l10n:
git.pot: v2.13.0 round 1 (96 new, 37 removed)).
Signed-off-by: Ralf Thielow
---
po/de.po | 323 ---
1 file changed, 142 insertions(+), 181 deletions(-)
diff --git a/p
Am 3. Mai 2017 um 14:38 schrieb Christian Brabandt :
> Hallo Ralf!
>
> Ralf Thielow schrieb am Dienstag, den 02. Mai 2017:
>
>> @@ -1260,6 +1260,8 @@ msgstr "Speicher verbraucht"
>> #: config.c:191
>> msgid "relative config include conditionals must come from files"
>> msgstr ""
>> +"Bedingungen
Le dimanche 30 avril 2017, 18:45:05 CEST Junio C Hamano a écrit :
> Jean-Noel Avila writes:
> > The building of the reflog message is using strbuf, which is not
> > friendly with internationalization frameworks. No other reflog
> > messages are translated right now and switching all the messages t
On 3/8/2017 1:50 PM, g...@jeffhostetler.com wrote:
From: Jeff Hostetler
[RFC] Partial Clone and Fetch
=
[...]
E. Unresolved Thoughts
==
*TODO* The server should optionally return (in a side-band?) a list
of the blobs that it omitted from the p
Signed-off-by: Jean-Noel Avila
---
git-filter-branch.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 2b8cdba15..dd3a605d0 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -239,7 +239,7 @@ git rev-parse --no-fl
The initial test was inherited from a previous commit, but it is no
longer needed, given the following switch case. Moreover, the question
sentence ending the program has been replace by an assertative one.
Signed-off-by: Jean-Noel Avila
---
builtin/read-tree.c | 5 +++--
1 file changed, 3 inser
Signed-off-by: Jean-Noel Avila
---
builtin/am.c | 4 ++--
builtin/checkout.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/am.c b/builtin/am.c
index a95dd8b4e..f5afa438d 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -1312,7 +1312,7 @@ static int parse_mail
As described in the bug report at
https://github.com/git/git-scm.com/issues/999
the user was disconcerted by the question asked by the program not
requiring a reply from the user. To improve the general usability of
the Git suite, The following rule was applied:
if the sentence
* appears in a n
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> We don't support config-as-a-directory (maybe someday we will?). Make
> sure we consistently fail in this case, which should happen on platforms
> where fopen() returns non-NULL if FREAD_READS_DIRECTORIES is
> defined.
>
> Signed-off-by:
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> In the first case, we already correctly return -1 if fopen() fails to
> open. But we should report something so people know what's wrong.
>
> In the second case, config_file == NULL does not necessarily mean "no
> config file". Bail out i
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> diff --git a/rerere.c b/rerere.c
> index 971bfedfb2..c26c29f87a 100644
> --- a/rerere.c
> +++ b/rerere.c
> @@ -484,13 +484,14 @@ static int handle_file(const char *path, unsigned char
> *sha1, const char *output
> io.input = fopen(p
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> There's plenty of error() in this code to safely assume --quiet is not a
> concern.
>
> t5512 needs update because if we check the path 'refs*master' (i.e. the
> asterisk is part of the path) then we'll get an EINVAL error.
So the first
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
I do think that this merits a one-line explanation why you do not use
fopen_or_warn() here.
> diff --git a/builtin/log.c b/builtin/log.c
> index b3b10cc1ed..26d6a3cf14 100644
> --- a/builtin/log.c
> +
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> builtin/blame.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 07506a3e45..1648b396dc 100644
> --- a/builtin/blame.c
> ++
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> The main thing to catch here is when fopen() is called on a
> directory. It's safe even without this change because a few lines
> earlier we do check if "filename" is a regular file.
>
> Regardless, let's stay on the safe side in case som
[Just replying to you & Duy in the same mail, easier]
On Wed, May 3, 2017 at 11:45 AM, Johannes Schindelin
wrote:
> Hi Ævar,
>
> On Tue, 2 May 2017, Ævar Arnfjörð Bjarmason wrote:
>
>> On Tue, May 2, 2017 at 6:05 PM, Johannes Schindelin
>> wrote:
>>
>> > [... complaint about the abrupt change th
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
As commented about warn_on_fopen_errors(), I do not see a benefit in
separating the introduction of this small function from the individual
files' changes to use it. Let's bring it all together.
Ciao
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
This commit message is a bit empty. How about:
In many places, Git warns about an inaccessible file after a
fopen() failed. To discern these cases from other cases where we
wan
Hi Duy,
On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote:
> This code uses the result FILE pointer right away without the NULL
> check. Let's use xfopen() and die if we could not open the file. That's
> still better than crashing,
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
While funny to read, mayb
Cc'ing Ævar because of his work on 'clone --no-tags'.
On Wed, Mar 15, 2017 at 6:08 PM, Jeff King wrote:
> On Sat, Mar 11, 2017 at 01:41:34AM +0100, SZEDER Gábor wrote:
>> > Though if I'm bikeshedding, I'd probably have written the whole thing
>> > with an argv_array and avoided counting at all.
Hi,
On Wed, 3 May 2017, ankostis wrote:
> On 3 May 2017 11:47, Johannes Schindelin wrote:
> > On Tue, 2 May 2017, ankostis wrote:
> >
> >> On Windows, with Cygwin-git 02.12.2-1 the python command:
> >> [...]
> >
> > You forgot to mention what python/pip you use (is it the Cygwin one,
> > or a st
Hi Jonathan,
On Tue, 2 May 2017, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
>
> > Over the past decade, there have been a couple of attempts to remedy the
> [...]
>
> I'm intentionally skimming this cover letter, since anything important
> it says needs to also be in the commit message
Hello My Dear,
This is my second mail but No response,from you Why? regarding my
Easter Donation Gift"
Reminding notice/ this is to inform you that i am still in the
hospital bed taking a medical treatments because of my Old age
illness.Please i need your urgent answer/ i want to know if you have
Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
non NUL-terminated string", 2016-09-21) git has errored out at
compile-time if the regular expression library doesn't support
REG_STARTEND.
While looking through G
Hallo Ralf!
Ralf Thielow schrieb am Dienstag, den 02. Mai 2017:
> @@ -1260,6 +1260,8 @@ msgstr "Speicher verbraucht"
> #: config.c:191
> msgid "relative config include conditionals must come from files"
> msgstr ""
> +"Bedingungen für das Einbinden von Konfigurationen aus relativen Pfaden
> m
>>> Samuel Lijin schrieb am 03.05.2017 um 09:12 in Nachricht
:
> On Mon, May 1, 2017 at 7:59 PM, Junio C Hamano wrote:
>> Samuel Lijin writes:
>>
>>> On Fri, Mar 31, 2017 at 10:52 AM, Junio C Hamano wrote:
>>>
It might not be a bad idea to teach "blame" not to pay attention to
any pat
Hi,
I'm trying to clone a custom ref, avoiding the need to init && fetch
manually. From reading [1] which says:
"Set a configuration variable in the newly-created repository; this
takes effect immediately after the repository is initialized, but
before the remote history is fetched or any files c
hs
On Tue, May 2, 2017 at 9:05 AM, Jeff Hostetler wrote:
>
>
> On 5/2/2017 12:17 AM, Stefan Beller wrote:
>>
>> On Mon, May 1, 2017 at 6:36 PM, Junio C Hamano wrote:
>>>
>>> Stefan Beller writes:
>>>
This applies to origin/master.
For better readability and understandability for newc
Hi Liam,
On Tue, 2 May 2017, Liam Beguin wrote:
> On Tue, 2017-05-02 at 17:48 +0200, Johannes Schindelin wrote:
>
> > I offered a couple of comments, my biggest one probably being that
> > this patch series is crossing paths with my patch series that tries to
> > move more functionality out of t
On Wed, May 3, 2017 at 4:45 PM, Johannes Schindelin
wrote:
>> So it makes sense to give our downstream distributors a nudge to
>> switch over to it.
Some contributor (i.e. me) was not happy with this nudging though. The
other day I switched to some branch (probably 'pu') and the build
fai
On Wed, May 3, 2017 at 5:27 PM, Johannes Schindelin
wrote:
> Hi all,
>
> I have a problem and would like to solicit advice how to fix it.
>
> The untracked cache has made a real difference on rather large
> repositories with tons of directories, and it is really, really useful.
>
> But. One innocu
Hi all,
I have a problem and would like to solicit advice how to fix it.
The untracked cache has made a real difference on rather large
repositories with tons of directories, and it is really, really useful.
But. One innocuous `git reset --hard` will just blow it away.
How? reset_index() calls
On Tue, May 2, 2017 at 8:36 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> This applies to origin/master.
>>
>> For better readability and understandability for newcomers it is a good idea
>> to not offer 2 APIs doing the same thing with on being the #define of the
>> other.
>>
>> In the
On 3 May 2017 11:47, Johannes Schindelin wrote:
> On Tue, 2 May 2017, ankostis wrote:
>
>> On Windows, with Cygwin-git 02.12.2-1 the python command:
>> [...]
>
> You forgot to mention what python/pip you use (is it the Cygwin one, or a
> standalone one?). Intentional?
I have tested it on using Wi
We don't support config-as-a-directory (maybe someday we will?). Make
sure we consistently fail in this case, which should happen on platforms
where fopen() returns non-NULL if FREAD_READS_DIRECTORIES is
defined.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
t/t1308-config-set.sh | 9 +
1 file
In the first case, we already correctly return -1 if fopen() fails to
open. But we should report something so people know what's wrong.
In the second case, config_file == NULL does not necessarily mean "no
config file". Bail out if needed.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
config.c
Signed-off-by: Nguyễn Thái Ngọc Duy
---
server-info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server-info.c b/server-info.c
index f6c1a3dfb0..e01ac154a8 100644
--- a/server-info.c
+++ b/server-info.c
@@ -133,7 +133,7 @@ static int read_pack_info_file(const char *infofi
In the first case, we should have reported the reason fopen() fails. In
the second case, fclose() might change errno but we want to report
fopen() failure.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
rerere.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/rerere.c b/rerere.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
wt-status.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/wt-status.c b/wt-status.c
index 0375484962..cdf9f5eed2 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1065,7 +1065,8 @@ static void show_am_in_progress(struct wt_status *s,
s
Signed-off-by: Nguyễn Thái Ngọc Duy
---
xdiff-interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xdiff-interface.c b/xdiff-interface.c
index 060038c2d6..d3f78ca2a7 100644
--- a/xdiff-interface.c
+++ b/xdiff-interface.c
@@ -164,9 +164,9 @@ int read_mmfile(mmfile_t
Signed-off-by: Nguyễn Thái Ngọc Duy
---
rerere.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rerere.c b/rerere.c
index 3bd55caf3b..971bfedfb2 100644
--- a/rerere.c
+++ b/rerere.c
@@ -200,7 +200,7 @@ static struct rerere_id *new_rerere_id(unsigned char *sha1)
static void r
Signed-off-by: Nguyễn Thái Ngọc Duy
---
sequencer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index 10c3b4ff81..11b5c7c114 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -897,8 +897,8 @@ static void flush_rewritten_pending(void) {
There's plenty of error() in this code to safely assume --quiet is not a
concern.
t5512 needs update because if we check the path 'refs*master' (i.e. the
asterisk is part of the path) then we'll get an EINVAL error.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
remote.c | 4 ++--
t/t5512
1 - 100 of 121 matches
Mail list logo
