On Sat, Dec 31, 2016 at 06:30:01PM -0800, Junio C Hamano wrote:
> Michael Haggerty writes:
>
> > "refname" has already been checked by check_refname_format(), so it
> > cannot have consecutive slashes.
>
> In the endgame state, this has two callers. Both use what came in
> the transaction->upd
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hello!
I'm attempting to package Git for our new Linux distribution and I
have run in to a failure on our PowerPC builder while running the test
suite.
The PowerPC builder runs a tiny version of grep(1) that was not built
with PCRE. As such, grep
Michael Haggerty writes:
> + if (errno == ENOENT || errno == EISDIR) {
> + /*
> + * The logfile doesn't already exist,
> + * but that is not an error; it only
> +
Mike Hommey writes:
> So I now have:
>
> A---G
> \---B---C---D---E
> \---F
>
> If I do the dumb thing, which is to do `git rebase master E` and `git
> rebase master F`, I end up with:
>
> A---G---B'---C'---D'---E'
> \---B"---C"---D"---F'
>
What people seem to do is to teach the b
Jeff King writes:
> On Sat, Dec 31, 2016 at 04:12:40AM +0100, Michael Haggerty wrote:
>
>> This is a re-roll of an old patch series. v1 [1] got some feedback,
>> which I think was all addressed in v2 [2]. But it seems that v2 fell
>> on the floor, and I didn't bother following up because it was i
Michael Haggerty writes:
> "refname" has already been checked by check_refname_format(), so it
> cannot have consecutive slashes.
In the endgame state, this has two callers. Both use what came in
the transaction->updates[] array. Presumably "has already been
checked by check_refname_format()"
Michael Haggerty writes:
> This function doesn't do anything beyond call files_log_ref_write(), so
s/call/&ing/; I think.
> replace it with the latter at its call sites.
>
> Signed-off-by: Michael Haggerty
> ---
> refs/files-backend.c | 24 ++--
> 1 file changed, 10 insert
Michael Haggerty writes:
>> But presumably you mean that we delete "foo/bar/baz/xyzzy", etc, up to
>> "foo/bar/baz", provided they are all empty directories. I think your
>> comment is probably OK and I was just being thick, but maybe stating it
>> like:
>>
>> ...removes the directory if it is
Stefan Beller writes:
> The checkout state was introduced via 16da134b1f9
> (read-trees: refactor the unpack_trees() part, 2006-07-30). An attempt to
> refactor the checkout state was done in b56aa5b268e (unpack-trees: pass
> checkout state explicitly to check_updates(), 2016-09-13), but we can
>
Mike Hommey writes:
> Hi,
>
> So I was checking out differences between two branches, accounting for
> file moves with -C, and was surprised by the number of insertions and
> deletions that it indicated, because it was telling me I had removed
> more than I added, which I really don't think is tr
Stefan Beller writes:
> Every once in a while someone complains to the mailing list to have
> run into this weird assertion[1].
>
> The usual response from the mailing list is link to old discussions[2],
> and acknowledging the problem stating it is known.
>
> For now just improve the user visibl
Jeff King writes:
> On Wed, Dec 28, 2016 at 09:28:37AM -0800, Stefan Beller wrote:
> ...
>> 2 files changed, 1362 deletions(-)
>> delete mode 100755 contrib/gitview/gitview
>> delete mode 100644 contrib/gitview/gitview.txt
>
> Thanks for assembling the patch. This seems reasonable to me, thoug
Hi,
I've had this kind of things to do more than once, and had to do it a
lot today, so I figured it would be worth discussing whether git-rebase
should be enhanced to support this, or if this should go in a separate
tool or whatever.
So here is what I'm trying to do in a not-too painful way:
I'
Hi,
So I was checking out differences between two branches, accounting for
file moves with -C, and was surprised by the number of insertions and
deletions that it indicated, because it was telling me I had removed
more than I added, which I really don't think is true.
I took a closer look, and wh
On Sat, Dec 31, 2016 at 08:58:43AM +0100, Michael Haggerty wrote:
> > The return value is always "0" or "-1". It seems like it would be
> > simpler to just return the descriptor instead of 0.
> >
> > I guess that makes it hard to identify the case when we chose not to
> > create a descriptor. I w
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller
Signed-off-by: Pranit Bauva
---
t/t3510-cherry-pick-sequence.sh | 6 +++---
t/t5504-fetch-receive-strict.sh | 2 +-
t/t5516-fetch-push.sh| 2 +-
On Thu, Dec 15, 2016 at 09:58:43PM +1030, Pierre Dumuid wrote:
> A suggested name is provided when creating a new "following" branch.
>
> Signed-off-by: Pierre Dumuid
> ---
> gitk | 86
>
> 1 file changed, 82 insertions(+), 4
On Thu, Dec 15, 2016 at 09:58:42PM +1030, Pierre Dumuid wrote:
> It's a bit clunky but it works!!
>
> Usage:
> - mark commit one (e.g. v45)
> - Select commit two.
> - Switch the gdttype to the option, "git-cherry between marked commit and:"
This needs a better description. "Git-cherry between
On Thu, Dec 15, 2016 at 09:58:44PM +1030, Pierre Dumuid wrote:
> Signed-off-by: Pierre Dumuid
> ---
> gitk | 117
> +++
> 1 file changed, 117 insertions(+)
Nice idea in general... a few comments below. Also, please don't put
the e
Hey Stephan,
On Tue, Nov 22, 2016 at 3:05 AM, Stephan Beyer wrote:
> Hi Pranit,
>
> in this mail I review the "second part" of your patch: the transition of
> bisect_next and bisect_auto_next to C.
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/
Hey Stephan,
Extremely sorry I just forgot to reply to this email before. I was
preparing from the next iteration when I saw this.
On Mon, Nov 21, 2016 at 1:31 AM, Stephan Beyer wrote:
> Hi Pranit,
>
> this one is hard to review because you do two or three commits in one here.
> I think the firs
On 12/31/2016 07:35 AM, Jeff King wrote:
> On Sat, Dec 31, 2016 at 04:12:54AM +0100, Michael Haggerty wrote:
>
>> It's unnecessary to pass a strbuf holding the reflog path up and down
>> the call stack now that it is hardly needed by the callers. Remove the
>> places where log_ref_write_1() uses i
22 matches
Mail list logo
