Re: t6044 broken on pu

On 8 May 2016 at 20:20, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> May a simple >> printf "1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n" >> >> be an option ? > > If you were to do that, at least have the decency to make it more > readable by doing something like: > > printf "%s\n" 1 2

[PATCH v7 3/3] submodule: pass on http.extraheader config settings

To support this developer's use case of allowing build agents token-based access to private repositories, we introduced the http.extraheader feature, allowing extra HTTP headers to be sent along with every HTTP request. This patch allows us to configure these extra HTTP headers for use with `git s

[PATCH v7 0/3] Add support for sending additional HTTP headers (part 2)

My use case is an army of build agents that need only limited and selective access to otherwise private repositories. The first part already made it into `master`, this is the remainder. This iteration still has the specific patch to make `git -c http.extraHeader=... submodule update` work; I pla

[PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

To test that extra HTTP headers are passed correctly, t5551 verifies that a fetch succeeds when two required headers are passed, and that the fetch does not succeed when those headers are not passed. However, this test would also succeed if the configuration required only one header. As Apache's c

[PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Lars Schneider noticed that the configuration introduced to test the extra HTTP headers cannot be used with Apache 2.2 (which is still actively maintained, as pointed out by Junio Hamano). To let the tests pass with Apache 2.2 again, let's substitute the offending and `expr` by using old school R

Re: [PATCH v2] gitk: Fix missing commits when using -S or -G

Nice catch; however, we should only update numcommits if the commits are for the current view, i.e. if $v == $curview. Do you want to update the patch? If you prefer, I can update the patch and put a note in the commit message about the issue. Sure, feel free to update the patch as you see fit

Re: t6044 broken on pu

On 08.05.16 20:20, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> May a simple >> printf "1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n" >> >> be an option ? > If you were to do that, at least have the decency to make it more > readable by doing something like: > > printf "%s\n" 1 2 3 4 5 6

Re: [PATCH v2] gitk: Fix missing commits when using -S or -G

On Fri, May 06, 2016 at 02:16:54PM +0200, Stefan Dotterweich wrote: > When -S or -G is used as a filter option, the resulting commit list > rarely contains all matching commits. Only a certain number of commits > are displayed and the rest are missing. > > "git log --boundary -S" does not return a

Re: Re: [RFD/PATCH] submodule doc: describe where we can configure them

Hi, On Wed, May 04, 2016 at 02:13:47PM -0700, Junio C Hamano wrote: > Jonathan Nieder writes: > > > This design is somewhat problematic for a few reasons: > > > > - When I want to stop paying attention to a particular submodule and > > start paying attention to it again later, all my local set

Re: Re: [RFD/PATCH] submodule doc: describe where we can configure them

Hi, On Wed, May 04, 2016 at 01:50:24PM -0700, Stefan Beller wrote: > On Wed, May 4, 2016 at 8:01 AM, Heiko Voigt wrote: > > On Tue, May 03, 2016 at 05:59:58PM -0700, Stefan Beller wrote: > >> On Tue, May 3, 2016 at 4:56 PM, Jonathan Nieder wrote: > >> > Stefan Beller wrote: > >> > > >> >> This i

Re: [PATCH 78/83] Move libified code from builtin/apply.c to apply.{c,h}

On Fri, May 6, 2016 at 11:07 PM, Junio C Hamano wrote: > Christian Couder writes: > >> By the way does someone know how such a patch can be applied? > > I think in mid Feb 2015 I sent out a message that says "'diff -B -M' > gives a broken result, do not use it". > I do not have time to dig the ma

[PATCH] i18n: remote: add comment for translators

Add comment drawing translator attention in order to align "Push URL:" and "Fetch URL:" fields translation of git remote show output. Aligning both fields makes the output more appealing and easier to grasp. Signed-off-by: Vasco Almeida --- Translators, you can check if your translation does al

Re: [PATCH v16 0/7] config commit verbose

Ævar Arnfjörð Bjarmason writes: > I.e. I really expect --verbose to be a more verbose version of the > primary thing a command is doing, which in the case of "commit > --amend" is giving me info I need to modify the commit. That summarises what I wanted to say very well. Thanks. -- To unsubscri

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

Junio C Hamano writes: > What I had in mind was more a long the lines of this change. I only > did the first several just for illustration (I added an 'exit' to > mark where I stopped), but I think you get the idea. The point is > that by doing things in subprocess inside test_expect_success you

Re: Config for git-blame flags -w, -M, and -C?

> git config alias.bl "blame -w -M -C" Indeed, that would do the trick when interacting with git directly. However, I am interested in something that would provide a consistent git blame across all tools that integrate with git, such as GUI tools and editor integrations like Fugitive. -- To unsubs

Re: Force-with-lease and new branches

John Keeping writes: > It looks like this has been the case since the first version of what > would become --force-with-lease [1] and I can't find any discussion > around this particular behaviour in the three versions of that patch set > I found on Gmane [2], [3], [4]. I never considered the "c

Re: Config for git-blame flags -w, -M, and -C?

Joe Lencioni writes: > Thoughts? For end-user facing commands that are expected to be used by human typing on the keyboard, I'd recommend git config alias.bl "blame -w -M -C" instead. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord..

Re: t6044 broken on pu

Torsten Bögershausen writes: > May a simple > printf "1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n" > > be an option ? If you were to do that, at least have the decency to make it more readable by doing something like: printf "%s\n" 1 2 3 4 5 6 7 8 9 10 ;-) But as I said, as a response to "t6044

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

Mike Rappazzo writes: >> Instead of cleaning things up like this, could you please please >> please fix these existing tests that chdir around without being in a >> subshell? If the "previous tests" failed before going down as this >> step expects, the "cd .. && rm -r" can make things worse. >

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

On Sun, May 8, 2016 at 9:00 PM, Christian Couder wrote: > On Sun, May 8, 2016 at 9:17 AM, Pranit Bauva wrote: >> On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin >> wrote: >>> Hi Pranit, >>> >>> On Fri, 6 May 2016, Pranit Bauva wrote: >>> diff --git a/builtin/bisect--helper.c b/builtin/

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

On Sun, May 8, 2016 at 9:17 AM, Pranit Bauva wrote: > On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin > wrote: >> Hi Pranit, >> >> On Fri, 6 May 2016, Pranit Bauva wrote: >> >>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c >>> index 3324229..d8de651 100644 >>> --- a/built

Re: [PATCH v5 0/2] bisect--helper: rewrite of check-term-format()

On Sun, May 8, 2016 at 11:53 AM, Pranit Bauva wrote: > On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote: >> Pranit Bauva writes: >> >>> I completely missed your point and you want me to go the Eric Sunshine's >>> way? >> >> I am neutral. >> >> When I read your response to Eric's "top down"

Draft of Git Rev News edition 15

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-15.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

[GSOC update] Week 1

My public git.git is available here[1]. I regularly keep pushing my work so anyone interested can track me there. Feel free to participate in the discussions going on PRs with my mentors. Your comments are valuable. The things I was able to do: * Finish off with my micro project[2] about adding

[PATCH 1/5] git-gui i18n: mark strings for translation

Mark strings for translation in lib/index.tcl that were seemingly left behind by 700e560 ("git-gui: Mark forgotten strings for translation.", 2008-09-04) which marks string in do_revert_selection procedure. These strings are passed to unstage_help and add_helper procedures. Signed-off-by: Vasco Al

[PATCH 4/5] git-gui: fix incorrect use of Tcl append command

Fix wrong use of append command in strings marked for translation. According to Tcl/Tk Documentation [1], append varName ?value value value ...? appends all value arguments to the current value of variable varName. This means that append "[appname] ([reponame]): " [mc "File Viewer"]

[PATCH 3/5] git-gui i18n: mark "usage:" strings for translation

Mark command-line "usage:" string for translation in git-gui.sh. Signed-off-by: Vasco Almeida --- git-gui.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-gui.sh b/git-gui.sh index 11048c7..4ae344f 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -3007,7 +3007,7 @@ bind

[PATCH 5/5] git-gui i18n: mark string in lib/error.tcl for translation

Mark string "$hook hook failed:" in lib/error.tcl for translation. Signed-off-by: Vasco Almeida --- lib/error.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/error.tcl b/lib/error.tcl index 71dc860..8968a57 100644 --- a/lib/error.tcl +++ b/lib/error.tcl @@ -77,7 +77,7

[PATCH 2/5] git-gui i18n: internationalize use of colon punctuation

Internationalize use of colon punctuation ':' in options window, windows titles, database statistics window. Some languages might use a different style, for instance French uses "User Name :" (space before colon). Signed-off-by: Vasco Almeida --- lib/branch_delete.tcl | 2 +- lib/database.tcl

Re: [PATCH 80/83] run-command: make dup_devnull() non static

On Sun, May 8, 2016 at 1:33 PM, Johannes Schindelin wrote: > The claim is that this libifies the procedure. But it makes the code > really nasty for use as a library: if this is run in a thread (and you > know that we are going to have to do this in the near future, for > performance reasons), it

Re: [PATCH v8 18/19] Add tracing to measure where most of the time is spent

On Fri, May 6, 2016 at 5:48 AM, Junio C Hamano wrote: > David Turner writes: > >> From: Nguyễn Thái Ngọc Duy >> Subject: Re: [PATCH v8 18/19] Add tracing to measure where most of the time >> is spent > > trace: measure where the time is spent in the index-heavy operations Right. All these inv

[PATCH v3 39/41] upload-pack.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- upload-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index dc802a0..f19444d 100644 --- a/upload-pack.c +++ b/upload-pack.c @@ -174,8 +174,7 @@ static void create_pack_file(void)

[PATCH v3 35/41] server-info.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- server-info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server-info.c b/server-info.c index 5a86e29..75dd677 100644 --- a/server-info.c +++ b/server-info.c @@ -36,7 +36,7 @@ static int update_info_file(char *path, int (*generate)(F

Re: [PATCH] Move test-* to t/helper/ subdirectory

So among the options we have so far, which way should we go, or leave it as is? On Tue, May 3, 2016 at 7:15 AM, Duy Nguyen wrote: > On Tue, May 3, 2016 at 12:34 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> I may have rushed to judgement. wrap-for-bin.sh has always been the >>> depende

[PATCH v3 38/41] unpack-trees.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- unpack-trees.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/unpack-trees.c b/unpack-trees.c index 9f55cc2..bb0d142 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -1499,8 +1499,7 @@ static int verify_absent_1(const struct ca

[PATCH v3 37/41] transport-helper.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- transport-helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index b934183..f09fadc 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -1166,7 +1166,7 @@ static int udt_do_read

[PATCH v3 36/41] sha1_file.c: use {error,die,warning}_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1_file.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index d0f2aa0..a7f45b3 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1107,9 +1107,8 @@ unsigned char *use_pack(stru

[PATCH v3 40/41] vcs-svn: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- vcs-svn/line_buffer.c| 4 ++-- vcs-svn/sliding_window.c | 2 +- vcs-svn/svndiff.c| 4 ++-- vcs-svn/svndump.c| 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/vcs-svn/line_buffer.c b/vcs-svn/line_buffer.c index 57cc

[PATCH v3 41/41] wrapper.c: use warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- wrapper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wrapper.c b/wrapper.c index 9afc1a0..3df2fe0 100644 --- a/wrapper.c +++ b/wrapper.c @@ -572,7 +572,7 @@ static int warn_if_unremovable(const char *op, const char *file, int r

[PATCH v3 29/41] ident.c: use warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- ident.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ident.c b/ident.c index 4fd82d1..139c528 100644 --- a/ident.c +++ b/ident.c @@ -75,14 +75,12 @@ static int add_mailname_host(struct strbuf *buf) mailname = fopen("/e

[PATCH v3 30/41] mailmap.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- mailmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mailmap.c b/mailmap.c index 9726237..b5c521f 100644 --- a/mailmap.c +++ b/mailmap.c @@ -189,8 +189,7 @@ static int read_mailmap_file(struct string_list *map, const char *filena

[PATCH v3 25/41] fast-import.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- fast-import.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fast-import.c b/fast-import.c index 9fc7093..21881d1 100644 --- a/fast-import.c +++ b/fast-import.c @@ -414,7 +414,7 @@ static void write_crash_report(const char *e

[PATCH v3 34/41] sequencer.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sequencer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sequencer.c b/sequencer.c index e66f2fe..4687ad4 100644 --- a/sequencer.c +++ b/sequencer.c @@ -875,8 +875,7 @@ static int sequencer_rollback(struct replay_opts *opts)

[PATCH v3 31/41] reachable.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- reachable.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/reachable.c b/reachable.c index ed35201..d0199ca 100644 --- a/reachable.c +++ b/reachable.c @@ -119,8 +119,7 @@ static int add_recent_loose(const unsigned char *sha1,

[PATCH v3 26/41] gpg-interface.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- gpg-interface.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gpg-interface.c b/gpg-interface.c index 2259938..c4b1e8c 100644 --- a/gpg-interface.c +++ b/gpg-interface.c @@ -219,11 +219,9 @@ int verify_signed_buffer(const char *p

[PATCH v3 27/41] grep.c: use error_errno()

While at there, improve the error message a bit (what operation failed?) Signed-off-by: Nguyễn Thái Ngọc Duy --- grep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grep.c b/grep.c index 528b652..ec6f7ff 100644 --- a/grep.c +++ b/grep.c @@ -1732,7 +1732,7 @@ static int

[PATCH v3 24/41] entry.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- entry.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/entry.c b/entry.c index a410957..519e042 100644 --- a/entry.c +++ b/entry.c @@ -168,8 +168,8 @@ static int write_entry(struct cache_entry *ce, ret

[PATCH v3 32/41] rerere.c: use error_errno() and warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- rerere.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/rerere.c b/rerere.c index c8b9f40..1810c04 100644 --- a/rerere.c +++ b/rerere.c @@ -501,8 +501,7 @@ static int handle_file(const char *path, unsigned char *sha

[PATCH v3 33/41] run-command.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- run-command.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/run-command.c b/run-command.c index e4593cd..842c8d1 100644 --- a/run-command.c +++ b/run-command.c @@ -233,7 +233,7 @@ static int wait_or_whine(pid_t pid, con

[PATCH v3 28/41] http.c: use error_errno() and warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- http.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/http.c b/http.c index 4304b80..7565c93 100644 --- a/http.c +++ b/http.c @@ -446,8 +446,7 @@ static int sockopt_callback(void *client, curl_socket_t fd, curlsocktype type)

[PATCH v3 23/41] editor.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- editor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/editor.c b/editor.c index 01c644c..7519ede 100644 --- a/editor.c +++ b/editor.c @@ -63,7 +63,6 @@ int launch_editor(const char *path, struct strbuf *buffer, const char *const *e

[PATCH v3 18/41] config.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- config.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/config.c b/config.c index 10b5c95..80411e4 100644 --- a/config.c +++ b/config.c @@ -2012,7 +2012,7 @@ int git_config_set_multivar_in_file_gently(const char

[PATCH v3 16/41] combine-diff.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- combine-diff.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/combine-diff.c b/combine-diff.c index 0e1d4b0..8f2313d 100644 --- a/combine-diff.c +++ b/combine-diff.c @@ -1005,8 +1005,7 @@ static void show_patch_diff(struct combine_dif

[PATCH v3 22/41] diff-no-index.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- diff-no-index.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 03daadb..1f8999b 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -65,8 +65,7 @@ static int populate_from_stdin(struct diff_fi

[PATCH v3 17/41] compat/win32/syslog.c: use warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- compat/win32/syslog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compat/win32/syslog.c b/compat/win32/syslog.c index b905aea..6c7c9b6 100644 --- a/compat/win32/syslog.c +++ b/compat/win32/syslog.c @@ -28,13 +28,13 @@ void sysl

[PATCH v3 21/41] credential-cache--daemon.c: use warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- credential-cache--daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c index 291c0fd..1f14d56 100644 --- a/credential-cache--daemon.c +++ b/credential-cache--daemon.c @@ -17

[PATCH v3 19/41] connected.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- connected.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/connected.c b/connected.c index 299c560..bf1b12e 100644 --- a/connected.c +++ b/connected.c @@ -86,17 +86,14 @@ static int check_everything_connected_real(sha1_iterate_

[PATCH v3 20/41] copy.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- copy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/copy.c b/copy.c index 574fa1f..4de6a11 100644 --- a/copy.c +++ b/copy.c @@ -42,15 +42,15 @@ int copy_file(const char *dst, const char *src, int mode) status = copy_fd(f

[PATCH v3 10/41] builtin/pack-objects.c: use die_errno() and warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/pack-objects.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index a27de5b..1145747 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -828,8 +828,7 @@ stat

[PATCH v3 15/41] check-racy.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- check-racy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check-racy.c b/check-racy.c index 00d92a1..24b6542 100644 --- a/check-racy.c +++ b/check-racy.c @@ -12,7 +12,7 @@ int main(int ac, char **av) struct stat st;

[PATCH v3 09/41] builtin/merge-file.c: use error_errno()

All these error() calls do not print error message previously, but because when they are called, errno should be set. Use error_errno() instead to give more information. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/merge-file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH v3 08/41] builtin/mailsplit.c: use error_errno()

There's one change, in split_mbox(), where an error() without strerror() as argument is converted to error_errno(). This is correct because the previous call is fopen (not shown in the context lines), which should set errno if it returns NULL. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/mail

[PATCH v3 14/41] builtin/worktree.c: use error_errno()

While at there, improve the error message to say _what_ failed to remove. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/worktree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/worktree.c b/builtin/worktree.c index d8e3795..331ecf6 100644 --- a/builtin/worktree.c

[PATCH v3 07/41] builtin/help.c: use warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/help.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/help.c b/builtin/help.c index 3c55ce4..8848013 100644 --- a/builtin/help.c +++ b/builtin/help.c @@ -127,7 +127,7 @@ static void exec_woman_emacs(const char *p

[PATCH v3 12/41] builtin/update-index.c: prefer "err" to "errno" in process_lstat_error

"errno" is already passed in as "err". Here we should use err instead of errno. errno is probably a copy/paste mistake in e011054 (Teach git-update-index about gitlinks - 2007-04-12) Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/update-index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 13/41] builtin/upload-archive.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/upload-archive.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/upload-archive.c b/builtin/upload-archive.c index dbfe14f..2caedf1 100644 --- a/builtin/upload-archive.c +++ b/builtin/upload-archive.c @@ -104,8 +104,7 @

[PATCH v3 11/41] builtin/rm.c: use warning_errno()

While at there, improve the message a bit (what operation failed?) and mark it for translation since the format string is now a sentence. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/rm.c b/builtin/rm.c index 882

[PATCH v3 04/41] builtin/am.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/am.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/builtin/am.c b/builtin/am.c index d003939..3dfe70b 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -769,15 +769,15 @@ static int split_mail_conv(mail_conv_fn fn, st

[PATCH v3 05/41] builtin/branch.c: use error_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/branch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/branch.c b/builtin/branch.c index 0adba62..6f1572d 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -593,8 +593,7 @@ static int edit_branch_description(con

[PATCH v3 03/41] bisect.c: use die_errno() and warning_errno()

Signed-off-by: Nguyễn Thái Ngọc Duy --- bisect.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/bisect.c b/bisect.c index 7996c29..6d93edb 100644 --- a/bisect.c +++ b/bisect.c @@ -860,8 +860,8 @@ static void check_good_are_ancestors_of_bad(const char *prefix, int no_c

[PATCH v3 00/41] Add and use error_errno() and warning_errno()

Code changes compared to v2 is below (one incorrect conversion reverted, two error message improvements). Other changes are text in these commits, not shown as diff in this mail: [06/41] builtin/fetch.c: use error_errno() [08/41] builtin/mailsplit.c: use error_errno() [09/41] builtin/merge-f

[PATCH v3 06/41] builtin/fetch.c: use error_errno()

A couple of newlines are also removed, because both error() and error_errno() automatically append a newline. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/fetch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/fetch.c b/builtin/fetch.c index f8455bd..1582ca7 1

[PATCH v3 02/41] usage.c: add warning_errno() and error_errno()

Similar to die_errno(), these functions will append strerror() automatically. Signed-off-by: Nguyễn Thái Ngọc Duy --- git-compat-util.h | 2 ++ usage.c | 21 + 2 files changed, 23 insertions(+) diff --git a/git-compat-util.h b/git-compat-util.h index 1f8b5f3..49d4

[PATCH v3 01/41] usage.c: move format processing out of die_errno()

fmt_with_err() will be shared with the coming error_errno() and warning_errno(). Signed-off-by: Nguyễn Thái Ngọc Duy --- usage.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/usage.c b/usage.c index 82ff131..8675d72 100644 --- a/usage.c +++ b/u

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

On Sun, May 8, 2016 at 12:34 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Fri, 6 May 2016, Pranit Bauva wrote: > >> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c >> index 3324229..d8de651 100644 >> --- a/builtin/bisect--helper.c >> +++ b/builtin/bisect--helper.c >> @@ -8,1

Re: [PATCH v5 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

Hi Pranit, On Fri, 6 May 2016, Pranit Bauva wrote: > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index 3324229..d8de651 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -8,13 +8,17 @@ static const char * const git_bisect_helper_usage[] = { >