On 08.05.16 04:21, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> That's true, but the test passes anyway.
> You can also remove the body of the test and replace it with "true"
> and say "the test passes anyway". Changing the test to use a file
> with only one line is irresponsible, if
Hi Chris,
On Wed, 4 May 2016, Christian Couder wrote:
> On Wed, May 4, 2016 at 4:56 PM, Johannes Schindelin
> wrote:
> >
> > On Wed, 4 May 2016, Christian Couder wrote:
> >
> >> My intent was to try to show that there is some important value to make
> >> the subject close to the "low level" thin
Hi Chris,
On Sat, 7 May 2016, Christian Couder wrote:
> On Sat, May 7, 2016 at 2:13 PM, Johannes Schindelin
> wrote:
> >
> > On Sat, 7 May 2016, Christian Couder wrote:
> >
> >> On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin
> >> wrote:
> >> >
> >> > No, you should change the code that req
On Sun, May 8, 2016 at 7:55 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> I completely missed your point and you want me to go the Eric Sunshine's way?
>
> I am neutral.
>
> When I read your response to Eric's "top down" suggestion, I didn't
> quite get much more than "I started going thi
Pranit Bauva writes:
> I completely missed your point and you want me to go the Eric Sunshine's way?
I am neutral.
When I read your response to Eric's "top down" suggestion, I didn't
quite get much more than "I started going this way, and I do not
want to change to the other direction.", which
Torsten Bögershausen writes:
> That's true, but the test passes anyway.
You can also remove the body of the test and replace it with "true"
and say "the test passes anyway". Changing the test to use a file
with only one line is irresponsible, if you do not know the nature
of expected future bug
Christian Couder wrote:
> Signed-off-by: Christian Couder
Thanks Christian,
Signed-off-by: Eric Wong
...And pushed to my svn/bad-ref branch for Junio.
(I don't think I'll have other git-svn-related changes
immediately pending)
The following changes since commit 63a35025b11bf0e7ef39693aeea3b6
On Sat, May 7, 2016 at 7:32 AM, Jeff King wrote:
> On Fri, May 06, 2016 at 08:33:15AM -0700, Junio C Hamano wrote:
>
>> > Then I replied:
>> >
>> >However, that doesn't mean that we have to spread this badly chosen
>> >name from options to config variables, does it? I think that if we
>>
I've noticed a slightly annoying behaviour of git-push's
--force-with-lease option around branch creation.
I'd like to be able to do:
git push --force-with-lease origin refs/heads/jk/*
to push out a load of topic branches safely in case I've switched client
machines and forgotten to pull
git-blame has a few options are useful when working with commits that
only modify whitespace (-w), move code within the file (-M), or move
code between files (-C). It would be nice if there was a way to
configure git so these options could be enabled by default when
running `git blame`.
I suppose
On 2016-05-07 14.19, Andreas Schwab wrote:
> Torsten Bögershausen writes:
>
>> The "seq" is not understood by all shells,
>> using printf fixes this,
>>
>> index 20a3ffe..48d964e 100755
>> --- a/t/t6044-merge-unrelated-index-changes.sh
>> +++ b/t/t6044-merge-unrelated-index-changes.sh
>> @@ -20,7
These tests fail here under Mac OS,
they pass under Linux:
commit ff3d9b660a4b6e9d3eeb664ce1febe717adff737
I haven't had a chance to dig further.
expecting success:
git for-each-ref --format="%(if)%(authorname)%(then)%(authorname):
%(refname)%(end)" >actual &&
cat >expect <<-\EOF
Good job.Cleaner now.
I found these typos by aspell, and duplicate words by grep -rnIE
'\b(\w+)\s+\1\b' :)
Thanks!
--
发件人：Junio C Hamano
发送时间：2016年5月7日(星期六) 02:30
收件人：李三0159
抄 送：Jeff King ; git
主 题：Re: [PATCH] utf8: fix duplica
Quoting Junio C Hamano :
SZEDER Gábor writes:
Arguably this helper function could be just a simple variable. I
opted for a function because:
- I preferred a single '#ifdef NO_POSIX_GOODIES', and putting a
static variable so near to EOF felt just wrong. (And this is why
it's not
Hi Dscho,
On Sat, May 7, 2016 at 2:13 PM, Johannes Schindelin
wrote:
> Hi Chris,
>
> On Sat, 7 May 2016, Christian Couder wrote:
>
>> On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin
>> wrote:
>> >
>> > No, you should change the code that requires that ugly dup()ing so that it
>> > can be con
On 07/05/16 14:15, Ramsay Jones wrote:
>
>
> On 07/05/16 13:19, Andreas Schwab wrote:
>> Torsten Bögershausen writes:
>>
>>> The "seq" is not understood by all shells,
>>> using printf fixes this,
>>>
>>> index 20a3ffe..48d964e 100755
>>> --- a/t/t6044-merge-unrelated-index-changes.sh
>>> +++
On Fri, May 6, 2016 at 6:10 PM, Junio C Hamano wrote:
> Michael Rappazzo writes:
>
>> t1500-rev-parse contains envrionment leaks (changing dir without
>> changing back, setting config variables, etc). Add a test to clean this
>> up up so that future tests can be added without worry of any settin
On 07/05/16 13:19, Andreas Schwab wrote:
> Torsten Bögershausen writes:
>
>> The "seq" is not understood by all shells,
>> using printf fixes this,
>>
>> index 20a3ffe..48d964e 100755
>> --- a/t/t6044-merge-unrelated-index-changes.sh
>> +++ b/t/t6044-merge-unrelated-index-changes.sh
>> @@ -20,7
On Sat, May 7, 2016 at 3:45 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> A very interesting fact to note:
>> I made a mistake by dropping of the first argument 'term' in the function
>> one_of() and compiled and the test suite passed fully (which was pointed
>> out by Christian). This sh
Torsten Bögershausen writes:
> The "seq" is not understood by all shells,
> using printf fixes this,
>
> index 20a3ffe..48d964e 100755
> --- a/t/t6044-merge-unrelated-index-changes.sh
> +++ b/t/t6044-merge-unrelated-index-changes.sh
> @@ -20,7 +20,7 @@ test_description="merges with unrelated inde
Hi Chris,
On Sat, 7 May 2016, Christian Couder wrote:
> On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin
> wrote:
> >
> > On Fri, 6 May 2016, Christian Couder wrote:
> >
> >> On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote:
> >> > Am 05.05.2016 um 11:50 schrieb Christian Couder:
> >> >>
The "seq" is not understood by all shells,
using printf fixes this,
index 20a3ffe..48d964e 100755
--- a/t/t6044-merge-unrelated-index-changes.sh
+++ b/t/t6044-merge-unrelated-index-changes.sh
@@ -20,7 +20,7 @@ test_description="merges with unrelated index changes"
# Commit E: renames a->subdir/
Hi Dscho,
On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin
wrote:
> Hi Chris,
>
> On Fri, 6 May 2016, Christian Couder wrote:
>
>> On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote:
>> > Am 05.05.2016 um 11:50 schrieb Christian Couder:
>> >>
>> >> On Mon, Apr 25, 2016 at 5:05 PM, Johannes
On Sat, May 7, 2016 at 2:18 AM, Stefan Beller wrote:
> On Fri, May 6, 2016 at 12:02 PM, Junio C Hamano wrote:
>> Stefan Beller writes:
>>
>>> On Fri, May 6, 2016 at 3:30 AM, Duy Nguyen wrote:
On Fri, May 6, 2016 at 6:27 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>>>
On Fri, May 6, 2016 at 5:31 PM, Thierry Suzanne wrote:
> Sorry, can't help :(
I just sent a patch. It would be nice if you could test it to confirm
that you get a nicer error message.
Also please reply below other people's comments, as customary on this list.
--
To unsubscribe from this list: se
25 matches
Mail list logo
