Re: [question] && chaining vs shell loops

2015-03-29 Thread Max Kirillov
On Sun, Mar 29, 2015 at 8:43 PM, Jeff King wrote: > In our test scripts, it is also OK to just "return 1", because > the test snippets execute inside a function. Thanks, sounds like a plan. -- Max -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majo

Re: [PATCH] t9814: Guarantee only one source exists in git-p4 copy tests

2015-03-29 Thread Junio C Hamano
Vitor Antunes writes: > * Modify source file (file2) before copying the file. > * Check that only file2 is the source in the output of "p4 filelog". > * Remove all "case" statements and replace them simple tests to check that > source is "file2". > > Signed-off-by: Vitor Antunes > --- I am no

[PATCH] t9814: Guarantee only one source exists in git-p4 copy tests

2015-03-29 Thread Vitor Antunes
* Modify source file (file2) before copying the file. * Check that only file2 is the source in the output of "p4 filelog". * Remove all "case" statements and replace them simple tests to check that source is "file2". Signed-off-by: Vitor Antunes --- t/t9814-git-p4-rename.sh | 46

[PATCH v2] parse-options: fix the description of defval

2015-03-29 Thread Ivan Ukhov
OPTION_BIT and OPTION_SET_INT do not store pointers in defval. Signed-off-by: Ivan Ukhov --- parse-options.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/parse-options.h b/parse-options.h index 7940bc7..c71e9da 100644 --- a/parse-options.h +++ b/parse-options.h @@ -95,8

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Junio C Hamano
Ivan Ukhov writes: > Hello Junio, > > > Yes, actually my intention to fix that comment was solely based on its > content. I saw that the elements in the first set, {BIT,SET_INT}, did > not match the elements in the second, {mask,integer,pointer}. Then I > found that commit removing OPT_SET_PTR, a

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Ivan Ukhov
Hello Junio, Yes, actually my intention to fix that comment was solely based on its content. I saw that the elements in the first set, {BIT,SET_INT}, did not match the elements in the second, {mask,integer,pointer}. Then I found that commit removing OPT_SET_PTR, and “pointer” seemed to be a le

Re: [question] && chaining vs shell loops

2015-03-29 Thread Jeff King
On Sun, Mar 29, 2015 at 06:07:39PM +0200, Andreas Schwab wrote: > Max Kirillov writes: > > > As far as I can see, loops in shell ignore non-zero exit > > codes of the bodies which are not last. For example, exit > > code of command 'for f in false true; do $f; done' is 0, > > even if there was f

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Junio C Hamano
Paul Tan writes: > On Sun, Mar 29, 2015 at 4:32 PM, Ivan Ukhov wrote: >> Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. >> > > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING > and OPTION_FILENAME. Since we are on the topic of updating the > docum

Re: [question] && chaining vs shell loops

2015-03-29 Thread Andreas Schwab
Max Kirillov writes: > As far as I can see, loops in shell ignore non-zero exit > codes of the bodies which are not last. For example, exit > code of command 'for f in false true; do $f; done' is 0, > even if there was false. There is nothing special with loops, that's how the exit code of compo

[question] && chaining vs shell loops

2015-03-29 Thread Max Kirillov
Hi. As far as I can see, loops in shell ignore non-zero exit codes of the bodies which are not last. For example, exit code of command 'for f in false true; do $f; done' is 0, even if there was false. How should one workaround it in test scripts, is there any established approach? -- Max -- To

Re: [PATCH] l10n: de.po: translate 99 new messages

2015-03-29 Thread Phillip Sz
Hi, > #: builtin/apply.c:3238 > -#, fuzzy, c-format > +#, c-format > msgid "reading from '%s' beyond a symbolic link" > -msgstr "Pfadspezifikation '%s' ist hinter einem symbolischen Verweis" > +msgstr "Lese von '%s' hinter einem symbolischen Verweis" "Lese von '%s', welches sich hinter einem sy

[PATCH] commit: add -f to force creation when no changes or an empty message

2015-03-29 Thread Ivan Ukhov
An attempt to commit gets rejected if there are no changes staged or there is no message given. In such a case, the --allow-empty and --allow-empty-message flags can be used to force the action. The standard approach to force an action, however, is the -f/--force flag, as used in other built-ins.

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Ivan Ukhov
Hello Paul, Yes, you are right. Thank you for the clarification! Regards, Ivan > On Mar 29, 2015, at 3:27 PM, Paul Tan wrote: > > Hi, > > On Sun, Mar 29, 2015 at 5:28 PM, Ivan Ukhov wrote: >> I have checked the definitions of the three macros you mentioned, and it >> seems that none of th

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Paul Tan
Hi, On Sun, Mar 29, 2015 at 5:28 PM, Ivan Ukhov wrote: > I have checked the definitions of the three macros you mentioned, and it > seems that none of them uses defval to store pointers. OPTION_CMDMODE stores > chars and integers. OPTION_STRING does not use defval at all (pointers go in > a di

Re: how to make "full" copy of a repo

2015-03-29 Thread Kevin D
On Sun, Mar 29, 2015 at 04:21:26AM +0200, Christoph Anton Mitterer wrote: > On Sat, 2015-03-28 at 15:31 +0100, Kevin D wrote: > [..] > > > * reflog (history of refs, though, by default disabled for bare > > repositories) > is there a way to get this copied? > > No, the reflog is considered s

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Ivan Ukhov
Hello Paul, > On Mar 29, 2015, at 11:08 AM, Paul Tan wrote: > > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING > and OPTION_FILENAME. I have checked the definitions of the three macros you mentioned, and it seems that none of them uses defval to store pointers. OPTION_CM

Re: [PATCH] parse-options: fix the description of defval

2015-03-29 Thread Paul Tan
Hi, On Sun, Mar 29, 2015 at 4:32 PM, Ivan Ukhov wrote: > Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING and OPTION_FILENAME. Since we are on the topic of updating the documentation, I think it woul

[PATCH] parse-options: fix the description of defval

2015-03-29 Thread Ivan Ukhov
Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. Signed-off-by: Ivan Ukhov --- parse-options.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/parse-options.h b/parse-options.h index 7940bc7..c71e9da 100644 --- a/parse-options.h +++ b/parse-options

Re: Change default branch name (server side) while cloning a repository

2015-03-29 Thread Gaurav Chhabra
@Stefan: Thanks for letting me know the version you tried on. I have the following: Gitolite version: gitolite3 v3.04-13-gcc9727c-dt on git 1.7.1 Git server version: git version 1.7.1 Git client version: git version 1.9.4.msysgit.2 My Git server version lags quite behind compared to yours. :) Clo