Re: [PATCH 0/2] fix git-archive with empty trees

2013-03-10 Thread Junio C Hamano
Jeff King writes: > On Sun, Mar 10, 2013 at 09:31:24PM -0400, Jeff King wrote: > >> I noticed that "git archive" will barf when the root tree is empty. >> [...] >> I didn't bother even looking at empty subtrees. AFAIK, git should never >> produce them (it omits the tree entirely if there is no co

Re: Memory corruption when rebasing with git version 1.8.1.5 on arch

2013-03-10 Thread Jeff King
On Sun, Mar 10, 2013 at 12:45:43PM +0100, Bernhard Posselt wrote: > > valgrind -q --trace-children=yes --log-file=/tmp/valgrind.out \ > > git pull --rebase https://github.com/Raydiation/core > > The log file was empty and it seemed to apply everything nice when > running valgrind. When i tr

Re: [PATCH v2 05/23] contrib/subtree: Add commands pull_all and push_all

2013-03-10 Thread Junio C Hamano
Paul Campbell writes: > From: bibendi > > For each subtree listed in .gittrees perform a push or a pull. > > Signed-off-by: Paul Campbell > > Conflicts: > contrib/subtree/git-subtree.sh The "Conflicts:" part is totally irrelevant. Please remove. > --- > contrib/subtree/git-subtree.sh

Re: [PATCH 0/2] fix git-archive with empty trees

2013-03-10 Thread Jeff King
On Sun, Mar 10, 2013 at 09:31:24PM -0400, Jeff King wrote: > I noticed that "git archive" will barf when the root tree is empty. > [...] > I didn't bother even looking at empty subtrees. AFAIK, git should never > produce them (it omits the tree entirely if there is no content in it). > You would h

Re: [PATCH v2 04/23] contrib/subtree: Teach push and pull to use .gittrees for defaults

2013-03-10 Thread Junio C Hamano
> From: bibendi > > Look in the config file .gittrees for a default repository and > refspec or commit when they are not provided on the command line. > > Uses the .gittrees config file in a similar way to how git-submodule > uses the .gitmodules file. What the patch does can be read from the cod

Re: [PATCH v2 03/23] contrib/subtree: Teach add to store repository & branch in .gittrees

2013-03-10 Thread Junio C Hamano
Paul Campbell writes: > From: Matt Hoffman > > The repository and branch of a subtree added with the add command is > stored in the .gittrees file. > > Signed-off-by: Paul Campbell > --- > contrib/subtree/git-subtree.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/contrib/s

Re: [PATCH v2 02/23] contrib/subtree: Add command from-submodule

2013-03-10 Thread Junio C Hamano
Paul Campbell writes: > @@ -721,4 +722,31 @@ cmd_push() > fi > } > > +cmd_from-submodule() > +{ I know contrib/subtree does not work with anything other than bash, and bash may accept this as a valid function name, but if you can avoid it easily I would prefer not to see a non-POSIX con

Re: [PATCH/RFC] Make help behaviour more consistent

2013-03-10 Thread Junio C Hamano
Kevin Bracey writes: > Previously, the command "help" and the option "-h" behaved differently > depending on whether a command was specified or not. Old user interface: > > Commands with no defaults show usage: "git" "git CMD" > To specifically request usage:"git help" "git

[PATCH 2/2] archive: handle commits with an empty tree

2013-03-10 Thread Jeff King
git-archive relies on get_pathspec to convert its argv into a list of pathspecs. When get_pathspec is given an empty argv list, it returns a single pathspec, the empty string, to indicate that everything matches. When we feed this to our path_exists function, we typically see that the pathspec turn

[PATCH 1/2] test-lib: factor out $GIT_UNZIP setup

2013-03-10 Thread Jeff King
We set up the $GIT_UNZIP variable and lazy prereq in multiple places (and the next patch is about to add another one). Let's factor it out to avoid repeating ourselves. Signed-off-by: Jeff King --- t/t0024-crlf-archive.sh | 6 -- t/t5003-archive-zip.sh | 6 -- t/test-lib.sh |

[PATCH 0/2] fix git-archive with empty trees

2013-03-10 Thread Jeff King
I noticed that "git archive" will barf when the root tree is empty. Instead, it should probably return an empty archive. I doubt many people really care about this corner case in practice, but it seems like we should handle it more gracefully (and it's an easy fix). It came to my attention because

Re: [PATCH/RFC] Make help behaviour more consistent

2013-03-10 Thread Philip Oakley
On 10/03/13 17:48, Kevin Bracey wrote: Previously, the command "help" and the option "-h" behaved differently depending on whether a command was specified or not. Old user interface: Commands with no defaults show usage: "git" "git CMD" To specifically request usage:"git help"

[PATCH v2 23/23] contrib/subtree: Fix order of case switches so default case is last

2013-03-10 Thread Paul Campbell
Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index aaee6ae..fb6f044 100755 --- a/contrib/subtree/git-subtree.sh +++ b/contrib/subtree/git-subt

[PATCH v2 21/23] contrib/subtree: Convert spaces to tabs and remove some trailing whitespace

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell Conflicts: contrib/subtree/.gitignore contrib/subtree/git-subtree.sh contrib/subtree/test.sh --- It's a nasty formatting only patch and I won't be surprised or too dissappiointed if this doesn't make it. Or are the rul

[PATCH v2 22/23] contrib/subtree: Parameters repository/branch for push/pull are optional

2013-03-10 Thread Paul Campbell
Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 263ea9f..aaee6ae 100755 --- a/contrib/subtree/git-subtree.sh +++ b/contrib/subtree/git-subt

[PATCH v2 19/23] contrib/subtree: Document list command

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 1 + contrib/subtree/git-subtree.txt | 4 2 files changed, 5 insertions(+) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 84c90c7

[PATCH v2 20/23] contrib/subtree: Teach push to use --force option

2013-03-10 Thread Paul Campbell
From: James Roper Signed-off-by: Paul Campbell Conflicts: contrib/subtree/git-subtree.sh Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 9 - contrib/subtree/git-subtree.txt | 5 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/contrib/s

[PATCH v2 18/23] contrib/subtree: Add missing commands to SYNOPSIS

2013-03-10 Thread Paul Campbell
From: Herman van Rink Add pull-all, push-all, from-submodule, prune and diff commands to SYNOPSIS. Add alternate parameter option for add command. Use long-form option for specifying prefix. Signed-off-by: Paul Campbell Conflicts: contrib/subtree/git-subtree.txt --- contrib/subtree/

[PATCH v2 17/23] contrib/subtree: Document from-submodule and prune commands

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt index c8fc103..48ba158 100644 --- a/contrib/subtree/git-subtree.txt +++ b/cont

[PATCH v2 15/23] contrib/subtree: Teach from-submodule to add new subtree to .gittrees

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index ae7d1fe..84c90c7 100755 --- a/contrib/subtree/g

[PATCH v2 16/23] contrib/subtree: Document pull-all and push-all

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt index e0957ee..c8fc103 100644 --- a/contrib/subtree/git-subtree.txt

[PATCH v2 14/23] contrib/subtree: Remove trailing slash from prefix parameter

2013-03-10 Thread Paul Campbell
From: Herman van Rink Conflicts: git-subtree.sh Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index d67fe5a..ae7d1fe 100755 --- a/contrib/subtree/git

[PATCH v2 12/23] contrib/subtree: Add command prune

2013-03-10 Thread Paul Campbell
From: Nate Jones Removes entries in .gittrees where the subtree files are no longer present on disk. Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/contrib/s

[PATCH v2 13/23] contrib/subtree: Add prune command to OPTS_SPEC

2013-03-10 Thread Paul Campbell
From: Herman van Rink Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 0c41383..d67fe5a 100755 --- a/contrib/subtree/git-su

[PATCH v2 11/23] contrib/subtree: Add command list

2013-03-10 Thread Paul Campbell
From: Matt Hoffman Lists subtrees from the .gittrees file. Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtre

[PATCH v2 10/23] contrib/subtree: Add command diff

2013-03-10 Thread Paul Campbell
From: Matt Hoffman Fetches the remote repo as a temporary git-remote then uses git-diff-tree to do comparison before removing the temporary git-remote. Signed-off-by: Paul Campbell Conflicts: git-subtree.sh --- contrib/subtree/git-subtree.sh | 34 +- 1

[PATCH v2 08/23] contrib/subtree: Replace invisible carriage return with a visible \r

2013-03-10 Thread Paul Campbell
From: Matt Hoffman The ctrl-M (^M) character used for the carriage return (CR) is not visible in all (most) text editors and is often silently converted to a new line (NL) or CR/NL combo. 'say' is a wrapper for echo with accepts the option -e to interperet escaped characters. \r becomes a CR, ye

[PATCH v2 09/23] contrib/subtree: Teach push to abort if split fails

2013-03-10 Thread Paul Campbell
From: Michael Hart Added a check to ensure that split succeeds before trying to push. Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index

[PATCH v2 06/23] contrib/subtree: Rename commands push_all/pull_all to push-all/pull-all

2013-03-10 Thread Paul Campbell
From: Matt Hoffman Changing underscores to dashes (push_all -> push-all) Signed-off-by: Paul Campbell Conflicts: .gitignore contrib/subtree/git-subtree.sh --- contrib/subtree/git-subtree.sh | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/c

[PATCH v2 07/23] contrib/subtree: Teach push and pull to use .gittrees if needed

2013-03-10 Thread Paul Campbell
From: Matt Hoffman Only when a repository and/or branch are not supplied on the command line will push and pull look for them in the .gittrees file. Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 32 1 file changed, 24 insertions(+), 8 deleti

[PATCH v2 05/23] contrib/subtree: Add commands pull_all and push_all

2013-03-10 Thread Paul Campbell
From: bibendi For each subtree listed in .gittrees perform a push or a pull. Signed-off-by: Paul Campbell Conflicts: contrib/subtree/git-subtree.sh --- contrib/subtree/git-subtree.sh | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/contrib

[PATCH v2 04/23] contrib/subtree: Teach push and pull to use .gittrees for defaults

2013-03-10 Thread Paul Campbell
From: bibendi Look in the config file .gittrees for a default repository and refspec or commit when they are not provided on the command line. Uses the .gittrees config file in a similar way to how git-submodule uses the .gitmodules file. Signed-off-by: Paul Campbell --- contrib/subtree/git-s

[PATCH v2 03/23] contrib/subtree: Teach add to store repository & branch in .gittrees

2013-03-10 Thread Paul Campbell
From: Matt Hoffman The repository and branch of a subtree added with the add command is stored in the .gittrees file. Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.sh | 8 1 file changed, 8 insertions(+) diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git

[PATCH v2 02/23] contrib/subtree: Add command from-submodule

2013-03-10 Thread Paul Campbell
From: Peter Jaros Converts a git-submodule into a git-subtree. Signed-off-by: Paul Campbell Conflicts: .gitignore contrib/subtree/git-subtree.sh test.sh --- contrib/subtree/git-subtree.sh | 30 +- 1 file changed, 29 insertions(+), 1 deletion

[PATCH v2 01/23] contrib/subtree: Fix typo (s/incldued/included/)

2013-03-10 Thread Paul Campbell
From: Paul Cartwright Signed-off-by: Paul Campbell --- contrib/subtree/git-subtree.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/subtree/git-subtree.txt b/contrib/subtree/git-subtree.txt index 7ba853e..e0957ee 100644 --- a/contrib/subtree/git-subtree.txt +++ b/

[PATCH v2 00/23] contrib/subtree: Collected updates

2013-03-10 Thread Paul Campbell
A selection of updates to git-subtree were offered to the list in May of last year ($gmane/196667) by Herman van Rink. At the time the commits were available as either a single commit or a large collection of commits and merges to the git-subtree prior to it's inclusion in contrib/subtree. The

[PATCH/RFC] Make help behaviour more consistent

2013-03-10 Thread Kevin Bracey
Previously, the command "help" and the option "-h" behaved differently depending on whether a command was specified or not. Old user interface: Commands with no defaults show usage: "git" "git CMD" To specifically request usage:"git help" "git CMD -h" To get a manual page:

Re: [PATCH] perf: update documentation of GIT_PERF_REPEAT_COUNT

2013-03-10 Thread Thomas Rast
Antoine Pelisse writes: > Currently the documentation of GIT_PERF_REPEAT_COUNT says the default is > five while "perf-lib.sh" uses a value of three as a default. > > Update the documentation so that it is consistent with the code. > > Signed-off-by: Antoine Pelisse Acked-by: Thomas Rast -- T

[RFC/PATCH] Documentation/technical/api-fswatch.txt: start with outline

2013-03-10 Thread Ramkumar Ramachandra
git operations are slow on repositories with lots of files, and lots of tiny filesystem calls like lstat(), getdents(), open() are reposible for this. On the linux-2.6 repository, for instance, the numbers for "git status" look like this: top syscalls sorted top syscalls sorted by acc. ti

Re: Merging submodules - best merge-base

2013-03-10 Thread Heiko Voigt
On Sat, Mar 09, 2013 at 06:45:56PM +0100, Jens Lehmann wrote: > Am 07.03.2013 19:59, schrieb Heiko Voigt: > > On Thu, Mar 07, 2013 at 10:49:09AM +0100, Daniel Bratell wrote: > >> Den 2013-03-06 19:12:05 skrev Heiko Voigt : > >>> So to summarize what you are requesting: You want a submodule merge be

[PATCH v2 4/4] teach config parsing to read from strbuf

2013-03-10 Thread Heiko Voigt
This can be used to read configuration values directly from gits database. Signed-off-by: Heiko Voigt --- .gitignore | 1 + Makefile | 1 + cache.h| 2 ++ config.c | 48 t/t1300-repo-confi

[PATCH v2 3/4] config: make parsing stack struct independent from actual data source

2013-03-10 Thread Heiko Voigt
To simplify adding other sources we extract all functions needed for parsing into a list of callbacks. We implement those callbacks for the current file parsing. A new source can implement its own set of callbacks. Instead of storing the concrete FILE pointer for parsing we store a void pointer. A

[PATCH v2 2/4] config: drop file pointer validity check in get_next_char()

2013-03-10 Thread Heiko Voigt
The only location where cf is set in this file is in do_config_from(). This function has only one callsite which is config_from_file(). In config_from_file() its ensured that the f member is set to non-zero. Signed-off-by: Heiko Voigt --- config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2 1/4] config: factor out config file stack management

2013-03-10 Thread Heiko Voigt
Because a config callback may start parsing a new file, the global context regarding the current config file is stored as a stack. Currently we only need to manage that stack from git_config_from_file. Let's factor it out to allow new sources of config data. Signed-off-by: Heiko Voigt --- config

[PATCH v2 0/4] allow more sources for config values

2013-03-10 Thread Heiko Voigt
The following issues still exist: * Error handling: If this should be useful to interrogate configs from the database during git operations we need a way to recover from parsing errors instead of dying. * More tests ? This is an update with the comments of the first iteration[1] incorpor

Re: [PATCH 4/4] teach config parsing to read from strbuf

2013-03-10 Thread Heiko Voigt
Hi, On Thu, Mar 07, 2013 at 06:42:43PM +, Ramsay Jones wrote: > Heiko Voigt wrote: > > +int git_config_from_strbuf(config_fn_t fn, struct strbuf *strbuf, void > > *data) > > +{ > > + struct config top; > > + struct config_strbuf str; > > + > > + str.strbuf = strbuf; > > + str.pos = 0;

Re: [PATCH 1/2] require pathspec for "git add -u/-A"

2013-03-10 Thread Matthieu Moy
Junio C Hamano writes: > As promised in 0fa2eb530fb7 (add: warn when -u or -A is used without > pathspec, 2013-01-28), "git add -u/-A" that is run without pathspec > in a subdirectory will stop working sometime before Git 2.0, to wean > users off of the old default, in preparation for adopting th

[PATCH] Translate git_more_info_string consistently

2013-03-10 Thread Kevin Bracey
"git help" translated the "See 'git help ' for more information..." message, but "git" didn't. Signed-off-by: Kevin Bracey --- git.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git.c b/git.c index d33f9b3..e484644 100644 --- a/git.c +++ b/git.c @@ -536,7 +536,7 @@ int mai

Re: rebase: strange failures to apply patc 3-way

2013-03-10 Thread Max Horn
Sorry for taking so long to reply... :-/ On 09.03.2013, at 19:32, Andrew Wong wrote: > On 03/09/13 06:26, Max Horn wrote: >> It tends to fail in separate places, but eventually "stabilizes". E.g. I >> just did a couple test rebases, and it failed twice in commit 14, then the >> third time in co

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Duy Nguyen
On Sun, Mar 10, 2013 at 7:11 PM, Antoine Pelisse wrote: >>> By the way, if we know the length of the string, we could use memcmp. >>> This one is allowed to compare 4-bytes at a time (he doesn't care >>> about end of string). This is true because the value of the length >>> parameter is no longer

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Antoine Pelisse
>> By the way, if we know the length of the string, we could use memcmp. >> This one is allowed to compare 4-bytes at a time (he doesn't care >> about end of string). This is true because the value of the length >> parameter is no longer "at most". > > We still need to worry about access violation

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Duy Nguyen
On Sun, Mar 10, 2013 at 6:54 PM, Antoine Pelisse wrote: > On Sun, Mar 10, 2013 at 12:43 PM, Antoine Pelisse wrote: >> On Sun, Mar 10, 2013 at 11:38 AM, Duy Nguyen wrote: >>> glibc's C strncmp version does 4-byte comparison at a time when n >=4, >>> then fall back to 1-byte for the rest. >> >> Lo

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Antoine Pelisse
On Sun, Mar 10, 2013 at 12:43 PM, Antoine Pelisse wrote: > On Sun, Mar 10, 2013 at 11:38 AM, Duy Nguyen wrote: >> glibc's C strncmp version does 4-byte comparison at a time when n >=4, >> then fall back to 1-byte for the rest. > > Looking at this > (http://fossies.org/dox/glibc-2.17/strncmp_8c_so

Re: Memory corruption when rebasing with git version 1.8.1.5 on arch

2013-03-10 Thread Bernhard Posselt
On 03/10/2013 08:05 AM, Jeff King wrote: On Sat, Mar 09, 2013 at 11:54:36AM +0100, Bernhard Posselt wrote: Also, I can almost reproduce here, as PatrickHeller/core.git is public. However, I suspect the problem is particular to your work built on top, which looks like it is at commit 0525bbd73c9

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Antoine Pelisse
On Sun, Mar 10, 2013 at 11:38 AM, Duy Nguyen wrote: > glibc's C strncmp version does 4-byte comparison at a time when n >=4, > then fall back to 1-byte for the rest. Looking at this (http://fossies.org/dox/glibc-2.17/strncmp_8c_source.html), it's not exactly true. It would rather be while (n >=

Re: [PATCH v2 6/6] exclude: filter patterns by directory level

2013-03-10 Thread Duy Nguyen
On Sun, Mar 10, 2013 at 5:58 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Nguyễn Thái Ngọc Duy writes: >> >>> A non-basename pattern that does not contain /**/ can't match anything >>> outside the attached directory. Record its directory level and avoid >>> matching unless the pathna

Re: Memory corruption when rebasing with git version 1.8.1.5 on arch

2013-03-10 Thread Bernhard Posselt
On 03/10/2013 08:05 AM, Jeff King wrote: On Sat, Mar 09, 2013 at 11:54:36AM +0100, Bernhard Posselt wrote: Also, I can almost reproduce here, as PatrickHeller/core.git is public. However, I suspect the problem is particular to your work built on top, which looks like it is at commit 0525bbd73c9

Re: [PATCH v2 6/6] exclude: filter patterns by directory level

2013-03-10 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> A non-basename pattern that does not contain /**/ can't match anything >> outside the attached directory. Record its directory level and avoid >> matching unless the pathname is also at the same directory level. > > Without defining wha

Re: [PATCH 2/2] shell: new no-interactive-login command to print a custom message

2013-03-10 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > * If the file ~/git-shell-commands/no-interactive-login exists, >run no-interactive-login to let the server say what it likes, >then hang up. > > * Otherwise, if ~/git-shell-commands/ is present, start an >interactive read-eval-print loop. > > * Otherwise, pr

Re: [PATCH v2 3/6] match_basename: use strncmp instead of strcmp

2013-03-10 Thread Duy Nguyen
On Sun, Mar 10, 2013 at 2:34 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> strncmp is provided length information which could be taken advantage >> by the underlying implementation. > > I may be missing something fundamental, but I somehow find the above > does not make any sense

Re: [PATCH v2 6/6] exclude: filter patterns by directory level

2013-03-10 Thread Duy Nguyen
On Sun, Mar 10, 2013 at 3:20 PM, Junio C Hamano wrote: >> + else if (*p == '/') >> + dirs--; > > I presume this is to compensate for a pattern like "/pat" whose > leading slash is only to anchor the pattern at the level. Correct? Yes. Also for the record, we could cut down the n

Re: pt_BR initializaton

2013-03-10 Thread Jiang Xin
Hi Harring, I'm glad to see that there will be another locale for Git. I reviewed three commit from you. There are some problems: Because git has a strict and high standard for commit log, so 1. your commit log must have "Signed-off-by: " line(s). Commit using "commit -s", or using alias suc

Fwd: mailmap documentation add grave accents

2013-03-10 Thread 乙酸鋰
Hi, Here is the patch. Regards, ch3cooli 0001-mailmap-add-grave-accents-around-mailmap.file-and-ma.patch Description: Binary data

Re: inotify to minimize stat() calls

2013-03-10 Thread Ramkumar Ramachandra
Duy Nguyen wrote: > On Fri, Mar 8, 2013 at 3:15 PM, Junio C Hamano wrote: >>> The possible options are: >>> + >>> - - 'no' - Show no untracked files >>> + - 'no' - Show no untracked files (this is fastest) >> >> There is a trade-off around the use of -uno between safety and >

Re: [PATCH v2 6/6] exclude: filter patterns by directory level

2013-03-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > A non-basename pattern that does not contain /**/ can't match anything > outside the attached directory. Record its directory level and avoid > matching unless the pathname is also at the same directory level. Without defining what a "directory level" is, the abov