On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote:
> t/test-lib.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 5293830..78c88c2 100755
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -182,13 +182,13 @@ then
>
On Thu, Sep 20, 2012 at 11:20:31PM -0400, Cristian Tibirna wrote:
> Running the script in attachment produces a git repository in which were
> operated a large number of file renames, in which many of the renamed files
> (in this particular case all) have the same content but different names.
>
Am 9/20/2012 21:46, schrieb Adam Spiers:
> test_expect_success 'general options plus command' '
> - test_completion "git --version check" "checkout " &&
> - test_completion "git --paginate check" "checkout " &&
> - test_completion "git --git-dir=foo check" "checkout " &&
> - test_c
The output from git push currently looks like this:
$ git push dest HEAD
fatal: [some message from index-pack]
error: unpack failed: index-pack abnormal exit
To dest
! [remote rejected] HEAD -> master (n/a (unpacker error))
That n/a is meant to be "the per-ref status is not
available"
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-
The unpack-objects command should not generally produce any
output on stdout. However, if it's given extra input after
the packfile, it will spew the remainder to stdout. When
called by receive-pack, this means we will break protocol,
since our stdout is connected to the remote send-pack.
Signed-o
While we are on the subject of http user experience, I thought I'd
mention this patch to route more errors from index-pack back to the
user. We're not doing it yet at GitHub, but I plan to apply it soon.
The first patch is a cleanup and minor bug fix. The second is the
interesting one. The third i
On Thu, Sep 20, 2012 at 04:05:03PM -0700, Shawn O. Pearce wrote:
> But right now I am seeing failures in libcurl's SSL connection that
> may also be causing the smart connection failures. For example this
> trace, where libcurl was just not able to connect to respond to the
> 401 with a password.
Adam Spiers writes:
> Sure, I can do that, but shouldn't this convention be documented in
> SubmittingPatches?
People must have learned this by imitating what senior contributors
send to the list, but the "[Subject] area: title" thing does not
appear in that document. I agree it should (patches
Hello
A colleague of mine discovered an inconsistency in the functioning of
git diff-tree -r -C
in specific conditions. As tenuous as these conditions might seem (once you
run the script in attachment and analyse its output), please rest assured that
it comes from a real-life case.
Running t
On Thu, Sep 20, 2012 at 10:43 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>> Adam Spiers writes:
>>> Adam Spiers (14):
>>> Update directory listing API doc to match code
>>> Improve documentation and comments regarding directory traversal API
>>> Rename cryptic 'which' variable to m
On Thu, Sep 20, 2012 at 10:24 AM, Jeff King wrote:
> On Wed, Sep 19, 2012 at 10:57:35PM -0700, Shawn O. Pearce wrote:
>
>> > so transient errors on the initial smart
>> > contact can cause us to fall back to dumb,
>>
>> Transient errors is actually what is leading me down this path. We see
>> abou
Am 18.09.2012 23:12, schrieb Junio C Hamano:
René Scharfe writes:
WindowsInfo-ZIP unzip
7-Zip PeaZip builtin Linux msysgit Windows
7-Zip 9.20 0 0 4626 43 43
PeaZip 4.7.1 win6
Junio C Hamano writes:
> Adam Spiers writes:
>
>> Adam Spiers (14):
>> Update directory listing API doc to match code
>> Improve documentation and comments regarding directory traversal API
>> Rename cryptic 'which' variable to more consistent name
>> Rename path_excluded() to is_path_ex
Adam Spiers writes:
> void add_exclude(const char *string, const char *base,
> - int baselen, struct exclude_list *el)
> + int baselen, struct exclude_list *el, const char *src, int
> srcpos)
> {
> struct exclude *x;
> size_t len;
> @@ -341,6 +341,8 @@ voi
On Thu, Sep 20, 2012 at 02:15:20PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > I'm half-tempted to just drop the config entirely, leave
> > GIT_SMART_HTTP=false as an escape hatch, and see if anybody even cares.
>
> Sounds like a very attractive minimalistic way to go forward. We
>
Adam Spiers writes:
> Adam Spiers (14):
> Update directory listing API doc to match code
> Improve documentation and comments regarding directory traversal API
> Rename cryptic 'which' variable to more consistent name
> Rename path_excluded() to is_path_excluded()
> Rename excluded_from
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff King writes:
> I'm half-tempted to just drop the config entirely, leave
> GIT_SMART_HTTP=false as an escape hatch, and see if anybody even cares.
Sounds like a very attractive minimalistic way to go forward. We
can always add per-remote configuration when we find it necessary,
but once we
Adam Spiers writes:
> This will allow us to test the test framework more thoroughly
> without disrupting the top-level test metrics.
>
> Signed-off-by: Adam Spiers
> ---
> t/t-basic.sh | 67
>
> 1 file changed, 29 insertions(+), 38 d
Jens Lehmann writes:
> That's pretty cool! Even though diff options like --stat and --name-only
> still won't take into account what happened inside the submodule this
> approach makes it possible to see the diff recursively. Wouldn't it make
> sense add this script to contrib (after teaching it
On Thu, Sep 20, 2012 at 11:36:34AM -0700, Junio C Hamano wrote:
> >> What would the user experience be when we introduce "even smarter"
> >> http server protocol extension? Will we add remote.foo.starterhttp?
> >
> > I would hope that it would actually be negotiated reliably at the
> > protocol l
Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> Heh, so I obviously didn't see this before sending the patch yesterday! :-D
>>
>> Yes, this solves the problem addressed by yesterday's patch, so please
>> ignore that. However, this tickles sparse to complain as well ... ;-)
>>
>> New patch on it
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 20.09.2012 00:31, schrieb Junio C Hamano:
> Junio C Hamano writes:
>
>> I also suspect that you do not have to change "git diff" at all to
>> show the patch recursively by using the attribute mechanism (look in
>> Documentation/gitattributes.text for a string GIT_EXTERNAL_DIFF).
>> It might be
This works in a similar manner to git-check-attr. Some code
was reused from add.c by refactoring out into pathspec.c.
Thanks to Jeff King and Junio C Hamano for the idea:
http://thread.gmane.org/gmane.comp.version-control.git/108671/focus=108815
Signed-off-by: Adam Spiers
---
.gitignore
>From the perspective of a newcomer to the codebase, the directory
traversal API has a few potentially confusing properties. These
comments clarify a few key aspects and will hopefully make it easier
to understand for other newcomers in the future.
Signed-off-by: Adam Spiers
---
Documentation/t
Signed-off-by: Adam Spiers
---
Documentation/technical/api-directory-listing.txt | 2 ++
dir.c | 23 +--
dir.h | 1 +
3 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/Docum
Start adopting clearer names for exclude functions. This 'is_*'
naming pattern for functions returning booleans was agreed here:
http://thread.gmane.org/gmane.comp.version-control.git/204661/focus=204924
Signed-off-by: Adam Spiers
---
builtin/add.c | 2 +-
builtin/ls-files.c | 2 +-
dir.c
'el' is only *slightly* less cryptic, but is already used as the
variable name for a struct exclude_list pointer in numerous other
places, so this reduces the number of cryptic variable names in use by
one :-)
Signed-off-by: Adam Spiers
---
dir.c | 10 +-
dir.h | 4 ++--
2 files changed
This is in preparation for reuse by a new git check-ignore command.
Signed-off-by: Adam Spiers
---
Makefile | 2 ++
builtin/add.c | 95 ++---
pathspec.c| 97 +++
pathspec.h|
Extract the body of the for loop in treat_gitlinks() into a separate
treat_gitlink() function so that it can be reused elsewhere. This
paves the way for a new check-ignore sub-command.
Signed-off-by: Adam Spiers
---
builtin/add.c | 49 +++--
1 file ch
For exclude patterns read in from files, the filename is stored together
with the corresponding line number (counting starting at 1).
For exclude patterns provided on the command line, the sequence number
is negative, with counting starting at -1, so for example the 2nd
pattern provided via --excl
In a similar way to the previous commit, this extracts a new helper
function last_exclude_matching() which returns the last exclude_list
element which matched, or NULL if no match was found. is_excluded()
becomes a wrapper around this, and just returns 0 or 1 depending on
whether any matching excl
In a similar way to the previous commit, this extracts a new helper
function last_exclude_matching_path() which return the last
exclude_list element which matched, or NULL if no match was found.
is_path_excluded() becomes a wrapper around this, and just returns 0
or 1 depending on whether any match
The excluded function uses a new helper function called
last_exclude_matching_from_list() to perform the inner loop over all of
the exclude patterns. The helper just tells us whether the path is
included, excluded, or undecided.
However, it may be useful to know _which_ pattern was triggered. So
Continue adopting clearer names for exclude functions. This is_*
naming pattern for functions returning booleans was discussed here:
http://thread.gmane.org/gmane.comp.version-control.git/204661/focus=204924
Signed-off-by: Adam Spiers
---
attr.c | 2 +-
dir.c | 10 +-
dir.h | 4 ++-
Continue adopting clearer names for exclude functions. This 'is_*'
naming pattern for functions returning booleans was discussed here:
http://thread.gmane.org/gmane.comp.version-control.git/204661/focus=204924
Signed-off-by: Adam Spiers
---
dir.c | 11 ++-
dir.h | 4
This is a re-vamp of my original check-ignore series, which aims to
address all the feedback which was raised in the first round of
reviews. The most notable changes are the CLI options and output
formats as suggested by Junio and Nguyễn; now there are three levels
of verbosity: --quiet, default,
7c4c97c0ac turned the flags in struct dir_struct into a single bitfield
variable, but forgot to update this document.
Signed-off-by: Adam Spiers
---
Documentation/technical/api-directory-listing.txt | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/te
On Thu, Sep 20, 2012 at 8:21 PM, Jeff King wrote:
> On Thu, Sep 20, 2012 at 08:11:52PM +0200, SZEDER Gábor wrote:
>
>> > > In order to achieve that I took bash-completion's quote() function,
>> > > which is rather simple, and renamed it to __git_quote() as per Jeff
>> > > King's suggestion.
>> > >
On 19.09.2012 15:43, Michael Haggerty wrote:
Is there any news about the proposed gatherings? I would be quite
interested in attending the developer meeting. October is just around
the corner...what's up?
I'm also very much interested in attending a gathering Berlin, though
preferably not i
Jeff King writes:
> On Thu, Sep 20, 2012 at 10:53:15AM -0700, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > I added the config item as remote.foo.smarthttp. You could also allow
>> > "http.$url.smart" (and just "http.smart", for that matter), which could
>> > be more flexible if you have
On Thu, Sep 20, 2012 at 08:11:52PM +0200, SZEDER Gábor wrote:
> > > In order to achieve that I took bash-completion's quote() function,
> > > which is rather simple, and renamed it to __git_quote() as per Jeff
> > > King's suggestion.
> > >
> > > Solves the original problem for me.
> >
> > Me to
Hi,
On Wed, Sep 19, 2012 at 09:46:08PM -0400, Jeff King wrote:
> On Thu, Sep 20, 2012 at 04:15:15AM +0200, Felipe Contreras wrote:
>
> > As reported by Jeroen Meijer[1]; the current code doesn't deal properly
> > with items (tags, branches, etc.) that have ${} in them because they get
> > expaned
On Thu, Sep 20, 2012 at 10:53:15AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > I added the config item as remote.foo.smarthttp. You could also allow
> > "http.$url.smart" (and just "http.smart", for that matter), which could
> > be more flexible if you have multiple remotes pointing t
After running "git clone --single", the resulting repository has the
usual default "+refs/heads/*:refs/remotes/origin/*" wildcard fetch
refspec installed, which means that a subsequent "git fetch" will
end up grabbing all the other branches.
Update the fetch refspec to cover only the singly cloned
On Thu, Sep 20, 2012 at 6:45 PM, Junio C Hamano wrote:
> Adam Spiers writes:
>> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote:
>>> Do you want this queued on top of your other series, or as an
>>> independent change?
>>
>> Independent please.
>
> With a sign-off?
Yep.
--
To unsubscribe
Jeff King writes:
> I added the config item as remote.foo.smarthttp. You could also allow
> "http.$url.smart" (and just "http.smart", for that matter), which could
> be more flexible if you have multiple remotes pointing to the same
> broken server.
What would the user experience be when we intr
Junio C Hamano writes:
> Nguyễn Thái Ngọc Duy writes:
>
>> %C+ tells the next specifiers that color is preferred. %C- the
>> opposite. So far only %H, %h and %d support coloring.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy
>> ---
>> Documentation/pretty-formats.txt | 2 ++
>> pretty.c
Adam Spiers writes:
> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote:
>> Do you want this queued on top of your other series, or as an
>> independent change?
>
> Independent please.
With a sign-off?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a messag
On Wed, Sep 19, 2012 at 10:57:35PM -0700, Shawn O. Pearce wrote:
> > I have been looking into this recently, as well. GitHub does not allow
> > dumb http at all these days,
>
> Interesting that GitHub doesn't support dumb transfer either.
Our objects are still in regular repos, and is served by
Usually there is no need for users to specify whether an
http remote is smart or dumb; the protocol is designed so
that a single initial request is made, and the client can
determine the server's capability from the response.
However, some misconfigured dumb-only servers may not like
the initial r
We don't actually care whether the connection is http or
not; what we care about is whether it might be smart http.
Rename the variable to be more accurate, which will make it
easier to later make smart-http optional.
Signed-off-by: Jeff King
---
remote-curl.c | 6 +++---
1 file changed, 3 inser
On Thu, Sep 20, 2012 at 12:24:56PM -0400, Jeff King wrote:
> I think Shawn's revert is the right thing to do. But it is not complete
> without the manual workaround. I'm putting that patch together now and
> should have it out in a few minutes.
And here it is. This goes on top of Shawn's revert p
On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote:
> Do you want this queued on top of your other series, or as an
> independent change?
Independent please.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo i
Jeff King writes:
> On Thu, Sep 20, 2012 at 04:15:15AM +0200, Felipe Contreras wrote:
>
>> As reported by Jeroen Meijer[1]; the current code doesn't deal properly
>> with items (tags, branches, etc.) that have ${} in them because they get
>> expaned by bash while using compgen.
>>
>> A simple so
Adam Spiers writes:
> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano wrote:
>> Adam Spiers writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
> test_e
Nguyễn Thái Ngọc Duy writes:
> %C+ tells the next specifiers that color is preferred. %C- the
> opposite. So far only %H, %h and %d support coloring.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> Documentation/pretty-formats.txt | 2 ++
> pretty.c | 13 -
>
Nguyen Thai Ngoc Duy writes:
> And this is a for-fun patch that adds %| to right align everything
> after that. I'm ignoring problems with line wrapping, i18n and so
> on. "%C+%h %s%|%d" looks quite nice. I'm not sure how much useful it
> is beyond --oneline though. It looks something like this
>
On Wed, Sep 19, 2012 at 11:29:34PM -0700, Junio C Hamano wrote:
> "Shawn O. Pearce" writes:
>
> > This reverts commit 703e6e76a14825e5b0c960d525f34e607154b4f7.
> >
> > Retrying without the query parameter was added as a workaround
> > for a single broken HTTP server at git.debian.org[1]. The ser
Stefano Lattarini writes:
> Hi Adam.
>
> On 09/20/2012 11:08 AM, Adam Spiers wrote:
>> Skipped tests indicate incomplete test coverage. Whilst this is
>> not a test failure or other error, it's still not complete
>> success, so according to the universal traffic lights coloring
>> scheme, yellow
And this is a for-fun patch that adds %| to right align everything
after that. I'm ignoring problems with line wrapping, i18n and so
on. "%C+%h %s%|%d" looks quite nice. I'm not sure how much useful it
is beyond --oneline though. It looks something like this
cc543b2 pretty: support placeholders %C
%C+ tells the next specifiers that color is preferred. %C- the
opposite. So far only %H, %h and %d support coloring.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
Documentation/pretty-formats.txt | 2 ++
pretty.c | 13 -
2 files changed, 14 insertions(+), 1 deletio
This also adds color support to format_decoration()
Signed-off-by: Nguyễn Thái Ngọc Duy
---
log-tree.c | 55 +--
log-tree.h | 3 +++
pretty.c | 19 +--
3 files changed, 37 insertions(+), 40 deletions(-)
diff --git a/log-tree
On Thu, Sep 20, 2012 at 5:43 PM, Nguyen Thai Ngoc Duy wrote:
> I tried --pretty=format:"%h %s %d" but the colors were lost.
> --decorate uses more than one color so %C* does not immitate the
> colorful output we have with --decorate. Maybe I should add %Cd as
> "colored %d" and update my alias to
On Thu, Sep 20, 2012 at 6:42 AM, Jeff King wrote:
> If you are particular about the exact format, how about using
> --format="%h%d %s" instead?
>
> Obviously Duy could do the same to achieve his format, but I think there
> is still value in considering what the default for --oneline should be.
Ye
Hi Adam.
On 09/20/2012 11:08 AM, Adam Spiers wrote:
> Skipped tests indicate incomplete test coverage. Whilst this is
> not a test failure or other error, it's still not complete
> success, so according to the universal traffic lights coloring
> scheme, yellow/brown seems more suitable than green
Skipped tests indicate incomplete test coverage. Whilst this is
not a test failure or other error, it's still not complete
success, so according to the universal traffic lights coloring
scheme, yellow/brown seems more suitable than green. However,
it's more informational than cautionary, so inste
On Thu, Sep 20, 2012 at 6:48 AM, Johannes Sixt wrote:
> Am 9/19/2012 22:24, schrieb Adam Spiers:
>> skip)
>> - tput bold; tput setaf 2;; # bold green
>> + tput setaf 4;;# blue
>
> It's unreadable on black background. Keep it bold; t
The pretty formats for GPG signatures were introduced but never
documented. Use the documentation from the commit that introduced them.
Do the same for the --show-signature option added to git log and
friends.
Signed-off-by: Stephen Boyd
---
I had to google for --show-signature one too many time
On 09/19/2012 09:07 PM, Ramsay Jones wrote:
> Michael Haggerty wrote:
>> Is there some documentation about how to run sparse on the git codebase?
>> I naively tried "make sparse" and ended up with zillions of errors like
>>
>> /usr/include/unistd.h:288:54: error: attribute '__leaf__': unknown attr
72 matches
Mail list logo
