Re: [gentoo-dev] [PATCH 1/3] dotnet.eclass: pass -S to file to disable seccomp

2023-01-03 Thread Ulrich Mueller
> On Tue, 03 Jan 2023, Sam James wrote: > - if [[ "$(file "${exe}")" == *"shell script > text"* ]] > + if [[ "$(file -S "${exe}")" == *"shell script > text"* ]] POSIX file doesn't know the -S option. Could that cause any problems, e.g.

Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2)

2023-01-03 Thread Maciej Barć
How do you pronounce it? ;-) Michał, I am not a phonetic expert but I guess it would be "e-dune", like "e" in "e-mail" or "i-djun" in broken Polish. :-D On 1/3/23 07:32, Michał Górny wrote: On Tue, 2023-01-03 at 00:19 +0100, Maciej Barć wrote: edune is a thin wrapper for dune, which will he

Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2)

2023-01-03 Thread Maciej Barć
It appears there is additional output between the ebegin / eend. You may want to consider dropping ebegin and eend. In general, the pattern ebegin, edo, eend should probably be avoided. I would like to keep the "Building ... [ OK ]" (made by ebegin) output as it was before the change. I thin

Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2)

2023-01-03 Thread Florian Schmaus
On 03/01/2023 15.51, Maciej Barć wrote: It appears there is additional output between the ebegin / eend. You may want to consider dropping ebegin and eend. In general, the pattern ebegin, edo, eend should probably be avoided. I would like to keep the "Building ... [ OK ]" (made by ebegin) outp

Re: [gentoo-dev] [PATCH] eclass/dune.eclass: introduce edune and dune-compile (v2)

2023-01-03 Thread Michał Górny
On Tue, 2023-01-03 at 15:47 +0100, Maciej Barć wrote: > > How do you pronounce it? ;-) > > Michał, I am not a phonetic expert but I guess it would be "e-dune", > like "e" in "e-mail" or "i-djun" in broken Polish. :-D I meant the "e-do-dune" part xP. -- Best regards, Michał Górny