On Wed, Sep 24, 2008 at 4:51 AM, Bo Ørsted Andresen <[EMAIL PROTECTED]> wrote:
> On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote:
>> default_src_install() {
>> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
>> if emake DESTDIR="${D} install || einstall ;
El mié, 24-09-2008 a las 02:35 +0200, Robert Buchholz escribió:
>
> Let's go with an even simpler default implementation:
>
> default_src_install() {
> if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
> emake DESTDIR="${D}" install || die "emake install failed
On Wednesday 24 September 2008 07:28:07 Alec Warner wrote:
> > Now figure out the four flaws in the above code.
>
> Why not be helpful and point them out?
>
> I would call your comment 'UnGentooey', if I may use a work term. I
> don't think saying there are flaws in a given piece of code is really
Ulrich Mueller wrote:
>> As I said; generality in lib functions seems like a useful thing.
>
> Other ebuild variables are space separated lists, so why should DOCS
> be an exception?
>
Because we're doing it right this time, while allowing existing usage. IOW
you can quite happily continue to use
Steve Long wrote:
> In summary that's why for
> instance no filenames with spaces (leave alone all the other characters
> you can't deal with atm) can be safely handled by any of your ebuild
> structure, unless it comes from a glob, and is never manipulated or
> referenced in and of itself. (Unles
