Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Mike Frysinger
On Tuesday, June 28, 2011 15:58:46 Michał Górny wrote: > On Tue, 28 Jun 2011 15:04:00 -0400 Nathan Phillip Brink wrote: > > On Tue, Jun 28, 2011 at 10:24:26PM +0400, Peter Volkov wrote: > > > ?? ??, 28/06/2011 ?? 12:23 -0400, Mike Frysinger ??: > > > > On Tuesday, June 28, 2011 02:54:03

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Michał Górny
On Tue, 28 Jun 2011 15:04:00 -0400 Nathan Phillip Brink wrote: > On Tue, Jun 28, 2011 at 10:24:26PM +0400, Peter Volkov wrote: > > ?? ??, 28/06/2011 ?? 12:23 -0400, Mike Frysinger ??: > > > On Tuesday, June 28, 2011 02:54:03 Micha?? G??rny wrote: > > > > emake CC="$(tc-getCC)" CFLAGS=

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Alexis Ballier
On Tue, 28 Jun 2011 22:24:26 +0400 Peter Volkov wrote: > В Втр, 28/06/2011 в 12:23 -0400, Mike Frysinger пишет: > > On Tuesday, June 28, 2011 02:54:03 Michał Górny wrote: > > > emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"... > > > > this is easily dangerous when it comes to packages (and many do) >

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Nathan Phillip Brink
On Tue, Jun 28, 2011 at 10:24:26PM +0400, Peter Volkov wrote: > ?? ??, 28/06/2011 ?? 12:23 -0400, Mike Frysinger ??: > > On Tuesday, June 28, 2011 02:54:03 Micha?? G??rny wrote: > > > emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"... > > > > this is easily dangerous when it comes to package

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Peter Volkov
В Втр, 28/06/2011 в 12:23 -0400, Mike Frysinger пишет: > On Tuesday, June 28, 2011 02:54:03 Michał Górny wrote: > > emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"... > > this is easily dangerous when it comes to packages (and many do) that append > in the Makefile. specifying on the command line bloc

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Mike Frysinger
On Tuesday, June 28, 2011 08:25:50 Peter Volkov wrote: > +Sometimes a package will not use the user's ${CFLAGS} or > +${LDFLAGS}. there are more flag vars than this. you should use language like: Sometimes a package will not use the user's build settings (such as CFLAGS or LDFLAGS). > -sed

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Mike Frysinger
On Tuesday, June 28, 2011 02:54:03 Michał Górny wrote: > On Tue, 28 Jun 2011 10:16:06 +0400 Peter Volkov wrote: > > But still our documentation explicitly suggests ':' for CFLAGS cases > > and example allows bash substitution. > > > > http://devmanual.gentoo.org/ebuild-writing/functions/src_compil

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-28 Thread Peter Volkov
Thank you Fabian, Michał. Added note on Makefile and mentioned other tools as well. Updated patch is in attachment. -- Peter. >From 9d24f4bab09be481e70ab04c85f20a246162dc0a Mon Sep 17 00:00:00 2001 From: Peter Volkov Date: Tue, 28 Jun 2011 10:05:17 +0400 Subject: [PATCH] Use | as a separator for

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-27 Thread Michał Górny
On Tue, 28 Jun 2011 10:16:06 +0400 Peter Volkov wrote: > But still our documentation explicitly suggests ':' for CFLAGS cases > and example allows bash substitution. > > http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building/index.html > see example in "Fixing Compiler Usage"

Re: [gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-27 Thread Fabian Groffen
On 28-06-2011 10:16:06 +0400, Peter Volkov wrote: > Are there any objections to suggest '|' for CFLAGS, LDFLAGS (see > attachment)? Not from my side. It's what we've been using so far. > > -When using sed with CFLAGS or LDFLAGS, it is not safe > to use > -a comma or a slash as a delimiter. Th

[gentoo-dev] demanual update (was: Don't use / when applying sed with CFLAGS)

2011-06-27 Thread Peter Volkov
В Пнд, 27/06/2011 в 17:01 +0200, Fabian Groffen пишет: > On 27-06-2011 14:08:52 +, Justin Lecher wrote: > > Please do not use / as seperater when using sed with CFLAGS. I came > across a bug today where it failed for crossdev. Here the toolchain > header paths in the cflags and consowuently the