Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Mike Frysinger
On Wednesday 18 May 2005 01:16 pm, Harald van DÄk wrote: > Mike Frysinger wrote: > > i'd have to agree with Diego ... i'd rather see people add patches that > > change 1 line in .m4 files ... in fact, ive already patched a bunch of > > the more common ones, i just didnt rev bump them :p > > -mike >

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Harald van DÄk
Mike Frysinger wrote: > i'd have to agree with Diego ... i'd rather see people add patches that > change > 1 line in .m4 files ... in fact, ive already patched a bunch of the more > common ones, i just didnt rev bump them :p > -mike The patch for xdelta (and possibly others) uses the full locat

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Diego 'Flameeyes' PettenÃ
On Wednesday 18 May 2005 17:11, Donnie Berkholz wrote: > It may be easier, but upstream would appreciate us sending a patch > instead of just fixing stuff locally. Not sure about this, we have also some not-so-friendly upstreams sometimes :) Well anyway I hope all those can be fixed soon, so ...

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Aaron Walker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Donnie Berkholz wrote: > Aaron Walker wrote: > >>>Ok that's fine. A function just seemed saner than adding 1 lines patches to >>>dozens of packages. > > > It may be easier, but upstream would appreciate us sending a patch > instead of just fixing s

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Donnie Berkholz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Aaron Walker wrote: > Ok that's fine. A function just seemed saner than adding 1 lines patches to > dozens of packages. It may be easier, but upstream would appreciate us sending a patch instead of just fixing stuff locally. -BEGIN PGP SIGNATURE-

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Diego 'Flameeyes' PettenÃ
On Wednesday 18 May 2005 15:42, Aaron Walker wrote: > sed is still aliased to gsed, no? Yes but I don't trust sed calls which depends on specific behaviour of gnu tools. -- Diego "Flameeyes" Pettenà Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64) http://dev.gentoo.org/~flameeyes/ pgpg

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Stephen Bennett
On Wed, 2005-05-18 at 09:42 -0400, Aaron Walker wrote: > sed is still aliased to gsed, no? Yes, but I want to kill that if possible. -- gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Aaron Walker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Diego 'Flameeyes' Pettenà wrote: > You tried it with bsd sed anyway? :) sed is still aliased to gsed, no? - -- One good turn usually gets most of the blanket. Aaron Walker <[EMAIL PROTECTED]> [ BSD | cron | forensics | shell-tools | commonbox | net

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Aaron Walker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger wrote: > On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote: > >>I'd like to propose a new function for eutils.eclass that fixes m4 files so >>that aclocal doesn't produce those annoying underquoted definition warnings >>when invoked

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Mike Frysinger
On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote: > I'd like to propose a new function for eutils.eclass that fixes m4 files so > that aclocal doesn't produce those annoying underquoted definition warnings > when invoked. i'd have to agree with Diego ... i'd rather see people add patches that

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Daniel
On Wed, 18 May 2005 05:34 pm, Aaron Walker wrote: > Fellow devs, > > I'd like to propose a new function for eutils.eclass that fixes m4 files so > that aclocal doesn't produce those annoying underquoted definition warnings > when invoked. > > fix_underquoted_m4defs() { > > Comments? Sounds great!

Re: [gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Diego 'Flameeyes' PettenÃ
On Wednesday 18 May 2005 09:34, Aaron Walker wrote: > Comments? Hmm I'm not sure about adding a "band-aid function"... fixing the underquoted definitions is usually trivial and requires just a little little patch. Adding a function surely will remove the need for a patch for package, and this is

[gentoo-dev] death to underquoted M4 definitions

2005-05-18 Thread Aaron Walker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fellow devs, I'd like to propose a new function for eutils.eclass that fixes m4 files so that aclocal doesn't produce those annoying underquoted definition warnings when invoked. fix_underquoted_m4defs() { local m4 for m4 in $(find ${