Re: [gentoo-dev] bzr.eclass changes, please review

2012-09-14 Thread Mike Gilbert
On Fri, Sep 14, 2012 at 12:12 PM, Rick "Zero_Chaos" Farina wrote: > I didn't mean to pick on bzr.eclass, I think it's always wrong to do > this. And you picked out the exact reasoning I did "I'm not sure if it > would be worth the effort to compute a more accurate argument for > addwrite." I thin

Re: [gentoo-dev] bzr.eclass changes, please review

2012-09-14 Thread Rick "Zero_Chaos" Farina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/14/2012 11:51 AM, Ulrich Mueller wrote: >> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote: > >>> addwrite / >> Am I reading this wrong, or is "addwrite /" being more than just a >> little lazy? I know this isn't part of you

Re: [gentoo-dev] bzr.eclass changes, please review

2012-09-14 Thread Ulrich Mueller
> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote: >> addwrite / > Am I reading this wrong, or is "addwrite /" being more than just a > little lazy? I know this isn't part of your change set but it has > always bothered me that it needs to unlocking writing on the whole > fil

Re: [gentoo-dev] bzr.eclass changes, please review

2012-09-14 Thread Rick "Zero_Chaos" Farina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/14/2012 05:01 AM, Ulrich Mueller wrote: > In bug 434746 it has been suggested that ${WORKDIR} should look like a > bzr branch or checkout. Proposed changes for bzr.eclass are included > below, comprising the following: > > - bzr_fetch can option

[gentoo-dev] bzr.eclass changes, please review

2012-09-14 Thread Ulrich Mueller
In bug 434746 it has been suggested that ${WORKDIR} should look like a bzr branch or checkout. Proposed changes for bzr.eclass are included below, comprising the following: - bzr_fetch can optionally call bzr checkout --lightweight instead of bzr export. The default behaviour won't change, the n

Re: [gentoo-dev] bzr.eclass: The next level (this time with patch)

2009-03-10 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 René 'Necoro' Neumann schrieb: > As one can easily see: While the fetch time for co and lw-co are more or > less equal, the export time is not. As one can say, that each package is > at least exported as often as updated (if not more often), this make

Re: [gentoo-dev] bzr.eclass: The next level (this time with patch)

2009-03-10 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I have some doubts about the usage of "co --lightweight" instead of the plain "co". The only reason I can see is the reduced disk-space needed. Because concerning time, the lightweight checkouts take (way) longer... Just some bash-time tests done with

Re: [gentoo-dev] bzr.eclass: The next level (this time with patch)

2009-03-06 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Perhaps add "> /dev/null" to the pushd/popd calls? To get rid of unnecessary output. - - Necoro -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmxTBcACgkQ4UO

[gentoo-dev] bzr.eclass: The next level (this time with patch)

2009-03-05 Thread Christian Faulhammer
Hi, after the review and more suggestions I would like to post the current version of the patch: * EAPI aware (ulm) * Better documentation * Some clean ups (a lot of people) V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http:/

[gentoo-dev] bzr.eclass: The next level

2009-03-05 Thread Christian Faulhammer
Hi, after the review and more suggestions I would like to post the current version of the patch: * EAPI aware (ulm) * Better documentation * Some clean ups (a lot of people) V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http:/

Re: [gentoo-dev] bzr.eclass

2009-02-20 Thread René 'Necoro' Neumann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jorge Manuel B. S. Vicetto schrieb: > Hi. > > Christian Faulhammer wrote: >> Hi, >> >> a user maintained a Bazaar overlay for some time now and introduced >> some changes to bzr eclass, I would like to introduce into the tree. >> Please review the att

Re: [gentoo-dev] bzr.eclass

2009-02-14 Thread Donnie Berkholz
On 17:19 Sat 14 Feb , Jorge Manuel B. S. Vicetto wrote: > # @ECLASS-VARIABLE: EBZR_DIFFSTAT_CMD > # @DESCRIPTION: > -# The bzr command to get the diffstat output. > -EBZR_DIFFSTAT_CMD="bzr diff" > +# The bzr command to get the diff output. > +EBZR_DIFF_CMD="bzr diff" > + ${EBZR_D

Re: [gentoo-dev] bzr.eclass

2009-02-14 Thread Jorge Manuel B. S. Vicetto
Hi. Christian Faulhammer wrote: > Hi, > > a user maintained a Bazaar overlay for some time now and introduced > some changes to bzr eclass, I would like to introduce into the tree. > Please review the attached patch. > > V-Li I'm attaching a revised patch that tries to improve some issues in th

Re: [gentoo-dev] bzr.eclass

2009-02-14 Thread Ulrich Mueller
> On Sat, 14 Feb 2009, Christian Faulhammer wrote: > Please review the attached patch. + local repo_type=3D$(bzr info "${EBZR_BRANCH_DIR}" | head -n 1 | cut -d '= (' -f 1) + if [[ "${repo_type}" !=3D "Lightweight checkout " ]]; then This test looks very fragile t

[gentoo-dev] bzr.eclass

2009-02-14 Thread Christian Faulhammer
Hi, a user maintained a Bazaar overlay for some time now and introduced some changes to bzr eclass, I would like to introduce into the tree. Please review the attached patch. V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http:/

Re: [gentoo-dev] bzr.eclass into Portage

2008-03-18 Thread Jorge Manuel B. S. Vicetto
Petteri Räty wrote: Christian Faulhammer kirjoitti: Hi, in the Emacs overlay we imported the bzr.eclass from the xeffects overlay. In the near future Emacs development will switch from CVS to Bazaar and thus we need the new eclass in Portage to still provide our live ebuilds from app-editors/e

Re: [gentoo-dev] bzr.eclass into Portage

2008-03-17 Thread Petteri Räty
Christian Faulhammer kirjoitti: Hi, in the Emacs overlay we imported the bzr.eclass from the xeffects overlay. In the near future Emacs development will switch from CVS to Bazaar and thus we need the new eclass in Portage to still provide our live ebuilds from app-editors/emacs-cvs. Question i

[gentoo-dev] bzr.eclass into Portage

2008-03-17 Thread Christian Faulhammer
Hi, in the Emacs overlay we imported the bzr.eclass from the xeffects overlay. In the near future Emacs development will switch from CVS to Bazaar and thus we need the new eclass in Portage to still provide our live ebuilds from app-editors/emacs-cvs. Question is now, who wrote it? V-Li -- Ch