Re: [gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd

2024-07-19 Thread Zurab Kvachadze
On Fri, 2024-07-19 at 06:31 +, Michael Orlitzky wrote: Ok, no problem. I understood the checkpath but was curious about the quality of the error message with checkconfig() vs start(). Thanks for working on this! Applied all the changes you've suggested to the branch specified in the cover

Re: [gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd

2024-07-19 Thread Michael Orlitzky
On Fri, 2024-07-19 at 09:20 +, Zurab Kvachadze wrote: > > I haven't even known of this OpenRC feature! As you explained it, the > removal of NGINX_{CONFIG,PID}FILE totally makes sense. Should I also add > '-g "pid ${pidfile};"' to command_args for your example with > 'nginx-internal' to work a

Re: [gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd

2024-07-19 Thread Zurab Kvachadze
I apologise for such delayed response. We're having major electricity outages here and I couldn't find the possibility to address your review. Nonetheless, here we are :) On Wed, 2024-07-17 at 08:41 +, Michael Orlitzky wrote: > On Wed, 2024-07-17 at 15:05 +0300, Zurab Kvachadze wrote: > > > >

Re: [gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd

2024-07-17 Thread Michael Orlitzky
On Wed, 2024-07-17 at 15:05 +0300, Zurab Kvachadze wrote: > > +NGINX_CONFIGFILE=${NGINX_CONFIGFILE:-/etc/nginx/nginx.conf} > +pidfile=${NGINX_PIDFILE:-/run/nginx.pid} OpenRC allows you to run multiple instances of the same service by creating symlinks in /etc/init.d. For example, I might symlink

[gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd

2024-07-17 Thread Zurab Kvachadze
This is the fifth revision of the init.d script for NGINX. Starting with this commit, NGINX does not check its configuration twice upon start and configuration reload (bug 481456). In the former case, if any errors occur, the error message will be printed. This is not the case with the reload() fu