Matti Bickel wrote:
> I totally agree with Donnie here. Please keep up the work, everybody
> should be encouraged to fix these (trivial) problems. I sincerly hope
> that these message will not have to continue for long. But as long as
> they do, they serve as a big reminder in your inbox of what is
Mike Doty <[EMAIL PROTECTED]> wrote:
> Donnie Berkholz wrote:
>> Over time, the number of these simple reviews should go dramatically down
>> so it no longer bothers anyone to see them. If it doesn't, that means some
>> of our developers aren't learning or paying attention, and we should take
>>
On 06:22 Mon 24 Sep , Thilo Bangert wrote:
> do people fix the stuff that is pointed out to them?
Yep, I've seen a lot of fixes for reviews.
> also, perhaps the more common ones should additionally be converted to
> repoman tests, if that is feasable.
That might be reasonable for some cases
i am all for the 'trivial' review. as i am not on the commit list,
however, i can't tell whether this acutally helps.
do people fix the stuff that is pointed out to them?
also, perhaps the more common ones should additionally be converted to
repoman tests, if that is feasable.
kind regards
Th
Donnie Berkholz wrote:
Mike Doty (KingTaco) just told me I could stop sending reviews to -dev
that are just about adding quotes or other trivial issues that come up
over and over. I'm going to tell you why it's still a good thing.
First, where one problem lurks, others often do too. In code wi
Mike Doty (KingTaco) just told me I could stop sending reviews to -dev
that are just about adding quotes or other trivial issues that come up
over and over. I'm going to tell you why it's still a good thing.
First, where one problem lurks, others often do too. In code with such
simple problems,
