Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc4

2024-01-16 Thread Jean-Baptiste Onofré
+0.8 (binding) I checked: - hash and signature are OK - incubating is in name NB: some files doesn't contain ASF headers whereas they can (for instance few md files like README.md or DevelopmentManual.md). NB: I found some binaries (png, svg, ... from the grafana dashboard) in the source distribut

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc4

2024-01-16 Thread Xuanwo
Hi, JB Based on the "APACHE VOTING PROCESS" [1]: > Votes from PMC Members on releases must use +1, 0, -1 to be considered > binding. Please correct me if I'm wrong, but I believe a +0.8 vote might not be sufficient to be considered binding. [1] https://www.apache.org/foundation/voting.html

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc4

2024-01-16 Thread Jean-Baptiste Onofré
That's right, the reason is because I'm puzzled :) I was hesitating between +1 (binding) and +0.8 (non binding). So, let me put +1 (binding) here and target to fix these small issues in the next release. Regards JB On Tue, Jan 16, 2024 at 3:41 PM Xuanwo wrote: > > Hi, JB > > Based on the "APACH

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc4

2024-01-16 Thread Willem Jiang
+1 (binding) Here is what I checked: [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] DISCLAIMER files exist [x] Artifacts has the Incubating in the name [x] No unexpected binary files Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Jan 5,

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc4

2024-01-16 Thread Willem Jiang
>From my understanding, we don't need to add the ASF headers on the markdown or JSON files, as the license header comment could cause some trouble for other software to consume. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Jan 16, 2024 at 6:32 PM Jean-Baptiste Onofré wrote: > > +0.