+1
I checked:
[ok] Download links are valid
[ok] Checksums and PGP signatures are valid
[ok] Source code artifacts have correct names matching the current release
[ok] No compiled archives bundled in source archive
Kent Yao 于2023年5月18日周四 14:57写道：
> Hi Justin & Yu. Thanks for the explaination.
+1 (non-binding)
I checked:
[x] Download links are valid
[x] Checksums and signatures
[x] LICENSE/NOTICE files exist
[x] All source files have ASF headers
[x] Can compile from source
Best,
Huajie Wang
Kent Yao 于2023年5月18日周四 14:57写道：
> Hi Justin & Yu. Thanks for the explaination.
>
> +1(non
+1 (binding)
I checked:
+ Download links are valid.
+ Checksums and signatures - although the SIGNING KEY has multiple entries,
it contains xua...@apache.org so I think it's OK.
+ LICENSE/NOTICE files exist
+ DISCLAIMER files exist
+ No unexpected binary files
+ All source files have ASF headers
+1 (non-binding)
I checked:
[x] Download links are valid.
[x] Checksums and signatures.
[x] No unexpected binary files
--
Best Regards
Mingyu Chen
Email:
morning...@apache.org
在 2023-05-18 15:24:35，"Huajie Wang" 写道：
>+1 (non-binding)
>
>I checked:
>
>[x] Download links are valid
>[
Hi,
-1(binding)
The mvn* files in the source package come from maven-wrapper, which is
not reflected in the License and NOTICE.
The AWS-SDK and PalDB mentioned in the NOTICE do not seem to be the
original NOTICE files, can you make sure?
I checked:
- Checksum and signature are fine.
- Incubati
+ 1 （binding）
[√] Download links are valid.
[√] Checksums and signatures.
[√] LICENSE/NOTICE files exist
[√] No unexpected binary files
[√] All source files have ASF headers
[√]Can compile from source
Best wishes!
Yu Xiao
Apache Member
Apache ShenYu V.P
Calvin Kirs 于2023年5月18日周四 16:40写道：
>
Hi Calvin,
Thanks for the careful checking.
About the AWS-SDK and PalDB mentioning in NOTICE file, since the referenced
codes (as mentioned in the LICENSE file) are irrelevant to the other
contents of AWS-SDK [1] and PalDB's [2] NOTICE files, only the "Copyright"
lines are bubbled up according to
Thanks all for your voting.
Thanks Calvin and Yu Li,
About mvn* files, yes, Paimon sources contain Maven Wrapper
Distribution. [1] We should add copyright in NOTICE. Paimon uses
distribution without any additional modifications, so there is no need
to add it to the license?
I will prepare a PR t
