Hi Justin,
I read your comments carefully and found that the only gap was in
./third_party/rust-sgx-sdk and I am going to fix it soon.
- I did not see any license problem with crypto/src/lib.rs or its relation with
https://github.com/skalenetwork/sgxwallet/blob/develop/LevelDB.cpp.
- The GPL
Hi,
I would need to do a review in more detail to find out what should be added to
LICENSE (and NOTICE) or if there are any other issues. I can see there further
3rd party software included in your source please than needs to bee mentioned
in LICENSE.
Re [1] it is under the MIT license but tha
+1 (binding)
- Checked release file name and location: *OK*
- Checked sum and signatures: *OK*
- Checked DISCLAIMER file exists: *OK*
- Checked LICENSE and NOTICE files: *OK*
* License of 3rd-party code contained correctly mentioned in LICENSE:
*OK*
* Included dependencies are mentioned
Hi Justin,
I opened an issue in https://github.com/dermesser/leveldb-rs/issues/26.
The auther confirmed the original and gave some explanation about the different
license.
Thanks,
He
On 2023/05/17 07:28:43 Justin Mclean wrote:
> Hi,
>
> I would need to do a review in more detail to find out wh
Hi Dave,
On Tue, May 16, 2023 at 9:14 AM Dave Fisher wrote:
>
> Hi Calvin,
>
> I think that since the ASF has moved from a mirror network to a CDN this
> requirement may have changed without proper updates.
>
> Would you mind reaching out to infra to confirm.
Thank you point for this, and I confi
+1 (binding)
- verified signature and checksum
- verified license in the source code
- locally built the source and ran all the tests. (Some of the tests are
occasionally failing due to testcontainer timeout, but does not seem a
blocker of release).
Thanks,
Jiangjie (Becket) Qin
On Wed, May 1
+1 （non-binding）
Download links are valid.
Checksums and signatures.
LICENSE/NOTICE files exist
All source files have ASF headers
Becket Qin 于2023年5月18日周四 14:22写道：
> +1 (binding)
>
> - verified signature and checksum
> - verified license in the source code
> - locally built the source and ran a
+1 (non-binding)
I checked:
[x] Download links are valid
[x] Checksums and PGP signatures are valid
[x] DISCLAIMER is included
[x] Source code artifacts have correct names matching the current release
[x] LICENSE and NOTICE files are correct for each repo
[x] All files have license headers if nec
The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due to
https://www.scala-lang.org/news/license-change.html
I am not sure if this is a blocker or not.
Kent Yao
On 2023/05/18 06:21:09 Becket Qin wrote:
> +1 (binding)
>
> - verified signature and checksum
> - verified li
HI,
> The NOTICE and the copy of LICENSE.scala in paimon-codegen are incorrect due
> to https://www.scala-lang.org/news/license-change.html
>
> I am not sure if this is a blocker or not.
I think that can be fixed in a later release, both licenses are compatible with
the Apache license so it m
Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
before Dec. 2018 it used BSD 3-clause license, and the scala version
depended in Paimon is 2.12.7, which was released in Sep. 2018.
I also noticed this during review and commented on the PR [1], JFYI.
Please let us know if any
Hi Justin & Yu. Thanks for the explaination.
+1(non-binding)
Kent Yao
On 2023/05/18 06:49:14 Yu Li wrote:
> Thanks for the note Kent. Scala has indeed changed to ALv2 today, but
> before Dec. 2018 it used BSD 3-clause license, and the scala version
> depended in Paimon is 2.12.7, which was rele
12 matches
Mail list logo
