Hi,
I had a look at the files and found that the key required to verify the
signature is not contained in the KEYS file in the tar ball. It has to
be downloaded from an external keyserver.
Not sure about the consequences of that, is it a minor thing or should a
new RC be cut?
Best,
Sebasti
Hi,
> I had a look at the files and found that the key required to verify the
> signature is not contained in the KEYS file in the tar ball.
AFAIK having the KEY file in the tar ball is not really helpful at all as it
could be modified and republished. The KEY file needs to be stored alongside
I am only reviewing the "diff -r" between RC2 and RC3.
Confirmed that the DevGuide.md is removed.
There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 )
to Dockerfiles, and a pom.xml fix adding a parent tag to the scala-package.
These seem fine and rectifies the blocking item
+1
- checked signatures
- checked building from source under ubuntu 16
On 19.05.2018 19:25, Hen wrote:
I am only reviewing the "diff -r" between RC2 and RC3.
Confirmed that the DevGuide.md is removed.
There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 )
to Dockerfiles,
Hi,
Thank you all for voting and providing your inputs.
The vote has passed with three +1 binding votes and no -1 or 0 votes.
+1 (binding):
Sergio
Henri
Sebastian
I will follow up on Monday, on the next steps for the release.
Anirudh
On Sat, May 19, 2018 at 2:08 PM, Sebastian wrote:
> +1
>
Hi,
As there is only one zip file, I guess it just the src distribution.
But after went through the file, I found lot of echart js files in the dist
directory and the rat jar.
So I'm confused what's the purpose of apache-echarts-4.1.0.rc3-
incubating.zip
Normally we distribute the src and binary
Hi,
As there are some License issues in the binary distribution (please check
the section4 for more information), I had to vote -1 (binding).
Here are the verifications which I did
1. check the checksums and verify the KEY.
These KEY are not signed by the others, so I got the warning WARNING: