+1 (binding)
I checked:
* The checksums and signatures are validated.
* The LICENSE and NOTICE files look good to me.
* There is DISCLAIMER-WIP
* No binary files in the source release
* I can build the binary from the source kit.
Best,
tison.
Kent Yao 于2023年6月29日周四 10:58写道：
> +1 (nonbinding)
+1 (nonbinding), I have checked:
[✓] The checksums and signatures are validated
[✓] The LICENSE and NOTICE are fine
[✓] DISCLAIMER-WIP is present
[✓] No binary files in the source release
[✓] Successfully build the binary from the source
Kent Yao
On 2023/06/29 02:44:02 Huajie Wang wrote:
> hi
hi PJ:
this issue[1] has been fixed[2]. Thanks for your careful review work and voting.
[1] https://github.com/apache/incubator-streampark/issues/2815
[2] https://github.com/apache/incubator-streampark/pull/2817
Best,
Huajie Wang
PJ Fanning 于2023年6月27日周二 23:19写道：
> +1 (binding)
>
> I che
+1 (binding)
I checked the source and binary tar.gz files.
- asc and sha512 files are valid
- LICENSE and NOTICE look ok - I did raise an small issue in your GitHub issues
[1]
- DISCLAIMER is in the tar.gz files
- no jars in src tar.gz
- I built the jars from scratch using the src tar.gz with no
+1 (binding)
Here is what I checked:
- The checksums and signatures are validated.
- The LICENSE and NOTICE files look good to me.
- There is DISCLAIMER-WIP
- No binary files in the source release
- I can build the binary from the source kit.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
O
