Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-07 Thread Josh Elser
Ok, thanks for the insight, Justin! I'll open up an issue to fix these in the next release. Justin Mclean wrote: Hi, Is this something we can fix on the next release, or do we need to tank this RC? I'm not sure how critically to apply the policy since these are generated code. I saw these

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-07 Thread Justin Mclean
Hi, > Is this something we can fix on the next release, or do we need to tank this > RC? I'm not sure how critically to apply the policy since these are generated > code. I saw these in my reviews but thought them ok. My understanding was because they are generated files they don’t need header

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-06 Thread Julian Hyde
> On Jan 6, 2016, at 7:16 AM, Steve Loughran wrote: > >> On 5 Jan 2016, at 11:55, Daniel Gruno wrote: >> >> See http://compliance.rocks/result.html?1152a2a9 for a list of minor >> nits (missing some license headers in a bunch of python scripts). >> > nice script +1 > I think some other proj

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-06 Thread Steve Loughran
> On 5 Jan 2016, at 11:55, Daniel Gruno wrote: > > Tentative +0.5 > > License and Notice there, no binaries in src archive, digests match > > License count as follows: > Apache License/2.0: 1196 > BSD 3-Clause License: 2 > License missing: 101 (see below) > Python License/2.0: 2 > > See http:

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Josh Elser
Justin Mclean wrote: Year is incorrect in the NOTICE file so you might want to fix that for the next release. I also noticed that some of the bundled (Apache licensed) kazoo files don’t have correct license headers. Perhaps you could fix that upstream? You could get them to add a NOTICE fil

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Justin Mclean
Hi, +1 binding I checked: - signature and hashes good - incubating in name - DISCLAIMER exists - LICENSE and NOTICE good - No unexpended binary files (false positive on one fake tar file) - All ASF source files have Apache header - Can compile from source Year is incorrect in the NOTICE file so

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Jon Maron
Forwarding my +1 vote from dev@slider > On Jan 4, 2016, at 2:34 PM, Steve Loughran wrote: > > > Hello, > > This is a call for a vote on the Apache Slider (incubating) release > 0.90.2-incubating. > > This release candidate, 0.90.2-incubating-RC1 has successfully passed a vote > for a release

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Josh Elser
Daniel Gruno wrote: License count as follows: Apache License/2.0: 1196 BSD 3-Clause License: 2 License missing: 101 (see below) Python License/2.0: 2 Seehttp://compliance.rocks/result.html?1152a2a9 for a list of minor nits (missing some license headers in a bunch of python scripts). Thanks fo

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Josh Elser
Forwarding my +1 (binding) from the dev@slider vote. Steve Loughran wrote: Hello, This is a call for a vote on the Apache Slider (incubating) release 0.90.2-incubating. This release candidate, 0.90.2-incubating-RC1 has successfully passed a vote for a release on the slider developer mailing l

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Daniel Gruno
Tentative +0.5 License and Notice there, no binaries in src archive, digests match License count as follows: Apache License/2.0: 1196 BSD 3-Clause License: 2 License missing: 101 (see below) Python License/2.0: 2 See http://compliance.rocks/result.html?1152a2a9 for a list of minor nits (missing

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-05 Thread Steve Loughran
My own vote, of course: +1 (binding) > On 4 Jan 2016, at 19:34, Steve Loughran wrote: > > > Hello, > > This is a call for a vote on the Apache Slider (incubating) release > 0.90.2-incubating. > > This release candidate, 0.90.2-incubating-RC1 has successfully passed a vote > for a release >

Re: [VOTE] Apache Slider (incubating) release 0.90.2-incubating

2016-01-04 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On 01/04/2016 08:34 PM, Steve Loughran wrote: Hello, This is a call for a vote on the Apache Slider (incubating) release 0.90.2-incubating. This release candidate, 0.90.2-incubating-RC1 has successfully passed a vote for a release on the slider developer mailing list