Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Jun Liu
> I strongly recommend that you include the full fingerprint of the > signing KEY in the KEYS file as well as the key ID. See [1] for an > example where some of the keys have this. A few years ago an attack was > demonstrated ([2], [3]) that show it was possible to create collisions > in the key ID

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Justin Mclean
Hi, > The license of guava is just boiler plate Apache License v2, I think > there is no need to keep a local copy of it. > Meanwhile, since the link points to a specific tag version, as long as > guava does not re-tag it or Github is not down, it should remain > unchanged. :) Which I agree with

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Justin Mclean
Hi, > A preliminary investigation shows these two files is not used > currently (a more careful check will be done later), it can be removed > later. Moreover the overall hessian-lite module is supposed to be > moved out of core repository as discussed on the mailing list. So looks like there n

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Jun Liu
> As the most IPMC has a daily job, so we cannot always stand by for > reviewing the kit. > You may take advantage of sending the vote before the weekend and provide > sophisticated verification in the internal vote thread to speed up the > review process. Thanks, we will provide a more detailed v

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Mark Thomas
Checks: Source bundle: - Hash and signature are correct - Hash of tag matches the hash quoted in the release vote mail - Contents of git tag match src bundle except for .gitignore file - Maven build passes - LICENSE and NOTICE look correct for source bundle - LICENSE and NOTICE look correct for bi

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Huxing Zhang
Hi, On Sun, Jun 3, 2018 at 2:08 PM, Justin Mclean wrote: > Hi, > > +1 (binding). There is an security software export issue that needs looking > into and probably acted on. > > I checked: > - incubating in name > - signatures and hashed all good > - DISCLAIMER exists > - LICENSE and NOTICE corre

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Huxing Zhang
Hi, On Sat, Jun 2, 2018 at 8:09 AM, Willem Jiang wrote: > Hi, > Here are my +1(binding) for this vote. > > I checked the sign and signature they are OK. > The License and Notice file are OK. > The release kit has the incubating work > I can build the binary from the source kit. > > Here are some

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-04 Thread Huxing Zhang
Hi, On Sun, Jun 3, 2018 at 2:08 PM, Justin Mclean wrote: > Hi, > > +1 (binding). There is an security software export issue that needs looking > into and probably acted on. > > I checked: > - incubating in name > - signatures and hashed all good > - DISCLAIMER exists > - LICENSE and NOTICE corre

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-02 Thread Justin Mclean
Hi, +1 (binding). There is an security software export issue that needs looking into and probably acted on. I checked: - incubating in name - signatures and hashed all good - DISCLAIMER exists - LICENSE and NOTICE correct - No unexpected binary files - Source files have ASF headers (with a coupl

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-01 Thread Justin Mclean
Hi, > As the most IPMC has a daily job, so we cannot always stand by for > reviewing the kit. > You may take advantage of sending the vote before the weekend and provide > sophisticated verification in the internal vote thread to speed up the > review process. All of your mentors are IPMC members

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-06-01 Thread Willem Jiang
Hi, Here are my +1(binding) for this vote. I checked the sign and signature they are OK. The License and Notice file are OK. The release kit has the incubating work I can build the binary from the source kit. Here are some minor issues that I found: 1. The release kit's name should start with Apa

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-05-31 Thread Jun Liu
Hello, This vote has opened for nearly 72 hours, i am asking again for help to check and vote on this release candidate. Best regards, Jun > On 29 May 2018, at 4:47 PM, Jun Liu wrote: > > Hello All, > > This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2. > > The Apac

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-05-31 Thread Xin Wang
+1 (non-binding) Huxing Zhang 于2018年5月31日周四 下午10:41写道: > +1 (non-binding) > > On Tue, May 29, 2018 at 4:47 PM, Jun Liu wrote: > > Hello All, > > > > This is a call for vote to release Apache Dubbo (Incubating) version > 2.6.2. > > > > The Apache Dubbo community has voted on and approved a propo

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC2]

2018-05-31 Thread Huxing Zhang
+1 (non-binding) On Tue, May 29, 2018 at 4:47 PM, Jun Liu wrote: > Hello All, > > This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2. > > The Apache Dubbo community has voted on and approved a proposal to release > Apache Dubbo (Incubating) version 2.6.2. > > We now kindl